Re: [389-devel] lib389: cleanup __init__

2013-10-31 Thread Rich Megginson
On 10/31/2013 09:58 AM, Roberto Polli wrote: Hi @all, I started investigating in mocking with fakeldap, and it seems an easy and viable way of adding unittests. A main issue is the DSAdmin.__init__ complexity. I thought - a long time ago actually - to remove from DSAdmin all cached references

Re: [389-devel] lib389: cleanup __init__

2013-10-31 Thread Roberto Polli
Hi Rich, On Thursday 31 October 2013 10:32:13 Rich Megginson wrote: I thought - a long time ago actually - to remove from DSAdmin all cached references to backends, suffixes and configuration. Part of the complexity is due to trying to keep data across a restart I agree with credential

Re: [389-devel] lib389: cleanup __init__

2013-10-31 Thread Rich Megginson
On 10/31/2013 10:35 AM, Roberto Polli wrote: Hi Rich, On Thursday 31 October 2013 10:32:13 Rich Megginson wrote: I thought - a long time ago actually - to remove from DSAdmin all cached references to backends, suffixes and configuration. Part of the complexity is due to trying to keep data

Re: [389-devel] lib389: cleanup __init__

2013-10-31 Thread Roberto Polli
On Thursday 31 October 2013 10:40:25 Rich Megginson wrote: Are all the __initPart2() attributes essential? No. You could do lazy evaluation of those fields. For example, instead of having a .dbdir field, have a .getdbdir() member that would do an ldapsearch if .dbdir is None. That's good.