Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Fri, Mar 23, 2018 at 7:24 AM, Michal Novotny wrote: > On Tue, Mar 20, 2018 at 3:31 PM, Jan Kaluza wrote: >> On Tue, Mar 20, 2018 at 10:06 AM, Michal Novotny wrote: >>> >>> The question here is why don't we actually implement the

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Tue, Mar 20, 2018 at 3:31 PM, Jan Kaluza wrote: > On Tue, Mar 20, 2018 at 10:06 AM, Michal Novotny wrote: >> >> The question here is why don't we actually implement the modularity >> the simple way. >> >> Let's suppose I would like to make nodejs-8

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Tue, Mar 20, 2018 at 3:18 PM, Kamil Paral wrote: > On Mon, Mar 19, 2018 at 8:08 PM, Jan Kaluza wrote: > >> Your tool can use good old buildsys.build.state.change fedmsg with the >> well known name/version/release fields like this: >> >>

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Tue, Mar 20, 2018 at 10:06 AM, Michal Novotny wrote: > The question here is why don't we actually implement the modularity > the simple way. > > Let's suppose I would like to make nodejs-8 available in EPEL7. > > The most effortless way would be to create subdirectory called

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Mon, Mar 19, 2018 at 8:08 PM, Jan Kaluza wrote: > Your tool can use good old buildsys.build.state.change fedmsg with the > well known name/version/release fields like this: > > https://apps.stg.fedoraproject.org/datagrepper/ >

Re: Goodbye nvr.rsplit('-', 2), hello modularity

The question here is why don't we actually implement the modularity the simple way. Let's suppose I would like to make nodejs-8 available in EPEL7. The most effortless way would be to create subdirectory called 8 at src.fedoraproject.org/rpms/nodejs with the updated spec file and sources for the

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Mon, Mar 19, 2018 at 4:43 PM, Adam Williamson wrote: > On Mon, 2018-03-19 at 10:58 +0100, Stanislav Ochotnicky wrote: > > On Mon 19 Mar 2018 09:38:58 AM GMT Fabio Valentini wrote: > > > So you think having to send a request to a web service instead of just > > >

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Mon, 2018-03-19 at 17:18 +0100, Nils Philippsen wrote: > On Mon, 2018-03-19 at 08:43 -0700, Adam Williamson wrote: > > What if I just want to write a tool that parses fedmsgs about module > > builds in Koji and does something that depends on module names, > > streams > > and versions? (e.g.

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Mon, 2018-03-19 at 08:43 -0700, Adam Williamson wrote: > What if I just want to write a tool that parses fedmsgs about module > builds in Koji and does something that depends on module names, > streams > and versions? (e.g. some sort of changelog thing) I haven't looked at actual fedmsgs

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Mon, 2018-03-19 at 10:58 +0100, Stanislav Ochotnicky wrote: > On Mon 19 Mar 2018 09:38:58 AM GMT Fabio Valentini wrote: > > So you think having to send a request to a web service instead of just > > parsing a string locally with one line of code is a good trade-off for > > allowing dashes? > >

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Mon, 2018-03-19 at 09:27 +0100, Petr Šabata wrote: > This, AFAIK, only affects what you see in some parts of the > build and update system (and on the bus). That's a very important parenthesis, as we as a project do a lot of work with fedmsg messages. -- Adam Williamson Fedora QA Community

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Mon, Mar 19, 2018 at 10:10:23AM +0100, Jan Kaluza wrote: >If something does not support modules and it should support modules and >*needs* to work with Koji content-generator imported builds for some >reason, it needs to updated to support modules and as part of this update, >it

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Mon 19 Mar 2018 09:38:58 AM GMT Fabio Valentini wrote: > So you think having to send a request to a web service instead of just > parsing a string locally with one line of code is a good trade-off for > allowing dashes? This has been mentioned several times in this thread and I think there's a

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Mon, Mar 19, 2018, 10:20 Petr Šabata wrote: > On Mon, Mar 19, 2018 at 08:57:08AM +, Zbigniew Jędrzejewski-Szmek > wrote: > > On Mon, Mar 19, 2018 at 09:27:30AM +0100, Petr Šabata wrote: > > > On Sun, Mar 18, 2018 at 07:09:23PM +, Zbigniew Jędrzejewski-Szmek > wrote:

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Mon, Mar 19, 2018 at 08:57:08AM +, Zbigniew Jędrzejewski-Szmek wrote: > On Mon, Mar 19, 2018 at 09:27:30AM +0100, Petr Šabata wrote: > > On Sun, Mar 18, 2018 at 07:09:23PM +, Zbigniew Jędrzejewski-Szmek wrote: > > > On Fri, Mar 16, 2018 at 04:14:27PM -0400, Randy Barlow wrote: > > > >

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Sat, Mar 17, 2018 at 4:15 PM, Patrick マルタインアンドレアス Uiterwijk < puiterw...@redhat.com> wrote: > > Don't be afraid of koji. :) > > I couldn't agree more, Koji's a pretty nice project to work on. > It might seems scary for newcomers because of all the ingrained knowledge > and assumptions, but

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Mon, Mar 19, 2018 at 09:27:30AM +0100, Petr Šabata wrote: > On Sun, Mar 18, 2018 at 07:09:23PM +, Zbigniew Jędrzejewski-Szmek wrote: > > On Fri, Mar 16, 2018 at 04:14:27PM -0400, Randy Barlow wrote: > > > On 03/16/2018 04:04 PM, Dennis Gregorovic wrote: > > > > modules are not RPMs.  I

Re: Goodbye nvr.rsplit('-', 2), hello modularity

(a repost from the infra list) Please note that modules (and therefore module builds) may reference to multiple RPM builds. Also, the module name doesn't need to match any RPM name. Therefore getting package names from the module build name would not be possible anyway. As an exapmple, see the

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Sun, Mar 18, 2018 at 07:09:23PM +, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Mar 16, 2018 at 04:14:27PM -0400, Randy Barlow wrote: > > On 03/16/2018 04:04 PM, Dennis Gregorovic wrote: > > > modules are not RPMs.  I would not expect them to necessarily use the > > > same format as RPMs. 

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Fri, Mar 16, 2018 at 04:14:27PM -0400, Randy Barlow wrote: > On 03/16/2018 04:04 PM, Dennis Gregorovic wrote: > > modules are not RPMs.  I would not expect them to necessarily use the > > same format as RPMs.  If we take koji out of the equation, we have > > module builds in N:S:V:C format and

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Sat, 2018-03-17 at 15:15 +, Patrick マルタインアンドレアス Uiterwijk wrote: > > Don't be afraid of koji. :) > > I couldn't agree more, Koji's a pretty nice project to work on. > It might seems scary for newcomers because of all the ingrained > knowledge and assumptions, but once you get close the

Re: Goodbye nvr.rsplit('-', 2), hello modularity

> Don't be afraid of koji. :) I couldn't agree more, Koji's a pretty nice project to work on. It might seems scary for newcomers because of all the ingrained knowledge and assumptions, but once you get close the community is nice and friendly :). > > It is under active development. Of course,

Re: Goodbye nvr.rsplit('-', 2), hello modularity

El vie, 16-03-2018 a las 15:19 -0700, Adam Williamson escribió: > On Fri, 2018-03-16 at 16:04 -0400, Dennis Gregorovic wrote: > > modules are not RPMs. I would not expect them to necessarily use > > the same > > format as RPMs. If we take koji out of the equation, > > That's an extremely big

Re: Goodbye nvr.rsplit('-', 2), hello modularity

Don't be afraid of koji. :) It is under active development. Of course, resources are limited and not everything can be taken on, but it's worth having the discussion. I have filed https://pagure.io/koji/issue/851 as a strawman and will try to solicit feedback on the idea. Patrick, if

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Fri, 2018-03-16 at 16:14 -0400, Randy Barlow wrote: > > > If that means > > tweaking the Koji UI we can look into that. > > For my concerns, it would be more helpful to tweak the Koji API than the > UI, so that tools that interact with Koji (like Bodhi) don't have to > know that Modules are

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Fri, 2018-03-16 at 16:04 -0400, Dennis Gregorovic wrote: > modules are not RPMs. I would not expect them to necessarily use the same > format as RPMs. If we take koji out of the equation, That's an extremely big and invalid 'if', though. -- Adam Williamson Fedora QA Community Monkey IRC:

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Fri, Mar 16, 2018 at 4:04 PM, Dennis Gregorovic wrote: > The challenge here is that those module builds are squeezed into a N-V-R > format when imported into Koji. The N-V-R format is used for all build > types in Koji and it works well for its purpose, but it's also not

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On 03/16/2018 04:04 PM, Dennis Gregorovic wrote: > modules are not RPMs.  I would not expect them to necessarily use the > same format as RPMs.  If we take koji out of the equation, we have > module builds in N:S:V:C format and module RPMs in N-V-R.A format.  They > use different separators, but

Re: Goodbye nvr.rsplit('-', 2), hello modularity

modules are not RPMs. I would not expect them to necessarily use the same format as RPMs. If we take koji out of the equation, we have module builds in N:S:V:C format and module RPMs in N-V-R.A format. They use different separators, but both can be parsed consistently. The challenge here is

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On 03/16/2018 05:18 AM, Pierre-Yves Chibon wrote: > I wonder what we can do about this. Is it FESCo material? > Can the folks working on modularity comment more on this? I am considering filing it for FESCo to consider. I haven't seen a compelling explanation for why modules are using a different

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Thu, Mar 15, 2018 at 05:47:41PM -0700, Adam Williamson wrote: > So: there would be no problem with - in the *name* of the modules, so > long as that's the first field, which apparently it is. > > The problem is if you allow the delimiter in *both* the first and last > fields, or in *any other

Re: Goodbye nvr.rsplit('-', 2), hello modularity

Randy Barlow wrote: > It sounds like this breaks a great deal of tooling. Can we reconsider > switching away from - separators in modules? Is allowing streams to have > -'s in them important enough to break so many tools? +1, I think allowing this ambiguity is a very bad idea. Kevin

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Thu, 2018-03-15 at 19:57 -0400, langdon wrote: > On 03/15/2018 04:31 PM, Simo Sorce wrote: > > On Thu, 2018-03-15 at 14:06 -0400, Randy Barlow wrote: > > > On 03/15/2018 12:28 PM, Chuck Anderson wrote: > > > > : doesn't work very well in filenames due to it being a pathname > > > > separator

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On 03/15/2018 04:31 PM, Simo Sorce wrote: On Thu, 2018-03-15 at 14:06 -0400, Randy Barlow wrote: On 03/15/2018 12:28 PM, Chuck Anderson wrote: : doesn't work very well in filenames due to it being a pathname separator in some filesystems among other things. It sounds like this breaks a great

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Thu, 2018-03-15 at 14:06 -0400, Randy Barlow wrote: > On 03/15/2018 12:28 PM, Chuck Anderson wrote: > > : doesn't work very well in filenames due to it being a pathname separator > > in some filesystems among other things. > > It sounds like this breaks a great deal of tooling. Can we

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On 03/15/2018 12:28 PM, Chuck Anderson wrote: > : doesn't work very well in filenames due to it being a pathname separator in > some filesystems among other things. It sounds like this breaks a great deal of tooling. Can we reconsider switching away from - separators in modules? Is allowing

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Thu, Mar 15, 2018 at 04:19:46PM +, Daniel P. Berrangé wrote: > On Thu, Mar 15, 2018 at 04:14:34PM +0100, Patrick Uiterwijk wrote: > > For user consumption, they are Name:Stream:Version:Context, so you may > > need to manually convert between one representation and the other if > > you need

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Thu, 2018-03-15 at 16:14 +0100, Patrick Uiterwijk wrote: > One of the interesting things they wanted to also allow: dashes in streams. > As a consequence, when you get an N-S-V.C as modules are represented > in Koji builds, doing a .rsplit('-', 2) will not give you Name, > Stream,

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Thu, Mar 15, 2018 at 04:14:34PM +0100, Patrick Uiterwijk wrote: > Hi all, > > If you maintain any application in Fedora Infra (or outside) that > tries to parse things out of RPM names, you might be interested in > this. > > For those wondering where I've been spending most of my time the

Re: Goodbye nvr.rsplit('-', 2), hello modularity

> On 15/03/18 15:30, Patrick Uiterwijk wrote: > > Well currently at any rate? What's the long term story? > > Only when some module rpms accidentally leaked into rawhide > recently they definitely had the kind of rather unhelpful names > that you described in your post and I got the impression

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On Thu, Mar 15, 2018 at 11:14 AM, Patrick Uiterwijk wrote: > Hi all, > > If you maintain any application in Fedora Infra (or outside) that > tries to parse things out of RPM names, you might be interested in > this. > > For those wondering where I've been spending most of

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On 15/03/18 15:30, Patrick Uiterwijk wrote: This does not affect traditional RPM/SRPM packages, right? Correct, this only impacts modules. Well currently at any rate? What's the long term story? Only when some module rpms accidentally leaked into rawhide recently they definitely had the

Re: Goodbye nvr.rsplit('-', 2), hello modularity

> > > This does not affect traditional RPM/SRPM packages, right? Correct, this only impacts modules. > > Thanks, > -Mat > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org

Re: Goodbye nvr.rsplit('-', 2), hello modularity

On 03/15/2018 10:14 AM, Patrick Uiterwijk wrote: Hi all, If you maintain any application in Fedora Infra (or outside) that tries to parse things out of RPM names, you might be interested in this. For those wondering where I've been spending most of my time the last few weeks: I've been deep in