Re: Trouble with building packages in F16: The moc has changed too much

2011-08-02 Thread Nils Philippsen
On Mon, 2011-08-01 at 19:08 +0100, Richard Hughes wrote:
 On 1 August 2011 15:24, Jaroslav Reznik jrez...@redhat.com wrote:
  It's not very good idea to ship pre-generated moc files, better to
  autogenerate them during the build-time. PackageKit is using automake,
  so it's a little bit more difficult but possible, check for example [1].
 
 Right, I *think* I'm doing the right thing in
 https://gitorious.org/packagekit/packagekit/blobs/master/lib/packagekit-qt/src/Makefile.am
 with the only difference being that I'm shipping the moc files in the
 tarball. Can I just nuke the moc files in the fedora spec file, and
 they'll get regenerated at build time? Or should I remove MOCFILES
 from EXTRA_DIST?

I'm no authority on qt/kde, but the original issue seems to indicate
that moc files should be generated during compilation time (i.e.
shouldn't be shipped in the tarball). Other than increasing compilation
time, this shouldn't be an issue as moc is part of qt-devel.

Nils
-- 
Nils Philippsen  Those who would give up Essential Liberty to purchase 
Red Hat   a little Temporary Safety, deserve neither Liberty
n...@redhat.com   nor Safety.  --  Benjamin Franklin, 1759
PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011

-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: Trouble with building packages in F16: The moc has changed too much

2011-08-02 Thread Laurent Rineau
On lundi 01 août 2011 20:08:12 Richard Hughes wrote:
 On 1 August 2011 15:24, Jaroslav Reznik jrez...@redhat.com wrote:
  It's not very good idea to ship pre-generated moc files, better to
  autogenerate them during the build-time. PackageKit is using automake,
  so it's a little bit more difficult but possible, check for example [1].
 
 Right, I *think* I'm doing the right thing in
 https://gitorious.org/packagekit/packagekit/blobs/master/lib/packagekit-qt/
 src/Makefile.am with the only difference being that I'm shipping the moc
 files in the tarball. Can I just nuke the moc files in the fedora spec
 file, and they'll get regenerated at build time? Or should I remove
 MOCFILES from EXTRA_DIST?

Yes. MOC files are generated files like .o files. The difference is that it is 
generated *source* files. MOC files are with a version of Qt is not guaranted 
to be usable with another one x.y.z, even if only the .z version number is 
changed.

-- 
Laurent Rineau
http://fedoraproject.org/wiki/LaurentRineau
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: Trouble with building packages in F16: The moc has changed too much

2011-08-02 Thread Richard Hughes
On 2 August 2011 14:54, Laurent Rineau
laurent.rineau__fed...@normalesup.org wrote:
 Yes. MOC files are generated files like .o files. The difference is that it is
 generated *source* files. MOC files are with a version of Qt is not guaranted
 to be usable with another one x.y.z, even if only the .z version number is
 changed.

Agreed. I fixed the problem upstream by not including the moc files in
the tarball, and in the Fedora spec file for the last release by
manually deleting the moc files, causing them to be regenerated.

Thanks to all of you! :)

Richard.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Trouble with building packages in F16: The moc has changed too much

2011-08-01 Thread Richard Hughes
In F16 and rawhide the PackageKit koji build is failing with This
file was generated using the moc from 4.7.2. It cannot be used with
the include files from this version of Qt. (The moc has changed too
much.) when it gets to building the PackageKit-qt library.

See http://koji.fedoraproject.org/koji/getfile?taskID=3243129name=build.log
for the full log. Does anybody know how to recreate the moc file so I
can build PackageKit for F16 and rawhide? Thanks.

Richard.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel


Re: Trouble with building packages in F16: The moc has changed too much

2011-08-01 Thread Jaroslav Reznik
Hi!

- Original Message -
 In F16 and rawhide the PackageKit koji build is failing with This
 file was generated using the moc from 4.7.2. It cannot be used with
 the include files from this version of Qt. (The moc has changed too
 much.) when it gets to building the PackageKit-qt library.

It's not very good idea to ship pre-generated moc files, better to 
autogenerate them during the build-time. PackageKit is using automake, 
so it's a little bit more difficult but possible, check for example [1].

Though I'm not sure we are going with Qt 4.8 for F16 as KDE build is
currently hit by one moc issue - and we don't have solution right now.
I'd like to investigate/fix it this week but...

Feel free to ask for any help.

Jaroslav

[1] http://blog.hartwork.org/?p=133

 See
 http://koji.fedoraproject.org/koji/getfile?taskID=3243129name=build.log
 for the full log. Does anybody know how to recreate the moc file so I
 can build PackageKit for F16 and rawhide? Thanks.
 
 Richard.
 --
 devel mailing list
 devel@lists.fedoraproject.org
 https://admin.fedoraproject.org/mailman/listinfo/devel

-- 
Jaroslav Řezník jrez...@redhat.com
Software Engineer - Base Operating Systems Brno

Office: +420 532 294 275
Mobile: +420 602 797 774
Red Hat, Inc.   http://cz.redhat.com/
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Re: Trouble with building packages in F16: The moc has changed too much

2011-08-01 Thread Richard Hughes
On 1 August 2011 15:24, Jaroslav Reznik jrez...@redhat.com wrote:
 It's not very good idea to ship pre-generated moc files, better to
 autogenerate them during the build-time. PackageKit is using automake,
 so it's a little bit more difficult but possible, check for example [1].

Right, I *think* I'm doing the right thing in
https://gitorious.org/packagekit/packagekit/blobs/master/lib/packagekit-qt/src/Makefile.am
with the only difference being that I'm shipping the moc files in the
tarball. Can I just nuke the moc files in the fedora spec file, and
they'll get regenerated at build time? Or should I remove MOCFILES
from EXTRA_DIST?

Thanks for your help,

Richard.
-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel