Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Eyal Edri
+1 indeed. I guess Martin should get merge rights for master branch on ovirt-engine pending approval of the proposal? On Sep 19, 2016 3:30 PM, "Doron Fediuck" wrote: > > > On Mon, Sep 19, 2016 at 3:25 PM, Sandro Bonazzola > wrote: > >> >> >> On Mon,

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Sandro Bonazzola
On Mon, Sep 19, 2016 at 2:12 PM, Doron Fediuck wrote: > Hi All, > > Martin Sivak has been working on the oVirt engine since June 2013. > His main focus over the years was around MoM, external scheduler, > hosted-engine, and > related engine code. > > In the past year Martin

[ovirt-devel] oVirt 4.0.4 RC4 build planned

2016-09-19 Thread Sandro Bonazzola
Fyi oVirt developers, An oVirt build is planned for this Tuesday 10:00 AM TLV time (9:00 AM CEST). Taking into consideration the time it takes for Jenkins to run a full CI everything need to be backported by Monday 11PM. Please make sure to mark as verified and CR +2 so it will be ready for

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Doron Fediuck
On Mon, Sep 19, 2016 at 4:00 PM, Eyal Edri wrote: > +1 indeed. > I guess Martin should get merge rights for master branch on ovirt-engine > pending approval of the proposal? > > Yes, this is true. > On Sep 19, 2016 3:30 PM, "Doron Fediuck" wrote: > >> >>

Re: [ovirt-devel] Best (and up-to-date) practices for developers?

2016-09-19 Thread Martin Betak
Yeah definitely +1. Even after being with the project for some time, I often wonder about things like in what order should fields in class be based on their function (as in logger, static sonstants, @Injected dependencies, actual instance fields...) so such document could answer questions like

[ovirt-devel] oVirt 4.0.4 RC4 merge / branch / tag / bugzilla reminder

2016-09-19 Thread Sandro Bonazzola
All stable branch maintainers, please make sure to - merge all relevant open bugs until Tuesday morning 11:00 AM TLV time. For each package that need to be built (i.e oVirt product) please make sure every bug in MODIFIED has the right Target Release and Target Milestone. A Target release

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Doron Fediuck
On Mon, Sep 19, 2016 at 3:25 PM, Sandro Bonazzola wrote: > > > On Mon, Sep 19, 2016 at 2:12 PM, Doron Fediuck > wrote: > >> Hi All, >> >> Martin Sivak has been working on the oVirt engine since June 2013. >> His main focus over the years was around MoM,

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Simone Tiraboschi
On Mon, Sep 19, 2016 at 3:07 PM, Roy Golan wrote: > > > On 19 September 2016 at 15:12, Doron Fediuck wrote: > >> Hi All, >> >> Martin Sivak has been working on the oVirt engine since June 2013. >> His main focus over the years was around MoM, external

Re: [ovirt-devel] Dropping rpm build from ovirt-engine check-merged.sh

2016-09-19 Thread Sandro Bonazzola
On Sun, Sep 18, 2016 at 4:18 PM, Eyal Edri wrote: > Hi, > > Following [1] I'd like to propose to remove rpm building from the > 'check-merged.sh' script from ovirt-engine (master for now). > > The job [2] takes on avg 15 min while actually the rpms are built already > in

[ovirt-devel] Best (and up-to-date) practices for developers?

2016-09-19 Thread Martin Sivak
Hi, I just wanted to find out if we have some documentation for the developers that would give hint on different aspects of the engine development in terms of coding. Like: - code style (we have the config in sources) - what libraries are (not) allowed (guava..ehm..) - how should CDI be used

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Martin Perina
On Mon, Sep 19, 2016 at 2:12 PM, Doron Fediuck wrote: > Hi All, > > Martin Sivak has been working on the oVirt engine since June 2013. > His main focus over the years was around MoM, external scheduler, > hosted-engine, and > related engine code. > > In the past year Martin

Re: [ovirt-devel] Best (and up-to-date) practices for developers?

2016-09-19 Thread Phillip Bailey
+1 for the idea if it doesn't already exist. It would ease development for those already working on the project, but it would also make it easier for others who would like to contribute to it, but aren't comfortable with navigating such a large code base. -Phillip Bailey On Mon, Sep 19, 2016 at

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Roy Golan
On 19 September 2016 at 15:12, Doron Fediuck wrote: > Hi All, > > Martin Sivak has been working on the oVirt engine since June 2013. > His main focus over the years was around MoM, external scheduler, > hosted-engine, and > related engine code. > > In the past year Martin

Re: [ovirt-devel] Dropping rpm build from ovirt-engine check-merged.sh

2016-09-19 Thread Vojtech Szocs
- Original Message - > From: "Sandro Bonazzola" > To: "Eyal Edri" > Cc: "Juan Hernandez" , "infra" , > "devel" > Sent: Monday, September 19, 2016 8:41:12 AM > Subject: Re: [ovirt-devel]

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Doron Fediuck
Thanks everyone for the vote of confidence. I believe we have sufficient +1's from engine maintainers. Congratulations Martin Sivak for becoming an engine maintainer for the SLA & Scheduling! Doron On Mon, Sep 19, 2016 at 5:06 PM, Roman Mohr wrote: > > > On Mon, Sep 19, 2016

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Martin Betak
- Original Message - > From: "Arik Hadas" > To: "Doron Fediuck" > Cc: "devel" > Sent: Monday, September 19, 2016 3:52:53 PM > Subject: Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for > SLA & Scheduling >

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Roman Mohr
On Mon, Sep 19, 2016 at 4:05 PM, Martin Betak wrote: > > > > > - Original Message - > > From: "Arik Hadas" > > To: "Doron Fediuck" > > Cc: "devel" > > Sent: Monday, September 19, 2016 3:52:53 PM > > Subject:

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Arik Hadas
- Original Message - > > > On Mon, Sep 19, 2016 at 3:07 PM, Roy Golan < rgo...@redhat.com > wrote: > > > > > > On 19 September 2016 at 15:12, Doron Fediuck < dfedi...@redhat.com > wrote: > > > > Hi All, > > Martin Sivak has been working on the oVirt engine since June 2013. >

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Martin Sivak
Thank you all very much for your support. Martin On Mon, Sep 19, 2016 at 4:27 PM, Francesco Romani wrote: > > > > > From: "Doron Fediuck" > To: "devel" > Sent: Monday, September 19, 2016 2:12:56 PM >

Re: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA & Scheduling

2016-09-19 Thread Francesco Romani
- Original Message - > From: "Doron Fediuck" > To: "devel" > Sent: Monday, September 19, 2016 2:12:56 PM > Subject: [ovirt-devel] Proposing Martin Sivak as a Backend Maintainer for SLA > & Scheduling > Hi All, > Martin Sivak has been working on

Re: [ovirt-devel] Dropping rpm build from ovirt-engine check-merged.sh

2016-09-19 Thread Eyal Edri
On Mon, Sep 19, 2016 at 6:49 PM, Vojtech Szocs wrote: > > > - Original Message - > > From: "Sandro Bonazzola" > > To: "Eyal Edri" > > Cc: "Juan Hernandez" , "infra" , > "devel"

Re: [ovirt-devel] Reporting vm disk stats "truesize" and "apparentsize"?

2016-09-19 Thread Michal Skrivanek
> On 18 Sep 2016, at 18:16, Nir Soffer wrote: > > On Sat, Sep 17, 2016 at 3:14 AM, Nir Soffer > wrote: > On Fri, Sep 16, 2016 at 10:49 AM, Michal Skrivanek > >