Re: [ovirt-devel] Gerrit parallel patch handling and CI (Or, why did my code fail post-merge)

2016-11-20 Thread Nir Soffer
On Sun, Nov 20, 2016 at 5:12 PM, Barak Korren wrote: >> With the current setting (in vdsm), submitting a series of patches is >> a huge pain. Sometimes refreshing the page and submitting the next >> patch in the series works, but sometimes you have to rebase again >> the next

Re: [ovirt-devel] Failures in OST (4.0/master) ( was error msg from Jenkins )

2016-11-20 Thread Nir Soffer
On Sun, Nov 20, 2016 at 6:30 PM, Eyal Edri wrote: > Renaming title and adding devel. > > On Sun, Nov 20, 2016 at 2:36 PM, Piotr Kliczewski > wrote: >> >> The last failure seems to be storage related. >> >> @Nir please take a look. >> >> Here is engine side

[ovirt-devel] Failures in OST (4.0/master) ( was error msg from Jenkins )

2016-11-20 Thread Eyal Edri
Renaming title and adding devel. On Sun, Nov 20, 2016 at 2:36 PM, Piotr Kliczewski wrote: > The last failure seems to be storage related. > > @Nir please take a look. > > Here is engine side error: > > 2016-11-20 05:54:59,605 DEBUG >

Re: [ovirt-devel] system tests failing on template export

2016-11-20 Thread Nir Soffer
On Sun, Nov 20, 2016 at 6:25 PM, Eyal Edri wrote: > It happened again in [1] > > 2016-11-20 10:48:12,106 ERROR (jsonrpc/2) [storage.TaskManager.Task] > (Task='6c1ec6e7-fb37-465b-8e30-1613317683b2') Unexpected error (task:870) > Traceback (most recent call last): > File

Re: [ovirt-devel] Gerrit parallel patch handling and CI (Or, why did my code fail post-merge)

2016-11-20 Thread Sandro Bonazzola
Il 20/Nov/2016 15:08, "Barak Korren" ha scritto: > > Hi there, > > I would like to address a concernt that had been raised to us by > multiple developers, and reach an agreement on how (and if) to remedy > it. > > Lets assume the following situation: > We have a Git repo in

Re: [ovirt-devel] Merge gating in Gerrit

2016-11-20 Thread Sandro Bonazzola
Il 20/Nov/2016 17:25, "Nir Soffer" ha scritto: > > On Sun, Nov 20, 2016 at 5:39 PM, Yedidyah Bar David wrote: > > On Sun, Nov 20, 2016 at 5:06 PM, Barak Korren wrote: > >> Hi all, > >> > >> Perhaps the main purpose of CI, is to prevent

Re: [ovirt-devel] Failures in OST (4.0/master) ( was error msg from Jenkins )

2016-11-20 Thread Yaniv Kaul
On Nov 20, 2016 6:30 PM, "Eyal Edri" wrote: > > Renaming title and adding devel. > > On Sun, Nov 20, 2016 at 2:36 PM, Piotr Kliczewski wrote: >> >> The last failure seems to be storage related. >> >> @Nir please take a look. >> >> Here is engine side error:

Re: [ovirt-devel] system tests failing on template export

2016-11-20 Thread Yaniv Kaul
On Nov 20, 2016 6:33 PM, "Nir Soffer" wrote: > > On Sun, Nov 20, 2016 at 6:25 PM, Eyal Edri wrote: > > It happened again in [1] > > > > 2016-11-20 10:48:12,106 ERROR (jsonrpc/2) [storage.TaskManager.Task] > > (Task='6c1ec6e7-fb37-465b-8e30-1613317683b2')

Re: [ovirt-devel] Merge gating in Gerrit

2016-11-20 Thread Sandro Bonazzola
Il 20/Nov/2016 16:06, "Barak Korren" ha scritto: > > Hi all, > > Perhaps the main purpose of CI, is to prevent braking code from > getting merged into the stable/master branches. Unfortunately our CI > is not there yet, and one of the reasons for that is that we do large >

Re: [ovirt-devel] Gerrit parallel patch handling and CI (Or, why did my code fail post-merge)

2016-11-20 Thread Martin Perina
On Sun, Nov 20, 2016 at 9:18 PM, Sandro Bonazzola wrote: > Il 20/Nov/2016 15:08, "Barak Korren" ha scritto: > > > > Hi there, > > > > I would like to address a concernt that had been raised to us by > > multiple developers, and reach an agreement on how

[ovirt-devel] Merge gating in Gerrit

2016-11-20 Thread Barak Korren
Hi all, Perhaps the main purpose of CI, is to prevent braking code from getting merged into the stable/master branches. Unfortunately our CI is not there yet, and one of the reasons for that is that we do large amount of our CI tests only _after_ the code is merged. The reason for that is that

[ovirt-devel] Gerrit parallel patch handling and CI (Or, why did my code fail post-merge)

2016-11-20 Thread Barak Korren
Hi there, I would like to address a concernt that had been raised to us by multiple developers, and reach an agreement on how (and if) to remedy it. Lets assume the following situation: We have a Git repo in Gerrit with top commit C0 in master. On time t0 developers Alice and Bob push patches

Re: [ovirt-devel] Gerrit parallel patch handling and CI (Or, why did my code fail post-merge)

2016-11-20 Thread Nir Soffer
On Sun, Nov 20, 2016 at 4:07 PM, Barak Korren wrote: > Hi there, > > I would like to address a concernt that had been raised to us by > multiple developers, and reach an agreement on how (and if) to remedy > it. > > Lets assume the following situation: > We have a Git repo in

Re: [ovirt-devel] Gerrit parallel patch handling and CI (Or, why did my code fail post-merge)

2016-11-20 Thread Barak Korren
> With the current setting (in vdsm), submitting a series of patches is > a huge pain. Sometimes refreshing the page and submitting the next > patch in the series works, but sometimes you have to rebase again > the next patches in the series, and in the worst cases, you have to > do several

Re: [ovirt-devel] Merge gating in Gerrit

2016-11-20 Thread Yedidyah Bar David
On Sun, Nov 20, 2016 at 5:06 PM, Barak Korren wrote: > Hi all, > > Perhaps the main purpose of CI, is to prevent braking code from > getting merged into the stable/master branches. Unfortunately our CI > is not there yet, and one of the reasons for that is that we do large >

Re: [ovirt-devel] Merge gating in Gerrit

2016-11-20 Thread Nir Soffer
On Sun, Nov 20, 2016 at 5:39 PM, Yedidyah Bar David wrote: > On Sun, Nov 20, 2016 at 5:06 PM, Barak Korren wrote: >> Hi all, >> >> Perhaps the main purpose of CI, is to prevent braking code from >> getting merged into the stable/master branches. Unfortunately

Re: [ovirt-devel] Gerrit parallel patch handling and CI (Or, why did my code fail post-merge)

2016-11-20 Thread Dan Kenigsberg
On Sun, Nov 20, 2016 at 06:09:59PM +0200, Nir Soffer wrote: > On Sun, Nov 20, 2016 at 5:12 PM, Barak Korren wrote: > >> With the current setting (in vdsm), submitting a series of patches is > >> a huge pain. Sometimes refreshing the page and submitting the next > >> patch in