Re: [PATCH 2/3] misc/wscript: Specify C language version

2021-03-31 Thread Gedare Bloom
On Wed, Mar 31, 2021 at 10:44 AM Joel Sherrill wrote: > > > > On Wed, Mar 31, 2021 at 9:56 AM Gedare Bloom wrote: >> >> Should we set the cstd version at the top-level? > > > That's not what was done for C++ when I looked for examples. I suppose this > lets the C++ version vary by tool or

Re: [PATCH 2/3] misc/wscript: Specify C language version

2021-03-31 Thread Joel Sherrill
On Wed, Mar 31, 2021 at 9:56 AM Gedare Bloom wrote: > Should we set the cstd version at the top-level? > That's not what was done for C++ when I looked for examples. I suppose this lets the C++ version vary by tool or library. And we did import some third-party code. --joel > > On Tue, Mar

Re: [PATCH 2/3] misc/wscript: Specify C language version

2021-03-31 Thread Gedare Bloom
Should we set the cstd version at the top-level? On Tue, Mar 30, 2021 at 3:16 PM Joel Sherrill wrote: > > CentOS 7 has gcc 4.8 which defaults to C90 and this results in warnings > for code that is valid C99 but not C90. > --- > misc/wscript | 3 ++- > 1 file changed, 2 insertions(+), 1