Re: Questions about waf config system: "grp" and updating configure.ac
> On Apr 9, 2021, at 08:25 , Sebastian Huber > wrote: > > On 09/04/2021 14:01, dufa...@hda.com wrote: > >> I checked all the "spec/build/bsps/ARCH/grp.yml" files and don't see >> anything like "variant" to restrict specifications to a subset of the BSPs >> in "ARCH". > > This is the wrong level for BSP-specific options. You have to look for: > > spec/build/bsps/ARCH/FAMILY/grp.yml This won't work, "powerpc/shared/console" is shared across powerpc FAMILYs: [dufault@gen6 powerpc]$ grep -r shared/console . ./beatnik/bspbeatnik.yml:- bsps/powerpc/shared/console/console.c ./beatnik/bspbeatnik.yml:- bsps/powerpc/shared/console/uart.c ./haleakala/bsphaleakala.yml:- bsps/powerpc/shared/console/console.c ./haleakala/bsphaleakala.yml:- bsps/powerpc/shared/console/uart.c ./motorola_powerpc/obj.yml:- bsps/powerpc/shared/console/console.c ./motorola_powerpc/obj.yml:- bsps/powerpc/shared/console/uart.c ./mvme3100/bspmvme3100.yml:- bsps/powerpc/shared/console/console.c ./mvme3100/bspmvme3100.yml:- bsps/powerpc/shared/console/uart.c ./mvme5500/bspmvme5500.yml:- bsps/powerpc/shared/console/console.c ./mvme5500/bspmvme5500.yml:- bsps/powerpc/shared/console/uart.c [dufault@gen6 powerpc]$ There is a missing FAMILY ("mvme") for the PowerPC VME boards "beatnik" (supports MVME5500 and MVME6100), "mvme3100", and "mvme5500" where we would put a "grp.yml" file for the console baud and other shared items on the VME boards. There are still other FAMILY members outside of that non-existent VME family that wouldn't be addressed ("haleakala", "motorola_powerpc"). Adding FAMILY "mvme" is a valuable cleanup, but not one I can do now when I'm trying to cleanly-enough fix the default console baud and then move on to other pressing items. I'll leave "uid: ../../optconsolebaud" in "spec/build/bsps/powerpc/{beatnik,haleakala,motorola_powerpc,mvme3100,mvme5500}/bsp*yml". > >> >> So, instead of changing the >> "powerpc/{beatnik/haleakala,motorola_powerpc,mvme3100,mvme5500}/bsp*.yml}" >> files to add the build-dependency on "uid: ../../optconsolebaud" can I put >> it in the "spec/build/bsps/powerpc/grp.yml" file? > Actually, it would be nice if all BSPs use the same option for this setting. > However, this requires that someone has the time to convert all console > drivers to use this option. Also the removal of the old build system is > required for cleanup work like this. > Peter - Peter Dufault HD Associates, Inc. Software and System Engineering This email is delivered through the public internet using protocols subject to interception and tampering. signature.asc Description: Message signed with OpenPGP ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: Questions about waf config system: "grp" and updating configure.ac
On 09/04/2021 14:01, dufa...@hda.com wrote: I checked all the "spec/build/bsps/ARCH/grp.yml" files and don't see anything like "variant" to restrict specifications to a subset of the BSPs in "ARCH". This is the wrong level for BSP-specific options. You have to look for: spec/build/bsps/ARCH/FAMILY/grp.yml So, instead of changing the "powerpc/{beatnik/haleakala,motorola_powerpc,mvme3100,mvme5500}/bsp*.yml}" files to add the build-dependency on "uid: ../../optconsolebaud" can I put it in the "spec/build/bsps/powerpc/grp.yml" file? Actually, it would be nice if all BSPs use the same option for this setting. However, this requires that someone has the time to convert all console drivers to use this option. Also the removal of the old build system is required for cleanup work like this. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: Questions about waf config system: "grp" and updating configure.ac
> On Apr 9, 2021, at 01:02 , Sebastian Huber > wrote: > >> 1. I changed all the "spec/build/bsps/powerpc/foo/bspfoo.yml" files (for bsp >> "foo", the ones that use powerpc/shared/{console.c,uart.c}) to add: >> - role: build-dependency >> - uid: ../../optconsolebaud > > if a BSP has more than one bsp*.yml file (and thus a grp.yml file), it should > be added to the grp.yml file, see also: > > https://docs.rtems.org/branches/master/eng/build-system.html#build-specification-items I looked at that documentation. For me it takes a while to sink in, I need to go through the steps (at least!). I checked all the "spec/build/bsps/ARCH/grp.yml" files and don't see anything like "variant" to restrict specifications to a subset of the BSPs in "ARCH". So, instead of changing the "powerpc/{beatnik/haleakala,motorola_powerpc,mvme3100,mvme5500}/bsp*.yml}" files to add the build-dependency on "uid: ../../optconsolebaud" can I put it in the "spec/build/bsps/powerpc/grp.yml" file? Peter - Peter Dufault HD Associates, Inc. Software and System Engineering This email is delivered through the public internet using protocols subject to interception and tampering. signature.asc Description: Message signed with OpenPGP ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: Questions about waf config system: "grp" and updating configure.ac
> On Apr 9, 2021, at 03:03 , Chris Johns wrote: > > On 9/4/21 4:45 pm, Sebastian Huber wrote: >> On 09/04/2021 08:28, Chris Johns wrote: >> >>> On 9/4/21 3:02 pm, Sebastian Huber wrote: I try to not break the old build system, however, I don't add new stuff to it. From my point of view the old build system should be removed. The major blocking point for the removal is that nobody had the time to convert the BSP builder to use the new build system. >>> It looks like recent changes have broken the autotool build system... >>> >>> https://lists.rtems.org/pipermail/build/2021-April/027232.html >>> >>> Is there any point in it staying if it does not work? I noticed that "mpc55xxevb/configure.ac" still uses "BSP_DEFAULT_BAUD_RATE" while the "waf" build system changed the code and configuration name to the standardized "BSP_CONSOLE_BAUD". I didn't fix it since it's not associated with the powerpc/shared changes, but it is bit-rot. If the old build system isn't supposed to be kept up-to-date I recommend removing it. Peter - Peter Dufault HD Associates, Inc. Software and System Engineering This email is delivered through the public internet using protocols subject to interception and tampering. signature.asc Description: Message signed with OpenPGP ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: Questions about waf config system: "grp" and updating configure.ac
On 9/4/21 4:45 pm, Sebastian Huber wrote: > On 09/04/2021 08:28, Chris Johns wrote: > >> On 9/4/21 3:02 pm, Sebastian Huber wrote: >>> I try to not break the old build system, however, I don't add new stuff to >>> it. >>> From my point of view the old build system should be removed. The major >>> blocking >>> point for the removal is that nobody had the time to convert the BSP >>> builder to >>> use the new build system. >> It looks like recent changes have broken the autotool build system... >> >> https://lists.rtems.org/pipermail/build/2021-April/027232.html >> >> Is there any point in it staying if it does not work? > > This failure is due to an out dated tool chain used by the build bot. > > I think only powerpc is broken due to the start/end file changes in GCC. I thought it failed on a networking .am that has been removed. This is new. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: Questions about waf config system: "grp" and updating configure.ac
On 09/04/2021 08:28, Chris Johns wrote: On 9/4/21 3:02 pm, Sebastian Huber wrote: I try to not break the old build system, however, I don't add new stuff to it. From my point of view the old build system should be removed. The major blocking point for the removal is that nobody had the time to convert the BSP builder to use the new build system. It looks like recent changes have broken the autotool build system... https://lists.rtems.org/pipermail/build/2021-April/027232.html Is there any point in it staying if it does not work? This failure is due to an out dated tool chain used by the build bot. I think only powerpc is broken due to the start/end file changes in GCC. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: Questions about waf config system: "grp" and updating configure.ac
On 9/4/21 3:02 pm, Sebastian Huber wrote: > I try to not break the old build system, however, I don't add new stuff to it. > From my point of view the old build system should be removed. The major > blocking > point for the removal is that nobody had the time to convert the BSP builder > to > use the new build system. It looks like recent changes have broken the autotool build system... https://lists.rtems.org/pipermail/build/2021-April/027232.html Is there any point in it staying if it does not work? Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: Questions about waf config system: "grp" and updating configure.ac
Hello Peter, On 08/04/2021 20:58, Peter Dufault wrote: I wanted to fix default console baud rate handling in "powerpc/beatnik" (and thus in anything using powerpc/shared/console). I believe: - The bsps (at least the "motload" ones) start up with the baud rate set by "motload" and some of the RTEMS tests actually work, that is, the baud rate must never be set. - The default console baud rate is hard-wired to 9600 in powerpc/shared/{console.c,uart.c}; - If you change the hard-wiring to e.g. 115200 the baud rate gets set back to 9600 if you use "termios" (in the first-open function the o_speed is still 9600). I fixed these items and figured how to configure the baud rate using "waf" with the BSP_CONSOLE_BAUD option but have questions: 1. I changed all the "spec/build/bsps/powerpc/foo/bspfoo.yml" files (for bsp "foo", the ones that use powerpc/shared/{console.c,uart.c}) to add: - role: build-dependency - uid: ../../optconsolebaud if a BSP has more than one bsp*.yml file (and thus a grp.yml file), it should be added to the grp.yml file, see also: https://docs.rtems.org/branches/master/eng/build-system.html#build-specification-items 2. I changed "spec/build/bsps/optconsolebaud.yml" to default those BSPs to 9600 (to retain current behavior): - value: 9600 variants: - m68k/m5484FireEngine - powerpc/hsc_cm01 - powerpc/beatnik - powerpc/haleakala - powerpc/motorola_powerpc - powerpc/mvme3100 - powerpc/mvme5500 Ok. 3. I changed the associated "configure.ac" for those BSPS to add: RTEMS_BSPOPTS_SET([BSP_CONSOLE_BAUD],[*],[9600]) RTEMS_BSPOPTS_HELP([BSP_CONSOLE_BAUD], [default console baud]) I try to not break the old build system, however, I don't add new stuff to it. From my point of view the old build system should be removed. The major blocking point for the removal is that nobody had the time to convert the BSP builder to use the new build system. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94 741 - 08 Registergericht: Amtsgericht München Registernummer: HRB 157899 Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler Unsere Datenschutzerklärung finden Sie hier: https://embedded-brains.de/datenschutzerklaerung/ ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel