Re: [developer] null check before free

2017-10-12 Thread Garrett D'Amore
On the face of it, it sounds reasonable, but one possible thing is that it may “mask” bugs caused by NULL pointers existing where they should not. An equally valid approach, I think, is to use an assertion instead of a check. If we know that it *must* be NULL at that point in the code, then just

[developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-12 Thread Jorgen Lundman
Looks like we managed to pass all tests finally. I plan to squash everything into one single commit unless there is some other number of commits people would prefer..? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https:

Re: [developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-12 Thread Udo Grabowski (IMK)
On 12/10/2017 12:47, Joerg Schilling wrote: Jorgen Lundman wrote: I prefer `print` myself, but there were no uses of `print` in existing zfs-tester test files, whereas there was precedent in using `tr -d` in `zfs_create_014_pos`. "print" is non standard and tus non-portable! "print" is a

Re: [developer] Re: [openzfs/openzfs] Native data and metadata encryption for zfs (#124)

2017-10-12 Thread Joerg Schilling
Jorgen Lundman wrote: > I prefer `print` myself, but there were no uses of `print` in existing > zfs-tester test files, whereas there was precedent in using `tr -d` in > `zfs_create_014_pos`. "print" is non standard and tus non-portable! "print" is a ksh-ism that was intentionally not adopte

Re: [developer] Re: [openzfs/openzfs] Change both echo -n this time (d6a584c)

2017-10-12 Thread Joerg Schilling
Igor K wrote: > you can use 'print' instead of 'echo' - more portable with formatted output > if needed. > illumos 'echo' a bit different with GNU echo from coreutils and it is big > pain try to avoid portability with it. Given that Sun published a bash binary with a correctly working "echo",