On the face of it, it sounds reasonable, but one possible thing is that it
may “mask” bugs caused by NULL pointers existing where they should not.
An equally valid approach, I think, is to use an assertion instead of a
check. If we know that it *must* be NULL at that point in the code, then
just
Looks like we managed to pass all tests finally. I plan to squash everything
into one single commit unless there is some other number of commits people
would prefer..?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https:
On 12/10/2017 12:47, Joerg Schilling wrote:
Jorgen Lundman wrote:
I prefer `print` myself, but there were no uses of `print` in existing
zfs-tester test files, whereas there was precedent in using `tr -d` in
`zfs_create_014_pos`.
"print" is non standard and tus non-portable!
"print" is a
Jorgen Lundman wrote:
> I prefer `print` myself, but there were no uses of `print` in existing
> zfs-tester test files, whereas there was precedent in using `tr -d` in
> `zfs_create_014_pos`.
"print" is non standard and tus non-portable!
"print" is a ksh-ism that was intentionally not adopte
Igor K wrote:
> you can use 'print' instead of 'echo' - more portable with formatted output
> if needed.
> illumos 'echo' a bit different with GNU echo from coreutils and it is big
> pain try to avoid portability with it.
Given that Sun published a bash binary with a correctly working "echo",