gwr commented on this pull request.
The rest looks reasonable, but let's chat about what to keep in libfakekernel
vs. consumers.
> + *
+ * CDDL HEADER END
+ */
+/*
+ * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2012, 2015 by Delphix. All
dweeezil commented on this pull request.
> + *within the mapping entry's range. If this is the case, the
+ *offset is considered to be "equal to" the mapping entry and
+ *0 will be returned.
+ *
+ *NOTE: If the offset is equal to the entry's source offset,
+ *
dweeezil commented on this pull request.
> + *
+ * 3. The last case to consider is if the offset actually falls
+ *within the mapping entry's range. If this is the case, the
+ *offset is considered to be "equal to" the mapping entry and
+ *0 will be returned.
+ *
+ *
Andriy Gapon wrote:
On 23/11/2017 18:05, Andriy Gapon wrote:
I've done a little experimentation with a version of abd_alloc_for_io() that
returns a chunked abd. zio_checksum_compute() couldn't cope with that in the
Another detail that's not directly related to the above is that even now we
On 23/11/2017 18:05, Andriy Gapon wrote:
>
> I've done a little experimentation with a version of abd_alloc_for_io() that
> returns a chunked abd. zio_checksum_compute() couldn't cope with that in the
> ZCHECKSUM_FLAG_EMBEDDED case.
> At present the function uses abd_to_buf() and that requires a
The lint and test errors have now been fixed. If I could get another review or
two that'd be great.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/494#issuecomment-348701614
