@rottegift yes, I've tried this. The paused scrub will just resume on import
(instead of staying paused) on older systems.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Sorry I'm late to the party but has anyone tried pausing a scrub, shutting the
system down, and booting a kernel that does not understand paused scrubs (the
older and less related to the normal kernel the better; ideally this could be
cross-platform testable with an image of a pool which is in
Closed #407 via c296160769c460efd21c8619cb23f91525e1e9d5.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/407#event-1215143893
--
ahrens approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/407#pullrequestreview-55611397
--
openzfs-developer
alek-p commented on this pull request.
> + } else if (*cmd != POOL_SCRUB_NORMAL) {
+ return (SET_ERROR(ENOTSUP));
+ }
+
+ return (0);
+}
+
+static void
+dsl_scrub_pause_resume_sync(void *arg, dmu_tx_t *tx)
+{
+ pool_scrub_cmd_t *cmd = arg;
+ dsl_pool_t
brad-lewis approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/407#pullrequestreview-49254397
--
openzfs-developer
sdimitro approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/407#pullrequestreview-48710702
--
openzfs-developer
sdimitro commented on this pull request.
- if (zfs_ioctl(hdl, ZFS_IOC_POOL_SCAN, ) == 0 ||
- (errno == ENOENT && func != POOL_SCAN_NONE))
+ /* ECANCELED on a scrub means we resumed a paused scrub */
Yeah I figured that was the case. I just wanted to ask first. Thank you
alek-p commented on this pull request.
> .\"
-.Dd Oct 2, 2016
+.Dd June 21, 2016
Thanks, I'll fix that in a couple min.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
alek-p commented on this pull request.
- if (zfs_ioctl(hdl, ZFS_IOC_POOL_SCAN, ) == 0 ||
- (errno == ENOENT && func != POOL_SCAN_NONE))
+ /* ECANCELED on a scrub means we resumed a paused scrub */
I agree with you that using errno here isn't the cleanest way to do this.
sdimitro commented on this pull request.
LGTM overall. I just have one question and a small nit.
> .\"
-.Dd Oct 2, 2016
+.Dd June 21, 2016
[nit] 2017
- if (zfs_ioctl(hdl, ZFS_IOC_POOL_SCAN, ) == 0 ||
- (errno == ENOENT && func != POOL_SCAN_NONE))
+ /* ECANCELED on a
@avg-I
yes it is
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/407#issuecomment-311765827
--
openzfs-developer
Archives:
I hear that there is some work on optimizing the scrub performance in the
pipeline.
I am curious if this change is compatible with that work...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Thanks for the link @loli10K! The problem was something else:
```
23:06:48.76 SUCCESS: is_pool_scrub_paused testpool
23:06:50.01 cannot scrub testpool: currently scrubbing; use 'zpool scrub -s' to
cancel current scrub
```
So it's the scrub resume that "wasn't working". In fact the resume was
14 matches
Mail list logo
