[developer] Re: [openzfs/openzfs] Large alloc in zdb can cause trouble (#635)

2018-05-07 Thread Matthew Ahrens
We'll need to get an illumos bug filed for this, too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/635#issuecomment-387122922 -- openzfs:

[developer] Re: [openzfs/openzfs] Large alloc in zdb can cause trouble (#635)

2018-05-07 Thread Matthew Ahrens
ahrens commented on this pull request. > @@ -4924,12 +4924,18 @@ zdb_embedded_block(char *thing) exit(1); } ASSERT3U(BPE_GET_LSIZE(), <=, SPA_MAXBLOCKSIZE); + buf = malloc(SPA_MAXBLOCKSIZE); + if (buf == NULL) { + (void) printf("out of

[developer] Re: [openzfs/openzfs] Large alloc in zdb can cause trouble (#635)

2018-05-07 Thread Matthew Ahrens
ahrens approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/635#pullrequestreview-118060229 -- openzfs:

[developer] Re: [openzfs/openzfs] Large alloc in zdb can cause trouble (#635)

2018-05-07 Thread Andriy Gapon
avg-I commented on this pull request. > @@ -4924,12 +4924,18 @@ zdb_embedded_block(char *thing) exit(1); } ASSERT3U(BPE_GET_LSIZE(), <=, SPA_MAXBLOCKSIZE); + buf = malloc(SPA_MAXBLOCKSIZE); + if (buf == NULL) { + (void) printf("out of

[developer] Re: [openzfs/openzfs] Large alloc in zdb can cause trouble (#635)

2018-05-07 Thread Jorgen Lundman
https://github.com/openzfsonosx/zfs/commit/ced236a5da6e72ea7bf6d2919fe14e17cffe10f1 Boom, by 10 days! :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/635#issuecomment-387029887

[developer] Re: [openzfs/openzfs] Large alloc in zdb can cause trouble (#635)

2018-05-07 Thread Andriy Gapon
This change is in FreeBSD already: https://svnweb.freebsd.org/base?view=revision=326150 https://svnweb.freebsd.org/base?view=revision=326187 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] Large alloc in zdb can cause trouble (#635)

2018-05-07 Thread Igor K
ikozhukhov approved this pull request. tested on DilOS -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/635#pullrequestreview-117950909 --