Re: [developer] ZFS Encryption Implementation for Review

2016-06-08 Thread Josef 'Jeff' Sipek
On Tue, Jun 07, 2016 at 12:23:09 +0900, Jorgen Lundman wrote: > > The manifest files (*.mf) are maintained by hand. > > > > That is surprising, especially since it seems very picky about order, and > line length. The pickiness is actually from pkgfmt which the build uses to verify that the mani

Re: [developer] ZFS Encryption Implementation for Review

2016-06-06 Thread Jorgen Lundman
> The manifest files (*.mf) are maintained by hand. > That is surprising, especially since it seems very picky about order, and line length. But it did the trick, added the appropriate tests to the manifests/system-test-zfstest.mf file and it seems happier. Cheers, Lund -- Jorgen Lundman

Re: [developer] ZFS Encryption Implementation for Review

2016-06-06 Thread Josef 'Jeff' Sipek
A quick reply from my phone... > On Jun 6, 2016, at 19:23, Jorgen Lundman wrote: > > >> >> That's the packaging step complaining. It's saying that there are some >> build files (in the proto area) that aren't mentioned by any of the package >> file manifests (usr/src/pkg/manifests/*) - in ill

Re: [developer] ZFS Encryption Implementation for Review

2016-06-06 Thread Jorgen Lundman
That's the packaging step complaining. It's saying that there are some build files (in the proto area) that aren't mentioned by any of the package file manifests (usr/src/pkg/manifests/*) - in illumos, the package descriptions explicitly list all the files and directories they provide. If you

Re: [developer] ZFS Encryption Implementation for Review

2016-06-06 Thread Josef 'Jeff' Sipek
On Mon, Jun 06, 2016 at 10:12:07 +0900, Jorgen Lundman wrote: > > Not to step on Tom's toes, but I did do the encryption changes for IllumOS. > Mostly as a way to learn how the IllumOS build process works. > > > The branch is: > > https://github.com/openzfsonosx/openzfs/tree/zol_crypto > > and

Re: [developer] ZFS Encryption Implementation for Review

2016-06-05 Thread Jorgen Lundman
Not to step on Tom's toes, but I did do the encryption changes for IllumOS. Mostly as a way to learn how the IllumOS build process works. The branch is: https://github.com/openzfsonosx/openzfs/tree/zol_crypto and the commit is: https://github.com/openzfsonosx/openzfs/commit/26127ea613b3e2e4ea

Re: [developer] ZFS Encryption Implementation for Review

2016-05-23 Thread Jorgen Lundman
Hello, Just to report that I have finished the OSX port of this pr, under the branch 'zol_crypto' available here: https://github.com/openzfsonosx/zfs/tree/zol_crypto Certainly easier to test that, than to compile a new Linux kernel :) I have had discussion with Tom about the porting process, a

Re: [developer] ZFS Encryption Implementation for Review

2016-05-18 Thread Thomas Caputi
I could do that, if that is what the community wants (it would take only a few minutes). However, the comment at the top of the file says: "Currently, the interface is Evolving (not Committed), but we intend to commit to it once it is more complete and we determine that it meets the needs of all co

Re: [developer] ZFS Encryption Implementation for Review

2016-05-18 Thread Richard Laager
On 05/17/2016 04:17 PM, Thomas Caputi wrote: I altered the prototype of lzc_create() and lzc_clone(). I understand that the purpose of libzfs_core is to have a stable api interacting with the ZFS ioctls. However, these functions need to accept wrapping keys separately from the rest of their param

Re: [developer] ZFS Encryption Implementation for Review

2016-05-18 Thread Manuel Amador
On 05/17/2016 09:17 PM, Thomas Caputi wrote: > The last feature is the actual data and metadata encryption. All data > in an encrypted dataset is stored encrypted on-disk. User-provided > metadata is also encrypted, but metadata structures have been left > plain so that scrubbing and resilvering st

[developer] ZFS Encryption Implementation for Review

2016-05-17 Thread Thomas Caputi
I have created an implementation for native encryption in ZFS. This implementation is currently available as a PR against ZoL (https://github.com/zfsonlinux/zfs/pull/4329). I would appreciate it if this PR could receive a review for consideration. For convenience, I have pasted the PR's description