Ramzec commented on this pull request.
first look. will try to understand how it works.
> @@ -188,9 +188,13 @@ zfs_iter_bookmarks(zfs_handle_t *zhp, zfs_iter_f func,
> void *data)
/* Setup the requested properties nvlist. */
props = fnvlist_alloc();
-
ahrens commented on this pull request.
> @@ -1054,6 +1054,8 @@ static const char *spa_feature_names[] = {
"com.delphix:embedded_data",
"org.open-zfs:large_blocks",
"org.illumos:sha512",
+ "com.delphix:redaction_bookmarks",
The `redaction_bookmarks` would be active
pcd1193182 commented on this pull request.
- return (0);
+ switch (new_type) {
+ case HOLE:
+ pending->sru.hole.datablksz = datablksz;
+ break;
+ case DATA:
+ pending->sru.data.datablksz = datablksz;
+
Ramzec commented on this pull request.
- return (0);
+ switch (new_type) {
+ case HOLE:
+ pending->sru.hole.datablksz = datablksz;
+ break;
+ case DATA:
+ pending->sru.data.datablksz = datablksz;
+
Ramzec commented on this pull request.
- return (0);
+ switch (new_type) {
+ case HOLE:
+ pending->sru.hole.datablksz = datablksz;
+ break;
+ case DATA:
+ pending->sru.data.datablksz = datablksz;
+
pcd1193182 commented on this pull request.
> @@ -1054,6 +1054,8 @@ static const char *spa_feature_names[] = {
"com.delphix:embedded_data",
"org.open-zfs:large_blocks",
"org.illumos:sha512",
+ "com.delphix:redaction_bookmarks",
It's primarily for tracking purposes.
pcd1193182 commented on this pull request.
> + */
+static int
+find_redact_book(libzfs_handle_t *hdl, const char *path,
+const uint64_t *redact_snap_guids, int num_redact_snaps,
+char **bookname)
+{
+ char errbuf[1024];
+ int error = 0;
+ nvlist_t *props =
pcd1193182 commented on this pull request.
> + dbn->dbn_dirty = B_FALSE;
+ }
+ }
+#ifdef ZFS_DEBUG
+ for (dsl_bookmark_node_t *dbn = avl_first(>ds_bookmarks);
+ dbn != NULL; dbn = AVL_NEXT(>ds_bookmarks, dbn)) {
+
Ramzec commented on this pull request.
- return (0);
+ switch (new_type) {
+ case HOLE:
+ pending->sru.hole.datablksz = datablksz;
+ break;
+ case DATA:
+ pending->sru.data.datablksz = datablksz;
+
Ramzec commented on this pull request.
> + dbn->dbn_dirty = B_FALSE;
+ }
+ }
+#ifdef ZFS_DEBUG
+ for (dsl_bookmark_node_t *dbn = avl_first(>ds_bookmarks);
+ dbn != NULL; dbn = AVL_NEXT(>ds_bookmarks, dbn)) {
+
10 matches
Mail list logo
