Closed #488 via 3aace5c077ce989ffe84c1c0f2f6e3bf96803e6c.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/488#event-1431383364
--
Ha. My first rebase, only took like 6 tries.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/488#issuecomment-356841770
--
openzfs-developer
That does not seem to have gone well at all...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/488#issuecomment-356839345
--
openzfs-developer
@allanjude Can you rebase onto the latest master branch, and squash to a single
commit? I can open the RTI after that's done.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
ahrens approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/488#pullrequestreview-73847786
--
openzfs-developer
ahrens commented on this pull request.
> @@ -5596,17 +5596,23 @@ print_holds(boolean_t scripted, size_t nwidth, size_t
> tagwidth, nvlist_t *nvl)
uint64_t val = 0;
time_t time;
struct tm t;
- char sep
@allanjude is your branch based off of illumos or openzfs? if it's illumos, can
you rebase onto the master branch of openzfs? I think that's what's causing the
tests to fail.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
ahrens commented on this pull request.
> @@ -5395,8 +5395,13 @@ print_holds(boolean_t scripted, size_t nwidth, size_t
> tagwidth, nvlist_t *nvl)
(void) strftime(tsbuf, DATETIME_BUF_LEN,
gettext(STRFTIME_FMT_STR), );
-
