Re: [Development] Nominating Giulio Camuffo (giucam) as an Approver

2014-04-22 Thread Blasche Alexander
Congratulations, Approver rights have been set in Gerrit and Jira. -- Alex From: development-bounces+alexander.blasche=digia@qt-project.org [development-bounces+alexander.blasche=digia@qt-project.org] on behalf of Nichols Andy

Re: [Development] [QIODevice]How to correctly treat/understand of the documentation?

2014-04-22 Thread Denis Shienkov
Hi Kuba, The `QSerialPort` API must be nonblocking, It is truth, currently it is non-blocking. The writes should be executed right away if they won’t block. The semantics would be: There are some problems, please see below: 1. Check how many bytes can be written to the OS device buffers

Re: [Development] Nominating Giulio Camuffo (giucam) as an Approver

2014-04-22 Thread Giulio Camuffo
Thank you everyone, it's been a pleasure working with you guys so far and I'm sure it will continue to be so. Looking forward to the day I'll be nominated Chief Mantainer. :-P Giulio 2014-04-22 10:17 GMT+03:00 Blasche Alexander alexander.blas...@digia.com: Congratulations, Approver rights

Re: [Development] [QIODevice]How to correctly treat/understand of the documentation?

2014-04-22 Thread Denis Shienkov
Hi Thiago, Kuba, It should support the same waitForBytesWritten() and waitForReadyRead() that QAbstractSocket and QProcess have. Those are blocking. Yes, QSerialPort does it (at least tries to do). :) Let's make sure we distinguish blocking from buffered. It's quite ok for QSerialPort to be

Re: [Development] Question about Qt's future

2014-04-22 Thread Robert Knight
Unfortunately that means there are now 4 completely separate UI stacks to maintain in Qt - widgets, QGraphicsView, the web and QtQuick v2. I wonder if they could be harmonized at all? We can use QML to describe UIs in all four. True - but I'm thinking more about the implementation. If

Re: [Development] Qt5.3 change files

2014-04-22 Thread Oswald Buddenhagen
On Thu, Apr 17, 2014 at 02:23:09PM +0200, Peter Hartmann wrote: On 04/17/2014 01:38 PM, Heikkinen Jani wrote: All maintainers: If your component doesn’t have 5.3 changes file yet, please add it as soon as possible! I was under the impression that the changes file is generated from the

Re: [Development] Question about Qt's future

2014-04-22 Thread Kevin Krammer
On Monday, 2014-04-21, 11:28:24, charleyb123 . wrote: ...In this case, none of class Cytometer nor class Laser nor class Wavelength derive from QObject, but we want them exposed to QML. Including their nested properties. Wrapping-or-deriving-from-QObject is now required. The Wavelength is

Re: [Development] Spurious downloadProgress signal with incorrect bytesTotal when loading from cache

2014-04-22 Thread Mandeep Sandhu
On 04/11/2014 11:08 AM, Mandeep Sandhu wrote: Shouldn't these be having valid size values or is this expected behaviour for cached content? I guess the 1st signal (with incorrect size) being emitted is still a bug. I think if the response comes from the cache the response always reported

Re: [Development] Question about Qt's future

2014-04-22 Thread Oswald Buddenhagen
On Mon, Apr 21, 2014 at 02:52:25PM +0200, Roland Winklmeier wrote: If I want to access this methods from QML I would have to derive them from QObject and register it in the QML context. try playing with Q_GADGET instead of QObject/Q_OBJECT - that's much less heavyweight. if it doesn't work with

Re: [Development] qt_add/removeObject hooks

2014-04-22 Thread Kevin Funk
On Wednesday 16 April 2014 14:46:56 Branislav Katreniak wrote: As mentioned on https://codereview.qt-project.org/#change,83272 Kevin Funk measured the difference between the current approach and using atomics using Olivier's initial benchmark, it's about 4-5x slower for checking if there's

Re: [Development] qt_add/removeObject hooks

2014-04-22 Thread Kevin Funk
On Wednesday 16 April 2014 12:55:38 Matthew Woehlke wrote: On 2014-04-16 03:18, Volker Krause wrote: On Tuesday 15 April 2014 08:02:56 Thiago Macieira wrote: In other words: use QBasicAtomicPointer. As mentioned on https://codereview.qt-project.org/#change,83272 Kevin Funk measured the

Re: [Development] Question about Qt's future

2014-04-22 Thread Simon Hausmann
On Monday 21. April 2014 15.13.08 Robert Knight wrote: The design direction is because QML is easier to develop with, more modern, and based on OpenGL. Widgets don't have that and will never be as efficient. Therefore, the effort is directed towards the technology that has the

Re: [Development] Question about Qt's future

2014-04-22 Thread Roland Winklmeier
If I want to access this methods from QML I would have to derive them from QObject and register it in the QML context. Not necessarily, depends on what you want to do. However, it is true that it would be nice to have something similar to QtScript's binding facilities.

Re: [Development] Documenting JavaScript with QDoc

2014-04-22 Thread Reinio Topi
Hello! I'm trying to add documentation to the JavaScript API of QWebChannel. It is a fundamental part of this module and as such, I think proper documentation is crucial. So far, I have not found a way to get qdoc to generate a page for my .js file for me. Can it? Or do I have to create

Re: [Development] Question about Qt's future

2014-04-22 Thread Olivier Goffart
On Tuesday 22 April 2014 12:20:58 Oswald Buddenhagen wrote: On Mon, Apr 21, 2014 at 02:52:25PM +0200, Roland Winklmeier wrote: If I want to access this methods from QML I would have to derive them from QObject and register it in the QML context. try playing with Q_GADGET instead of

Re: [Development] Question about Qt's future

2014-04-22 Thread André Somers
Olivier Goffart schreef op 22-4-2014 13:01: On Tuesday 22 April 2014 12:20:58 Oswald Buddenhagen wrote: On Mon, Apr 21, 2014 at 02:52:25PM +0200, Roland Winklmeier wrote: If I want to access this methods from QML I would have to derive them from QObject and register it in the QML context. try

Re: [Development] utf-8 BOM and parsers

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 12:35:33, Knoll Lars escreveu: Hi, Just came back from vacation today. Unfortunately BOM’s at the beginning of files seem to still be used quite a bit esp. in the Windows world. So I would actually vote for option 1 and rather keep compatibility. Reason is that

Re: [Development] [QIODevice]How to correctly treat/understand of the documentation?

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 12:28:39, Denis Shienkov escreveu: If to be honest, I don't agree with implementation with emission of the bytesWritten() signal in QAbstractSocket. IMHO, this signal has to be emitted when data were really transferred, i.e. after completion of transfer, when fired the

[Development] Qt-Designer sources ?

2014-04-22 Thread Martin Koller
Where do I find the sources for Qt Designer ? Or is there no longer a stand-alone designer application in Qt5 as was in Qt4 ? Thanks. -- Best regards/Schöne Grüße Martin A: Because it breaks the logical sequence of discussion Q: Why is top posting bad? () ascii ribbon campaign - against html

Re: [Development] Qt-Designer sources ?

2014-04-22 Thread Richard Moore
On 22 April 2014 16:20, Martin Koller kol...@aon.at wrote: Where do I find the sources for Qt Designer ? Or is there no longer a stand-alone designer application in Qt5 as was in Qt4 ? https://qt.gitorious.org/qt/qttools/source/e7b791c8bb5e64a4c786bf370b10366815af704f:src/designer Cheers

Re: [Development] [QIODevice]How to correctly treat/understand of the documentation?

2014-04-22 Thread Denis Shienkov
Hi Thiago, That's simply not workable. If the buffer never empties, bytesWritten() would never fire. Imagine the user is always writing data at the same speed as the device is transmitting (or faster). Hmm.. Yes. But this scenario it is possible in case of continuous flushing (or, maybe

Re: [Development] Qt-Designer sources ?

2014-04-22 Thread Olivier Goffart
On Tuesday 22 April 2014 17:20:44 Martin Koller wrote: Where do I find the sources for Qt Designer ? Or is there no longer a stand-alone designer application in Qt5 as was in Qt4 ? Thanks. In the qttools repository. qttools/src/designer -- Olivier Woboq - Qt services and support -

Re: [Development] QScreen API

2014-04-22 Thread Aleix Pol
On Sat, Apr 19, 2014 at 12:00 AM, Alan Alpert 4163654...@gmail.com wrote: On Thu, Apr 17, 2014 at 7:54 AM, Aleix Pol aleix...@kde.org wrote: Hi, Yesterday I was trying to figure out a problem I've been having on some code that keeps track of screen management changes on my system. After

Re: [Development] [QIODevice]How to correctly treat/understand of the documentation?

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 19:34:48, Denis Shienkov escreveu: 1. or keep it as is, but then bytesWritten() will be tell lies It's not lying. It's telling the user that the bytes were written from the QIODevice to the underlying device. That's the best we can do, since now those bytes are no longer

Re: [Development] [QIODevice]How to correctly treat/understand of the documentation?

2014-04-22 Thread Carlos Duclos
Hi Thiago, Kuba, It should support the same waitForBytesWritten() and waitForReadyRead() that QAbstractSocket and QProcess have. Those are blocking. Yes, QSerialPort does it (at least tries to do). :) Let's make sure we distinguish blocking from buffered. It's quite ok for QSerialPort to

Re: [Development] [QIODevice]How to correctly treat/understand of the documentation?

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 11:13:00, Carlos Duclos escreveu: PS1 Where could I take a look at your code? QtSerialPort is part of Qt since 5.2. https://qt.gitorious.org/qt/qtserialport http://code.woboq.org/qt5/qtserialport/ -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect

Re: [Development] qt_add/removeObject hooks

2014-04-22 Thread Milian Wolff
On Thursday 17 April 2014 18:11:03 Kevin Funk wrote: On Wednesday 16 April 2014 12:55:38 Matthew Woehlke wrote: On 2014-04-16 03:18, Volker Krause wrote: On Tuesday 15 April 2014 08:02:56 Thiago Macieira wrote: In other words: use QBasicAtomicPointer. As mentioned on

Re: [Development] qt_add/removeObject hooks

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 21:02:24, Milian Wolff escreveu: BTW: Did you really compile this with Qt5? The operator T*() is gone from QAtomicPointer, no? https://qt-project.org/doc/qt-5/qatomicpointer-members.html It's back.

[Development] Qt 5.3 header diff

2014-04-22 Thread Thiago Macieira
Results Modules with no public headers: Enginio QtAndroidExtras QtCompositor QtFtp QtHttp QtMacExtras QtOrganizer QtPlatformSupport QtPlatformSupport QtQmlDevTools QtQuickParticles QtVersit

[Development] Debugging crashes in QML / QtDeclarative [was: Question about Qt's future]

2014-04-22 Thread Kleint Friedemann
Hi Christoph, Christoph Feck wrote: Not speaking for Michael, but let me add that C++ is much easier to debug compared to QML, if you get a crash. We have nearly hundred backtraces in the Plasma bug tracker that point back to crashes in QtDeclarative, without a single clue where the

[Development] Qt 5.3 header diff: QtDBus

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtDBus.diff diff --git a/src/dbus/qdbusserver.h b/src/dbus/qdbusserver.h index d455f8e..7a7f54b 100644 --- a/src/dbus/qdbusserver.h +++ b/src/dbus/qdbusserver.h @@ -66,6 +66,9 @@ public: QDBusError lastError() const; QString address() const; +void

[Development] Qt 5.3 header diff: QtBluetooth

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtBluetooth.diff diff --git a/src/bluetooth/qbluetoothdevicediscoveryagent.h b/src/bluetooth/qbluetoothdevicediscoveryagent.h index a311d14..4ac1685 100644 --- a/src/bluetooth/qbluetoothdevicediscoveryagent.h +++ b/src/bluetooth/qbluetoothdevicediscoveryagent.h

[Development] Qt 5.3 header diff: QtLocation

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtLocation.diff diff --git a/src/location/maps/qgeocodingmanagerengine.h b/src/location/maps/qgeocodingmanagerengine.h index aa2839a..11862db 100644 --- a/src/location/maps/qgeocodingmanagerengine.h +++ b/src/location/maps/qgeocodingmanagerengine.h @@ -56,7 +56,7

[Development] Qt 5.3 header diff: QtConcurrent

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtConcurrent.diff diff --git a/src/concurrent/qtconcurrentiteratekernel.h b/src/concurrent/qtconcurrentiteratekernel.h index b47c30a..0969029 100644 --- a/src/concurrent/qtconcurrentiteratekernel.h +++ b/src/concurrent/qtconcurrentiteratekernel.h @@ -86,6 +86,8

[Development] Qt 5.3 header diff: QtPositioning

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtPositioning.diff diff --git a/src/positioning/qgeorectangle.h b/src/positioning/qgeorectangle.h index cd91c1d..babbe62 100644 --- a/src/positioning/qgeorectangle.h +++ b/src/positioning/qgeorectangle.h @@ -55,6 +55,7 @@ public: QGeoRectangle();

[Development] Qt 5.3 header diff: QtNetwork

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtNetwork.diff diff --git a/src/network/access/qnetworkreply.h b/src/network/access/qnetworkreply.h index a7db2d1..f11a5e8 100644 --- a/src/network/access/qnetworkreply.h +++ b/src/network/access/qnetworkreply.h @@ -93,12 +93,20 @@ public:

[Development] Qt 5.3 header diff: QtMultimedia

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtMultimedia.diff diff --git a/src/multimedia/camera/qcamera.h b/src/multimedia/camera/qcamera.h index 6a29b2c..9c413c3 100644 --- a/src/multimedia/camera/qcamera.h +++ b/src/multimedia/camera/qcamera.h @@ -64,6 +64,7 @@ QT_BEGIN_NAMESPACE class

[Development] Qt 5.3 header diff: QtPrintSupport

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtPrintSupport.diff diff --git a/src/printsupport/dialogs/qprintdialog.h b/src/printsupport/dialogs/qprintdialog.h index c822aa0..886cd1e 100644 --- a/src/printsupport/dialogs/qprintdialog.h +++ b/src/printsupport/dialogs/qprintdialog.h @@ -106,7 +106,6 @@

[Development] Qt 5.3 header diff: QtSql

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtSql.diff diff --git a/src/sql/kernel/qsqldriver.h b/src/sql/kernel/qsqldriver.h index 017ffd4..f93a030 100644 --- a/src/sql/kernel/qsqldriver.h +++ b/src/sql/kernel/qsqldriver.h @@ -62,6 +62,7 @@ class QVariant; class Q_SQL_EXPORT QSqlDriver : public QObject

[Development] Qt 5.3 header diff: QtQuick

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtQuick.diff diff --git a/src/quick/items/qquickitem.h b/src/quick/items/qquickitem.h index 2500a2d..2b08cc2 100644 --- a/src/quick/items/qquickitem.h +++ b/src/quick/items/qquickitem.h @@ -56,7 +56,7 @@ QT_BEGIN_NAMESPACE class QQuickItem; class

[Development] Qt 5.3 header diff: QtSensors

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtSensors.diff diff --git a/src/sensors/qcompass.h b/src/sensors/qcompass.h index 75b6869..5351062 100644 --- a/src/sensors/qcompass.h +++ b/src/sensors/qcompass.h @@ -67,7 +67,7 @@ class Q_SENSORS_EXPORT QCompassFilter : public QSensorFilter public:

[Development] Qt 5.3 header diff: QtSerialPort

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtSerialPort.diff diff --git a/src/serialport/qserialport.h b/src/serialport/qserialport.h index 6e16463..6ca5af4 100644 --- a/src/serialport/qserialport.h +++ b/src/serialport/qserialport.h @@ -64,11 +64,11 @@ class Q_SERIALPORT_EXPORT QSerialPort : public

[Development] Qt 5.3 header diff: QtQml

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtQml.diff diff --git a/src/qml/qml/qqml.h b/src/qml/qml/qqml.h index b6c6fe8..721f2cc 100644 --- a/src/qml/qml/qqml.h +++ b/src/qml/qml/qqml.h @@ -91,13 +91,13 @@ class QQmlPropertyValueInterceptor; const char *className = T::staticMetaObject.className(); \

[Development] Qt 5.3 header diff: QtWidgets

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtWidgets.diff diff --git a/src/widgets/dialogs/qmessagebox.h b/src/widgets/dialogs/qmessagebox.h index c5598a8..5fae174 100644 --- a/src/widgets/dialogs/qmessagebox.h +++ b/src/widgets/dialogs/qmessagebox.h @@ -72,6 +72,7 @@ class Q_WIDGETS_EXPORT QMessageBox :

[Development] Qt 5.3 header diff: QtTest

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtTest.diff diff --git a/src/testlib/qtest.h b/src/testlib/qtest.h index ac1d6cc..7c9a7b2 100644 --- a/src/testlib/qtest.h +++ b/src/testlib/qtest.h @@ -66,14 +66,14 @@ QT_BEGIN_NAMESPACE namespace QTest { -template inline char *toString(const QLatin1String

[Development] Qt 5.3 header diff: QtOpenGL

2014-04-22 Thread Thiago Macieira
http://macieira.org/~thiago/qt-5.3/QtOpenGL.diff diff --git a/src/opengl/qglframebufferobject.h b/src/opengl/qglframebufferobject.h index 9312a23..affa47c 100644 --- a/src/opengl/qglframebufferobject.h +++ b/src/opengl/qglframebufferobject.h @@ -63,17 +63,11 @@ public:

Re: [Development] Qt 5.3 header diff: QtLocation

2014-04-22 Thread Sune Vuorela
On 2014-04-22, Thiago Macieira thiago.macie...@intel.com wrote: -QGeoCodingManagerEngine(const QMapQString, QVariant parameters, QObject *parent = 0); +QGeoCodingManagerEngine(const QVariantMap parameters, QObject *parent = 0); Given it is just changes to typedefs, it should be

Re: [Development] Qt 5.3 header diff: QtNetwork

2014-04-22 Thread Sune Vuorela
On 2014-04-22, Thiago Macieira thiago.macie...@intel.com wrote: --- a/src/network/ssl/qsslconfiguration.h +++ b/src/network/ssl/qsslconfiguration.h @@ -131,6 +132,21 @@ public: +static const char NextProtocolSpdy3_0[]; +static const char NextProtocolHttp1_1[]; These static const

Re: [Development] Qt 5.3 header diff: QtLocation

2014-04-22 Thread Sergio Ahumada
Qt Location is not officially part of Qt 5.3.0 .. is it? Sent from my BlackBerry 10 smartphone. Original Message From: Sune Vuorela Sent: Dienstag, 22. April 2014 23:56 To: development@qt-project.org Subject: Re: [Development] Qt 5.3 header diff: QtLocation On 2014-04-22, Thiago Macieira

Re: [Development] Qt 5.3 header diff: QtSerialPort

2014-04-22 Thread Sune Vuorela
On 2014-04-22, Thiago Macieira thiago.macie...@intel.com wrote: --- a/src/serialport/qserialport.h +++ b/src/serialport/qserialport.h @@ -64,11 +64,11 @@ class Q_SERIALPORT_EXPORT QSerialPort : public QIODevice Q_PROPERTY(FlowControl flowControl READ flowControl WRITE setFlowControl

Re: [Development] Qt 5.3 header diff: QtWidgets

2014-04-22 Thread Sune Vuorela
On 2014-04-22, Thiago Macieira thiago.macie...@intel.com wrote: --- a/src/widgets/widgets/qlcdnumber.h +++ b/src/widgets/widgets/qlcdnumber.h @@ -43,7 +43,6 @@ #define QLCDNUMBER_H #include QtWidgets/qframe.h -#include QtCore/qbitarray.h QT_BEGIN_NAMESPACE I guess this is

[Development] Changelogs for 5.3.0

2014-04-22 Thread Thiago Macieira
Please find attached the raw logs for each of the modules that had any [ChangeLog] in the v5.2.1..origin/release range. I'm taking responsibility of editing the one for qtbase. For all other modules, I'd like someone to reply to this email saying they'll be the editor. Otherwise, there will be

[Development] Project structure for multi-platform mobile devices

2014-04-22 Thread Luca Bonifacio
Hi everyone Actually, I’m getting serious problems by setting up a Qt/QML project integrating also unit tests for a multi-platform mobile application. The idea is to set up a project skeleton for the development of applications, which will run on Android and iOS; and at the same time, the unit

Re: [Development] Qt 5.3 header diff: QtLocation

2014-04-22 Thread Sze Howe Koh
I believe only Qt Positioning has been released. Qt Location hasn't. Regards, Sze-Howe On 23 April 2014 06:00, Sergio Ahumada sahum...@blackberry.com wrote: Qt Location is not officially part of Qt 5.3.0 .. is it? Sent from my BlackBerry 10 smartphone. Original Message From: Sune Vuorela

Re: [Development] Changelogs for 5.3.0

2014-04-22 Thread Thiago Macieira
Here's some editing I've done. This serves as suggestions for other editors. Everyone who has committed to qtbase please read through because I have editing questions for you. Em ter 22 abr 2014, às 15:13:41, Thiago Macieira escreveu: GLES3 and desktop OpenGL are now fully supported with EGL

Re: [Development] Qt 5.3 header diff: QtGui

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: diff --git a/src/gui/kernel/qopenglcontext.h b/src/gui/kernel/qopenglcontext.h index ce34a2d..fce983f 100644 --- a/src/gui/kernel/qopenglcontext.h +++ b/src/gui/kernel/qopenglcontext.h @@ -192,6 +192,17 @@ public: QSetQByteArray

Re: [Development] Qt 5.3 header diff: QtDBus

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: http://macieira.org/~thiago/qt-5.3/QtDBus.diff Looks fine. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development

Re: [Development] Qt 5.3 header diff: QtCore

2014-04-22 Thread Thiago Macieira
No major issues. All cosmetic. Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: --- a/src/corelib/kernel/qmetatype.h +++ b/src/corelib/kernel/qmetatype.h @@ -771,9 +771,13 @@ struct VariantData , flags(flags_) { } +VariantData(const VariantData other) +

Re: [Development] Qt 5.3 header diff: QtPositioning

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: --- a/src/positioning/qpositioningglobal.h +++ b/src/positioning/qpositioningglobal.h @@ -48,13 +48,17 @@ QT_BEGIN_NAMESPACE #ifndef QT_STATIC #if defined(QT_BUILD_POSITIONING_LIB) # define Q_POSITIONING_EXPORT

Re: [Development] Qt 5.3 header diff: QtQml

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: diff --git a/src/qml/qml/qqmlprivate.h b/src/qml/qml/qqmlprivate.h Why do we have a public header with private in the name? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center

Re: [Development] Qt 5.3 header diff: QtSensors

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: http://macieira.org/~thiago/qt-5.3/QtSensors.diff Looks fine. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___ Development

Re: [Development] Qt 5.3 header diff: QtQuick

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: http://macieira.org/~thiago/qt-5.3/QtQuick.diff Looks fine from the C++ side. I have no clue what those Q_REVISION changes do to QML. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source

Re: [Development] Qt 5.3 header diff: QtSql

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: http://macieira.org/~thiago/qt-5.3/QtSql.diff Looks fine, if scary. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center ___

Re: [Development] Qt 5.3 header diff: QtTest

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: http://macieira.org/~thiago/qt-5.3/QtTest.diff Looks fine, not including the ugly exception verification macros. I didn't even read those. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source

Re: [Development] Qt 5.3 header diff: QtWidgets

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 14:12:46, Thiago Macieira escreveu: --- a/src/widgets/widgets/qplaintextedit.h +++ b/src/widgets/widgets/qplaintextedit.h @@ -141,6 +145,9 @@ public: bool centerOnScroll() const; bool find(const QString exp, QTextDocument::FindFlags options = 0); +#ifndef

Re: [Development] Qt 5.3 header diff: QtCore

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 16:34:09, Thiago Macieira escreveu: --- a/src/corelib/kernel/qobject.h +++ b/src/corelib/kernel/qobject.h @@ -549,6 +549,83 @@ template class T inline const char * qobject_interface_iid() Q_CORE_EXPORT QDebug operator(QDebug, const QObject *); #endif

Re: [Development] Changelogs for 5.3.0

2014-04-22 Thread Thiago Macieira
Em ter 22 abr 2014, às 16:09:07, Thiago Macieira escreveu: - QTextDocumentLayout: * [QTBUG-36743] Emit updateBlock signal in QTextDocumentLayout. The updateBlock() signal is now emitted. This implies we had a signal that was never emitted before. If that's not correct, please

Re: [Development] Qt 5.3 header diff: QtBluetooth

2014-04-22 Thread Aaron McCarthy
On Tue, 22 Apr 2014 14:12:46 Thiago Macieira wrote: http://macieira.org/~thiago/qt-5.3/QtBluetooth.diff Looks fine. Cheers, -- Aaron McCarthy ___ Development mailing list Development@qt-project.org

Re: [Development] Qt 5.3 header diff: QtLocation

2014-04-22 Thread Aaron McCarthy
On Tue, 22 Apr 2014 14:12:46 Thiago Macieira wrote: http://macieira.org/~thiago/qt-5.3/QtLocation.diff This is fine. Qt Location is not part of the 5.3 release. Cheers, -- Aaron McCarthy ___ Development mailing list Development@qt-project.org

[Development] What am I not seeing in the QByteArray::capacity test failure?

2014-04-22 Thread Thiago Macieira
FAIL! : tst_QByteArray::reserve() 'qba.constData() != data' returned FALSE. tst_qbytearray.cpp(1871) : failure location http://testresults.qt-project.org/ci/QtBase_stable_Integration/build_03694/win32-msvc2010_Windows_7/log.txt.gz Code around the location is: 1858

Re: [Development] Qt 5.3 header diff: QtLocation

2014-04-22 Thread Thiago Macieira
Em qua 23 abr 2014, às 10:28:51, Aaron McCarthy escreveu: On Tue, 22 Apr 2014 14:12:46 Thiago Macieira wrote: http://macieira.org/~thiago/qt-5.3/QtLocation.diff This is fine. Qt Location is not part of the 5.3 release. Indeed. However, Ubuntu did ship it in previous releases.