Re: [Development] Qt Location and Geoclue 2

2015-06-08 Thread Aaron McCarthy
Hi, On Mon, 8 Jun 2015 22:25:12 Lisandro Damián Nicanor Pérez Meyer wrote: > Hi! I have just received a bug [debbug] in which geoclue maintainrs states > that he wants to get geoclue removed in favor of geoclue2. And it seems I'm > not alone [fedbug]. > > I searched the web and it seems the work

[Development] Qt Location and Geoclue 2

2015-06-08 Thread Lisandro Damián Nicanor Pérez Meyer
Hi! I have just received a bug [debbug] in which geoclue maintainrs states that he wants to get geoclue removed in favor of geoclue2. And it seems I'm not alone [fedbug]. I searched the web and it seems the work on this has stoped. Does anyone knows the state for this? Thanks in advance, Lisan

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Alex Montgomery
On Mon, Jun 8, 2015 at 3:27 PM, Thiago Macieira wrote: > On Tuesday 09 June 2015 00:12:47 Milian Wolff wrote: > > Sorry Thiago, but imo your answers are not on topic: The documentation is > > /wrong/. QList is _not_ the right container class to use "for most > > purposes". If, inside Qt, it is cu

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Thiago Macieira
On Tuesday 09 June 2015 00:12:47 Milian Wolff wrote: > Sorry Thiago, but imo your answers are not on topic: The documentation is > /wrong/. QList is _not_ the right container class to use "for most > purposes". If, inside Qt, it is currently (ab)used for historical reasons, > well then fine. But ca

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Milian Wolff
On Monday 08 June 2015 17:50:31 Thiago Macieira wrote: > On Monday 08 June 2015 15:40:01 Milian Wolff wrote: > > On Monday 08 June 2015 09:32:42 Thiago Macieira wrote: > > > On Monday 08 June 2015 14:57:19 Joerg Bornemann wrote: > > > > On 08-Jun-15 15:38, Marc Mutz wrote: > > > > > QList should be

Re: [Development] Qt 5.5.0 header diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 22:31:15 Marc Mutz wrote: > It would probably be a good idea to do an additional header diff (incl. new > headers) on the ML after the alpha. I don't follow the development of > modules other than QtBase closely, nor do I want to, and apparently I'm too > strict a reviewer t

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 15:58:23 Olivier Goffart wrote: > > > There is no reason to stop improving qmetatype. > > > > > > > > The qFatal was there for a good reason. > > It was there for a good reason for the existing flags. > But for new flags of course it does not make sens. It did make sense:

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 15:40:01 Milian Wolff wrote: > On Monday 08 June 2015 09:32:42 Thiago Macieira wrote: > > On Monday 08 June 2015 14:57:19 Joerg Bornemann wrote: > > > On 08-Jun-15 15:38, Marc Mutz wrote: > > > > QList should be QVector > > > > > > Speaking of that, should we adjust the foll

Re: [Development] Qt 5.5.0 header diff

2015-06-08 Thread Marc Mutz
On Monday 08 June 2015 15:36:21 Thiago Macieira wrote: > On Thursday 04 June 2015 15:29:10 Frederik Gladhorn wrote: > > It's time for the header diffs, please help review the changes (Qt 5.4.2 > > to 5.5.0) to make sure nothing that was added to the public headers > > slipped through when it should

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Marc Mutz
On Monday 08 June 2015 15:29:46 Thiago Macieira wrote: > On Monday 08 June 2015 15:26:26 Marc Mutz wrote: > > On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > > > return a QTemporaryDir (which > > > implies passing in by output parameter) > > > > > > > > Or simply return QSharedPointer..

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-08 Thread Olivier Goffart
On Monday 8. June 2015 09:34:30 Thiago Macieira wrote: > On Monday 08 June 2015 11:28:48 Olivier Goffart wrote: > > On Saturday 6. June 2015 11:17:30 Thiago Macieira wrote: > > > On Friday 05 June 2015 10:11:28 Frederik Gladhorn wrote: > > > > > > > > > I can't tell if the qmetatype.h template ma

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 15:38:21 Marc Mutz wrote: > > +QList supportedViewfinderResolutions( > > +const QCameraViewfinderSettings &settings = > > QCameraViewfinderSettings()) const; > > QList should be QVector We know that QList is defective, but let's keep it in API. We'll get a c

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Milian Wolff
On Monday 08 June 2015 09:32:42 Thiago Macieira wrote: > On Monday 08 June 2015 14:57:19 Joerg Bornemann wrote: > > On 08-Jun-15 15:38, Marc Mutz wrote: > > > QList should be QVector > > > > Speaking of that, should we adjust the following recommendation in the > > docs? > > > > "For most purpose

Re: [Development] Qt 5.5.0 header diff

2015-06-08 Thread Thiago Macieira
On Thursday 04 June 2015 15:29:10 Frederik Gladhorn wrote: > It's time for the header diffs, please help review the changes (Qt 5.4.2 to > 5.5.0) to make sure nothing that was added to the public headers slipped > through when it shouldn't be there. We seem to be doing API reviews and finding mist

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 11:28:48 Olivier Goffart wrote: > On Saturday 6. June 2015 11:17:30 Thiago Macieira wrote: > > On Friday 05 June 2015 10:11:28 Frederik Gladhorn wrote: > > > > > > I can't tell if the qmetatype.h template magic is binary compatible or > > not. > > As evidenced by a recent p

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 14:57:19 Joerg Bornemann wrote: > On 08-Jun-15 15:38, Marc Mutz wrote: > > QList should be QVector > > Speaking of that, should we adjust the following recommendation in the docs? > > "For most purposes, QList is the right class to use. Its index-based API > is more conveni

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Oswald Buddenhagen
On Mon, Jun 08, 2015 at 01:17:26PM +, Lopes Yoann wrote: > > > On 08 Jun 2015, at 15:38, Marc Mutz wrote: > > > > On Friday 05 June 2015 10:10:52 Frederik Gladhorn wrote: > >> +typedef QPair FrameRateRange; > > > > Should be a struct, not a QPair: > > > > FrameRateChange chg = ...; >

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Thiago Macieira
On Monday 08 June 2015 15:26:26 Marc Mutz wrote: > On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > > return a QTemporaryDir (which > > implies passing in by output parameter) > > Or simply return QSharedPointer... Right, but no one has done it yet. -- Thiago Macieira - thiago.macieira

Re: [Development] Some Qt3D feedback

2015-06-08 Thread Sean Harmer
Hey Steve, thanks for the feedback! On Monday 08 Jun 2015 01:11:23 Stephen Kelly wrote: > Hello, > > Congrats to Paul, Sean and others working on getting this module in a > releasable state for Qt 5.5! > > I have not reviewed the code, but I found some items to raise: > > 1) The include/Qt3DCo

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Lopes Yoann
> On 08 Jun 2015, at 15:38, Marc Mutz wrote: > > On Friday 05 June 2015 10:10:52 Frederik Gladhorn wrote: >> +typedef QPair FrameRateRange; > > Should be a struct, not a QPair: > > FrameRateChange chg = ...; > chg.first... // what's first??? > chg.second... // what's second??? It’s

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Oswald Buddenhagen
On Mon, Jun 08, 2015 at 03:26:26PM +0200, Marc Mutz wrote: > On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > > return a QTemporaryDir (which > > implies passing in by output parameter) > > Or simply return QSharedPointer... > smart pointers in the api are not liked by binding authors

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Joerg Bornemann
On 08-Jun-15 15:38, Marc Mutz wrote: > QList should be QVector Speaking of that, should we adjust the following recommendation in the docs? "For most purposes, QList is the right class to use. Its index-based API is more convenient than QLinkedList's iterator-based API, and it is usually faste

Re: [Development] Qt 5.5.0 header diff: QtQml.diff

2015-06-08 Thread Marc Mutz
On Friday 05 June 2015 10:11:30 Frederik Gladhorn wrote: > +static bool startTcpDebugServer(int port, bool block = false, > +const QString &hostName = QString()); boolean argument should be an enum. -- Marc Mutz | Senior Software Engineer KDAB (Deutschlan

Re: [Development] Qt 5.5.0 header diff: QtBluetooth.diff

2015-06-08 Thread Marc Mutz
On Friday 05 June 2015 10:11:25 Frederik Gladhorn wrote: > +bool operator==(const QBluetoothHostInfo &other) const; > +bool operator!=(const QBluetoothHostInfo &other) const; > + should be non-member (friends, if needed) -- Marc Mutz | Senior Software Engineer KDAB (Deutschland) GmbH &

Re: [Development] Qt 5.5.0 header diff: QtMultimedia.diff

2015-06-08 Thread Marc Mutz
On Friday 05 June 2015 10:10:52 Frederik Gladhorn wrote: > +typedef QPair FrameRateRange; Should be a struct, not a QPair: FrameRateChange chg = ...; chg.first... // what's first??? chg.second... // what's second??? > enum Status { > UnavailableStatus, > Unloa

Re: [Development] Qt 5.5.0 header diff: QtTest.diff

2015-06-08 Thread Marc Mutz
On Saturday 06 June 2015 10:11:45 Thiago Macieira wrote: > return a QTemporaryDir (which > implies passing in by output parameter) Or simply return QSharedPointer... -- Marc Mutz | Senior Software Engineer KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company Tel: +49-30-521325470 KDAB - The Q

Re: [Development] Qt 5.5.0 header diff: QtLocation.diff

2015-06-08 Thread Marc Mutz
On Friday 05 June 2015 10:10:37 Frederik Gladhorn wrote: > diff --git a/src/location/maps/qgeocodereply.h > b/src/location/maps/qgeocodereply.h index a30a863..f713e42 100644 > --- a/src/location/maps/qgeocodereply.h > +++ b/src/location/maps/qgeocodereply.h > @@ -56,7 +59,7 @@ class QGeoServiceProv

[Development] Humiditysensor

2015-06-08 Thread Attila Csipa
Hi, Looking at the sensor list in the current sensors module, I noticed one missing: humidity. I'm doing some sensor synthesis and nowadays higher-end Android devices also come with humidity sensors, so it would be great to have this as well. On Android at least there seems to be no reason why

Re: [Development] Qt 5.5.0 header diff: QtCore.diff

2015-06-08 Thread Olivier Goffart
On Saturday 6. June 2015 11:17:30 Thiago Macieira wrote: > On Friday 05 June 2015 10:11:28 Frederik Gladhorn wrote: > > > I can't tell if the qmetatype.h template magic is binary compatible or not. > As evidenced by a recent push [1] about the IsGadget flag, it isn't. > > I'm going to put a stop

[Development] Header diff related changes

2015-06-08 Thread Heikkinen Jani
Hi all, I tried to collect "change requests" from header diffs. We need to get needed changes in RC so we need to get needed fixes in really soon, preferably today. QtQml: rename qqmfile.h into qqmlfile_p.h. (Simon Hausman)? QtGui: src/gui/accessible/qaccessible.h : This is not Qt-like API. T

Re: [Development] Qt 5.5.0 header diff: QtNetwork.diff

2015-06-08 Thread Giuseppe D'Angelo
Il 06/06/2015 15:26, Thiago Macieira ha scritto: The symmetry only existed because we added them to QSslSocket before QSslCertificate existed. I'd rather new API existed only in QSslConfiguration. That way, we don't need to duplicate in QSslSocket. Richard, Peter, do you concur on this? I can

Re: [Development] Qt 5.5.0 header diff: QtWidgets.diff

2015-06-08 Thread Marc Mutz
On Monday 08 June 2015 11:07:26 Marc Mutz wrote: > On Friday 05 June 2015 10:11:27 Frederik Gladhorn wrote: > > diff --git a/src/widgets/widgets/qmaccocoaviewcontainer_mac.h > > b/src/widgets/widgets/qmaccocoaviewcontainer_mac.h index a98d30f..5920c1f > > 100644 > > --- a/src/widgets/widgets/qmacco

Re: [Development] Qt 5.5.0 header diff: QtWidgets.diff

2015-06-08 Thread Marc Mutz
On Friday 05 June 2015 10:11:27 Frederik Gladhorn wrote: > diff --git a/src/widgets/widgets/qmaccocoaviewcontainer_mac.h > b/src/widgets/widgets/qmaccocoaviewcontainer_mac.h index a98d30f..5920c1f > 100644 > --- a/src/widgets/widgets/qmaccocoaviewcontainer_mac.h > +++ b/src/widgets/widgets/qmaccoco

Re: [Development] Q_OBJECT and "override"

2015-06-08 Thread Olivier Goffart
On Sunday 7. June 2015 21:04:51 Sergio Martins wrote: > On Thursday, June 04, 2015 16:01:01 Aleix Pol wrote: > > Is it really that much work? I hear there's tools to do so [1] and > > it's the compiler telling whether it's correct or not. > > > > Aleix > > I've added Q_DECL_OVERRIDE to some kdepi

Re: [Development] Qt 5.5.0 header diff: QtPositioning.diff

2015-06-08 Thread Blasche Alexander
> -Original Message- > Thiago Macieira > On Friday 05 June 2015 10:10:50 Frederik Gladhorn wrote: > > -qreal distanceTo(const QGeoCoordinate &other) const; > > -qreal azimuthTo(const QGeoCoordinate &other) const; > > +Q_INVOKABLE qreal distanceTo(const QGeoCoordinate &other) con