On Thu, Jan 2, 2014 at 10:36 AM, Jiergir Ogoerg wrote:
> Found, thanks. I submitted "Patch Set 3" with corrections from their
> comments, do the reviewers get notified of the new patch submission or
> do I have to poke them?
Gerrit will inform them! :) Any updates to the review page will go as
em
Found, thanks. I submitted "Patch Set 3" with corrections from their
comments, do the reviewers get notified of the new patch submission or
do I have to poke them?
The patch set 3 is here:
https://codereview.qt-project.org/#change,74537
On Thu, Jan 2, 2014 at 3:21 AM, Sze Howe Koh wrote:
> On 2
On 2 January 2014 09:05, Jiergir Ogoerg wrote:
>
> Thanks,
> On gerrit there are 5 buttons the related to reply:
> Reply...
> Reply Done
> Discard
> Cancel
> Save
>
> Which one actually send the reply so the reviewer views my reply?
After you Save all your your replies, you need to Publish Commen
Thanks,
On gerrit there are 5 buttons the related to reply:
Reply...
Reply Done
Discard
Cancel
Save
Which one actually send the reply so the reviewer views my reply?
On Wed, Jan 1, 2014 at 7:37 AM, Mandeep Sandhu
wrote:
> Hi,
>
> You should probably add a reviewer in Gerrit first. Look at the
Hi,
You should probably add a reviewer in Gerrit first. Look at the
maintainers page to see whom to add. Or you can even look at commit
log of the file you've touched to figure out a reviewer.
Also, you might want to fix the sanity failure before adding reviewers! :)
-mandeep
On Wed, Jan 1, 20
Hi,
I have added for the 1st time code for review, please let me know if
it's ready for review or if I have to do some additional work.
2 Submits:
1) https://codereview.qt-project.org/#change,74524
Cosmetic, removes trailing whitespaces:
2) https://codereview.qt-project.org/#change,74525
___
