[Development] Documentation for QPagedPrintDevice::setPageSize should specify a unit

Hello, Steve Schilz requested on Wed, 4 May 2016: QPagedPrintDevice::setPageSize should specify a unit QTextDocument::setPageSize (http://doc.qt.io/qt-5/qtextdocument.html#pageSize-prop) --- Looking at the source code and the generated PDF's my conclusion is is that the numbers of the property

Re: [Development] Documentation for QPagedPrintDevice::setPageSize should specify a unit`

Hi Steve, Thanks for actually stepping up the plate to create a contribution! It looks fine to me, but I cannot approve this myself. https://codereview.qt-project.org/158402 André Op 05/05/2016 om 19:34 schreef Steve Schilz: Hi Andre, Challenge Accepted! I have looked at this before and fou

Re: [Development] Documentation for QPagedPrintDevice::setPageSize should specify a unit`

Oops, I ment QTextDocument::setPageSize (http://doc.qt.io/qt-5/qtextdocument.html#pageSize-prop) Does that make more sense? Steve Schilz PASCO scientific - think science On 5/4/16, 2:17 PM, "Giuseppe D'Angelo" wrote: >Hi, > >On Wed, May 4, 2016 at 10:09 PM, Steve Schilz wrote: >> The

Re: [Development] Documentation for QPagedPrintDevice::setPageSize should specify a unit

Hi, On Wed, May 4, 2016 at 10:09 PM, Steve Schilz wrote: > The doc is confusing because it does not specify a unit for the input > parameter “pageSize" The parameter is of type QPageSize, which has multiple setters and constructors. Which one(s) is missing the unit specification? Thanks, -- Gi

[Development] Documentation for QPagedPrintDevice::setPageSize should specify a unit

Hi, I would like to suggest a small update to the documentation for QPagedPaintDevice::setPageSize(const QPageSize &pageSize) See https://doc-snapshots.qt.io/qt5-5.7/qpagedpaintdevice.html#setPageSize i The doc is confusing because it does not specify a unit for the input parameter “pageSize"