Re: [Development] Give reviewers ample time to respond

2017-08-02 Thread Lorn Potter
> On 1 Aug 2017, at 10:44 pm, Kai Koehne wrote: > > I'd like to remind everyone about our commit policy: > https://wiki.qt.io/Review_Policy . In particular, it says 'Give reviewers > ample time to respond', which is assumed to be a full working day minimum > (preferably two

[Development] Give reviewers ample time to respond

2017-08-01 Thread Kai Koehne
Hi, I'd like to remind everyone about our commit policy: https://wiki.qt.io/Review_Policy . In particular, it says 'Give reviewers ample time to respond', which is assumed to be a full working day minimum (preferably two days). That is, even if you have a +2 by an approver, you should _not_