Hi Peter,
Thanks!
Why an incomplete copy/paste? I see it's missing the changes to
tools/qtconfig/mainwindow.cpp, did you omit other changes as well?
Because the gerrit code is Qt5 not Qt4.
So it needs a complete review and test by you if it works on Mac,
I don't have a Mac.
Peter
On Thursday April 23 2015 16:58:05 Peter Kuemmel wrote:
Because the gerrit code is Qt5 not Qt4.
Doh ... I wondered about that and should have realised it was the case seeing
the dialoghelper file on the list.
So it needs a complete review and test by you if it works on Mac,
Actually, I am
On 23.04.2015 20:31, René J.V. Bertin wrote:
On Thursday April 23 2015 16:58:05 Peter Kuemmel wrote:
Because the gerrit code is Qt5 not Qt4.
Doh ... I wondered about that and should have realised it was the case seeing
the dialoghelper file on the list.
So it needs a complete review and
On 23.04.2015 14:30, René J.V. Bertin wrote:
On Thursday April 23 2015 11:13:41 Peter Kuemmel wrote:
René, maybe this helps you a bit:
https://codereview.qt-project.org/#/c/111056/
It's only a incomplete copy and paste of your Qt 4 patch,
but it could show you the direction.
Hi Peter,
On Thursday April 23 2015 02:26:22 Jan Kundrát wrote:
Hi,
what did the damn system say, and what command did you use to send your
patch to that damn system?
I cannot answer that exactly, I was trying to do the push amidst the
preparations for a trip which I'm now on and which explains that
René, maybe this helps you a bit:
https://codereview.qt-project.org/#/c/111056/
It's only a incomplete copy and paste of your Qt 4 patch,
but it could show you the direction.
Peter
___
Development mailing list
Development@qt-project.org
On Thursday April 23 2015 11:13:41 Peter Kuemmel wrote:
René, maybe this helps you a bit:
https://codereview.qt-project.org/#/c/111056/
It's only a incomplete copy and paste of your Qt 4 patch,
but it could show you the direction.
Hi Peter,
Thanks!
Why an incomplete copy/paste? I see
On Wednesday 22 April 2015 09:55:52 René J.V. Bertin wrote:
https://git.reviewboard.kde.org/r/123458/
Sure, but your patch should be rejected there.
Opinion, not a fact.
The patch is up there for review and reference, not to sneak into Qt via a
backdoor. There is no backdoor, only a
On Tuesday, 21 April 2015 21:19:43 CEST, René J.V. Bertin wrote:
Damn system refused to let me push anything where before I've
been able to do so.
Hi René,
what did the damn system say, and what command did you use to send your
patch to that damn system?
Cheers,
Jan
--
Trojitá, a fast Qt
On Tuesday April 21 2015 15:02:33 Thiago Macieira
... just whining.
No comment.
But just for the record, I was indeed annoyed (with myself at least as much as
with gerrit) but otherwise just observing a fact. I think I made it clear
enough that I wasn't going to have time to spend on the issue
Cc: Heikkinen Jani
Subject: Re: [Development] HEADS-UP: Qt 5.4.2 release coming
On Monday April 20 2015 10:54:36 Heikkinen Jani wrote:
Hi,
Once again: Please remember that '5.4.2' is release branch and so on no
any nice-to-have fixes in anymore!
I'm trying to finish up a patch to the logic
On Tuesday April 21 2015 10:07:49 Thiago Macieira wrote:
Either they've been putting up with it or they've never noticed. Either way,
that makes the bug not critical for a patch release.
Possibly.
I've just tried to create a code review for the Qt 4.8 version of my patch.
Damn system
Hi René,
* René J.V. Bertin rjvber...@gmail.com [2015-04-21 21:19:43 +0200]:
On Tuesday April 21 2015 10:07:49 Thiago Macieira wrote:
Either they've been putting up with it or they've never noticed. Either
way,
that makes the bug not critical for a patch release.
Possibly.
I've
Hi all!
Downmerge from '5.4' to '5.4.2' is now done all changes targeted to
Qt5.4.2 release must be done
in '5.4.2' branch. From now on '5.4' is for possible Qt5.4.3 release. If
there is some open changes in '5.4' which should be in Qt5.4.2 please sent
re-targeting request to Ossi.
On Tuesday April 21 2015 14:37:49 Olivier Goffart wrote:
If people have been living in the 80s for that long, they can wait until the
next minor release.
If I decided to pick up on this it's because I had had enough of it that about
none of the Medium/Semibold fonts I use in my GUIs were
On Tuesday April 21 2015 06:32:47 Heikkinen Jani wrote:
If you aren't fixing critical bug you should use '5.5' branch for that. '5.4'
is for possible 5.4.3 and not for any nice-to-have fixes, sorry.
This is actually more than just a nice-to-have fix. It affects anyone doing any
kind of serious
Perhaps worth mentioning that QPushButtons don't render on Android:
https://bugreports.qt.io/browse/QTBUG-45714
On 21/04/2015 15:20, Massimo Callegari wrote:
Hi all!
Downmerge from '5.4' to '5.4.2' is now done all changes targeted to
Qt5.4.2 release must be done
in '5.4.2' branch. From
On Tuesday 21. April 2015 15:26:36 René J.V. Bertin wrote:
On Tuesday April 21 2015 14:37:49 Olivier Goffart wrote:
If people have been living in the 80s for that long, they can wait until
the next minor release.
If I decided to pick up on this it's because I had had enough of it that
On Tuesday 21. April 2015 10:33:50 René J.V. Bertin wrote:
On Tuesday April 21 2015 06:32:47 Heikkinen Jani wrote:
If you aren't fixing critical bug you should use '5.5' branch for that.
'5.4' is for possible 5.4.3 and not for any nice-to-have fixes, sorry.
This is actually more than just a
On Tuesday April 21 2015 16:38:57 Olivier Goffart wrote:
That's not the point.
That *was* not my point. Which was: who knows how many users have been working
around it, or putting up with it, as I used to do.
As I said, i don't know the specific details of this patch, but the problem
is
On Tuesday 21 April 2015 17:51:13 René J.V. Bertin wrote:
That's not the point.
That *was* not my point. Which was: who knows how many users have been
working around it, or putting up with it, as I used to do.
Either they've been putting up with it or they've never noticed. Either way,
On Tuesday April 21 2015 21:23:13 Florian Bruhin wrote:
Hi
I'm sure enough people here will be more than happy to help you with
In the meantime, this site was more than happy to accept my patch - no gitting
or committing required :)
https://git.reviewboard.kde.org/r/123458/
R.
On Tuesday 21 April 2015 22:32:51 René J.V. Bertin wrote:
On Tuesday April 21 2015 21:23:13 Florian Bruhin wrote:
Hi Florian,
I'm sure enough people here will be more than happy to help you with
that, but it'd be useful to know what exactly went wrong.
It looked as if commits are no
On Monday April 20 2015 10:54:36 Heikkinen Jani wrote:
Hi,
Once again: Please remember that '5.4.2' is release branch and so on no any
nice-to-have fixes in anymore!
I'm trying to finish up a patch to the logic behind the support for font
weights and styles testing against 5.4.1 currently
Hi all!
Downmerge from '5.4' to '5.4.2' is now done all changes targeted to Qt5.4.2
release must be done in '5.4.2' branch. From now on '5.4' is for possible
Qt5.4.3 release.
If there is some open changes in '5.4' which should be in Qt5.4.2 please sent
re-targeting request to Ossi.
Once
25 matches
Mail list logo
