Re: [Development] Names of classes in Android Extras

2013-10-08 Thread Lopes Yoann
On Oct 7, 2013, at 8:48 PM, Thiago Macieira thiago.macie...@intel.com wrote: Would this class work with a different JNI? Suppose Qt Jambi wanted to use those classes. Would they even compile? Compiling wouldn't be the problem. A few implementation details can work only on Android, namely the

Re: [Development] Names of classes in Android Extras

2013-10-08 Thread Stromme Christian
On Oct 7, 2013, at 8:48 PM, Thiago Macieira thiago.macie...@intel.com wrote: Would this class work with a different JNI? Suppose Qt Jambi wanted to use those classes. Would they even compile? Compiling wouldn't be the problem. A few implementation details can work only on Android, namely the

[Development] Names of classes in Android Extras

2013-10-07 Thread Alejandro Exojo
Hi. I've stumbled upon the names of the classes in Qt Android Extras: - QJNIEnvironment - QJNIObject The all capital part due to the acronym is inconsistent with other Qt classes, where the acronym is written as if it were a word: e.g. QHttp* instead of QHTTP*, QUrl instead of QURL, etc. I've

Re: [Development] Names of classes in Android Extras

2013-10-07 Thread Thiago Macieira
On segunda-feira, 7 de outubro de 2013 22:11:28, Alejandro Exojo wrote: Hi. I've stumbled upon the names of the classes in Qt Android Extras: - QJNIEnvironment - QJNIObject The all capital part due to the acronym is inconsistent with other Qt classes, where the acronym is written as if

Re: [Development] Names of classes in Android Extras

2013-10-07 Thread André Pönitz
On Mon, Oct 07, 2013 at 10:11:28PM +0200, Alejandro Exojo wrote: Hi. I've stumbled upon the names of the classes in Qt Android Extras: - QJNIEnvironment - QJNIObject The all capital part due to the acronym is inconsistent with other Qt classes, where the acronym is written as if it

Re: [Development] Names of classes in Android Extras

2013-10-07 Thread Stromme Christian
The names are one part legacy and one part for consistency. Either way I don't feel strongly about the names, so if we can agree on the names I'll fix it asap. So the options are QAndroidJniXxx and QJniXxx? Personally I prefer the later. -- Christian Thiago Macieira thiago.macie...@intel.com

Re: [Development] Names of classes in Android Extras

2013-10-07 Thread Thiago Macieira
On terça-feira, 8 de outubro de 2013 00:02:45, Stromme Christian wrote: So the options are QAndroidJniXxx and QJniXxx? Personally I prefer the later. Would this class work with a different JNI? Suppose Qt Jambi wanted to use those classes. Would they even compile? If so, then the generic name

Re: [Development] Names of classes in Android Extras

2013-10-07 Thread Jake Petroules
Furthermore, if they're going to be called QJniXxx and not QAndroidJniXxx, why are they even in QtAndroidExtras? They aren't Android-specific, so what about placing them in a QtJavaExtras module instead? Who knows, some other Java-based platform may come along at some point. -- Jake Petroules