Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-29 Thread Thiago Macieira
On Friday, 28 February 2020 10:42:54 PST Thiago Macieira wrote: > On Thursday, 27 February 2020 11:50:02 PST Simon Hausmann wrote: > > Hi, > > > > Declarative in 5.15 (5.14?) has public API taking a std::function and that > > appears to be okay so far :) > > Good to know. I see it in two public

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-28 Thread Thiago Macieira
On Thursday, 27 February 2020 11:50:02 PST Simon Hausmann wrote: > Hi, > > Declarative in 5.15 (5.14?) has public API taking a std::function and that > appears to be okay so far :) Good to know. I see it in two public headers in 5.14. We've just found out that std::mutex is missing on a

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-27 Thread Simon Hausmann
Hi, Declarative in 5.15 (5.14?) has public API taking a std::function and that appears to be okay so far :) Simon > Am 27.02.2020 um 18:53 schrieb Thiago Macieira : > > On Monday, 24 February 2020 03:07:00 PST Lars Knoll wrote: >>> On 21 Feb 2020, at 18:49, Thiago Macieira >>> wrote: >

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-27 Thread Thiago Macieira
On Monday, 24 February 2020 03:07:00 PST Lars Knoll wrote: > > On 21 Feb 2020, at 18:49, Thiago Macieira > > wrote: > > On Friday, 21 February 2020 08:39:57 PST Volker Hilsheimer wrote: > > > >> I’m fine with that, and as communicated by Jani, deprecations can be > >> done > >> even with

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-24 Thread Lars Knoll
> On 21 Feb 2020, at 18:49, Thiago Macieira wrote: > > On Friday, 21 February 2020 08:39:57 PST Volker Hilsheimer wrote: >> I’m fine with that, and as communicated by Jani, deprecations can be done >> even with feature freeze in effect, with approval from module maintainer >> (up until Beta1;

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-21 Thread Thiago Macieira
On Friday, 21 February 2020 08:53:33 PST Oswald Buddenhagen wrote: > On Fri, Feb 21, 2020 at 08:29:54AM -0800, Thiago Macieira wrote: > >can we deprecate setupChildProcess() in Qt 5.15 and *remove it* in 6.0? > > at least, we should. ;) > but let's bikeshed the name of the callback setter, which

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-21 Thread Thiago Macieira
On Friday, 21 February 2020 08:39:57 PST Volker Hilsheimer wrote: > I’m fine with that, and as communicated by Jani, deprecations can be done > even with feature freeze in effect, with approval from module maintainer > (up until Beta1; after that only with Lars’ approval). Do note the flip side

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-21 Thread Oswald Buddenhagen
On Fri, Feb 21, 2020 at 08:29:54AM -0800, Thiago Macieira wrote: can we deprecate setupChildProcess() in Qt 5.15 and *remove it* in 6.0? at least, we should. ;) but let's bikeshed the name of the callback setter, which needs to be added at the same time -

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-21 Thread Volker Hilsheimer
> On 21 Feb 2020, at 17:29, Thiago Macieira wrote: > > On Tuesday, 18 February 2020 15:44:24 PST Thiago Macieira wrote: >> $ grep -r 'public QProcess' >> kcoreaddons/src/lib/io/kprocess.h:class KCOREADDONS_EXPORT KProcess : public >> QProcess >> khtml/src/java/kjavaprocess.h:class KJavaProcess :

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-21 Thread Thiago Macieira
On Tuesday, 18 February 2020 15:44:24 PST Thiago Macieira wrote: > $ grep -r 'public QProcess' > kcoreaddons/src/lib/io/kprocess.h:class KCOREADDONS_EXPORT KProcess : public > QProcess > khtml/src/java/kjavaprocess.h:class KJavaProcess : public QProcess //QObject > kpty/src/kpty.cpp:class

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-18 Thread Thiago Macieira
On Tuesday, 18 February 2020 03:17:38 PST Edward Welbourne wrote: > Thiago Macieira (17 February 2020 20:35) wrote: > > Sorry, this just occurred to me. This is a request for 5.15 feature freeze > > exception. > > > > Re: https://bugreports.qt.io/browse/QTBUG-17331 > > Closed: 30-07-2013 03:38,

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-18 Thread Thiago Macieira
On Tuesday, 18 February 2020 04:11:01 PST Christian Kandeler wrote: > In qbs, we use it to call setpgid() with the id of the newly created > process. But I don't understand why that should matter at all: Whether we > inject the code via an overriden virtual or a std::function is purely a >

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-18 Thread Christian Kandeler
On Tue, 18 Feb 2020 11:17:38 + Edward Welbourne wrote: > > - of the 6 times I can find of QProcess being derived from in Qt & Qt > > Creator, 5 are to override setupChildProcess anyway and the last one > > is in tst_QProcess > > Does anyone have sources from outside Qt project that are

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-18 Thread Joerg Bornemann
On 2/18/20 12:17 PM, Edward Welbourne wrote: > We would presumably want to subsequently rationalise the MS and Unix > APIs to have a common form, instead of having naked MS types in the API > for one and something else for the other. That would mean deprecating > the existing MS-specific API in

Re: [Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-18 Thread Edward Welbourne
Thiago Macieira (17 February 2020 20:35) wrote: > Sorry, this just occurred to me. This is a request for 5.15 feature freeze > exception. > > Re: https://bugreports.qt.io/browse/QTBUG-17331 Closed: 30-07-2013 03:38, >9 years ago. > Re: 97645478de3ceffce11f58eab140c4c775e48be5 > ("QProcess: use

[Development] Qt5.15 deprecating & Qt6 removing QProcess::setupChildProcess

2020-02-17 Thread Thiago Macieira
Sorry, this just occurred to me. This is a request for 5.15 feature freeze exception. Re: https://bugreports.qt.io/browse/QTBUG-17331 Re: 97645478de3ceffce11f58eab140c4c775e48be5 ("QProcess: use FFD_USE_FORK when the class is not QProcess itself") The bug report is complaining that the use of