changed. A full fix would be nice, but I'll
settle for the location of where the d pointer is set.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40
to fix the crash, but it's still a hack and
the d pointer might be used in the future.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm
On quarta-feira, 2 de maio de 2012 16.26.42, Thiago Macieira wrote:
The following two pending commit changes the QString 8-bit functions to use
UTF-8, by *temporarily* changing fromAscii to mean fromUtf8, and toAscii to
mean toUtf8.
https://codereview.qt-project.org/24700
https
you can use them in your exception-
bearing code.
Given that, -fno-exceptions is entirely binary compatible: the container code
is mostly inline anyway and will use whatever flags the application is using,
while the non-inline code is out-of-bounds for exceptions anyway.
--
Thiago Macieira
into a so/dll to perform it
sounds like premature pessimisation :)
The regular copy constructor is fast enough. There's no need to make the code
worse to read for minimal gain.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
On quarta-feira, 9 de maio de 2012 21.39.53, lars.kn...@nokia.com wrote:
How about this then?
https://codereview.qt-project.org/#change,25788
https://codereview.qt-project.org/#change,25787
Yes, something like that. I'm not sure we should do it on 5.0 though.
--
Thiago Macieira
-behave if an exception goes
through it. Since that's the case, we might as well save in code size and the
exception handling tables.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
On sábado, 12 de maio de 2012 15.28.16, Loaden wrote:
Hi, all!
I want build Qt5 use out-of-source like this way, and final failed.
What is this final that failed?
Out-of-source buiding works for me, though not all the time. Sometimes there
are issues that need fixing.
--
Thiago Macieira
was a public company, so the records are public.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description
pays back to Nokia is worth
200 full-time top-notch developers? I really want you to tell me with a
straight face that you can do the math and say it does.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB
understand, their build will have a renamed tool anyway.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
be necessary if you want to test (and, usually,
have more than one system).
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
On sábado, 12 de maio de 2012 22.28.40, Thiago Macieira wrote:
Developers like you might be the numerical majority, but when it comes to
number of products developed and shipped to customers, I'm pretty sure that
no one will come close to next billion.
Correcting myself. There is one who has
a q_object_cast to an interface.
At run-time they must match for the cast to succeed.
So it's ok to do a global search-and-replace changing com.trolltech to org.qt-
project?
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB
On domingo, 6 de maio de 2012 07.47.44, Thiago Macieira wrote:
On sábado, 5 de maio de 2012 23.18.18, Giuseppe D'Angelo wrote:
qgraphicsview.cpp-2790-d-useLastMouseEvent = false;
qgraphicsview.cpp-2791-// a hack to pass a viewport pointer to
the scene inside the leave event
On segunda-feira, 14 de maio de 2012 11.36.04, Thiago Macieira wrote:
On domingo, 6 de maio de 2012 07.47.44, Thiago Macieira wrote:
On sábado, 5 de maio de 2012 23.18.18, Giuseppe D'Angelo wrote:
qgraphicsview.cpp-2790-d-useLastMouseEvent = false;
qgraphicsview.cpp-2791
. But the user might install a subclass
of QGraphicsScene in the view and might inject other events, which would be of
the wrong type and cause a crash.
I cannot guarantee that I wouldn't be breaking anything.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source
://doc.trolltech.com/3.3/qfile.html#encodeName
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description
On segunda-feira, 14 de maio de 2012 13.16.46, Olivier Goffart wrote:
On Monday 14 May 2012 11:42:33 Thiago Macieira wrote:
On segunda-feira, 14 de maio de 2012 11.36.04, Thiago Macieira wrote:
Since no one has a suggestion on how to fix the hack, I'll close the
task
and abandon
On segunda-feira, 14 de maio de 2012 12.26.53, lars.kn...@nokia.com wrote:
Full support from my side for it.
https://codereview.qt-project.org/26155
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration
time by asking on IRC, but
leaving a comment on the change is also fine.
I've now pressed the button for you.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan
/ld:/build/qt5-2/qt
base/src/corelib/QtCore.dynlist:1: syntax error collect2: ld returned 1 exit
status
[snip]
Does anyone have some idea ? thanks
Please paste the full linker command-line, which make printed before the first
line you pasted here.
--
Thiago Macieira - thiago.macieira
reporting
Cons over proposal 1:
- less discoverable and harder to document that the option is needed in cases
like the FTP one above.
Which one shall it be?
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB
if that helps.
It is incorrect to write any constant larger than INT_MAX without the
suffixes...
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista
has been a problem in Qt for years. I've got
reports going as far back as 2010 on this.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista
On terça-feira, 15 de maio de 2012 17.17.47, Thiago Macieira wrote:
tst_qtendian.cpp:75: error: integer constant is too large for 'long'
type
[snip]
qint64 cannot be a long. Since it can't, I don't think that's what the
compiler is complaining about.
Note that your type isn't qint64
[-Wlong-
long]
stdin:1:14: error: ISO C++ 1998 does not support ‘long long’ [-Wlong-long]
But I cannot get your error alone. It's always matched by that second error
saying that C++98 does not support long long, which you didn't get.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software
miscompilation issues, the result of the tests is the same
no matter what compiler you use.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista
.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message part
Jens into service too :-)
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally
John
What's the benefit of this change? Do you have something planned for the future
that would require this?
From what I can tell, this would only remove the abstract base class...
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
this issue?
Those paths are not Qt's doing, but they come instead from the compiler. It
chooses how to save the path on the debug information.
In the case above, the path is an artifact of the #includes that were
followed.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect
changes fixing that. There seems to be a few bugs
here and there about how the zlib dependency is handled.
The patches aren't cleaned up unfortunately, which is why I haven't sent them.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
On quarta-feira, 16 de maio de 2012 09.32.59, Rohan McGovern wrote:
Thiago Macieira said:
I am guessing you all have transitioned to 64 bits for your build
system, etc. What is your policy statement on 32 bit systems? Try
not break them? They deserve to get broken? ??? For me I
, or don't know exactly what they want. There
must be room for the contributors to exercise their imaginations and come up
with new, revolutionary solutions.
I firmly believe that QML is in that camp.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source
tweaks it could be made to suit most people's requests.
No one has suggested an alternative.
So I suggest we spend our energy discussing those tweaks I mention, what's
necessary to make the technology more attractive to current developers, what
the impact on maintenance will be, etc.
--
Thiago
- should we use QWS's protocol or should we have something different?
- QWS was raster, so we need something different
- do we invent our own or is there something that we could use?
- there's Wayland...
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source
repository of Qt WebKit is a branch of the webkit SVN
that contains the latest version supposed to work with Qt. It's not exactly
the same thing.
If the Phonon devs do the same for qtphonon.git, I don't see a problem in
keeping the repository around. That's not the current situation.
--
Thiago
we move to at some later point.)
Distros of course should bundle Qt with the latest version from upstream.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660
On sexta-feira, 18 de maio de 2012 20.34.51, Thiago Macieira wrote:
(P1) expand the size of QBasicMutex and QMutex to accommodate more data,
for Mac and Windows. On Windows, the extra data required is one pointer (a
HANDLE), whereas on Mac it's a semaphore_t. Depending on the next task, we
On sexta-feira, 18 de maio de 2012 22.45.22, Olivier Goffart wrote:
On Friday 18 May 2012 20:34:51 Thiago Macieira wrote:
Hello
I've just completed a review of the QMutex family internals, as well as
the Intel optimisation manuals about threading, data sharing, locking
On sábado, 19 de maio de 2012 00.36.56, Olivier Goffart wrote:
On Friday 18 May 2012 23:25:47 Thiago Macieira wrote:
Which non-negligible performance penalty are you takling about here?
The need to allocate memory and do the test-and-set loop for setting the
private.
There is no memory
for Qt 5.1
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message
On sábado, 19 de maio de 2012 10.26.03, Thiago Macieira wrote:
But fast uncontended case is critical because it allows the use of mutex
in
part that might or not be used with threads. Example: QObject. We need to
put mutexes while emiting a signal because maybe it is used in multiple
there would not be improvement on Windows.
If we don't improve for recursive mutexes and I simply don't try Windows or
Mac, then there's no need to increase the mutex size.
Then I need only to look into QReadWriteLock.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open
of
locking, which is the goal of the current implementation by Olivier and Brad
(cheap to create, cheap to lock if not contended).
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
On domingo, 20 de maio de 2012 02.17.53, Olivier Goffart wrote:
On Saturday 19 May 2012 19:05:58 Thiago Macieira wrote:
On sábado, 19 de maio de 2012 18.34.30, Olivier Goffart wrote:
Hi,
Regarding valgrind:
*) On debug build, nothing is inlined.
*) If we keep it inline, then we
modifying qmake itself.
It's much easier to compile them as regular static libraries, then to merge
the .a archives using ar.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
On segunda-feira, 21 de maio de 2012 08.34.32, bradley.hug...@nokia.com wrote:
On May 18, 2012, at 8:34 PM, ext Thiago Macieira wrote:
Recommendations (priority):
(P0) de-inline QBasicMutex locking functions until we solve some or all of
the below problems
I agree with this, so
On segunda-feira, 14 de maio de 2012 18.29.23, Thiago Macieira wrote:
== Proposal 2 =
So instead of adding decodedPath(), decodedUserName(), decodedPassword(),
etc. and cluttering the Qt5 QUrl API like the Qt4 one was, there's a
separate proposal:
- add an option to QUrl
that compiler.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message
On segunda-feira, 21 de maio de 2012 17.07.51, Stephen Chu wrote:
On 5/21/12 4:28 PM, Thiago Macieira wrote:
On sexta-feira, 18 de maio de 2012 16.56.09, Stephen Chu wrote:
On the other hand, compiling using gcc 4.7 is successful. I am not sure
if gcc is more lex on this or Q_DECL_CONSTEXPR
On segunda-feira, 21 de maio de 2012 18.01.22, Stephen Chu wrote:
Q_DECL_CONSTEXPR inline QByteArray(QByteArrayDataPtr dd)
: d(reinterpret_castData *(dd.ptr))
{
}
And I don't think it can ever be made a constexpr.
I agree.
--
Thiago Macieira - thiago.macieira
if someone added that by accident. It's unlikely.
If that isn't the case, use qmake -d -d and analyse the output to see where
that gui came from. More than likely, qmake read some other file it wasn't
supposed to.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source
they very much liked the idea of spinning while trying to
acquire a lock (consumes power)... at least we have a call to
QThread::yieldCurrentThread(), though it would be interesting to see what
happens if we replace it with a PAUSE instruction.
--
Thiago Macieira - thiago.macieira (AT) intel.com
a maintainer of something is what requires dedication.
Unfortunately, for all sysadmin-related jobs, we have legal issues that need
to be dealt with, so it's not as simple as starting to do it. I don't know how
to go from here.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel
was *still* inserted into the application code.
So what matters to us is not the fact that the function is marked inline or
not. The problem is that the effects of such a function would be in the
application code, with the consequences that they can have.
--
Thiago Macieira - thiago.macieira
.
[1] http://labs.qt.nokia.com/2011/04/01/qt-hidden-gems/
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
On quarta-feira, 23 de maio de 2012 04.54.11, bradley.hug...@nokia.com wrote:
On May 22, 2012, at 11:01 AM, ext Thiago Macieira wrote:
And I don't think they very much liked the idea of spinning while trying
to
acquire a lock (consumes power)... at least we have a call to
QThread
it was so simple and
evident that I'd be able to remember or work it out again.
I haven't been able to. Fermat would be proud.
Anyway, that reminds me I have some pending QSharedPointer work to do. I'll
get on with it.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect
:-)
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message part
it doesn't
even include QTextCodec.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description
different purposes and we should benchmark.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description
! :-)
The warning needs to go away, at least, provided that Qt *is* tested on
Windows 8. Whether we add the enum or not, that's a bit orthogonal.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189
.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message part
On quinta-feira, 24 de maio de 2012 12.13.31, Yan Shapochnik wrote:
Since you are back porting this change to 4.8, I would also like to make a
suggestion and include Mac OS X 10.8 Mountain Lion support in the same
manner.
Yes, makes sense.
--
Thiago Macieira - thiago.macieira (AT) intel.com
On quinta-feira, 24 de maio de 2012 11.46.05, Alberto Mardegan wrote:
On 05/23/2012 02:43 PM, Thiago Macieira wrote:
My original solution was to have a parent only deref its children's shared
pointer counter, deleting it only if it became zero. That means that if
you
had a QSharedPointer
that we don't
clash with a user-provided zlib.
I don't understand #3 and the comment from Friedemann in the change doesn't
help.
I'd say also say that #1 is the simplest, short-term solution, but #4 is the
goal, after we have a decent buildsystem that can pull it off.
--
Thiago Macieira
On quinta-feira, 24 de maio de 2012 07.51.15, Carl Schumann wrote:
Is this unavailability over? Anyone have indications of problems?
Thanks for any insights please.
It's working for me. I've just pushed a commit.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel
.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message part
.
This was just something I experimented with, but didn't work as intended. It
crashed QWidget left and right.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15
::convertFromUnicode() and
QUtf8::convertToUnicode().
Keep them Latin1. At least the tools will not screw up user data if they can't
figure out the locale.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number
of
codecs, then you can't change it.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description
On sexta-feira, 25 de maio de 2012 06.27.05, lars.kn...@nokia.com wrote:
On 5/24/12 11:38 PM, ext Thiago Macieira thiago.macie...@intel.com
wrote:
On quinta-feira, 24 de maio de 2012 13.15.16, 1+1=2 wrote:
If we want to bootstrap tool such as qmake support utf8
Why would we want to?
One
on that too. Besides, helping in triaging *is* a form of contribution.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
kernel.
We could add the Mac OS X 10.9 macro, but not its cat name because we don't
know which one it will be.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15
on 64-bit, people might search for something specific to
64-bit.
Other useful information is the SHA-1 of the commit you tried and the configure
line.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration
the error was:
cl.exe: Bad command or file name ?
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description
was required, for example in
the use of QString.
While good, it was year behind the state of the art JS engine. It was much
much slower (did not have JIT) and the new ECMAScript feature were not
implemented yet. (the old engine is still available in the QtScript
Classic solution [1])
--
Thiago
On quinta-feira, 31 de maio de 2012 15.22.53, Flex Ferrum wrote:
In Qt 5 this option is already removed:
QMAKE_CFLAGS= -nologo -Zm200 -Zc:wchar_t
But Qt 4.8 still contains one.
Then the problem is solved.
We won't change Qt 4.8 now.
--
Thiago Macieira - thiago.macieira
it went on Linux and Windows.
[1] http://releases.qt-project.org/qt5.0/beta-snapshots/latest/
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista
.
The version is 11.0, but the marketing name is 2012. And the internal _MSC_VER
is probably around 1700 already :-)
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
On sexta-feira, 1 de junho de 2012 16.11.33, Matt Williams wrote:
On 1 June 2012 15:54, Joerg Bornemann joerg.bornem...@nokia.com wrote:
On 01/06/2012 15:30, ext Thiago Macieira wrote:
Allright, I take back everything. MS actually announced the RC of Visual
Studio 2012 yesterday:
http
it.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message part
that is not
recompiled will probably crash due to a change in the layout of the d pointer.
The change is fully source-compatible, though.
Those two changes fix a design flaw in QSharedPointer. The changes that follow
are simply cleanups and optimisations.
--
Thiago Macieira - thiago.macieira (AT) intel.com
anyone has compiler using that compiler for months or even
years.
It's completely untested. Here there be dragons.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan
On terça-feira, 5 de junho de 2012 16.48.58, João Abecasis wrote:
Thiago Macieira wrote:
On terça-feira, 5 de junho de 2012 13.20.36, João Abecasis wrote:
I would not go as far as saying that the concept is broken, but it
definitely isn't portable. One big issue is that nowadays we don't
. So it
seems an error, but does anyone know how to fix it ? or how to ignore such
error ?
You can remove this line. Declaring a QPair's type info is not necessary since
there's a partial template specialisation for it in qpair.h which will do the
right thing.
--
Thiago Macieira - thiago.macieira
guess he had already
left for the day.
That SHA-1 above is the commit for this patch:
https://codereview.qt-project.org/28033
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
?
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message part
if they want to, though.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally
On quarta-feira, 6 de junho de 2012 11.54.16, Oswald Buddenhagen wrote:
On Wed, Jun 06, 2012 at 09:03:46AM +0200, ext Thiago Macieira wrote:
Yeah, I broke it yesterday somehow creating a topic branch. I got a
database error when pushing and let Matias know immediately, but I guess
he had
, with the logs. Are you able to do that already?
[1] the commit that a build IDs refers to can be obtained from the Gerrit
repository
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
using QFile::decodeName (no-op
right now)
5) idem for Laszlo's command-line parser class
Later, we can decide whether to add escaping to those functions.
However, I cannot agree with bringing the setter functions back. I do agree
with removing them completely, though.
--
Thiago Macieira
flag
within this Makefile.
That is a mistake and needs to be fixed. QtWidgets cannot link to
QtPlatformSupport (which, by the way, is a .a file, never a .so one).
However, can you check if the platform plugins have the same issue?
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software
it.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
Knarrarnäsgatan 15, 164 40 Kista, Stockholm, Sweden
signature.asc
Description: This is a digitally signed message part
no. see first paragraph. doing this would only increase the mess.
How do you figure making no-op changes increase the mess?
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB - Registration Number: 556189-6027
pointer)
The optimisation simply changes what the pointed function does. Wiithout it,
it will call another stored function pointer. With it, it will call delete
directly.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source Technology Center
Intel Sweden AB
containing a
pass / fail and, maybe, logs. This is much more complex, since it needs to
deal with connections breaking. The CI control script needs to be modified to
accept multiple replies and produce a conclusion.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open Source
.
I've just had an idea to make this optimisation slightly more generic. I need
to experiment a little to see if it's worth it. If it is, I'll send a
replacement and let reviewers judge which one is better.
--
Thiago Macieira - thiago.macieira (AT) intel.com
Software Architect - Intel Open
301 - 400 of 6026 matches
Mail list logo
