[Development] Using string literals in autotests

[Axel Spoerl via Development]

Hi,

is there any documentation, blog post, wiki page, other source or guideline 
about usage of string literals in autotests?

More specifically:

The line
QString ("I love QLatin1StringView");

...triggers 'QString' is deprecated: Use fromUtf8, QStringLiteral, or 
QLatin1StringView. QString has been explicitly marked deprecated here'

in qwindow.cpp, but not in tst_qwindow.cpp.

In gui autotests, only tst_QStandardItemModel uses the _L1 macro, in widgets 
only tst_QComboBox. "using namespace Qt::StringLiterals" can be found at the 
beginning of a test class, as well as at the beginning of a test function.
>From what I see, most test functions actually construct QString with a const 
>char*. Some use QStringLiteral locally, others use QLatin1StringView.

Since _L1 usage is massive in corelib, I wonder whether there is a standard 
that everyone can apply when writing or reviewing autotests. If it exists and I 
have overlooked it, please forgive my negligence and point me to it.


  *
What is the recommended way to construct a string in autotests?
  *
Where to place "using namespace"?
  *
Shall string constructions be fixed as a drive-by?

IMHO, clarifying these questions generally helps and expedites code reviews.
See 
https://codereview.qt-project.org/c/qt/qtbase/+/551645
 as a recent example.

Thanks, kind regards and happy Easter
Axel
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating Jøger Hansegård for approver rights

[Axel Spoerl via Development]

+1

Von: Development  im Auftrag von Tor Arne 
Vestbø via Development 
Gesendet: Donnerstag, 14. März 2024 10:06
An: development 
Betreff: [Development] Nominating Jøger Hansegård for approver rights

Hi,

I would like to nominate Jøger Hansegård for approver rights in the Qt project.

Jøger joined The Qt Company 10 months ago and has since then been getting his 
hands dirty in Qt Multimedia, and lately focusing on color management.

Jøger is a thorough and responsible engineer and I trust that he will make a 
good approver for the Qt project.

Authored changes: 
https://codereview.qt-project.org/q/owner:joger.hansegard%2540qt.io
Reviews: https://codereview.qt-project.org/q/reviewer:joger.hansegard%2540qt.io

Cheers,
Tor Arne
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

[Development] Nominating Dr. Máté Barany as an approver for the Qt project

[Axel Spoerl via Development]

Dear Colleagues,

I hereby nominate Dr. Máté Barany as an approver for the Qt project.
Máté has been a valuable contributor and reviewer, providing sound code, 
guidance and input.
As a reference, see his dashboard 
here:https://codereview.qt-project.org/dashboard/1010490

I fully trust his advice, expertise and judgement. I am certain that he will 
exercise approver rights to the benefit of the Qt project.

I am neither working in Máté's team, nor sharing an office with him.
Máté and I do know each other personally.

Kind regards
Axel


-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating Matthias Rauter for approval status

[Axel Spoerl via Development]

+1

On 30 Jan 2024, at 13:15, Paul Tvete via Development 
 wrote:


Hi,

I would like to nominate Matthias Rauter as an approver for the Qt Project.

Matthias has been working on Qt for more than a year now. In this time, he has 
done great work on Qt Location and Qt SVG, among other. I have had the pleasure 
to work with him on the Curve Rendering project in Qt Quick Shapes where he has 
made impressive contributions. He has been consistently professional in 
development and review, and I am certain that he will exercise his approver 
powers responsibly.

List of changes made by Matthias: 
https://codereview.qt-project.org/q/owner:matthias.rauter%2540qt.io
Matthias's review activity: 
https://codereview.qt-project.org/q/commentby:matthias.rauter%2540qt.io

Cheers,
 - Paul
--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Stepping down as Android maintainer

[Axel Spoerl via Development]

+1 for Assam - it's great working with you!

Von: Development  im Auftrag von Mårten 
Nordheim via Development 
Gesendet: Montag, 8. Januar 2024 10:47
An: Fabian Kosmale ; development@qt-project.org 
; BogDan Vatra ; Przemysław 
Nogaj 
Betreff: Re: [Development] Stepping down as Android maintainer

Thanks for the great work BogDan!
And +1 for Assam!

Mårten


From: Development  on behalf of Przemysław 
Nogaj via Development 
Sent: Monday, January 8, 2024 10:06
To: Fabian Kosmale; development@qt-project.org; BogDan Vatra
Subject: Re: [Development] Stepping down as Android maintainer

Hard to find better person than Assam! +1




From: Development  on behalf of Fabian 
Kosmale via Development 
Sent: Monday, January 8, 2024 10:00:42 AM
To: development@qt-project.org ; BogDan Vatra 

Subject: Re: [Development] Stepping down as Android maintainer

⚠ This email originates from outside the organization or the sender could not 
be verified.

Hi,

first of all, thanks to BogDan for all the work he did on the Android port. 
We've come quite a way since
the initial days of the Necessitas project!

Next, I'll second the +1 for Assam - he has been very helpful and responsive 
with addressing issues on
the Android platform in all areas, including tooling support, solving CI 
problems and the framework code
itself.

Regards,
Fabian


Von: Development  im Auftrag von BogDan 
Vatra via Development 
Gesendet: Montag, 8. Januar 2024 09:47
An: development@qt-project.org
Betreff: [Development] Stepping down as Android maintainer

Hello there,


  I have been less active on the Android port recently and Assam has been doing 
the majority of the work maintaining the Android port.

I'm therefor stepping down as the maintainer of the Android port and nominate 
Assam to take over.


Cheers,

BogDan.


--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
Please consider the environment before printing this e-mail.

This e-mail (including any attachments) is intended solely for the use of the 
individual or entity to which it is addressed and may contain confidential 
information. This message is not a binding agreement and does not conclude an 
agreement without the express confirmation of the sender’s superior or a 
director of the company.
If you are not the intended recipient, you should immediately notify the sender 
and delete the message along all the attachments. Any disclosure, copying, 
distribution or any other action is prohibited and may be illegal. No e-mail 
transmission can be guaranteed to be 100% secure or error-free, as information 
could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or 
contain viruses. Although Spyrosoft has taken precautions to ensure that this 
e-mail is free from viruses, the company does not accept liability for any 
errors or omissions in the content of this message, which arise as a result of 
the e-mail transmission. This e-mail is deemed to be professional in nature. 
Spyrosoft does not permit the employees to send emails which contravene 
provisions of the law.
--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Failed to run configure.bat in qt/qt5 on MINGW64/MSYS2 shell?

[Axel Spoerl via Development]

Hi,
just ran the configure command without any issues on 6.2.9 / mingw64.
Which submodules are you using?
Is the build tree clean?
Is there a specific reason for using -developer-build in release mode?
Does a simple ../../configure (without arguments) work?
Have you tested 6.5 / 6.6 as well?
I suggest to file a bug report, including the cmake output, CMakeOutput.log, 
CMakeError.log.
Cheers,
Axel

Von: Development  im Auftrag von Haowei Hsu 

Gesendet: Samstag, 7. Oktober 2023 19:10
An: Qt development mailing list 
Betreff: Re: [Development] Failed to run configure.bat in qt/qt5 on 
MINGW64/MSYS2 shell?

Hello, Qt Development Team.

It's been a while since the last time we discuss this issue.
And recently, I re-tried to configure qt-6.2.4 with msys2/mingw64 shell.
However, it still failed with the same error again:

Configuring 'qttools'
-- CMAKE_BUILD_TYPE was set to: 'Release'
-- Performing Test HAVE_FFI_CALL
-- Performing Test HAVE_FFI_CALL - Success
-- Found FFI: C:/msys64/mingw64/lib/libffi.dll.a
-- Found ZLIB: C:/msys64/mingw64/lib/libz.dll.a (found version "1.3.#define 
ZLIB_VERSION "1.3"")
CMake Error at C:/msys64/mingw64/lib/cmake/zstd/zstdTargets.cmake:42 (message):
  Some (but not all) targets in this export set were already defined.

  Targets Defined: zstd::libzstd_static

  Targets not yet defined: zstd::libzstd_shared

Call Stack (most recent call first):
  C:/msys64/mingw64/lib/cmake/zstd/zstdConfig.cmake:1 (include)
  qtbase/cmake/FindZSTD.cmake:21 (find_package)
  C:/msys64/mingw64/lib/cmake/llvm/LLVMConfig.cmake:269 (find_package)
  C:/msys64/mingw64/lib/cmake/clang/ClangConfig.cmake:10 (find_package)
  qttools/cmake/FindWrapLibClang.cmake:14 (find_package)
  qtbase/cmake/QtFindPackageHelpers.cmake:130 (find_package)
  qttools/configure.cmake:19 (qt_find_package)
  qtbase/cmake/QtFeature.cmake:573 (include)
  qttools/src/CMakeLists.txt:21 (qt_feature_evaluate_features)


-- Configuring incomplete, errors occurred!
CMake Error at 
D:/Repo/tmp/qt-6.2.4/qtbase/cmake/QtProcessConfigureArgs.cmake:957 (message):
  CMake exited with code 1.

After reading the log, I think it is because the configure process called 
find_package(zstd) twice:

  1.  The 1st time happens when configuring 'qtbase'
  2.  The 2nd time happens when configuring 'qttools'

Let's why the 2nd time thinks the 'zstd::libzstd_static' target is already 
defined.
If so, I wondered whether you have any solution to the cause of this 
zstd-relared error?

---
Haowei Hsu

Haowei Hsu mailto:hwhsu1...@gmail.com>> 於 2023年8月25日 週五 
下午4:31寫道：
Hello, Dennis.
I followed the command you provided:

../../configure -release -developer-build -nomake examples -nomake tests -- 
-DFEATURE_system_zlib=OFF

However, it still failed.
You can see the attachment with the full log: 
log-still-failed-with-feature-system-zlib-off.txt
---
Haowei Hsu
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] QAbstractItemModel's meta-object got changed in QtQuick

[Axel Spoerl via Development]

Hi Songziming,

Thanks for sharing.
The file system model is stack allocated after the application and the qml 
engine. So it’s deleted before them, when main() goes out of scope. The QML 
engine shutdown still finds a (stale) QObject and tries to disconnect signals 
from it, hence the warnings.

Allocating the model on the heap solves the issue. If parented to the engine, 
no manual deletion is necessary.

Brgds
Axel


On 15 Aug 2023, at 08:45, Ziming Song  wrote:

Hi,

I create the custom model object in main function on stack. Model is 
instantiated after QQmlApplicationEngine, and is deleted before 
QQmlApplicationEngine. During custom model’s destruction, 
QItemSelectionModelPrivate::initModel(NULL) is called.

I also tested QFileSystemModel, which also reports signals not found.

Bug reported: https://bugreports.qt.io/browse/QTBUG-116056

Thanks
songziming

发件人: Axel Spoerl
发送时间: 2023年8月14日 21:26
收件人: Ziming Song
抄送: development@qt-project.org
主题: Re: [Development] QAbstractItemModel's meta-object got changed in QtQuick

Hi,

The meta object doesn’t change during execution. The messages probably mean, 
that upon app close, the custom class (inheriting from QObject) is already 
deleted. Only a QObject is left, which is what className() correctly reports.

Maybe throw a qDebug() in the custom class destructor, to check if it is 
reached too early. I personally haven’t seen error logs of that kind. It 
doesn’t seem right that the custom class gets deleted, with its connections 
still being reported as active. Unless there is a bug in the custom class 
implementation, I suggest to file a bug report with a minimal reproducer.

Cheers
Axel


On 14 Aug 2023, at 15:06, Ziming Song 
mailto:s.zim...@hotmail.com>> wrote:

Hi,

I’m playing with QtQuick TreeView with custom QAbstractItemModel in C++. The 
program runs fine, except some error logs when program exits:

qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::rowsAboutToBeRemoved(QModelIndex,int,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::columnsAboutToBeRemoved(QModelIndex,int,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::rowsAboutToBeInserted(QModelIndex,int,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::columnsAboutToBeInserted(QModelIndex,int,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::rowsAboutToBeMoved(QModelIndex,int,int,QModelIndex,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::columnsAboutToBeMoved(QModelIndex,int,int,QModelIndex,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::rowsMoved(QModelIndex,int,int,QModelIndex,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::columnsMoved(QModelIndex,int,int,QModelIndex,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::layoutAboutToBeChanged(QList,QAbstractItemModel::LayoutChangeHint)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::layoutChanged(QList,QAbstractItemModel::LayoutChangeHint)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::modelReset()

This is what I found.

Error messages come from QItemSelectionModelPrivate::initModel, which is called 
(at least) twice, one during app start to set the model and connect some 
signals, one during app close to disconnect signals and set model to NULL.

At app starting, m->metaObject()->className() is correct (my custom model class 
name).

At app closing, m->metaObject() value changes, and m->metaObject()->className() 
is “QObject”, which doesn’t have those signals, thus the error message.

Can metaobject be modified during execution? If so, why?

Thanks in advance
songziming
--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] QAbstractItemModel's meta-object got changed in QtQuick

[Axel Spoerl via Development]

Hi,

The meta object doesn’t change during execution. The messages probably mean, 
that upon app close, the custom class (inheriting from QObject) is already 
deleted. Only a QObject is left, which is what className() correctly reports.

Maybe throw a qDebug() in the custom class destructor, to check if it is 
reached too early. I personally haven’t seen error logs of that kind. It 
doesn’t seem right that the custom class gets deleted, with its connections 
still being reported as active. Unless there is a bug in the custom class 
implementation, I suggest to file a bug report with a minimal reproducer.

Cheers
Axel

On 14 Aug 2023, at 15:06, Ziming Song  wrote:

Hi,

I’m playing with QtQuick TreeView with custom QAbstractItemModel in C++. The 
program runs fine, except some error logs when program exits:

qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::rowsAboutToBeRemoved(QModelIndex,int,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::columnsAboutToBeRemoved(QModelIndex,int,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::rowsAboutToBeInserted(QModelIndex,int,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::columnsAboutToBeInserted(QModelIndex,int,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::rowsAboutToBeMoved(QModelIndex,int,int,QModelIndex,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::columnsAboutToBeMoved(QModelIndex,int,int,QModelIndex,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::rowsMoved(QModelIndex,int,int,QModelIndex,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::columnsMoved(QModelIndex,int,int,QModelIndex,int)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::layoutAboutToBeChanged(QList,QAbstractItemModel::LayoutChangeHint)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::layoutChanged(QList,QAbstractItemModel::LayoutChangeHint)
qt.core.qobject.connect: QObject::disconnect: No such signal 
QObject::modelReset()

This is what I found.

Error messages come from QItemSelectionModelPrivate::initModel, which is called 
(at least) twice, one during app start to set the model and connect some 
signals, one during app close to disconnect signals and set model to NULL.

At app starting, m->metaObject()->className() is correct (my custom model class 
name).

At app closing, m->metaObject() value changes, and m->metaObject()->className() 
is “QObject”, which doesn’t have those signals, thus the error message.

Can metaobject be modified during execution? If so, why?

Thanks in advance
songziming
--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Can't get review for more than two years

[Axel Spoerl via Development]

Hi Ilya,
I had a look at the patch and commented it.
IMHO it raises a valid point, but it can't be landed like this.
Suggest to file a suggestion in https://bugreports.qt.io, to document in more 
detail what this is about.
Cheers
Axel

Von: Development  im Auftrag von Ilya Fedin 

Gesendet: Donnerstag, 29. Juni 2023 00:43
An: development@qt-project.org 
Betreff: Re: [Development] Can't get review for more than two years

On Wed, 28 Jun 2023 19:21:30 -0300
Lisandro Damián Nicanor Pérez Meyer  wrote:

> Hi,
>
> On Tue, 20 Jun 2023 at 02:41, Ilya Fedin  wrote:
> >
> > Hi,
> >
> > I have a change[1] I made two years ago. People were adding another
> > people to reviewers as no one of them had knowledge to review the
> > change. Since some time people has just started ignoring pings. More
> > than two years has passed but the change is still there, with no
> > votes nor clear explanation of what blocks it. It's the most
> > terrible contributing experience I've ever had.
> >
> > [1] https://codereview.qt-project.org/c/qt/qtbase/+/343628
>
> The patch you proposed has comments and NACKs.
>
> I'll add more info: the problem you are trying to solve **might** be
> easily solved by installing xdg-desktop-portal and/or some other
> portal like the gtk and kde ones.
>
> My 2c, Lisandro
>
>

They were added thanks to this e-mail yet discussion has stopped even
though I've answered to those NACKs (which are based on false
assumptions)

I already have xdg-desktop-portal installed, Qt doesn't read font
settings from it (and it shouldn't really use portals for that on X11,
that's relevant only for Wayland).
--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating Santhosh Kumar Selvaraj for approver rights

[Axel Spoerl via Development]

+1
Santhosh is a highly experienced software engineer, a very good reviewer and I 
trust he will add value as an approver.
Disclaimer: Santhosh and I are office roommates.

On 20 Jun 2023, at 21:26, Shawn Rutledge via Development 
 wrote:

 +1

On 20 Jun 2023, at 20:55, Jan-Arve Sæther via Development 
 wrote:

Hello all,

I would like to nominate Santhosh Kumar Selvaraj for approver rights in the Qt 
project.

Santhosh is a member of the UI Team, and has been working on improvement to our 
styles, dark mode support, palette handling both in qtbase and qtdeclarative.

You can see his merged changes here:
https://codereview.qt-project.org/q/owner:santhosh.kumar.selvaraj%2540qt.io+is:merged

and his reviews here:

https://codereview.qt-project.org/q/reviewer:santhosh.kumar.selvaraj%2540qt.io

cheers,
---
Jan Arve Sæther
Team Lead

The Qt Company
Sandakerveien 116
0484, Oslo, Norway
jan-arve.saet...@qt.io
http://qt.io
---


--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating Artem Dyomin as Approver

[Axel Spoerl via Development]

+1

Von: Development  im Auftrag von Lars Knoll 

Gesendet: Samstag, 27. Mai 2023 17:41
An: Qt development mailing list 
Betreff: [Development] Nominating Artem Dyomin as Approver

Hi all,

I’d like to nominate Artem Dyomin for approver rights in Qt.

Artem has been working with Qt Multimedia since last summer, doing a very good 
job implementing new features, fixing bugs and refactoring code in the module.

You can see his merged changes here: 
https://codereview.qt-project.org/q/owner:artem.dyomin%2540qt.io+is:merged

And his reviews here: 
https://codereview.qt-project.org/q/reviewer:artem.dyomin%2540qt.io

Cheers,
Lars

-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating Konrad Kujawa as approver

[Axel Spoerl via Development]

+1

On 24 May 2023, at 12:32, Alexey Edelev via Development 
 wrote:


Hello everyone,

I would like to nominate Konrad Kujawa for approver rights in the Qt project.

Konrad is a member of the Qt Core team, and has been mainly working on
QtGrpc among other contributions to qtbase, qthttpserver, qtdeclarative and
other repos.

You can see his merged changes here:
https://codereview.qt-project.org/q/owner:konrad.kujawa%2540qt.io+is:merged

and his reviews here:
https://codereview.qt-project.org/q/reviewer:konrad.kujawa%2540qt.io


Alexey Edelev

Software Engineer

Qt Group
Erich-Thilo-Str. 10 12489
Berlin, Germany

alexey.ede...@qt.io

www.qt.io

[https://s3.eu-north-1.amazonaws.com/email-signature-tool-leroy/Qt-Group-logo-black-1.png]
[https://s3.eu-north-1.amazonaws.com/email-signature-tool-leroy/facebook-x2-right.png]

[https://s3.eu-north-1.amazonaws.com/email-signature-tool-leroy/twitter-x2.png] 
 
[https://s3.eu-north-1.amazonaws.com/email-signature-tool-leroy/linkedin-x2.png]
 
[https://s3.eu-north-1.amazonaws.com/email-signature-tool-leroy/youtube-x2.png] 

--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating Edward Welbourne as QLocale / date/time maintainer

[Axel Spoerl via Development]

A very warm and happy +1

Von: Development  im Auftrag von Marc Mutz 
via Development 
Gesendet: Donnerstag, 4. Mai 2023 12:10
An: development@qt-project.org 
Betreff: [Development] Nominating Edward Welbourne as QLocale / date/time 
maintainer

Hi,

I'd like to nominate Eddy as the maintainer for the QLocale and
src/corelib/time QtCore subsystems. Eddy is filling that role de-facto
already; making it de-jure sounds only logical.

I asked, and he'd be on board, if we'd have him.

Anyone else in favour? (I'm not sure I have a vote, actually...)

Thanks,
Marc

--
Marc Mutz 
Principal Software Engineer

The Qt Company
Erich-Thilo-Str. 10 12489
Berlin, Germany
www.qt.io

Geschäftsführer: Mika Pälsi, Juha Varelius, Jouni Lintunen
Sitz der Gesellschaft: Berlin,
Registergericht: Amtsgericht Charlottenburg,
HRB 144331 B
--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] API style guide: scoped enum or not?

[Axel Spoerl via Development]

+1 for every new enum added being an enum class. Exceptions to be approved here 
case by case. 

> On 3 May 2023, at 18:42, Giuseppe D'Angelo via Development 
>  wrote:
> 
> Il 02/05/23 10:58, Volker Hilsheimer via Development ha scritto:
>> During the header review, but also in API discussions leading up to it, we 
>> had a few cases where it would have helped if we had clearer guidelines 
>> about when to use scoped enums, and when not.
>> Scoped enums have some clear technical advantages (such as better type 
>> safety, thanks to no implicit conversion to int). And they sometimes result 
>> in better APIs when enum values don’t have to repeat the enum’s name in 
>> order to be clear.
> 
> Should we vote on this? To me it's a no brainer: any new enumeration added to 
> Qt shall be an enum class.
> 
>> But sometimes it’s also creating too much verbosity to use a scoped enum 
>> (ie. Qt::Orientation::Horizontal would perhaps not be an improvement).
> 
> I wouldn't consider this tiny bit of extra verbosity a huge impediment. Note 
> that Qt::Horizontal is violating the API naming guidelines. It should've been 
> called Qt::HorizontalOrientation. How is that now better than 
> Qt::Orientation::Horizontal?
> 
> No, Qt::Horizontal isn't "unambiguous" so it can't be non-qualified. Does it 
> refer to what? Text alignment? Text direction? Layout direction? (Hint: none 
> of these.)
> 
> The extra verbosity e.g. in switches can be tamed; one more reason to upgrade 
> to C++20:
> 
> https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1099r5.html
> 
> My 2 c,
> -- 
> Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer
> KDAB (France) S.A.S., a KDAB Group company
> Tel. France +33 (0)4 90 84 08 53, http://www.kdab.com
> KDAB - The Qt, C++ and OpenGL Experts
> 
> -- 
> Development mailing list
> Development@qt-project.org
> https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

[Development] KDE ColorScheme change notifications on DBus

[Axel Spoerl via Development]

Good morning,

this is a call to KDE experts on this line.

In order to react to KDE color scheme changes, Qt listens to DBus for changes 
(under more) of the keys

  *   "ColorScheme" in org.kde.kdeglobals.General
  *   "widgetStyle" in org.kde.kdeglobals.KDE

A DBus signal correctly received and processed by Qt would look like that:

---snip---
method return time=1682062165.741561 sender=org.freedesktop.DBus -> 
destination=:1.87 serial=50 reply_serial=89
signal time=1682062165.742192 sender=:1.28 -> destination=(null destination) 
serial=38 path=/org/freedesktop/portal/desktop; 
interface=org.freedesktop.impl.portal.Settings; member=Setting
Changed
  string "org.kde.kdeglobals.General"
  string "ColorScheme"
  variant   string "BreezeLight"
---snap---

On some systems, however, none of signals mentioned gets emitted. As a 
consequence, Qt doesn't notify its applications: 
https://bugreports.qt.io/browse/QTBUG-103093
=> I fail to reproduce the bug, so I can only assume that it a local 
configuration issue (e.g. Plasma only installation).
=> OTOH I can't find the spot in the KDE documentaiton, where it is defined how 
to reliably subscribe to changes of color scheme, widget style and the like.

Questions:
a) In which cases are the mentioned DBus emitted or not?
b) Could you point me at the respective spot in the KDE documentation?

Thanks and brgds
axel
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating Amir Masoud Abdol as approver

[Axel Spoerl via Development]

+1

Von: Development  im Auftrag von Alexandru 
Croitor via Development 
Gesendet: Mittwoch, 29. März 2023 15:31
An: Qt development mailing list 
Betreff: [Development] Nominating Amir Masoud Abdol as approver

Hi,

I would like to nominate Amir Masoud Abdol for approver rights in the Qt 
project.

He's been doing good work in the Qt build system, as well as tidying up code 
across all repositories to prepare Qt for unity builds.

I trust him to approve changes responsibly.

Work: https://codereview.qt-project.org/q/owner:amir.abdol%2540qt.io

Reviews: https://codereview.qt-project.org/q/reviewer:amir.abdol%2540qt.io
--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] who can fix this bug?

[Axel Spoerl via Development]

The traces posted don't say much.
Check the syslog in /var/log/messages and / or the output of journalctl

Update the bug report, especially if you find lines containing:

qt.qpa.xcb: QXcbConnection: XCB error...


Von: Development  im Auftrag von Thiago 
Macieira 
Gesendet: Mittwoch, 1. März 2023 21:29
An: development@qt-project.org 
Betreff: Re: [Development] who can fix this bug?

On Wednesday, 1 March 2023 11:36:05 PST Alexander Procenko wrote:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1031489

NVidia driver involved → NVidia driver bug (guilty until proven innocent)→
NVidia people have to fix.

Pasting a stack trace could help prove the driver innocent.

--
Thiago Macieira - thiago.macieira (AT) intel.com
  Cloud Software Architect - Intel DCAI Cloud Engineering
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Resizing borders for dock widgets

[Axel Spoerl via Development]

Hi David,
The margin for recognizing a mouse resize is handled by the window manager, 
hence not controlled by Qt.
Since a QDockWidget is a window of its own and not embedded in a main window, 
the margins for resize handling are a little smaller than otherwise
(at least for Linux, not sure for other OSes).
That's why a dock widget is more affected if the window manager uses a thin 
border margin.
Depending on the window manager used, that margin can typically be modified on 
a theme level.
In GTK themes, the property is called "border-right-width" (left, top, bottom 
respectively).
In the Ambiance theme (frequently used used on Ubuntu), the property is set 
with a distance and defaults to 1.
You could increase the margin to 5px by adding / modifying a line in the theme:

(left, bottom, top respectively).
Cheers
Axel


Von: Development  im Auftrag von David C. 
Partridge 
Gesendet: Samstag, 18. Februar 2023 12:21
An: development@qt-project.org 
Betreff: [Development] Resizing borders for dock widgets


When a dock widget is undocked (at least when using the “Fusion” style), the 
resizing border is very small (perhaps only 1 pixel).


This means it can the tricky to resize it on hi-res monitors.

Can this be changed please?



Cheers, David




-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Qt TextToSpeech: Adding dependency to Qt Multimedia - ok?

[Axel Spoerl via Development]

+1
QtSpeech will not work on all platforms without Qt Multimedia, so this 
dependency makes sense IMO.

Von: Development  im Auftrag von Volker 
Hilsheimer via Development 
Gesendet: Montag, 30. Januar 2023 16:45
An: Kai Köhne 
Cc: development@qt-project.org 
Betreff: Re: [Development] Qt TextToSpeech: Adding dependency to Qt Multimedia 
- ok?


> On 23 Jan 2023, at 16:07, Kai Köhne  wrote:
>
> Hi,
>
>> -Original Message-
>> From: Development  On Behalf Of
>> [...]
>> This is a binary compatibility breakage of sorts. Applications that were 
>> linked
>> against Qt 6.4 or Qt 6.5, and want to run against Qt 6.6 won’t work unless Qt
>> Multimedia is present.
>
> This doesn't violate the binary compatibility guarantee per se, IMO. The 
> guarantee is against the Qt framework itself, not against individual 
> libraries in it. We also don't allow upgrading individual Qt modules, for 
> instance.

To clarify, the problem is not upgrading an individual module here, but that an 
application running against Qt 6.6 will require Qt Multimedia, while an 
application running against Qt 6.4 or Qt 6.5 will not.

But, I agree that we can assume that on systems where binary compatibility 
matters, all Qt modules are installed (or get installed when upgrading).


> Anyhow, you could consider making the dependency optional at configure time. 
> Then users who don't need it could still configure without qtmultimedia - no 
> idea whether this is worth the hassle though.
>
> Regards
>
> Kai


Ok. Given the footprint of Qt TextToSpeech, I don’t think it’s worth the hassle 
to make this configurable.

Volker

--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Longstanding bug in Qt with Arabic language

[Axel Spoerl via Development]

Hi Muhammed,
thanks for pointing this issue out.
I will look into it and report back on QTBUG-93371 in the course of next week.
Brgds
Axel

Von: Development  im Auftrag von Muhammed 
Hanny Sabbagh via Development 
Gesendet: Freitag, 20. Januar 2023 08:21
An: Development 
Betreff: [Development] Longstanding bug in Qt with Arabic language

Hello Qt developers.

I want to ask about a longstanding bug in Qt, related to the Arabic language: 
https://bugreports.qt.io/browse/QTBUG-93371

The bug happens when accelerators are being used, which causes Arabic words to 
break and hence, the UI gets broken and non-usable in every Qt application. 
This happens on all Linux distributions.

This bug isn't new, it has been reported since 2016 in Qt5: 
https://bugreports.qt.io/browse/QTBUG-54350

And I personally remember reporting it in Qt4 since 10 years ago (but sadly I 
don't have the link from my old account).

So we are talking about decades of broken user interfaces for Arabic users with 
all Qt applications, in Q4 all the way up to Qt6.

Is there anything we can do to help fix this issue or "accelerate" interest in 
it? :) I have tens of folks who would confirm this issue and its importance to 
the Qt team if you would like.

This bug causes a very unfortunate user experience for Arabic users on the 
Linux desktop; because every Qt application they use has a broken UI.

I wish I was able to help by providing code but sadly I don't know C or the 
structure of Qt, so all I can do is bring attention to it and/or help test any 
possible fixes or patches. It sounds this bug can be fixed only from someone 
who knows the internals of Qt, mainly the Qt dev team itself (thus why I post 
here).

Thank you in advance for any possible help!
Regards.
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating Axel Spoerl as approver

[Axel Spoerl via Development]

Happy new year and thanks to all - it's an honor!
I'll use my privileges thoroughly and responsibly.
Axel

Von: Development  im Auftrag von Alex 
Blasche via Development 
Gesendet: Montag, 2. Januar 2023 09:34
An: development@qt-project.org 
Betreff: Re: [Development] Nominating Axel Spoerl as approver

Congratulations to Axel. Approver rights have been granted.

Happy New Year.
--
Alex


From: Development  on behalf of Volker 
Hilsheimer via Development 
Sent: Monday, 5 December 2022 10:57
To: development@qt-project.org
Subject: [Development] Nominating Axel Spoerl as approver

Hi,


I’d like to nominate Axel Spoerl as an approver for the Qt project.

Axel has been working in The Qt Company since January, writing tests, analysing 
and fixing bugs, participating in the port of Qt Speech to Qt 6, investigating 
and stabilising flaky tests across all platforms, and most recently 
implementing platform theme support for GTK3-based Linux desktop environments.

I trust him to be a good approver. Links to gerrit dashboards:

Patches: https://codereview.qt-project.org/q/owner:axel.spoerl%2540qt.io
Reviews: https://codereview.qt-project.org/q/reviewer:axel.spoerl%2540qt.io

Disclosure: I’m Axel’s indirect line manager at The Qt Company in Oslo.


Volker

___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] How to modify the "Full Name" of Jira?

[Axel Spoerl via Development]

Hi,
thanks for reaching out. Processing might take a few days longer than usual due 
to Christmas bank holidays.
Cheers
Axel

Von: Development  im Auftrag von JiDe Zhang 

Gesendet: Montag, 26. Dezember 2022 03:11
An: Qt邮件列表 
Betreff: Re: [Development] How to modify the "Full Name" of Jira?

Hi Paul,

Thank you.
I sent an email to jira-ad...@qt-project.org, but I did not receive a reply.


From: Paul Wicking 
Sent: Wednesday, December 21, 2022 16:02
To: JiDe Zhang 
Cc: Qt邮件列表 
Subject: Re: [Development] How to modify the "Full Name" of Jira?

Hi,

get in touch with jira-ad...@qt-project.org 
for these types of requests.

Cheers,
Paul

On 21 Dec 2022, at 03:28, JiDe Zhang  wrote:

Hi, My account of Jira is "zccrs", I want to modify my "Full Name" to "JiDe 
Zhang", but I can't find an edit button for it.
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating Mikołaj Boć as approver

[Axel Spoerl via Development]

+1

Von: Development  im Auftrag von Paul 
Wicking via Development 
Gesendet: Mittwoch, 21. Dezember 2022 16:09
An: Morten Sørvig 
Cc: development@qt-project.org 
Betreff: Re: [Development] Nominating Mikołaj Boć as approver

+1

On 21 Dec 2022, at 15:42, Morten Sørvig via Development 
 wrote:

Hello again,

Correct links to gerrit should be:

https://codereview.qt-project.org/q/owner:Mikolaj.Boc%2540qt.io
https://codereview.qt-project.org/q/reviewer:Mikolaj.Boc%2540qt.io

(copy/paste error on my part :)

Morten

On 21 Dec 2022, at 15:21, Morten Sørvig via Development 
mailto:development@qt-project.org>> wrote:

Hi,


I’d like to nominate Mikołaj Boć as an approver for the Qt project.

Mikołaj joined the Qt Company earlier this year and hit the ground running. He 
has contributed features and many bug fixes for the Qt for WebAssembly platform 
integration, as well as bug fixes for other parts of Qt.

I trust him to be a good approver. Links to gerrit dashboards:

Patches: 
https://codereview.qt-project.org/q/owner:Mikolaj.Boc%2540qt.io
Reviews: 
https://codereview.qt-project.org/q/reviewer:Mikolaj.Boc%2540qt.io

(I’m a colleague of Mikołaj at the Qt Company where we are on the same team)

Regards,
Morten
___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Re: [Development] Nominating Mårten Nordheim and Timur Pocheptsov as new co-maintainers of Qt WebSocket

[Axel Spoerl via Development]

+1

And I’d like to nominate Mårten Nordheim and Timur Pocheptsov as 
co-maintainers. I’ve confirmed with them, and they would be ok with extending 
their existing co-maintainership of Qt Network to that module as well.



___
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development