Re: [Development] Moving QDesktopServices from Gui to Core?

2024-05-06 Thread Jaroslaw Kobus via Development
The basic question: does it mean moving any public class / function from one lib into another? If so, how do you want to resolve the BC issue, especially on Win? Jarek From: Development on behalf of Marc Mutz via Development Sent: Monday, May 6, 2024

Re: [Development] Should QObject::event() be protected or public?

2024-03-15 Thread Jaroslaw Kobus via Development
ha scritto: >> Il 15/03/24 19:17, Jaroslaw Kobus via Development ha scritto: >>> +1. Typically, the designer of a subclass knows what he is doing. But it >>>also happens that users of this class know better how to use it :) >> I'm not sure what this means. >>

Re: [Development] Should QObject::event() be protected or public?

2024-03-15 Thread Jaroslaw Kobus via Development
> From: Development on behalf of Thiago > Macieira > Sent: Friday, March 15, 2024 7:03 PM > To: development@qt-project.org > Subject: Re: [Development] Should QObject::event() be protected or public? > > On Friday, 15 March 2024 10:09:31 PDT Marc Mutz via Development wrote: >> I like simple

Re: [Development] Should QObject::event() be protected or public?

2024-03-13 Thread Jaroslaw Kobus via Development
Most probably making it protected (temporarily) and trying to build everything else (including QtCreator) may reveal the original reason for being public. Jarek From: Development on behalf of Marc Mutz via Development Sent: Wednesday, March 13, 2024

Re: [Development] Future of java-style iterators?

2023-12-05 Thread Jaroslaw Kobus via Development
https://code.qt.io/cgit/qt-creator/qt-creator.git/tree/src/libs/utils/filesearch.h FileContainer & FileContainerIterator could be an inspiration, too. The SubDirFileContainer enables traversal according to the selected filters and exclusion filters. This all is a part of the Utils lib inside

Re: [Development] QTimer question

2023-05-30 Thread Jaroslaw Kobus via Development
machine) doesn't like the https://codereview.qt-project.org/c/qt-creator/qt-creator/+/480663 > > 3. Despite of how 1. and 2. will be proceeded, I think we should clearly > > document it. It's really not obvious that Qt users can't rely on the proper > > order of timeouts.

Re: [Development] QTimer question

2023-05-30 Thread Jaroslaw Kobus via Development
[Re-sending my reply to Thiago to the mailing list, as I think it may be possibly interesting for more people.] [In meantime I've created https://codereview.qt-project.org/c/qt/qtbase/+/480703 and waiting for CI results.] > On Monday, 29 May 2023 11:40:14 PDT Jaroslaw Kobus via Developm

[Development] QTimer question

2023-05-29 Thread Jaroslaw Kobus via Development
Hi All, when I start 2 single shot timers synchronously in a row, with exactly the same interval, from the same thread, can I rely on having their handlers called in the same order in which they were started? I.e.: QTimer::singleShot(1000, [] { qDebug() << "1st timer elapsed"; });

Re: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style

2023-05-09 Thread Jaroslaw Kobus via Development
> - drop the requirement for () in lambdas > > Rationale: this was a word-around for older MSVCs. The standard doesn't > require the empty parameter list (except when adorning the lambda with > noexcept etc, and then the compiler complains) and people have voted > with their feet: we now have

Re: [Development] API style guide: scoped enum or not?

2023-05-04 Thread Jaroslaw Kobus via Development
>> On 4 May 2023, at 17:34, Marc Mutz via Development >> wrote: >> >> On 04.05.23 15:38, Volker Hilsheimer via Development wrote: >>> Should we have Qt::TextLayout::Horizontal and Qt::Layout::Horizontal? Or >>> QSlider::Orientation::Horizontal? >> >> Without looking at the docs, tell me what

Re: [Development] API style guide: scoped enum or not?

2023-05-03 Thread Jaroslaw Kobus via Development
"enum class" has one advantage over "enum" inside a "class" : you may forward declare the "enum class", while the other not. That's quite often case that your header must include the other header just because you use the "enum" in "class" in your API and nothing more. Jarek

Re: [Development] Nominating Marcus Tillmanns as Approver

2022-11-22 Thread Jaroslaw Kobus via Development
+1 Good job, Marcus! Jarek From: Development on behalf of Cristian Adam via Development Sent: Tuesday, November 22, 2022 10:39 PM To: A. Pönitz; development@qt-project.org Subject: Re: [Development] Nominating Marcus Tillmanns as Approver +1 Cheers,

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-13 Thread Jaroslaw Kobus via Development
> 1. Use overloads for methods that take views or spans. In new API we can > omit the methods that take owning containers. If the overload set grows > out of hand, don't add the view/span alternative until we can remove > something. By Thiago's argument, that means not to convert existing >