Re: [Development] Timeout for QFuture::waitForFinished()

2018-07-10 Thread Lorenz Haas
Thanks for all your input. I'll have a look at QUIP-6 and a closer look at the implementation. 2018-07-10 23:55 GMT+02:00 Thiago Macieira : > On Tuesday, 10 July 2018 12:31:30 PDT Lorenz Haas wrote: >> So I wonder if there is any technical/intentional reason why there is >> no ti

Re: [Development] Timeout for QFuture::waitForFinished()

2018-07-10 Thread Lorenz Haas
Hi André, you are right. My statement was not precise enough: Adding a parameter to the existing function would be BiC, adding an overload "void QFutureWatcher::waitForFinished(int timeout);" is BC but would be SiC because it makes function pointers ambiguous - at least I think so. About the

[Development] Timeout for QFuture::waitForFinished()

2018-07-10 Thread Lorenz Haas
Hi, today I wished QFuture::waitForFinished() had a timeout parameter. After a brief look waitForFinished() uses a QWaitCondition::wait() internally, which already provides an optional timeout parameter. So I wonder if there is any technical/intentional reason why there is no timeout parameter?

Re: [Development] Threads and the SQL Module

2017-02-15 Thread Lorenz Haas
Hi, AFAIS it does not matter if sqlite is thread safe or not. The problem is that QSQLiteDriver itself is not thread safe. For example if two threads call beginTransaction() on the same driver and the "COMMIT" fails, both threads will call QSqlDriver::setLastError() which does "d->error =

Re: [Development] clang-format config file.

2016-06-30 Thread Lorenz Haas
Hi, > The style disabled any re-wraping of the comments, because the qdoc rules are > not encoded in clang-format. So comments will not be touched. just for the record: clang-format can exclude specific comment types from re-wrapping. Thus if you/we do not mind a "either re-wrap all comments or

Re: [Development] Is QFutureInterface internal like the other d-pointer classes?

2015-07-23 Thread Lorenz Haas
2015-07-23 13:20 GMT+02:00 Marc Mutz marc.m...@kdab.com: It's undocumented, and considered private, but since it's a template and thus must be visible, it effectively is public API and falls under the same restrictions for changes as public API. IOW: it cannot change (incompatibly) until Qt 6.

[Development] Is QFutureInterface internal like the other d-pointer classes?

2015-07-23 Thread Lorenz Haas
Hi, most - if not all - d-pointer/private implementation files are *internal* and should not be used in a normal project - meaning a project that just uses Qt. These files/classes are clearly marked by // // W A R N I N G // - // // This file is not part of the Qt API. It exists

Re: [Development] QVector now has rvalue push_back (was: Re: HEADS UP: potential trouble from a recent QVector change)

2015-07-21 Thread Lorenz Haas
2015-07-20 21:26 GMT+02:00 Thiago Macieira thiago.macie...@intel.com: Aside from the variadic and the templateness, what's the difference? The templateness changes how a type different than the vector's type gets constructed (it might undergo a conversion first). But assuming I am pushing