Re: [Development] Question about push reviewed code to Gerrit repo.

2012-02-17 Thread Oswald Buddenhagen
On Thu, Feb 16, 2012 at 11:26:24PM +0400, ext Denis Shienkov wrote: > Oops... Oswald, tell me please, what happened to the repo project > QtSerialPort of the Gerrit playground? What to do now? :) > err, i messed up the permissions. sorry. fixed. > Best regards, > Denis > > 16.02.2012, 22:05, "O

Re: [Development] Question about push reviewed code to Gerrit repo.

2012-02-16 Thread Denis Shienkov
Oops... Oswald, tell me please, what happened to the repo project QtSerialPort of the Gerrit playground? What to do now? :) Best regards, Denis 16.02.2012, 22:05, "Oswald Buddenhagen" : > On Thu, Feb 16, 2012 at 08:30:11PM +0400, ext Denis Shienkov wrote: > >>  I'm talking about the fix names of

Re: [Development] Question about push reviewed code to Gerrit repo.

2012-02-16 Thread Oswald Buddenhagen
On Thu, Feb 16, 2012 at 08:30:11PM +0400, ext Denis Shienkov wrote: > I'm talking about the fix names of the authors, ie that you do not like and > what specifically needs to change? > standardize the "fullname" in your commits on your real name, like in about half of the commits already. and re

Re: [Development] Question about push reviewed code to Gerrit repo.

2012-02-16 Thread Denis Shienkov
Hi, Oswald. > please read some appropriate manuals and tutorials on git history > rewriting, in particular git filter-branch. interactive rebasing is of > interest as well, though maybe not for such a mass change. This by itself, but I'm not talking about it. I'm talking about the fix names of th

Re: [Development] Question about push reviewed code to Gerrit repo.

2012-02-16 Thread Oswald Buddenhagen
On Thu, Feb 16, 2012 at 07:01:46PM +0400, ext Denis Shienkov wrote: > Hi, Oswald. > > >fwiw, if you have the time and inclination i'd recommend that you > >rewrite the git history of the project - at the very least, the author > >names need fixing. > > How exactly should correct author names, and

Re: [Development] Question about push reviewed code to Gerrit repo.

2012-02-16 Thread Denis Shienkov
Hi, Oswald. >fwiw, if you have the time and inclination i'd recommend that you >rewrite the git history of the project - at the very least, the author >names need fixing. How exactly should correct author names, and etc? >you are in the "Qt Serial Port" group and the group is self-owned, so >you

Re: [Development] Question about push reviewed code to Gerrit repo.

2012-02-16 Thread Oswald Buddenhagen
On Thu, Feb 16, 2012 at 06:13:17PM +0400, ext Denis Shienkov wrote: > Hi, Oswald. > > > which project is it? > > playground/qtserialport > ok, you are now an approver within your project. you should still try to stick to our commit policy and other guidelines, even if nobody from the "establishm

[Development] Question about push reviewed code to Gerrit repo.

2012-02-16 Thread Denis Shienkov
Hi, Oswald. > which project is it? playground/qtserialport > how many people are involved? two. Best regards, Denis > 16.02.2012, 17:55, "Oswald Buddenhagen" : > >>  On Thu, Feb 16, 2012 at 04:49:32PM +0400, ext Denis Shienkov wrote: >>>   How to add changes to the Gerrit pero after a success

Re: [Development] Question about push reviewed code to Gerrit repo.

2012-02-16 Thread Oswald Buddenhagen
On Thu, Feb 16, 2012 at 04:49:32PM +0400, ext Denis Shienkov wrote: > How to add changes to the Gerrit pero after a successful code review? > Who is it supposed to do? > gerrit is a bit daft, so only approvers can push even if the change is already approved. so you need to bug your reviewers to do

[Development] Question about push reviewed code to Gerrit repo.

2012-02-16 Thread Denis Shienkov
Hi all. How to add changes to the Gerrit pero after a successful code review? Who is it supposed to do? Can I perform an review of my own code, and personally update the repository? And if so - how is it done? In the example projects in the playground. I have something confused. Best regards, D