Re: [Development] QtBase WIP branch request

2016-10-14 Thread Morten Sorvig 

> On 12 Oct 2016, at 22:57, James Turner  wrote:
> 
> 
>> On 7 Oct 2016, at 02:32, Morten Sorvig  wrote:
>> 
>> 
>> What is actually in development? The scope is outlined in QTBUG-49827 and 
>> includes
>> - Improving expose event handling
>> - Improving support for Core Animation layer-backed QWindows
>> - Improving support for embedding QWindow in NSView hierarchies
>> - Driving QWindow::requestUpdate() animations via CVDisplayLink
> 
> Morten, I was doing some work, and have some patches (not yet available) in 
> this area, to do with embedding NSView hierarchies inside QWidgets. The 
> approximate changes are in the Cocoa QPA, to ensure that child QWindows are 
> inserted into the NSView heirarchy as subviews correctly, and re-ordered in 
> the subviews list (by removing and re-adding, as the AppKit docs suggest).
> 
> One of the bugs hopefully fixed by this is:
> 
>   https://bugreports.qt.io/browse/QTBUG-7140
> 
> I can provide the patches via email, but I wonder if they will be subsumed by 
> this work you’re about to start.

Hi, I don’t think I’ve made this change. Perhaps you can post the patch(es) on
codereview? We could then either merge them or move them into the WIP branch.

What I’ve seen is that compositing using layer-backed views is required to get
proper stacking of QWindows with OpenGL content. But that presumably requires
correctly ordered views first.

Morten



___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] QtBase WIP branch request

2016-10-12 Thread James Turner 

> On 7 Oct 2016, at 02:32, Morten Sorvig  wrote:
> 
> 
> What is actually in development? The scope is outlined in QTBUG-49827 and 
> includes
> - Improving expose event handling
> - Improving support for Core Animation layer-backed QWindows
> - Improving support for embedding QWindow in NSView hierarchies
> - Driving QWindow::requestUpdate() animations via CVDisplayLink

Morten, I was doing some work, and have some patches (not yet available) in 
this area, to do with embedding NSView hierarchies inside QWidgets. The 
approximate changes are in the Cocoa QPA, to ensure that child QWindows are 
inserted into the NSView heirarchy as subviews correctly, and re-ordered in the 
subviews list (by removing and re-adding, as the AppKit docs suggest).

One of the bugs hopefully fixed by this is:

https://bugreports.qt.io/browse/QTBUG-7140

I can provide the patches via email, but I wonder if they will be subsumed by 
this work you’re about to start.

Kind regards,
James

--
James Turner - Senior Software Developer
KDAB - The Qt, C++ and OpenGL Experts






smime.p7s
Description: S/MIME cryptographic signature
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] QtBase WIP branch request

2016-10-07 Thread Oswald Buddenhagen 
On Fri, Oct 07, 2016 at 07:32:14AM +, Morten Sorvig wrote:
> I would like to develop on dev as soon as possible, once the branch is
> regression-free (as verified by the CI system), and we have settled on
> major implementation decisions.
> 
fair enough. from this i'm also inferring that you want the branch
created from current dev. done.

___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] QtBase WIP branch request

2016-10-07 Thread Morten Sorvig 

> On 6 Oct 2016, at 16:10, Oswald Buddenhagen  wrote:
> 
> On Thu, Oct 06, 2016 at 09:32:40PM +0800, Tim Blechmann wrote:
 We’re working on an update to the macOS/Cocoa platform plugin,
 and I would like to request a WIP branch where the changes can
 be finalized:
 
   wip/remac
 
>>> you have Good Reasons (TM) for creating a branch according to
>>> https://wiki.qt.io/Branch_Guidelines#Creating_a_new_feature_branch , yes?
>> 
>> i'm experiencing many of the issues that this branch will address (and
>> hacked around them in my own version of the cocoa platform plugin).
>> having a branch which is easy to access would allow me test the changes
>> in a real-world context.
>> 
> as the wiki explains, a gerrit review series is also a branch, so you
> can just check it out.
> 
> the one thing the wiki doesn't mention (but probably should): why do you
> want to branch _at all_? i can think of two valid reasons:
> - the work is experimental and may end up being discarded wholesale. in
>  this case, having it in a separate branch is cleaner than reverts on
>  the mainline.
> - the development will take a long/unpredictable time, and you don't
>  want the unfinished parts to be in mainline for the time being, as per
>  feature integration policy.
> 

Those are the reasons, yes. (we won’t discard all of it; parts may be removed
or completely rewritten). As a bonus reason sharing becomes easier ('git 
checkout
wip/remac’ vs ‘find the current head of patch series on gerrit’).

I would like to develop on dev as soon as possible, once the branch is 
regression-free
(as verified by the CI system), and we have settled on major implementation 
decisions.

What is actually in development? The scope is outlined in QTBUG-49827 and 
includes
 - Improving expose event handling
 - Improving support for Core Animation layer-backed QWindows
 - Improving support for embedding QWindow in NSView hierarchies
 - Driving QWindow::requestUpdate() animations via CVDisplayLink

Morten


___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] QtBase WIP branch request

2016-10-06 Thread Oswald Buddenhagen 
On Thu, Oct 06, 2016 at 09:32:40PM +0800, Tim Blechmann wrote:
> >> We’re working on an update to the macOS/Cocoa platform plugin,
> >> and I would like to request a WIP branch where the changes can
> >> be finalized:
> >>
> >>wip/remac
> >>
> > you have Good Reasons (TM) for creating a branch according to
> > https://wiki.qt.io/Branch_Guidelines#Creating_a_new_feature_branch , yes?
> 
> i'm experiencing many of the issues that this branch will address (and
> hacked around them in my own version of the cocoa platform plugin).
> having a branch which is easy to access would allow me test the changes
> in a real-world context.
> 
as the wiki explains, a gerrit review series is also a branch, so you
can just check it out.

the one thing the wiki doesn't mention (but probably should): why do you
want to branch _at all_? i can think of two valid reasons:
- the work is experimental and may end up being discarded wholesale. in
  this case, having it in a separate branch is cleaner than reverts on
  the mainline.
- the development will take a long/unpredictable time, and you don't
  want the unfinished parts to be in mainline for the time being, as per
  feature integration policy.

the one thing that is definitely *not* a good reason: there may be
dysfunctional intermediate states. nope, you don't get to violate
atomicity just because you're on a branch.

of course, if you just want to be sloppy and are fine with a throw-away
branch, all the power to you.

> tia!
> tim
> 
> > mergable or throw-away?
> 
> 
> 
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] QtBase WIP branch request

2016-10-06 Thread Tim Blechmann 
>> We’re working on an update to the macOS/Cocoa platform plugin,
>> and I would like to request a WIP branch where the changes can
>> be finalized:
>>
>>wip/remac
>>
> you have Good Reasons (TM) for creating a branch according to
> https://wiki.qt.io/Branch_Guidelines#Creating_a_new_feature_branch , yes?

i'm experiencing many of the issues that this branch will address (and
hacked around them in my own version of the cocoa platform plugin).
having a branch which is easy to access would allow me test the changes
in a real-world context.

tia!
tim

> mergable or throw-away?



___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

Re: [Development] QtBase WIP branch request

2016-10-06 Thread Oswald Buddenhagen 
On Wed, Oct 05, 2016 at 08:37:32PM +, Morten Sorvig wrote:
> We’re working on an update to the macOS/Cocoa platform plugin,
> and I would like to request a WIP branch where the changes can
> be finalized:
> 
>wip/remac
> 
you have Good Reasons (TM) for creating a branch according to
https://wiki.qt.io/Branch_Guidelines#Creating_a_new_feature_branch , yes?
mergable or throw-away?
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development

[Development] QtBase WIP branch request

2016-10-05 Thread Morten Sorvig 
Hi,

We’re working on an update to the macOS/Cocoa platform plugin,
and I would like to request a WIP branch where the changes can
be finalized:

   wip/remac

Thanks!
Morten


___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development