Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2016-01-05 Thread Peter Chen
ow to let USB devices know its device node, the user reported issue that they can't handle interfaces below in USB device since that. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-21 Thread Peter Chen
On Tue, Dec 22, 2015 at 3:40 AM, Alan Stern wrote: > On Mon, 21 Dec 2015, Peter Chen wrote: > >> There are two problems which needs device tree to support, I have >> below solutions for them, please help to see if it is reasonable. >> >> 1. The USB device can't

Re: [RFC PATCH 2/5] doc: dt-binding: generic onboard USB device

2015-12-21 Thread Peter Chen
On Sat, Dec 19, 2015 at 12:15 PM, Rob Herring wrote: > On Fri, Dec 18, 2015 at 05:33:56PM +0800, Peter Chen wrote: >> Add dt-binding documentation for generic onboard USB device. > > As has already been mentioned, please following the existing USB device > binding convent

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-21 Thread Peter Chen
On Sat, Dec 19, 2015 at 7:48 AM, Maciej S. Szmigiero wrote: > On 17.12.2015 07:57, Peter Chen wrote: >> On Wed, Dec 16, 2015 at 09:05:35PM +0100, Maciej S. Szmigiero wrote: >>> Hi Fabio, >>> Hi Peter, >>> >>> On 16.12.2015 11:11, Fabio Estevam wrote:

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-21 Thread Peter Chen
On Fri, Dec 18, 2015 at 11:38 PM, Alan Stern wrote: > On Fri, 18 Dec 2015, Peter Chen wrote: > >> On Fri, Dec 18, 2015 at 12:13 AM, Alan Stern >> wrote: > >> > It's not clear (to me, anyway) how this is meant to work. USB is a >> > completely di

[RFC PATCH 1/5] usb: hub: add device tree support for populating onboard usb device

2015-12-18 Thread Peter Chen
t will populate platform device under this HUB. Signed-off-by: Peter Chen --- drivers/usb/core/hub.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 5e32ce7..889f188 100644 --- a/drivers/usb/core/hub.

[RFC PATCH 5/5] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

2015-12-18 Thread Peter Chen
The current dts describes USB HUB's property at USB controller's entry, it is improper. The USB HUB should be the child node under USB controller. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl-udoo.dtsi | 35 ++- 1 file changed, 14 inserti

[RFC PATCH 0/5] USB: add generic onboard USB driver

2015-12-18 Thread Peter Chen
] Thanks. [1] http://www.spinics.net/lists/linux-usb/msg134082.html [2] http://www.spinics.net/lists/linux-usb/msg131502.html [3] http://marc.info/?l=linux-usb&m=142772952730243&w=2 Peter Chen (5): usb: hub: add device tree support for populating onboard usb device doc: dt-binding: generic

[RFC PATCH 2/5] doc: dt-binding: generic onboard USB device

2015-12-18 Thread Peter Chen
Add dt-binding documentation for generic onboard USB device. Signed-off-by: Peter Chen --- .../bindings/usb/generic-onboard-device.txt| 31 ++ 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/generic-onboard-device.txt diff

[RFC PATCH 3/5] usb: misc: generic_onboard_hub: add generic onboard USB device driver

2015-12-18 Thread Peter Chen
device's pins at device tree, and these configuration will be effective before the USB bus can be used, it can avoid unexpected signals at USB bus during this USB device hardware reset process, so we use subsys_initcall for this driver. Signed-off-by: Peter Chen --- MAINTA

[RFC PATCH 4/5] usb: chipidea: host: let the hcd know's parent device node

2015-12-18 Thread Peter Chen
ned-off-by: Peter Chen --- drivers/usb/chipidea/host.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c index 3d24304..63a6aa4 100644 --- a/drivers/usb/chipidea/host.c +++ b/drivers/usb/chipidea/host.c

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-17 Thread Peter Chen
On Fri, Dec 18, 2015 at 12:13 AM, Alan Stern wrote: > On Wed, 16 Dec 2015, Rob Herring wrote: > >> On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: >> > On Monday 14 December 2015 15:26:11 Peter Chen wrote: >> >> Hi all, >> >> >> >>

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-17 Thread Peter Chen
On Thu, Dec 17, 2015 at 9:49 PM, Rob Herring wrote: > On Wed, Dec 16, 2015 at 8:31 PM, Peter Chen wrote: >> On Thu, Dec 17, 2015 at 12:13:07AM +0100, Arnd Bergmann wrote: >>> On Wednesday 16 December 2015 16:59:39 Rob Herring wrote: >>> > On Mon, Dec 14, 2015 at

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Peter Chen
On Wed, Dec 16, 2015 at 09:05:35PM +0100, Maciej S. Szmigiero wrote: > Hi Fabio, > Hi Peter, > > On 16.12.2015 11:11, Fabio Estevam wrote: > > Hi Peter, > > > > On Wed, Dec 16, 2015 at 2:11 AM, Peter Chen > > wrote: > > > >> Thanks, Fabio

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-16 Thread Peter Chen
On Thu, Dec 17, 2015 at 12:13:07AM +0100, Arnd Bergmann wrote: > On Wednesday 16 December 2015 16:59:39 Rob Herring wrote: > > On Mon, Dec 14, 2015 at 3:35 AM, Arnd Bergmann wrote: > > > On Monday 14 December 2015 15:26:11 Peter Chen wrote: > > > > I agree on doin

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-15 Thread Peter Chen
On Tue, Dec 15, 2015 at 09:32:18AM -0200, Fabio Estevam wrote: > On Tue, Dec 15, 2015 at 4:28 AM, Peter Chen wrote: > > > Thanks, Fabio. > > > > I am afraid I forget to set gpio as output, would you please apply > > below patch against my original ones: > > S

Re: [PATCH 2/3] doc: dt-binding: generic onboard USB HUB

2015-12-15 Thread Peter Chen
On Tue, Dec 15, 2015 at 09:21:09PM +0100, Ulf Hansson wrote: > On 9 December 2015 at 09:55, Arnd Bergmann wrote: > > On Wednesday 09 December 2015 16:12:24 Peter Chen wrote: > >> On Tue, Dec 08, 2015 at 09:24:03PM -0600, Rob Herring wrote: > >> > On Tue, Dec 08,

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-15 Thread Peter Chen
On Mon, Dec 14, 2015 at 10:35:19AM +0100, Arnd Bergmann wrote: > On Monday 14 December 2015 15:26:11 Peter Chen wrote: > > Hi all, > > > > There is a known issue that the USB code can't handle USB HUB's > > external pins well, in that case, it may cause some

Re: [PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-14 Thread Peter Chen
On Mon, Dec 14, 2015 at 09:26:55AM -0200, Fabio Estevam wrote: > Hi Peter, > > On Mon, Dec 14, 2015 at 5:26 AM, Peter Chen wrote: > > > Hi all, > > > > There is a known issue that the USB code can't handle USB HUB's > > external pins well, in tha

[PATCH v2 0/3] USB: add generic onboard USB HUB driver

2015-12-13 Thread Peter Chen
ts/linux-usb/msg131502.html In this patch set, I add a generic onboard USB HUB driver to handle this problem, the external signals will be configured before usb controller's initialization, it much likes we did it at board code before. The user needs to add this generic hub node at dts to suppo

[PATCH v2 3/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

2015-12-13 Thread Peter Chen
The current dts describes USB HUB's property at USB controller's entry, it is improper. Fix it by using a generic USB HUB entry. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl-udoo.dtsi | 26 +++--- 1 file changed, 7 insertions(+), 19 deletions(-) diff --

[PATCH v2 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-13 Thread Peter Chen
ns at device tree, and these configuration will be effective before the USB bus can be used, it can avoid unexpected signals at USB bus during the USB HUB reset, so we use subsys_initcall for this driver. Signed-off-by: Peter Chen --- MAINTAINERS| 7 ++ drivers/usb

[PATCH v2 2/3] doc: dt-binding: generic onboard USB HUB

2015-12-13 Thread Peter Chen
Add dt-binding documentation for generic onboard USB HUB. Signed-off-by: Peter Chen --- .../devicetree/bindings/usb/generic-onboard-hub.txt | 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/generic-onboard-hub.txt diff --git

RE: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-09 Thread Peter Chen
Best regards, Peter Chen > -Original Message- > From: Lucas Stach [mailto:l.st...@pengutronix.de] > Sent: Wednesday, December 09, 2015 5:13 PM > To: Chen Peter-B29397 > Cc: Mathieu Poirier ; Mark Rutland > ; devicetree@vger.kernel.org; feste...@gmail.com; > Phili

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-09 Thread Peter Chen
On Wed, Dec 09, 2015 at 10:10:51AM +0100, Arnd Bergmann wrote: > On Wednesday 09 December 2015 09:57:40 Lucas Stach wrote: > > Am Mittwoch, den 09.12.2015, 16:50 +0800 schrieb Peter Chen: > > > On Tue, Dec 08, 2015 at 08:36:00AM -0700, Mathieu Poirier wrote: > > > &g

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-09 Thread Peter Chen
On Wed, Dec 09, 2015 at 09:57:40AM +0100, Lucas Stach wrote: > Am Mittwoch, den 09.12.2015, 16:50 +0800 schrieb Peter Chen: > > On Tue, Dec 08, 2015 at 08:36:00AM -0700, Mathieu Poirier wrote: > > > On 7 December 2015 at 18:37, Peter Chen wrote: > > > > + &g

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-09 Thread Peter Chen
On Tue, Dec 08, 2015 at 08:36:00AM -0700, Mathieu Poirier wrote: > On 7 December 2015 at 18:37, Peter Chen wrote: > > + > > + if (dev->of_node) { > > + struct device_node *node = dev->of_node; > > + > > + hub_data

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-09 Thread Peter Chen
On Tue, Dec 08, 2015 at 07:55:05AM -0600, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > >> seriously ? Is this really all ? What about that reset line below ? > > > > The clock is PHY input clock on the HUB, this clock may from SoC's > > P

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-09 Thread Peter Chen
On Tue, Dec 08, 2015 at 10:44:02AM +0100, Sascha Hauer wrote: > On Tue, Dec 08, 2015 at 05:26:56PM +0800, Peter Chen wrote: > > On Tue, Dec 08, 2015 at 07:19:05AM +0100, Sascha Hauer wrote: > > > > + hub_data = devm_kzalloc(dev, sizeof(*hub_data), GFP_KERNEL); > >

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-09 Thread Peter Chen
On Tue, Dec 08, 2015 at 10:48:28AM +0100, Arnd Bergmann wrote: > On Tuesday 08 December 2015 09:37:48 Peter Chen wrote: > > > +struct usb_hub_generic_data { > > + struct clk *clk; > > +}; > > + > > +static int usb_hub_generic_probe(struct platform_device *pde

Re: [PATCH 2/3] doc: dt-binding: generic onboard USB HUB

2015-12-09 Thread Peter Chen
On Tue, Dec 08, 2015 at 09:24:03PM -0600, Rob Herring wrote: > On Tue, Dec 08, 2015 at 10:58:48AM +0100, Arnd Bergmann wrote: > > On Tuesday 08 December 2015 10:50:49 Philipp Zabel wrote: > > > Am Dienstag, den 08.12.2015, 09:37 +0800 schrieb Peter Chen: > > > > Ad

Re: [PATCH 2/3] doc: dt-binding: generic onboard USB HUB

2015-12-09 Thread Peter Chen
On Tue, Dec 08, 2015 at 10:50:49AM +0100, Philipp Zabel wrote: > Hi Peter, > > Am Dienstag, den 08.12.2015, 09:37 +0800 schrieb Peter Chen: > > Add dt-binding documentation for generic onboard USB HUB. > > > > Signed-off-by: Peter Chen > > --- > > .

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-08 Thread Peter Chen
On Tue, Dec 08, 2015 at 11:16:31AM +0800, kbuild test robot wrote: > Hi Peter, > > [auto build test ERROR on usb/usb-testing] > [also build test ERROR on v4.4-rc4 next-20151207] > > url: > https://github.com/0day-ci/linux/commits/Peter-Chen/USB-add-generic-onboard-US

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-08 Thread Peter Chen
pdata->gpio_reset, reset_pol > > + ? GPIOF_OUT_INIT_HIGH : GPIOF_OUT_INIT_LOW, > > + dev_name(dev)); > > + if (!ret) > > + gpiod_reset = gpio_to_desc(pdata->gpio_reset); > &

Re: [PATCH 2/3] doc: dt-binding: generic onboard USB HUB

2015-12-08 Thread Peter Chen
On Tue, Dec 08, 2015 at 12:30:59AM -0200, Fabio Estevam wrote: > On Mon, Dec 7, 2015 at 11:37 PM, Peter Chen wrote: > > Add dt-binding documentation for generic onboard USB HUB. > > > > Signed-off-by: Peter Chen > > --- > > .../bindings/usb/gener

Re: [PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-08 Thread Peter Chen
On Mon, Dec 07, 2015 at 08:59:19PM -0600, Felipe Balbi wrote: > > Hi, > > Peter Chen writes: > > diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile > > index 45fd4ac..da52e9a 100644 > > --- a/drivers/usb/misc/Makefile > > +++ b/drivers/usb/mis

[PATCH 2/3] doc: dt-binding: generic onboard USB HUB

2015-12-07 Thread Peter Chen
Add dt-binding documentation for generic onboard USB HUB. Signed-off-by: Peter Chen --- .../bindings/usb/generic-onboard-hub.txt | 28 ++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/generic-onboard-hub.txt diff --git

[PATCH 3/3] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property

2015-12-07 Thread Peter Chen
The current dts describes USB HUB's property at USB controller's entry, it is improper. Fix it by using a generic USB HUB entry. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl-udoo.dtsi | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --

[PATCH 1/3] usb: misc: generic_onboard_hub: add generic onboard USB HUB driver

2015-12-07 Thread Peter Chen
ns at platform part (through dts or platform), and these configuration will be effective before the USB bus can be used, we use subsys_initcall for this driver. Signed-off-by: Peter Chen --- MAINTAINERS | 7 ++ drivers/usb/misc/Kconfig| 9 ++ driver

[PATCH 0/3] USB: add generic onboard USB HUB driver

2015-12-07 Thread Peter Chen
releted platform data to support it. The udoo users, help to test please. Peter Chen (3): usb: misc: generic_onboard_hub: add generic onboard USB HUB driver doc: dt-binding: generic onboard USB HUB ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property .../bindings/usb/generic-onboar

Re: [PATCH v4 3/3] usb: chipidea: register driver as a peripheral with the phy

2015-11-23 Thread Peter Chen
urrent chipidea framework (find this problem after testing), the chipidea core manages its host and device function using its own API start/stop, it does not define struct usb_otg APIs. In fact, it is not reasonable control host and device function at PHY driver. -- Best Regards, Peter Chen -- To

Re: [PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-22 Thread Peter Chen
On Fri, Nov 20, 2015 at 06:58:59PM -0600, Felipe Balbi wrote: > > Hi, > > Tim Bird writes: > > On 11/16/2015 09:21 AM, Felipe Balbi wrote: > >> > >> Hi, > >> > >> Peter Chen writes: > >>> On Wed, Nov 11, 2015 at 09:48:00AM

Re: [PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-12 Thread Peter Chen
On Wed, Nov 11, 2015 at 09:48:00AM -0800, Tim Bird wrote: > > > On 11/10/2015 07:14 PM, Peter Chen wrote: > > On Tue, Nov 10, 2015 at 04:46:51PM -0800, Tim Bird wrote: > >> This fixes a bug where if you disconnect and re-connect the USB cable, > >> the gadget dr

Re: [PATCH 2/2] usb: phy: msm: fix connect/disconnect bug for dragonboard OTG port

2015-11-10 Thread Peter Chen
m_hsusb.h > index 8c8f685..08c67a3 100644 > --- a/include/linux/usb/msm_hsusb.h > +++ b/include/linux/usb/msm_hsusb.h > @@ -164,6 +164,7 @@ struct msm_otg { > struct usb_phy phy; > struct msm_otg_platform_data *pdata; > int irq; > + int async_irq; > struct clk *clk; > struct clk *pclk; > struct clk *core_clk; > -- > 1.8.2.2 > -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v5 1/2] ARM: dts: imx27.dtsi: change the clock information for usb

2015-10-20 Thread Peter Chen
r2 : r1 : 0001 r0 : 0001 Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel Control: 0005317f Table: a0004000 DAC: 0017 Process swapper (pid: 1, stack limit = 0xc783e190) Stack: (0xc783fe08 to 0xc784) Signed-off-by: Peter Chen Reported-by: Fabio

[PATCH v5 2/2] usb: chipidea: imx: refine clock operations to adapt for all platforms

2015-10-20 Thread Peter Chen
Some i.mx platforms need three clocks to let controller work, but others only need one, refine clock operation to adapt for all platforms, it fixes a regression found at i.mx27. Signed-off-by: Peter Chen Tested-by: Fabio Estevam Cc: #v4.1+ --- drivers/usb/chipidea/ci_hdrc_imx.c | 131

[PATCH v5 0/2] usb: change clock information for chipidea

2015-10-20 Thread Peter Chen
x27;s tested-by and Cc: #v3.19+ - Some typo and commit description Peter Chen (2): ARM: dts: imx27.dtsi: change the clock information for usb usb: chipidea: imx: refine clock operations to adapt for all platforms arch/arm/boot/dts/imx27.dtsi | 16 +++-- drivers/usb/chipid

Re: [PATCH v4 2/2] usb: chipidea: imx: refine clock operations to adapt for all platforms

2015-10-14 Thread Peter Chen
On Wed, Oct 14, 2015 at 10:07:59AM +0200, Marc Kleine-Budde wrote: > On 10/14/2015 03:57 AM, Peter Chen wrote: > > Some i.mx platforms need three clocks to let controller work, but > > others only need one, refine clock operation to adapt for all > > platforms, it fixes

[PATCH v4 1/2] ARM: dts: imx27.dtsi: change the clock information for usb

2015-10-13 Thread Peter Chen
r2 : r1 : 0001 r0 : 0001 Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel Control: 0005317f Table: a0004000 DAC: 0017 Process swapper (pid: 1, stack limit = 0xc783e190) Stack: (0xc783fe08 to 0xc784) Signed-off-by: Peter Chen Reported-by: Fabio

[PATCH v4 2/2] usb: chipidea: imx: refine clock operations to adapt for all platforms

2015-10-13 Thread Peter Chen
Some i.mx platforms need three clocks to let controller work, but others only need one, refine clock operation to adapt for all platforms, it fixes a regression found at i.mx27. Signed-off-by: Peter Chen Tested-by: Fabio Estevam Cc: #v4.1+ --- drivers/usb/chipidea/ci_hdrc_imx.c | 132

[PATCH v4 0/2] usb: change clock information for chipidea

2015-10-13 Thread Peter Chen
three-clocks", and using of_device_id->data to differentiate platforms - change #v3.19+ to #v4.1+ Changes for v2: - Add imx25 & imx27 dts change - Add Fabio's tested-by and Cc: #v3.19+ - Some typo and commit description Peter Chen (2): ARM: dts: imx27.dtsi: change the clock inf

[PATCH 1/1] doc: dt-binding: ci-hdrc-usb2: improve property description

2015-10-13 Thread Peter Chen
Improve the description of properties "tx-burst-size-dword" and "rx-burst-size-dword". Signed-off-by: Peter Chen Cc: Lucas Stach Cc: Shanw Guo --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -

Re: [PATCH v3 08/10] Doc: usb: ci-hdrc-usb2: add tx(rx)-burst-config-dword for binding doc

2015-10-07 Thread Peter Chen
On Fri, Aug 14, 2015 at 12:02:37PM +0200, Lucas Stach wrote: > Am Freitag, den 14.08.2015, 16:40 +0800 schrieb Peter Chen: > > On Fri, Aug 14, 2015 at 10:37:30AM +0200, Lucas Stach wrote: > > > Am Freitag, den 07.08.2015, 15:15 +0800 schrieb Peter Chen: > > > > It i

Re: [RESEND PATCH v3 0/5] usb: change clock information for chipidea

2015-09-29 Thread Peter Chen
On Wed, Sep 30, 2015 at 01:28:36PM +0800, Shawn Guo wrote: > On Wed, Sep 30, 2015 at 10:25:20AM +0800, Peter Chen wrote: > > This patch set changes usb clock information for legacy i.mx platforms. > > At these platforms, they needs three clocks to let controller work. &g

[RESEND PATCH v3 2/5] ARM: dts: imx27.dtsi: change the clock information for usb

2015-09-29 Thread Peter Chen
r2 : r1 : 0001 r0 : 0001 Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel Control: 0005317f Table: a0004000 DAC: 0017 Process swapper (pid: 1, stack limit = 0xc783e190) Stack: (0xc783fe08 to 0xc784) Signed-off-by: Peter Chen Reported-by: Fabio

[RESEND PATCH v3 1/5] doc: dt-binding: ci-hdrc-usb2: split vendor specific properties

2015-09-29 Thread Peter Chen
Each vendor may have its specific properties, they are not belonged to common optional properties, split them from common's. Signed-off-by: Peter Chen Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 10 ++ 1 file changed, 6 insertions(+), 4 dele

[RESEND PATCH v3 0/5] usb: change clock information for chipidea

2015-09-29 Thread Peter Chen
: - Delete property "needs-three-clocks", and using of_device_id->data to differentiate platforms - change #v3.19+ to #v4.1+ Changes for v2: - Add imx25 & imx27 dts change - Add Fabio's tested-by and Cc: #v3.19+ - Some typo and commit description Peter Chen (5): doc: dt

[RESEND PATCH v3 4/5] ARM: dts: imx35.dtsi: change the clock information for usb

2015-09-29 Thread Peter Chen
For imx35, it needs three clocks to let the controller work, the old code is wrong, and the usbmisc does not include clock handling code any more. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx35.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot

[RESEND PATCH v3 5/5] usb: chipidea: imx: refine clock operations to adapt for all platforms

2015-09-29 Thread Peter Chen
Some i.mx platforms need three clocks to let controller work, but others only need one, refine clock operation to adapt for all platforms, it fixes a regression found at i.mx27. Signed-off-by: Peter Chen Tested-by: Fabio Estevam Cc: #v4.1+ --- drivers/usb/chipidea/ci_hdrc_imx.c | 156

[RESEND PATCH v3 3/5] ARM: dts: imx25.dtsi: change the clock information for usb

2015-09-29 Thread Peter Chen
For imx25, it needs three clocks to let the controller work, the old code is wrong, and usbmisc has not included clock handling code any more. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx25.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts

Re: [RFC PATCH 2/2] usb: phy: Add platform driver support for ULPI PHYs

2015-09-24 Thread Peter Chen
t; ci->usb_phy->set_vbus(ci->usb_phy, 0); > } > > After these changes host mode and otg modes works fine > for my case. > Get it, there are several vbus control ways, I may need to consolidate them, of cos, this is another topic. -- Best Regards,

Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver

2015-09-24 Thread Peter Chen
interrupts = <0 21 4>; > +reg = <0xe0002000 0x1000>; Although just call devm_ioremap twice for the same register region does not cause any errors, I am not sure if it will has other potential problems. Cc: arm list. > +

Re: [RFC PATCH 2/2] usb: phy: Add platform driver support for ULPI PHYs

2015-09-24 Thread Peter Chen
0; > +} > + > +/* Match table for of_platform binding */ > +static const struct of_device_id ulpi_phy_table[] = { > + { .compatible = "ulpi-phy" }, > + { /* end of list */}, > +}; > +MODULE_DEVICE_TABLE(of, ulpi_phy_table); > + > +static struct platform_driver ulpi_phy_driver = { > + .probe = ulpi_phy_probe, > + .remove = ulpi_phy_remove, > + .driver = { > + .name = "ulpi-platform-phy", > + .of_match_table = of_match_ptr(ulpi_phy_table), > + }, > +}; > +module_platform_driver(ulpi_phy_driver); > + > +MODULE_DESCRIPTION("ULPI PHY platform driver"); > +MODULE_AUTHOR("Xilinx, Inc"); > +MODULE_LICENSE("GPL v2"); > -- > 1.7.1 > -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 00/10] USB: chipidea misc patches

2015-09-22 Thread Peter Chen
On Wed, Aug 05, 2015 at 10:08:14PM +0800, Shawn Guo wrote: > On Mon, Aug 03, 2015 at 12:47:08PM +0800, Peter Chen wrote: > > Hi all, > > > > In this series, I add several new interfaces for chipidea driver, > > they are mainly for system configuration adjustment. The

Re: [PATCH v3 0/5] usb: change clock information for chipidea

2015-09-21 Thread Peter Chen
On Mon, Sep 21, 2015 at 09:49:11PM -0300, Fabio Estevam wrote: > On Sun, Sep 20, 2015 at 9:43 PM, Peter Chen wrote: > > This patch set changes usb clock information for legacy i.mx platforms. > > At these platforms, they needs three clocks to let controller work. > > > &

[PATCH v3 0/5] usb: change clock information for chipidea

2015-09-20 Thread Peter Chen
_device_id->data to differentiate platforms - change #v3.19+ to #v4.1+ Changes for v2: - Add imx25 & imx27 dts change - Add Fabio's tested-by and Cc: #v3.19+ - Some typo and commit description Peter Chen (5): doc: dt-binding: ci-hdrc-usb2: split vendor specific properties ARM: d

[PATCH v3 4/5] ARM: dts: imx35.dtsi: change the clock information for usb

2015-09-20 Thread Peter Chen
For imx35, it needs three clocks to let the controller work, the old code is wrong, and the usbmisc does not include clock handling code any more. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx35.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot

[PATCH v3 2/5] ARM: dts: imx27.dtsi: change the clock information for usb

2015-09-20 Thread Peter Chen
r2 : r1 : 0001 r0 : 0001 Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel Control: 0005317f Table: a0004000 DAC: 0017 Process swapper (pid: 1, stack limit = 0xc783e190) Stack: (0xc783fe08 to 0xc784) Signed-off-by: Peter Chen Reported-by: Fabio

[PATCH v3 5/5] usb: chipidea: imx: refine clock operations to adapt for all platforms

2015-09-20 Thread Peter Chen
Some i.mx platforms need three clocks to let controller work, but others only need one, refine clock operation to adapt for all platforms, it fixes a regression found at i.mx27. Signed-off-by: Peter Chen Tested-by: Fabio Estevam Cc: #v4.1+ --- drivers/usb/chipidea/ci_hdrc_imx.c | 156

[PATCH v3 1/5] doc: dt-binding: ci-hdrc-usb2: split vendor specific properties

2015-09-20 Thread Peter Chen
Each vendor may have its specific properties, they are not belonged to common optional properties, split them from common's. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --

[PATCH v3 3/5] ARM: dts: imx25.dtsi: change the clock information for usb

2015-09-20 Thread Peter Chen
For imx25, it needs three clocks to let the controller work, the old code is wrong, and usbmisc has not included clock handling code any more. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx25.dtsi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts

Re: [PATCH 2/4] doc: dt-binding: ci-hdrc-usb2: add i.mx specific binding "need-three-clocks"

2015-09-17 Thread Peter Chen
On Wed, Sep 16, 2015 at 08:54:25AM -0500, Rob Herring wrote: > On 09/15/2015 08:49 PM, Peter Chen wrote: > > Some SoCs needs three clock to let controller work, but others only > > need one, add one property to differentiate this. > > A given licensed IP block is going to ha

[PATCH v2 1/6] doc: dt-binding: ci-hdrc-usb2: split vendor specific properties

2015-09-15 Thread Peter Chen
Each vendor may have its specific properties, they are not belonged to common optional properties, split them from common's. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --

[PATCH v2 5/6] ARM: dts: imx35.dtsi: change the clock information for usb

2015-09-15 Thread Peter Chen
For imx35, it needs three clocks to let the controller work, the old code is wrong, and the usbmisc does not include clock handling code any more. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx35.dtsi | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm

[PATCH v2 3/6] ARM: dts: imx27.dtsi: change the clock information for usb

2015-09-15 Thread Peter Chen
r2 : r1 : 0001 r0 : 0001 Flags: nZCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel Control: 0005317f Table: a0004000 DAC: 0017 Process swapper (pid: 1, stack limit = 0xc783e190) Stack: (0xc783fe08 to 0xc784) Signed-off-by: Peter Chen Reported-by: Fabio

[PATCH v2 2/6] doc: dt-binding: ci-hdrc-usb2: add i.mx specific binding "need-three-clocks"

2015-09-15 Thread Peter Chen
Some SoCs needs three clock to let controller work, but others only need one, add one property to differentiate this. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/usb

[PATCH v2 4/6] ARM: dts: imx25.dtsi: change the clock information for usb

2015-09-15 Thread Peter Chen
For imx25, it needs three clocks to let the controller work, the old code is wrong, and usbmisc has not included clock handling code any more. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx25.dtsi | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot

[PATCH v2 6/6] usb: chipidea: imx: refine clock operations to adapt for all platforms

2015-09-15 Thread Peter Chen
Some i.mx platforms need three clocks to let controller work, but others only need one, refine clock operation to adapt for all platforms, it fixes a regression found at i.mx27. Signed-off-by: Peter Chen Tested-by: Fabio Estevam Cc: #v3.19+ --- drivers/usb/chipidea/ci_hdrc_imx.c | 138

[PATCH v2 0/6] usb: change clock information

2015-09-15 Thread Peter Chen
This patch set changes usb clock information for legacy i.mx platforms. At these platforms, they needs three clocks to let controller work. Changes for v2: - Add imx25 & imx27 dts change - Add Fabio's tested-by and Cc: #v3.19+ - Some typo and commit description Peter Chen (6): doc: d

Re: [PATCH 3/4] ARM: dts: imx27.dtsi: change the clock information for usb

2015-09-15 Thread Peter Chen
On Wed, Sep 16, 2015 at 12:25:17AM -0300, Fabio Estevam wrote: > On Tue, Sep 15, 2015 at 10:49 PM, Peter Chen wrote: > > For imx27, it needs three clocks to let the controller work, > > the old code is wrong, and will cause below data abort when > > accass usbmisc regis

Re: [PATCH 2/4] doc: dt-binding: ci-hdrc-usb2: add i.mx specific binding "need-three-clocks"

2015-09-15 Thread Peter Chen
On Wed, Sep 16, 2015 at 12:23:26AM -0300, Fabio Estevam wrote: > On Tue, Sep 15, 2015 at 10:49 PM, Peter Chen wrote: > > Some SoCs needs three clock to let controller work, but others only > > need one, add one property to differentiate this. > > > >

[PATCH 3/4] ARM: dts: imx27.dtsi: change the clock information for usb

2015-09-15 Thread Peter Chen
Mode SVC_32 ISA ARM Segment kernel Control: 0005317f Table: a0004000 DAC: 0017 Process swapper (pid: 1, stack limit = 0xc783e190) Stack: (0xc783fe08 to 0xc784) Signed-off-by: Peter Chen Reported-by: Fabio Estevam Cc: --- arch/arm/boot/dts/imx27.dtsi | 19 +++ 1 file

[PATCH 2/4] doc: dt-binding: ci-hdrc-usb2: add i.mx specific binding "need-three-clocks"

2015-09-15 Thread Peter Chen
Some SoCs needs three clock to let controller work, but others only need one, add one property to differentiate this. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/usb

[PATCH 1/4] doc: dt-binding: ci-hdrc-usb2: split vendor specific properties

2015-09-15 Thread Peter Chen
Each vendor may have its specific properties, they are not belonged to common optional properties, split them from common's. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --

[PATCH 4/4] usb: chipidea: imx: refine clock operations to adapt for all platforms

2015-09-15 Thread Peter Chen
Some i.mx platforms need three clocks to let controller work, but others only need one, refine clock operation to adapt for all platforms. Cc: Fabio Estevam Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 138 - 1 file changed, 120

Re: [PATCH v4] usb: chipidea: Use extcon framework for VBUS and ID detect

2015-09-08 Thread Peter Chen
ll queue it for next rc1, thanks. Peter > --- > > Changes sice v3 [1]: > > * Migrate to new extcon framework API > * Address comments from Peter Chen. > > Tested DRD role with "qcom,ci-hdrc" and "qcom,usb-8x16-phy" on DB410c > > [1] https://lkm

Re: [PATCH v2 1/2] usb: chipidea: add xilinx zynq platform data

2015-08-31 Thread Peter Chen
struct platform_device > *pdev) > return 0; > } > > -static const struct of_device_id ci_hdrc_usb2_of_match[] = { > - { .compatible = "chipidea,usb2" }, > - { } > -}; > -MODULE_DEVICE_TABLE(of, ci_hdrc_usb2_of_match); > - > static struct platfo

Re: [PATCH 1/2] usb: chipidea: add xilinx zynq platform data

2015-08-30 Thread Peter Chen
return -ENOMEM; > @@ -96,12 +115,6 @@ static int ci_hdrc_usb2_remove(struct platform_device > *pdev) > return 0; > } > > -static const struct of_device_id ci_hdrc_usb2_of_match[] = { > - { .compatible = "chipidea,usb2" }, > - { } > -}; > -M

Re: [PATCH 1/2] usb: chipidea: add xilinx zynq platform data

2015-08-30 Thread Peter Chen
On Mon, Aug 31, 2015 at 09:01:51AM +0530, punnaiah choudary kalluri wrote: > On Mon, Aug 31, 2015 at 6:10 AM, Peter Chen wrote: > > On Fri, Aug 28, 2015 at 09:42:56AM -0500, Nathan Sullivan wrote: > >> On Fri, Aug 28, 2015 at 09:30:12AM +0800, Peter Chen wrote: > >> &

Re: [PATCH 1/2] usb: chipidea: add xilinx zynq platform data

2015-08-30 Thread Peter Chen
On Fri, Aug 28, 2015 at 09:42:56AM -0500, Nathan Sullivan wrote: > On Fri, Aug 28, 2015 at 09:30:12AM +0800, Peter Chen wrote: > > On Thu, Aug 27, 2015 at 09:33:07AM -0500, Nathan Sullivan wrote: > > > On Thu, Aug 27, 2015 at 01:11:30PM +0530, punnaiah choudary kalluri

Re: [PATCH 1/2] usb: chipidea: add xilinx zynq platform data

2015-08-27 Thread Peter Chen
On Thu, Aug 27, 2015 at 09:33:07AM -0500, Nathan Sullivan wrote: > On Thu, Aug 27, 2015 at 01:11:30PM +0530, punnaiah choudary kalluri wrote: > > Hi, > > > > On Thu, Aug 27, 2015 at 10:03 AM, Peter Chen > > wrote: > > > On Thu, Aug 27, 2015 at 10:59

Re: [PATCH 1/2] usb: chipidea: add xilinx zynq platform data

2015-08-26 Thread Peter Chen
return 0; > > } > > > > -static const struct of_device_id ci_hdrc_usb2_of_match[] = { > > - { .compatible = "chipidea,usb2" }, > > - { } > > -}; > > -MODULE_DEVICE_TABLE(of, ci_hdrc_usb2_of_match); > > - > >

Re: [PATCH v3 08/10] Doc: usb: ci-hdrc-usb2: add tx(rx)-burst-config-dword for binding doc

2015-08-14 Thread Peter Chen
On Fri, Aug 14, 2015 at 10:37:30AM +0200, Lucas Stach wrote: > Am Freitag, den 07.08.2015, 15:15 +0800 schrieb Peter Chen: > > It is used to override the default setting for burst size, changing > > burst size takes effect only when the SBUSCFG.AHBBRST = 0. > > > >

RE: [PATCH v3 00/10] USB: chipidea misc patches

2015-08-13 Thread Peter Chen
not used. [Patch 2/10, 6/10, 10/10] > - According to Greg and Sascha comments, format patch 2/10's > commit log. > - using non-burst instead of unburst for patch 7/10 > > Peter Chen (10): > usb: chipidea: udc: zero-length packet is only needed for TX > usb: chipide

[PATCH v3 09/10] ARM: imx6: change default burst size for USB

2015-08-07 Thread Peter Chen
It can improve the USB performance when choosing larger burst size at some systems (bus size is larger), there is no side effect if this burst size is larger than bus size. Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl.dtsi | 8 arch/arm/boot/dts/imx6sl.dtsi | 6 ++ arch

[PATCH v3 03/10] usb: chipidea: imx: add stream mode enable for device mode at imx6sl/imx6sx

2015-08-07 Thread Peter Chen
Stream mode enable is known for better performance, this stream mode enable patch has been passed with stress tests at device mode for imx6sl and imx6sx, and no issue is found. Signed-off-by: Peter Chen --- drivers/usb/chipidea/ci_hdrc_imx.c | 16 ++-- 1 file changed, 10 insertions

[PATCH v3 10/10] usb: chipidea: add tx/rx burst size configuration interface

2015-08-07 Thread Peter Chen
The user can adjust it through dts or platform data Signed-off-by: Peter Chen --- drivers/usb/chipidea/bits.h | 4 drivers/usb/chipidea/ci.h| 1 + drivers/usb/chipidea/core.c | 35 +++ include/linux/usb/chipidea.h | 4 4 files changed, 44

[PATCH v3 07/10] usb: chipidea: usbmisc_imx: add non-burst setting for imx6

2015-08-07 Thread Peter Chen
With this setting and AHBBRST at SBUSCFG as "Incremental burst of unspecified length", each non-burst size can be taken as single transfer. It is benefit for non-burst size transfer. Signed-off-by: Peter Chen --- drivers/usb/chipidea/usbmisc_imx.c | 12 ++-- 1 file c

[PATCH v3 08/10] Doc: usb: ci-hdrc-usb2: add tx(rx)-burst-config-dword for binding doc

2015-08-07 Thread Peter Chen
It is used to override the default setting for burst size, changing burst size takes effect only when the SBUSCFG.AHBBRST = 0. Signed-off-by: Peter Chen --- Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation

[PATCH v3 05/10] ARM: imx6: set ahb-burst-config as 0 for USB

2015-08-07 Thread Peter Chen
After setting ahb burst configuration as 0, we can increase tx/rx burst size, it will improve the USB performance Signed-off-by: Peter Chen --- arch/arm/boot/dts/imx6qdl.dtsi | 4 arch/arm/boot/dts/imx6sl.dtsi | 3 +++ arch/arm/boot/dts/imx6sx.dtsi | 3 +++ 3 files changed, 10 insertions

  1   2   3   4   5   >