Re: [PATCH 3/3] ARM: dts: OMAP2+: Add mailbox nodes

2013-06-20 Thread Cousson, Benoit
On 6/18/2013 5:35 PM, Suman Anna wrote: The mailbox DT node data has been added for OMAP2420, OMAP2430, OMAP3430/OMAP3630, OMAP44xx devices. Data for OMAP5 is skipped for now since the corresponding hwmod entry is not present. The mailbox static device initialization logic is also adjusted for a

Re: [PATCH 2/3] mailbox/omap: add support for parsing dt devices

2013-06-20 Thread Cousson, Benoit
Hi Suman, On 6/18/2013 5:34 PM, Suman Anna wrote: Logic has been added to the OMAP2+ mailbox code to parse the mailbox dt nodes and construct the different mailboxes associated with the instance. The design is based on gathering the same information that was being passed previously through the p

RE: [PATCH v5 0/2] ARM: dts: Add USB host support for Beagle-xm

2013-06-20 Thread Cousson, Benoit
Roger >Sent: Thursday, June 20, 2013 7:46 AM >To: Cousson, Benoit >Cc: t...@atomide.com; linux-o...@vger.kernel.org; devicetree- >disc...@lists.ozlabs.org; linux-arm-ker...@lists.infradead.org; linux- >ker...@vger.kernel.org; Quadros, Roger >Subject: [PATCH v5 0/2] ARM: dts: Add USB hos

Re: [PATCH] ARM: dts: Protect pinctrl headers against multiple inclusions

2013-06-12 Thread Cousson, Benoit
Hi Florian, On 6/12/2013 8:42 AM, Florian Vaussard wrote: Hello Grant, On 06/11/2013 11:57 PM, Grant Likely wrote: On Tue, 11 Jun 2013 16:50:50 +0200, Florian Vaussard wrote: Pinctrl headers were not protected with #ifndef. Signed-off-by: Florian Vaussard Obviously this needs to go in vi

Re: [PATCHv2 3/3] arm: dts: add bandgap entry for OMAP4460 devices

2013-05-29 Thread Cousson, Benoit
Hi Eduardo, On 5/29/2013 4:11 PM, Eduardo Valentin wrote: Salut Monsieur Benoit, On 16-05-2013 08:27, Eduardo Valentin wrote: On 16-05-2013 03:20, Benoit Cousson wrote: Hi Eduardo, We need to check. Yeah, I also dont think this will work, because we will reparent the interrupt, settin

Re: [PATCH v6] ARM:dts:omap4-panda: Update the LED support for the panda DTS

2013-05-29 Thread Cousson, Benoit
Hi Dan, On 5/24/2013 8:56 PM, Dan Murphy wrote: On 05/17/2013 11:17 AM, Dan Murphy wrote: On 05/17/2013 11:15 AM, Nishanth Menon wrote: On 11:02-20130517, Dan Murphy wrote: The GPIO for LED D1 on the omap4-panda a1-a3 rev and the omap4-panda-es are different. A1-A3 = gpio_wk7 ES = gpio_110

Re: [PATCH 1/2] ARM: dts: OMAP3: Add GPMC controller

2013-02-18 Thread Cousson, Benoit
Hi Javier, On 2/16/2013 5:44 PM, Javier Martinez Canillas wrote: On Sat, Feb 16, 2013 at 2:09 PM, Anil Kumar wrote: Hi Florian, On Mon, Jan 28, 2013 at 11:24 PM, Florian Vaussard wrote: Add device-tree support for the GPMC controller on the OMAP3. Signed-off-by: Florian Vaussard --- arc

Re: [PATCH] arm: dts: Add uart1 and uart2 to igep boards.

2013-02-15 Thread Cousson, Benoit
Hi Matthias, On 2/15/2013 10:35 AM, Matthias Brugger wrote: 2013/1/26 Javier Martinez Canillas : On Sat, Jan 26, 2013 at 4:16 PM, Matthias Brugger wrote: Hi Benoit, 2012/12/12 Benoit Cousson : Hi Matthias, On 12/12/2012 04:33 PM, Matthias Brugger wrote: This patch is a follow-up patch for

Re: [RFC] Device Tree Overlays Proposal (Was Re: capebus moving omap_devices to mach-omap2)

2012-11-08 Thread Cousson, Benoit
+ Peter Hi Stephen, On 11/7/2012 6:25 PM, Stephen Warren wrote: On 11/07/2012 03:19 AM, Benoit Cousson wrote: Hi Panto, On 11/07/2012 09:13 AM, Pantelis Antoniou wrote: Hi Grant On Nov 6, 2012, at 9:45 PM, Grant Likely wrote: On Tue, Nov 6, 2012 at 7:34 PM, Pantelis Antoniou wrote: [ s

Re: [RESEND/PATCHv3] arm: dts: omap5-evm: Add keypad support

2012-10-30 Thread Cousson, Benoit
Hi Sourav, On 10/30/2012 6:26 AM, Sourav wrote: Hi Benoit, On Monday 29 October 2012 10:14 PM, Benoit Cousson wrote: Hi Sourav, On 10/29/2012 11:40 AM, Sourav Poddar wrote: Add keypad data node in omap5-evm. Based on I2C support patch for omap5, which has been already posted as a different s

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-28 Thread Cousson, Benoit
On 9/28/2012 3:07 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Fri, Sep 28, 2012 at 4:18 AM, Cousson, Benoit wrote: On 9/27/2012 7:24 AM, Rob Herring wrote: On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring wrote: On 09/06/2012 09:57 AM

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-27 Thread Cousson, Benoit
On 9/27/2012 7:24 AM, Rob Herring wrote: On 09/25/2012 05:06 AM, ABRAHAM, KISHON VIJAY wrote: Hi, On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring wrote: On 09/06/2012 09:57 AM, Kishon Vijay Abraham I wrote: All phy related programming like enabling/disabling the clocks, powering on/off the phy

Re: [PATCH v2 0/2] OMAP: mailbox initial device tree support

2012-09-26 Thread Cousson, Benoit
Hi Omar, On 9/26/2012 3:21 PM, Omar Ramirez Luna wrote: Hi Benoit, On 12 September 2012 19:08, Omar Ramirez Luna wrote: To allow mailbox driver to function with device tree. Tested in OMAP4 and OMAP3. OMAP2 untested. Patch: arm/dts: OMAP2+: Add mailbox nodes, was Acked by Benoit however it

Re: [PATCH v2 3/9] ARM: OMAP4: hwmod data: add mmu hwmod for ipu and dsp

2012-09-19 Thread Cousson, Benoit
+ Paul On 9/12/2012 2:45 PM, Omar Ramirez Luna wrote: Add mmu hwmod data for ipu and dsp. Cc: Benoit Cousson Signed-off-by: Omar Ramirez Luna Acked-by: Benoit Cousson Thanks Paul for taking care of that patch. Regards, Benoit --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 136 +++

Re: [PATCH 1/3] arm/dts: add wdt node for omap3 and omap4

2012-05-31 Thread Cousson, Benoit
On 5/31/2012 4:55 PM, Jon Hunter wrote: On 05/31/2012 12:51 AM, Xiao Jiang wrote: Hi Jon and Benoit, Thanks for reminding, how about below patch? diff --git a/Documentation/devicetree/bindings/watchdog/omap-wdt.txt b/Documentation/devicetree/bindings/watchdog/omap-wdt.txt new file mode 100644

Re: [PATCH 3/3] watchdog: omap_wdt: add device tree support

2012-05-30 Thread Cousson, Benoit
Hi Jon, On 5/30/2012 5:03 PM, Jon Hunter wrote: Hi Benoit, On 05/30/2012 02:54 AM, Cousson, Benoit wrote: On 5/30/2012 5:18 AM, Xiao Jiang wrote: Jon Hunter wrote: On 05/25/2012 05:42 AM, jgq...@gmail.com wrote: From: Xiao Jiang Add device table for omap_wdt to support dt. Signed-off-by

Re: [PATCH 3/3] watchdog: omap_wdt: add device tree support

2012-05-30 Thread Cousson, Benoit
On 5/30/2012 5:18 AM, Xiao Jiang wrote: Jon Hunter wrote: On 05/25/2012 05:42 AM, jgq...@gmail.com wrote: From: Xiao Jiang Add device table for omap_wdt to support dt. Signed-off-by: Xiao Jiang --- drivers/watchdog/omap_wdt.c | 8 1 files changed, 8 insertions(+), 0 deletions(-) di

Re: [PATCH 2/2] arm/dts: OMAP2+: Add mailbox nodes

2012-05-24 Thread Cousson, Benoit
On 5/1/2012 7:47 PM, Omar Ramirez Luna wrote: Add nodes for mailbox DT, to interface with hwmods. Signed-off-by: Omar Ramirez Luna Acked-by: Benoit Cousson --- arch/arm/boot/dts/omap2.dtsi |5 + arch/arm/boot/dts/omap3.dtsi |5 + arch/arm/boot/dts/omap4.dtsi |5 +

Re: [PATCH 0/2] OMAP: mailbox initial device tree support

2012-05-24 Thread Cousson, Benoit
On 5/2/2012 7:42 AM, Bedia, Vaibhav wrote: Hi Omar, On Tue, May 01, 2012 at 23:17:38, Omar Ramirez Luna wrote: To allow mailbox driver to function with device tree. Tested in OMAP4 and OMAP3. OMAP2 untested. I think the mailbox code needs a cleanup similar to what you had proposed earlier [1

Re: [PATCH 01/11] OMAP2+: Add SoC specific map_io functions

2012-05-14 Thread Cousson, Benoit
Salut Thomas, Sorry for the delay. On 5/4/2012 5:59 PM, Thomas Petazzoni wrote: Hello Benoit, Le Fri, 23 Sep 2011 22:23:09 +0200, Benoit Cousson a écrit : Add SoC specific map_io function to be used by the generic DT board file. This is an intermediate step before having some generic DT awa

Re: [PATCH] ASoC: twl6040: Support for DT

2012-05-11 Thread Cousson, Benoit
On 5/11/2012 3:08 PM, Mark Brown wrote: On Fri, May 11, 2012 at 01:02:26PM +0200, Cousson, Benoit wrote: On 5/9/2012 3:35 PM, Mark Brown wrote: Clearly. This is all very circular. Obviously if you're intent on using a phandle specific to the MFD child then you need to have that i

Re: [PATCH] ASoC: twl6040: Support for DT

2012-05-11 Thread Cousson, Benoit
+ DT list Hi Mark, On 5/9/2012 3:35 PM, Mark Brown wrote: On Wed, May 09, 2012 at 03:01:23PM +0300, Peter Ujfalusi wrote: On 05/08/2012 04:41 PM, Mark Brown wrote: On Tue, May 08, 2012 at 03:42:41PM +0300, Peter Ujfalusi wrote: Also without a DT entry I will not have a way to use phandle t

Re: [PATCH v3 4/4] ARM: omap: pass minimal SoC/board data for UART from dt

2012-04-11 Thread Cousson, Benoit
Hi Omar, On 4/11/2012 2:16 AM, Ramirez Luna, Omar wrote: Hi, On Wed, Dec 14, 2011 at 5:55 AM, Rajendra Nayak wrote: Pass minimal data needed for console boot, from dt, for OMAP4 panda/sdp and OMAP3 beagle boards, and get rid of the static initialization from generic board file. ... diff --g

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Cousson, Benoit
Hi Chris, On 4/10/2012 6:21 PM, Chris Ball wrote: Hi, On Tue, Apr 10 2012, Cousson, Benoit wrote: Hi Balaji, On 4/10/2012 5:11 PM, Balaji T K wrote: If of_have_populated_dt is called from module, build fails with "allnodes" undefined error, so remove inline and export of_have_po

Re: [RFC] dt: export of_have_populated_dt

2012-04-10 Thread Cousson, Benoit
Hi Balaji, On 4/10/2012 5:11 PM, Balaji T K wrote: If of_have_populated_dt is called from module, build fails with "allnodes" undefined error, so remove inline and export of_have_populated_dt. Is this function really called from the MMC driver? Regards, Benoit Signed-off-by: Balaji T K ---

Re: [PATCH 1/2] arm/dts: omap4-sdp: Add keypad data

2012-04-04 Thread Cousson, Benoit
On 4/4/2012 3:30 PM, Sourav Poddar wrote: This patch add keypad data node in omap4 device tree file. Nit #2: Never write "this patch" in a patch changelog... Because at some point it will become a commit in a GIT tree. I think AKPM wrote something on that. Benoit Cc: Benoit Cousson Cc: R

Re: [PATCH 1/2] arm/dts: omap4-sdp: Add keypad data

2012-04-04 Thread Cousson, Benoit
Hi Sourav, On 4/4/2012 3:30 PM, Sourav Poddar wrote: This patch add keypad data node in omap4 device tree file. Nit: You should adapt first the driver to DT and document the binding before using it. So this patch should be the second one. Regards, Benoit Cc: Benoit Cousson Cc: Rob Herri

Re: [PATCH] of: Add generic device tree DMA helpers

2012-03-19 Thread Cousson, Benoit
Hi Nico, On 3/19/2012 5:31 PM, Nicolas Ferre wrote: On 03/19/2012 04:33 PM, Russell King - ARM Linux : On Mon, Mar 19, 2012 at 02:06:34PM +, Arnd Bergmann wrote: mmci /* in drivers/dma/ste_dma40.c, others in pl330.c, coh901318.c, ... */ bool stedma40_filter(struct dma_chan *chan,

Re: [PATCH] of: Add generic device tree DMA helpers

2012-03-19 Thread Cousson, Benoit
On 3/19/2012 4:20 PM, Russell King - ARM Linux wrote: On Mon, Mar 19, 2012 at 02:37:56PM +0100, Nicolas Ferre wrote: On 03/18/2012 09:13 PM, Arnd Bergmann : On Saturday 17 March 2012, Grant Likely wrote: +static LIST_HEAD(of_dma_list); + +struct of_dma { + struct list_head of_dma_controlle

Re: [PATCH] of: Add generic device tree DMA helpers

2012-03-16 Thread Cousson, Benoit
On 3/16/2012 1:04 PM, Arnd Bergmann wrote: On Friday 16 March 2012, Cousson, Benoit wrote: And it seems that other ARM SoCs are using it for the same purpose. There are at least 230+ IORESOURCE_DMA instances in the kernel today. These tend to be the ones that don't use dmaengine but e

Re: [PATCH] of: Add generic device tree DMA helpers

2012-03-16 Thread Cousson, Benoit
On 3/16/2012 11:03 AM, Arnd Bergmann wrote: On Thursday 15 March 2012, Nicolas Ferre wrote: For legacy reason another API will export the DMA request number into a Linux resource of type IORESOURCE_DMA. Can you explain which legacy scenarios you think this is going to help with? We do have a

Re: [PATCH] of: Add generic device tree DMA helpers

2012-03-15 Thread Cousson, Benoit
On 3/15/2012 9:41 PM, Arnd Bergmann wrote: On Thursday 15 March 2012, Russell King - ARM Linux wrote: On Thu, Mar 15, 2012 at 05:30:49PM +0100, Cousson, Benoit wrote: This was done like IRQ on purpose, because an Interrupt ReQuest line and a DMA Request line are really similar for the HW point

Re: [PATCH] of: Add generic device tree DMA helpers

2012-03-15 Thread Cousson, Benoit
On 3/15/2012 10:22 AM, Arnd Bergmann wrote: On Thursday 15 March 2012, Nicolas Ferre wrote: Add some basic helpers to retrieve a DMA controller device_node and the DMA request specifications. By making DMA controllers register a generic translation function, we allow the management of any type o

Re: OMAP DSS device tree design problems

2012-03-13 Thread Cousson, Benoit
+ devicetree list and Mike T. for the clock aspect Hi Tomi, On 3/12/2012 2:45 PM, Tomi Valkeinen wrote: Hi, I'm struggling with the design of the DT data for OMAP display subsystem driver, and any thoughts and ideas are welcome. This mail is a rather long one, where I'm trying to show the diff

Re: [PATCH v2 7/7] Document: devicetree: add OF documents for arch-mmp

2012-03-05 Thread Cousson, Benoit
On 3/5/2012 3:46 PM, Arnd Bergmann wrote: On Monday 05 March 2012, Haojian Zhuang wrote: Add OF support in Document/devicetree directory. Signed-off-by: Haojian Zhuang Acked-by: Arnd Bergmann One question for Benoit, Grant or Rob: +Required properties: +- compatible: should be "mrvl,sa1100

Re: [PATCH] devicetree: Add empty of_platform_populate() for !CONFIG_OF_ADDRESS (sparc)

2012-03-05 Thread Cousson, Benoit
Hi Grant, On 3/3/2012 5:09 AM, Grant Likely wrote: On Fri, 2 Mar 2012 17:07:15 -0800, Andrew Morton wrote: On Fri, 2 Mar 2012 22:20:16 +0100 "Cousson, Benoit" wrote: Hi Grant, In fact this patch is not working for build without CONFIG_OF like x86. On 2/24/2012 11:06 PM, Gr

Re: [RFC PATCH] of: DMA helpers: manage generic requests specification

2012-03-05 Thread Cousson, Benoit
On 2/29/2012 9:54 PM, Stephen Warren wrote: Nicolas Ferre wrote at Wednesday, February 29, 2012 7:54 AM: By making DMA controllers register a generic translation function, we allow the management of any type of DMA requests specification. The void * output of an of_dma_xlate() function that will

Re: [RFC PATCH] of: DMA helpers: manage generic requests specification

2012-03-05 Thread Cousson, Benoit
Hi Nico, On 2/29/2012 3:54 PM, Nicolas Ferre wrote: By making DMA controllers register a generic translation function, we allow the management of any type of DMA requests specification. The void * output of an of_dma_xlate() function that will be implemented by the DMA controller can carry any t

Re: [PATCH] devicetree: Add empty of_platform_populate() for !CONFIG_OF_ADDRESS (sparc)

2012-03-02 Thread Cousson, Benoit
Hi Grant, In fact this patch is not working for build without CONFIG_OF like x86. On 2/24/2012 11:06 PM, Grant Likely wrote: --- a/include/linux/of_platform.h +++ b/include/linux/of_platform.h @@ -81,7 +81,7 @@ extern struct platform_device *of_device_alloc(struct device_node *np,

Re: [PATCH-V1] arm/dts: Add support for TI OMAP3 EVM board

2012-02-29 Thread Cousson, Benoit
On 2/29/2012 11:31 PM, Tony Lindgren wrote: * Hiremath, Vaibhav [120105 02:46]: ... Can this merged? OR anybody has any comments here? For reference, looks like this one is queued up as commit f0e15e2b0c6b3e89daade25a1e9a2d80136c14c3. Yes, it is, I included it in my DTS pull-request becaus

Re: [PATCH v3 0/2] Device tree support for TWL regulators

2012-02-27 Thread Cousson, Benoit
On 2/27/2012 11:17 PM, Grant Likely wrote: On Mon, Feb 27, 2012 at 6:52 AM, Cousson, Benoit wrote: Hi Mark, On 2/27/2012 2:41 PM, Mark Brown wrote: On Mon, Feb 27, 2012 at 06:01:20PM +0530, Rajendra Nayak wrote: Depending on what order Mark happens to pull them in, I am fine re-sending

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-02-27 Thread Cousson, Benoit
On 2/27/2012 2:09 PM, Nicolas Ferre wrote: On 02/23/2012 04:57 PM, Cousson, Benoit : On 2/23/2012 4:51 PM, Nicolas Ferre wrote: On 02/23/2012 11:03 AM, Cousson, Benoit : Salut Nico, Coucou Benoit ;-) On 2/22/2012 11:59 AM, Nicolas Ferre wrote: On 01/27/2012 06:29 PM, Cousson, Benoit

Re: [PATCH v3 0/2] Device tree support for TWL regulators

2012-02-27 Thread Cousson, Benoit
On 2/27/2012 3:03 PM, Mark Brown wrote: On Mon, Feb 27, 2012 at 02:52:05PM +0100, Cousson, Benoit wrote: On 2/27/2012 2:41 PM, Mark Brown wrote: On Mon, Feb 27, 2012 at 06:01:20PM +0530, Rajendra Nayak wrote: Please can you guys come up with a single unified series for this stuff - I&#x

Re: [PATCH v3 0/2] Device tree support for TWL regulators

2012-02-27 Thread Cousson, Benoit
Hi Mark, On 2/27/2012 2:41 PM, Mark Brown wrote: On Mon, Feb 27, 2012 at 06:01:20PM +0530, Rajendra Nayak wrote: Depending on what order Mark happens to pull them in, I am fine re-sending adding support for the 2 twl6030 fixed regulators. Please can you guys come up with a single unified ser

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2012-02-24 Thread Cousson, Benoit
On 2/22/2012 7:29 PM, Stephen Warren wrote: Rob Herring wrote at Wednesday, February 22, 2012 10:23 AM: On 02/22/2012 08:31 AM, Cousson, Benoit wrote: On 2/22/2012 3:23 PM, Rob Herring wrote: On 02/15/2012 10:04 AM, Benoit Cousson wrote: Adapt the GPIO driver to retrieve information from a

Re: [PATCH v2 1/4] mmc: omap_hsmmc: Convert hsmmc driver to use device tree

2012-02-24 Thread Cousson, Benoit
On 2/24/2012 1:58 PM, Rajendra Nayak wrote: On Friday 24 February 2012 06:21 PM, Cousson, Benoit wrote: On 2/24/2012 12:35 PM, Rajendra Nayak wrote: On Friday 24 February 2012 05:02 PM, T Krishnamoorthy, Balaji wrote: On Thu, Feb 23, 2012 at 5:31 PM, Rajendra Nayak wrote: ... +Required

Re: [PATCH v2 1/4] mmc: omap_hsmmc: Convert hsmmc driver to use device tree

2012-02-24 Thread Cousson, Benoit
On 2/24/2012 12:35 PM, Rajendra Nayak wrote: On Friday 24 February 2012 05:02 PM, T Krishnamoorthy, Balaji wrote: On Thu, Feb 23, 2012 at 5:31 PM, Rajendra Nayak wrote: Define dt bindings for the ti-omap-hsmmc, and adapt the driver to extract data (which was earlier passed as platform_data) fro

Re: [PATCH v2 4/4] arm/dts: OMAP3: Add mmc controller nodes and board data

2012-02-24 Thread Cousson, Benoit
On 2/24/2012 5:00 AM, Rajendra Nayak wrote: On Friday 24 February 2012 12:27 AM, Tony Lindgren wrote: --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -113,5 +113,31 @@ #size-cells =<0>; ti,hwmods = "i2c3"; }; + + mmc1: mmc@1 { + compatible = "ti,omap2-hsmmc"; + ti,hwmods

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-02-23 Thread Cousson, Benoit
On 2/23/2012 4:51 PM, Nicolas Ferre wrote: On 02/23/2012 11:03 AM, Cousson, Benoit : Salut Nico, Coucou Benoit ;-) On 2/22/2012 11:59 AM, Nicolas Ferre wrote: On 01/27/2012 06:29 PM, Cousson, Benoit : Add some basic helpers to retrieve a DMA controller device_node and the DMA request line

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-02-23 Thread Cousson, Benoit
Salut Nico, On 2/22/2012 11:59 AM, Nicolas Ferre wrote: On 01/27/2012 06:29 PM, Cousson, Benoit : Add some basic helpers to retrieve a DMA controller device_node and the DMA request line number. For legacy reason another API will export the DMA request number into a Linux resource of type

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2012-02-22 Thread Cousson, Benoit
On 2/22/2012 3:23 PM, Rob Herring wrote: On 02/15/2012 10:04 AM, Benoit Cousson wrote: Adapt the GPIO driver to retrieve information from a DT file. Allocate the irq_base dynamically and rename bank->virtual_irq_start to bank->irq_base. Change irq_base type to int instead of u16 to match irq_al

Re: [PATCH v5 00/27] irq_domain generalization and rework

2012-02-21 Thread Cousson, Benoit
On 2/17/2012 6:55 PM, Russell King - ARM Linux wrote: > On Fri, Feb 17, 2012 at 06:42:31PM +0100, Cousson, Benoit wrote: [...] >> @@ -1237,8 +1238,10 @@ twl_probe(struct i2c_client *client, const struct >> i2c_device_id *id) >> >> pdata->irq_base = status;

Re: [PATCH v5 00/27] irq_domain generalization and rework

2012-02-17 Thread Cousson, Benoit
Hi Grant, On 2/16/2012 11:52 PM, Andrew Morton wrote: > On Thu, 16 Feb 2012 02:09:01 -0700 > Grant Likely wrote: > >> >> This series generalizes the "irq_host" infrastructure from powerpc >> so that it can be used by all architectures and renames it to "irq_domain". > > drivers/mfd/twl-core.c i

Re: [PATCH v5 08/27] irq_domain: Move irq_domain code from powerpc to kernel/irq

2012-02-16 Thread Cousson, Benoit
OK, forget about it, I've just seen your email on that and pulled your latest update. Regards, Benoit On 2/16/2012 6:38 PM, Cousson, Benoit wrote: Hi Grant, It looks like there is a small regression in that update, it cannot build due to a missing semi-colon. On 2/16/2012 10:09 AM,

Re: [PATCH v5 08/27] irq_domain: Move irq_domain code from powerpc to kernel/irq

2012-02-16 Thread Cousson, Benoit
Hi Grant, It looks like there is a small regression in that update, it cannot build due to a missing semi-colon. On 2/16/2012 10:09 AM, Grant Likely wrote: +/** + * irq_find_mapping() - Find a linux irq from an hw irq number. + * @host: domain owning this hardware interrupt + * @hwirq: hardwa

Re: [PATCH 1/5] gpio/omap: Remove bank->id information and misc cleanup

2012-02-16 Thread Cousson, Benoit
On 2/16/2012 6:53 AM, DebBarma, Tarun Kanti wrote: On Wed, Feb 15, 2012 at 9:34 PM, Benoit Cousson wrote: The driver does not need anymore any id to identify the GPIO instance. Remove every occurence of the bank->id inside the driver. Remove two trailing spaces. Add a dev variable for better r

Re: [PATCH 2/5] gpio/omap: Use devm_ API and add request_mem_region

2012-02-16 Thread Cousson, Benoit
On 2/16/2012 7:37 AM, Shubhrajyoti wrote: On Thursday 16 February 2012 11:11 AM, DebBarma, Tarun Kanti wrote: Hi Benoit, On Wed, Feb 15, 2012 at 9:34 PM, Benoit Cousson wrote: Replace the regular kzalloc and ioremap with the devm_ equivalent to simplify error handling. Add the missing devm_r

Re: [PATCH 1/4] spi/omap: Add DT support to McSPI driver

2012-02-15 Thread Cousson, Benoit
On 2/15/2012 8:34 PM, Rob Herring wrote: On 02/15/2012 11:37 AM, Benoit Cousson wrote: Add device tree support to the OMAP2+ McSPI driver. Add the bindings documentation. Based on original code from Rajendra. Signed-off-by: Benoit Cousson Cc: Grant Likely Cc: Rajendra Nayak --- Documentation

Re: [PATCH 2/4] arm/dts: OMAP4: Add SPI controller nodes

2012-02-15 Thread Cousson, Benoit
On 2/15/2012 9:02 PM, Grant Likely wrote: On Wed, Feb 15, 2012 at 06:37:35PM +0100, Benoit Cousson wrote: Add the 4 McSPI controller nodes present in an OMAP4 device. Remove SPI static device initialisation if DT is populated. Signed-off-by: Benoit Cousson Cc: Grant Likely --- arch/arm/boot/

Re: [PATCH v3 2/4] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller

2012-02-15 Thread Cousson, Benoit
On 2/14/2012 9:52 PM, Grant Likely wrote: On Tue, Feb 14, 2012 at 06:56:10PM +0100, Benoit Cousson wrote: Add a function to initialize the OMAP2/3 interrupt controller (INTC) using a device tree node. This version take advantage of the new irq_domain_add_legacy API. Replace some printk() with

Re: [PATCH v3 2/4] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller

2012-02-15 Thread Cousson, Benoit
On 2/14/2012 8:48 PM, Rob Herring wrote: On 02/14/2012 11:56 AM, Benoit Cousson wrote: Add a function to initialize the OMAP2/3 interrupt controller (INTC) using a device tree node. This version take advantage of the new irq_domain_add_legacy API. Replace some printk() with the proper pr_ macr

Re: [PATCH] I2C: OMAP: fix build breakage when CONFIG_OF is not set

2012-02-08 Thread Cousson, Benoit
Hi Luca, On 2/8/2012 12:25 PM, Luciano Coelho wrote: On Wed, 2012-02-08 at 16:42 +0530, Shubhrajyoti Datta wrote: On Wed, Feb 8, 2012 at 4:34 PM, Luciano Coelho wrote: On Wed, 2012-02-08 at 12:59 +0200, Felipe Balbi wrote: On Wed, Feb 08, 2012 at 12:56:52PM +0200, Luciano Coelho wrote: Sinc

Re: [PATCH v3 13/25] irq_domain: Remove 'new' irq_domain in favour of the ppc one

2012-02-03 Thread Cousson, Benoit
Hi Grant, I finally had the time to rebase most of the OMAP3 and OMAP4 DT patches on your latest irq_domain series and found a couple of minors regressions that breaks OMAP3 boot. On 1/27/2012 10:36 PM, Grant Likely wrote: [...] diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c

Re: [PATCH] arm/dts: OMAP3: Add omap3evm and am335xevm support

2012-02-02 Thread Cousson, Benoit
Hi Vaibhav, On 2/2/2012 10:34 AM, Hiremath, Vaibhav wrote: On Thu, Feb 02, 2012 at 10:26:29, Grant Likely wrote: On Wed, Feb 01, 2012 at 11:57:00AM +0530, Vaibhav Hiremath wrote: TI's OMAP3EVM and AM335xEVM are software development boards available for OMAP35x(AM/DM37x) and AM335x devices resp

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-02-02 Thread Cousson, Benoit
On 2/2/2012 9:45 AM, Russell King - ARM Linux wrote: > On Wed, Feb 01, 2012 at 11:50:30AM +0100, Cousson, Benoit wrote: >> Hi Russell, >> >> On 2/1/2012 12:09 AM, Russell King - ARM Linux wrote: >>> On Sat, Jan 28, 2012 at 11:06:02AM -0700, Grant Likely wrote: >&

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-02-01 Thread Cousson, Benoit
Hi Russell, On 2/1/2012 12:09 AM, Russell King - ARM Linux wrote: On Sat, Jan 28, 2012 at 11:06:02AM -0700, Grant Likely wrote: This makes the assumption that dma specifiers will only ever be 1 cell. I think to be generally useful, the full dma specifier needs to be either handed to the dma co

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-01-31 Thread Cousson, Benoit
Hi Grant, On 1/28/2012 7:06 PM, Grant Likely wrote: On Fri, Jan 27, 2012 at 06:29:22PM +0100, Cousson, Benoit wrote: Add some basic helpers to retrieve a DMA controller device_node and the DMA request line number. For legacy reason another API will export the DMA request number into a Linux

Re: [RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-01-27 Thread Cousson, Benoit
On 1/27/2012 7:13 PM, Stephen Warren wrote: Cousson, Benoit wrote at Friday, January 27, 2012 10:29 AM: Add some basic helpers to retrieve a DMA controller device_node and the DMA request line number. For legacy reason another API will export the DMA request number into a Linux resource of

[RFC PATCH 2/2] arm/dts: OMAP4: Add dma-controller and dma-request for I2C

2012-01-27 Thread Cousson, Benoit
Add the DMA controller node. Add the dma-request attributes for the OMAP4 I2C controllers. Signed-off-by: Benoit Cousson Cc: Grant Likely Cc: Rob Herring --- arch/arm/boot/dts/omap4.dtsi | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/

[RFC PATCH 1/2] of: Add generic device tree DMA helpers

2012-01-27 Thread Cousson, Benoit
Add some basic helpers to retrieve a DMA controller device_node and the DMA request line number. For legacy reason another API will export the DMA request number into a Linux resource of type IORESOURCE_DMA. This API is usable only on system with an unique DMA controller. Signed-off-by: Benoit Co

[RFC PATCH 0/2] Generic DMA bindings helpers for Device Tree

2012-01-27 Thread Cousson, Benoit
Hi All, Here is a first RFC to introduce a generic binding for DMA controller and DMA request along with a couple of basic helpers functions. The support is very limited since the a lot of DMA controllers in ARM SoCs are far for being adapted to dmaengine. At least this is the case for OMAP. It

Re: [RFCv2 00/14]

2012-01-25 Thread Cousson, Benoit
On 1/23/2012 10:53 PM, Rob Herring wrote: On 01/23/2012 03:07 PM, Grant Likely wrote: Hey everyone, Here's the second RFC for the irq_domain patches. I could use some help testing now. I still expect there will be a few bugs. The series is based on v3.3-rc1, and I've pushed it out to my git

Re: [PATCH] arm/dts: omap3-evm: Add i2c and twl4030 support

2012-01-23 Thread Cousson, Benoit
Hi Vaibhav, On 1/23/2012 9:49 AM, Hiremath, Vaibhav wrote: On Wed, Jan 18, 2012 at 12:25:39, Hiremath, Vaibhav wrote: Add support for TWL4030, which is interfaced on i2c1 bus. Also add clock frequencies for other i2c instances(2& 3) required for client-device exist on OMAP3EVM board. Signed-o

Re: [PATCH V6 4/7] cpufreq: add clk-reg cpufreq driver

2012-01-13 Thread Cousson, Benoit
On 1/12/2012 11:52 PM, Kevin Hilman wrote: Richard Zhao writes: [...] Do you have real case to need different voltage/clk? Sure, any system with independently scalable CPUs/clusters. AFAIK, in the ARM SoC world there is a least the MSM8660 that does support that today. Regards, Benoit

Re: [PATCH v2 4/5] arm/dts: OMAP3: Add interrupt-controller bindings for INTC

2012-01-13 Thread Cousson, Benoit
On 1/13/2012 1:31 PM, Hiremath, Vaibhav wrote: On Fri, Jan 13, 2012 at 16:33:07, Cousson, Benoit wrote: Hi Vaibhav, On 1/13/2012 7:14 AM, Hiremath, Vaibhav wrote: On Tue, Dec 20, 2011 at 19:09:57, Cousson, Benoit wrote: [...] +++ b/arch/arm/boot/dts/omap3.dtsi @@ -54,10 +54,12

Re: [PATCH v2 4/5] arm/dts: OMAP3: Add interrupt-controller bindings for INTC

2012-01-13 Thread Cousson, Benoit
Hi Vaibhav, On 1/13/2012 7:14 AM, Hiremath, Vaibhav wrote: On Tue, Dec 20, 2011 at 19:09:57, Cousson, Benoit wrote: [...] +++ b/arch/arm/boot/dts/omap3.dtsi @@ -54,10 +54,12 @@ ranges; ti,hwmods = "l3_main"; - intc: interrupt-co

Re: [PATCH v2 09/10] arm/dts: omap3-beagle: Add twl4030 and i2c EEPROM

2012-01-10 Thread Cousson, Benoit
On 1/10/2012 12:24 AM, Tabi Timur-B04825 wrote: On Fri, Dec 9, 2011 at 8:02 AM, Benoit Cousson wrote: + eeprom@50 { + compatible = "ti,eeprom"; + reg =<0x50>; + }; Why is this "ti,"? For EDID, isn't the I2C device actually on the monitor itself, and D

[GIT PULL] ARM: OMAP3+: Add DT support for i2c, twl6030 and EVM

2012-01-09 Thread Cousson, Benoit
Hi Tony, If this is not too late, could you please pull the various OMAP device tree patches? This series assume that all the drivers adaptation to DT are already merged and is based on my previous interrupt controller series. It means it has a strong dependency with i2c tree, mfd tree and rtc

[GIT PULL] ARM: OMAP2+: Interrupt controllers adaptation to DT

2012-01-09 Thread Cousson, Benoit
Hi Tony, If this is not too late, could you please pull the OMAP interrupt controllers adaptation to device tree? This series is based on your lo/dt branch to get the DTS and board cleanup. Thanks, Benoit The following changes since commit 40c0591f0a349ec074357e05c6ab1a3bc951807c: Benoit Co

Re: [PATCH v2 1/5] arm/dts: OMAP4: Update DTS file with new GIC bindings

2012-01-09 Thread Cousson, Benoit
On 1/6/2012 10:30 PM, Rob Herring wrote: > On 01/06/2012 03:15 PM, Grant Likely wrote: >> On Tue, Dec 20, 2011 at 02:39:54PM +0100, Benoit Cousson wrote: >>> The GIC binding was updated in 3.2 and expect 3 interrupt-cells. >>> - Update the #interrupt-cells >>> - interrupt-parent seems to be needed

Re: [PATCH v2 2/5] ARM: OMAP2/3: intc: Add irqdomain support

2012-01-09 Thread Cousson, Benoit
Hi Grant, On 1/6/2012 10:22 PM, Grant Likely wrote: On Tue, Dec 20, 2011 at 02:39:55PM +0100, Benoit Cousson wrote: [...] + /* +* XXX: Use a 0 irq_base for the moment since the legacy devices +* created statically are expected a hwirq = irq mapping. +* A proper

Re: [PATCH] irqdomain: Initialize number of IRQs for simple domains

2012-01-06 Thread Cousson, Benoit
Hi Thierry, On 1/6/2012 3:28 PM, Thierry Reding wrote: The irq_domain_add() function needs the number of interrupts in the domain to properly initialize them. In addition the allocated domain is now returned by the irq_domain_{add,generate}_simple() helpers. [...] diff --git a/arch/arm/mach-

Re: [PATCH v2 0/5] ARM: OMAP2+: Interrupt controllers adaptation to DT

2012-01-06 Thread Cousson, Benoit
Hi Rob/Grant, Gentle ping on that series too. This should the last one:-) Thanks, Benoit On 12/23/2011 10:46 AM, Cousson, Benoit wrote: Hi Rob, Are you OK with that update? Thanks, Benoit On 12/20/2011 2:39 PM, Benoit Cousson wrote: Hi Tony and Rob, Here is the series to take advantage

Re: [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

2012-01-06 Thread Cousson, Benoit
On 1/4/2012 9:11 PM, Grant Likely wrote: On Tue, Dec 6, 2011 at 9:49 AM, Benoit Cousson wrote: devicetree will become the mandatory boot method for OMAP2+. In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF, select USE_OF by default for every OMAP2+ systems. Select as well the APP

Re: [PATCH-V1] arm/dts: Add support for TI OMAP3 EVM board

2012-01-05 Thread Cousson, Benoit
Hi Vaibhav, On 1/5/2012 12:18 PM, Hiremath, Vaibhav wrote: From: Hiremath, Vaibhav Sent: Friday, December 16, 2011 12:36 PM To: linux-o...@vger.kernel.org Cc: t...@atomide.com; linux-arm-ker...@lists.infradead.org; devicetree- disc...@lists.ozlabs.org; grant.lik...@secretlab.ca; Cousson, Benoit

Re: [PATCH v2 03/10] mfd: twl-core: Add initial DT support for twl4030/twl6030

2012-01-05 Thread Cousson, Benoit
Hi Grant, On 1/4/2012 7:12 PM, Grant Likely wrote: On Fri, Dec 09, 2011 at 03:02:34PM +0100, Benoit Cousson wrote: [...] @@ -1183,22 +1187,53 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id) int status; unsigned

Re: [PATCH 3/3] of/irq: Add interrupts-names property to name an irq resource

2012-01-04 Thread Cousson, Benoit
Hi Grant, On 1/4/2012 8:17 AM, Grant Likely wrote: On Mon, Dec 05, 2011 at 03:23:56PM +0100, Benoit Cousson wrote: In a HW system, resources in general have name to identify them. The is the case as well for IORESOURCE_IRQ resources filled by DT "interrupts" entries. The current DT mechanism is

Re: [PATCH v2 02/10] i2c: OMAP: Add DT support for i2c controller

2012-01-04 Thread Cousson, Benoit
Hi Kevin, On 12/14/2011 2:06 AM, Kevin Hilman wrote: Benoit Cousson writes: Add initial DT support to retrieve the frequency using a DT attribute instead of the pdata pointer if of_node exist. Add documentation for omap i2c controller binding. Based on original patches from Manju and Grant.

Re: [PATCH 1/3] of/base: Take NULL string into account for property with multiple strings

2012-01-03 Thread Cousson, Benoit
Hi Grant, On 12/19/2011 3:02 PM, Rob Herring wrote: On 12/05/2011 08:23 AM, Benoit Cousson wrote: The current implementation just ignore any NULL string inserted in a multiple strings property. In some cases we can have a property with a fix number of strings but not necessarily used, like for

Re: [PATCH v4 03/12] mfd: twl-core: Add initial DT support for twl4030/twl6030

2012-01-03 Thread Cousson, Benoit
On 1/2/2012 10:04 AM, Grant Likely wrote: > On Thu, Dec 22, 2011 at 03:56:37PM +0100, Benoit Cousson wrote: >> Add initial device-tree support for twl familly chips. >> The current version is missing the regulator entries due >> to the lack of DT regulator bindings for the moment. >> Only the simpl

Re: [PATCH v2 0/5] ARM: OMAP2+: Interrupt controllers adaptation to DT

2011-12-23 Thread Cousson, Benoit
Hi Rob, Are you OK with that update? Thanks, Benoit On 12/20/2011 2:39 PM, Benoit Cousson wrote: Hi Tony and Rob, Here is the series to take advantage of the new DT interrupt init mechanism. Thanks to Marc's CONFIG_MULTI_IRQ_HANDLER series, OMAP4 just has to use the default GIC binding and do

Re: [PATCH v3 00/11] OMAP4: Add DT support for i2c and twl6030

2011-12-23 Thread Cousson, Benoit
On 12/22/2011 4:07 PM, Rob Herring wrote: For the series: Acked-by: Rob Herring Thanks Rob. Regards, Benoit ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v3 02/11] i2c: OMAP: Add DT support for i2c controller

2011-12-22 Thread Cousson, Benoit
Hi Olof, On 12/20/2011 10:24 PM, Olof Johansson wrote: Hi, On Tue, Dec 20, 2011 at 8:27 AM, Benoit Cousson wrote: diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index a43d002..dcbc1ec 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @

Re: [PATCH v3 02/11] i2c: OMAP: Add DT support for i2c controller

2011-12-22 Thread Cousson, Benoit
Hi Rob, On 12/20/2011 5:42 PM, Rob Herring wrote: On 12/20/2011 10:27 AM, Benoit Cousson wrote: Add initial DT support to retrieve the frequency using a DT attribute instead of the pdata pointer if of_node exist. Add documentation for omap i2c controller binding. Based on original patches fro

Re: [PATCH v2 04/10] rtc: rtc-twl: Add DT support for RTC inside twl4030/twl6030

2011-12-20 Thread Cousson, Benoit
Hi Andrew, I've never got any feedback on this patch from Alessandro and it seems that you took care of some rtc stuff recently. Thanks in advance, Benoit On 12/9/2011 3:02 PM, Benoit Cousson wrote: Add the DT support for the TI rtc-twl present in the twl4030 and twl6030 devices. Signed-off-b

Re: [PATCH 3/3] ARM: OMAP2+: board-generic: Replace #if defined by #ifdef for consistency

2011-12-20 Thread Cousson, Benoit
Hi Tony, What about that patch? This is the only one that is missing in lo. I know it is not a big deal, but it will make things a little bit cleaner. Thanks, Benoit On 12/6/2011 5:49 PM, Benoit Cousson wrote: The file contains a mix of #ifdef and #if defined(). Replace the #if... by #ifdef.

Re: [RFC v2 PATCH 0/3] dt: device tree bindings and data for EMIF and DDR

2011-12-20 Thread Cousson, Benoit
Hi Aneesh, On 12/20/2011 11:44 AM, Aneesh V wrote: On Tuesday 20 December 2011 05:05 AM, Tony Lindgren wrote: * Rob Herring [111219 14:29]: On 12/19/2011 08:05 AM, Aneesh V wrote: This is an RFC to add new device tree bindings for DDR memories and EMIF - TI's DDR SDRAM controller. The first

Re: [PATCH v2 04/10] rtc: rtc-twl: Add DT support for RTC inside twl4030/twl6030

2011-12-19 Thread Cousson, Benoit
Hi Alessandro, Gentle ping on this patch. Thanks, Benoit On 12/9/2011 3:02 PM, Benoit Cousson wrote: Add the DT support for the TI rtc-twl present in the twl4030 and twl6030 devices. Signed-off-by: Benoit Cousson Cc: Alessandro Zummo --- Documentation/devicetree/bindings/rtc/twl-rtc.txt |

Re: [PATCH 2/9] irq: check domain hwirq range for DT translate

2011-12-19 Thread Cousson, Benoit
On 12/19/2011 3:23 PM, Rob Herring wrote: Benoit, On 12/19/2011 06:41 AM, Cousson, Benoit wrote: Hi Rob, While trying your series to take advantage of the generic-irq domain support for OMAP3 INTC, I realized that the following patch is breaking drivers that are using irq_domain_add_simple

Re: [PATCH v2 03/10] mfd: twl-core: Add initial DT support for twl4030/twl6030

2011-12-19 Thread Cousson, Benoit
Salut Samuel, On 12/19/2011 1:03 PM, Samuel Ortiz wrote: Hi Benoit, On Fri, Dec 09, 2011 at 03:02:34PM +0100, Benoit Cousson wrote: Add initial device-tree support for twl familly chips. The current version is missing the regulator entries due to the lack of DT regulator bindings for the momen

  1   2   3   >