Re: [PATCH 3/3] MAINTAINERS: Refactor device tree maintainership

2013-07-20 Thread Joe Perches
On Sat, 2013-07-20 at 17:17 -0700, Olof Johansson wrote: > On Fri, Jul 19, 2013 at 8:19 PM, Grant Likely wrote: > > Device tree bindings require a lot more attention than they used to. > > We've got a group of volunteers willing to take over maintaining > > bindings. This patch adds them to the MA

Re: New device tree mailing list

2013-07-19 Thread Joe Perches
On Fri, 2013-07-19 at 18:23 -0700, Grant Likely wrote: > The ozlabs devicetree list was requiring too much work to moderate, so > I'm closing down that list and replacing it with a list on > vger.kernel.org. > > http://vger.kernel.org/vger-lists.html#devicetree Hey Grant. Can you also please set

Re: [PATCH 1/3] misc: Add crossbar driver

2013-07-18 Thread Joe Perches
On Thu, 2013-07-18 at 22:13 +0530, Sricharan R wrote: > Some socs have a large number of interrupts/dma requests to service > the needs of its many peripherals and subsystems. All of the > requests lines from the subsystems are not needed at the same > time, so they have to be muxed to the controll

[PATCH] gps6507x.txt: Remove executable bits

2013-07-12 Thread Joe Perches
Documentation shouldn't be executable. Signed-off-by: Joe Perches --- diff --git a/Documentation/devicetree/bindings/mfd/tps6507x.txt b/Documentation/devicetree/bindings/mfd/tps6507x.txt old mode 100755 new mode 100644 ___ devicetree-discuss ma

Re: [PATCH v7] ethernet/arc/arc_emac - Add new driver

2013-06-21 Thread Joe Perches
On Fri, 2013-06-21 at 17:58 +0200, Arnd Bergmann wrote: > On Friday 21 June 2013, Joe Perches wrote: > > On Fri, 2013-06-21 at 10:53 +, Alexey Brodkin wrote: > > > On 06/21/2013 02:32 PM, Joe Perches wrote: > > > > On Fri, 2013-06-21 at 11:20 +0400, Alexey Brod

Re: [PATCH v7] ethernet/arc/arc_emac - Add new driver

2013-06-21 Thread Joe Perches
On Fri, 2013-06-21 at 10:53 +, Alexey Brodkin wrote: > On 06/21/2013 02:32 PM, Joe Perches wrote: > > On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote: > >> Driver for non-standard on-chip ethernet device ARC EMAC 10/100, > >> instantiated in some legacy ARC

Re: [PATCH v7] ethernet/arc/arc_emac - Add new driver

2013-06-21 Thread Joe Perches
On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote: > Driver for non-standard on-chip ethernet device ARC EMAC 10/100, > instantiated in some legacy ARC (Synopsys) FPGA Boards such as > ARCAngel4/ML50x. Looks fine to me. One nit you could fix later and a question. > diff --git a/drivers/net

Re: [PATCH] gpio MIPS/OCTEON: Add a driver for OCTEON's on-chip GPIO pins.

2013-06-20 Thread Joe Perches
On Thu, 2013-06-20 at 11:27 -0700, David Daney wrote: > On 06/20/2013 11:18 AM, Joe Perches wrote: > > On Thu, 2013-06-20 at 11:10 -0700, David Daney wrote: > >> Sorry for not responding earlier, but my e-mail system seems to have > >> malfunctioned with respect to thi

Re: Re: [PATCH] gpio MIPS/OCTEON: Add a driver for OCTEON's on-chip GPIO pins.

2013-06-20 Thread Joe Perches
On Thu, 2013-06-20 at 11:10 -0700, David Daney wrote: > Sorry for not responding earlier, but my e-mail system seems to have > malfunctioned with respect to this message... [] > On 06/17/2013 01:51 AM, Linus Walleij wrote: > >> +static int octeon_gpio_get(struct gpio_chip *chip, unsigned offset) >

Re: [PATCH v4] ethernet/arc/arc_emac - Add new driver

2013-06-16 Thread Joe Perches
On Sat, 2013-06-15 at 20:47 +, Alexey Brodkin wrote: > On 06/16/2013 12:37 AM, Joe Perches wrote: > > On Sun, 2013-06-16 at 00:20 +0400, Alexey Brodkin wrote: [] > >> +static int arc_emac_rx(struct net_device *ndev, int budget) > > [] > >> +

Re: [PATCH v4] ethernet/arc/arc_emac - Add new driver

2013-06-15 Thread Joe Perches
On Sun, 2013-06-16 at 00:20 +0400, Alexey Brodkin wrote: > Driver for non-standard on-chip ethernet device ARC EMAC 10/100, > instantiated in some legacy ARC (Synopsys) FPGA Boards such as > ARCAngel4/ML50x. > diff --git a/drivers/net/ethernet/arc/emac_main.c > b/drivers/net/ethernet/arc/emac_mai

Re: [PATCH v3] ethernet/arc/arc_emac - Add new driver

2013-06-13 Thread Joe Perches
On Thu, 2013-06-13 at 21:25 +0300, Andy Shevchenko wrote: > On Thu, Jun 13, 2013 at 5:37 PM, Alexey Brodkin > wrote: > > Driver for non-standard on-chip ethernet device ARC EMAC 10/100, > > instantiated in some legacy ARC (Synopsys) FPGA Boards such as > > ARCAngel4/ML50x. > > Much better. But st

Re: [PATCH v2] ethernet/arc/arc_emac - Add new driver

2013-06-07 Thread Joe Perches
On Fri, 2013-06-07 at 19:07 +0400, Alexey Brodkin wrote: > Driver for non-standard on-chip ethernet device ARC EMAC 10/100, > instantiated in some legacy ARC (Synopsys) FPGA Boards such as > ARCAngel4/ML50x. trivial comments only: > diff --git a/drivers/net/ethernet/arc/arc_emac_main.c > b/drive

Re: [PATCH -next] net: sun4i-emac: fix a typo in emac_probe()

2013-06-03 Thread Joe Perches
On Mon, 2013-06-03 at 21:36 +0800, Wei Yongjun wrote: > Just fixed a typo in emac_probe(). also fixed a memory leak. > diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c > b/drivers/net/ethernet/allwinner/sun4i-emac.c [] > @@ -821,7 +821,7 @@ static int emac_probe(struct platform_device *p

Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver

2013-02-18 Thread Joe Perches
On Mon, 2013-02-18 at 20:13 -0800, Simon Glass wrote: > On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov > > On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: > >> + for (row = 0; row < ckdev->rows; row++) { > >> + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row)) > >>

Re: [PATCH v2 2/6] mfd: Add ChromeOS EC implementation

2013-02-12 Thread Joe Perches
On Tue, 2013-02-12 at 18:42 -0800, Simon Glass wrote: > This is the base EC implementation, which provides a high level > interface to the EC for use by the rest of the kernel. The actual > communcations is dealt with by a separate protocol driver which > registers itself with this interface. triv

[PATCH] drivers: net: Remove remaining alloc/OOM messages

2013-02-07 Thread Joe Perches
alignment. Signed-off-by: Joe Perches --- Let me know if you want multiple small patches instead. drivers/net/can/usb/ems_usb.c | 4 +- drivers/net/ethernet/amd/pcnet32.c | 47 +++--- drivers/net/ethernet/freescale/gianfar.c | 25

Re: [PATCH] drivers: phy: add generic PHY framework

2012-09-26 Thread Joe Perches
On Wed, 2012-09-26 at 20:31 +0530, Kishon Vijay Abraham I wrote: > The PHY framework provides a set of API's for the PHY drivers to > create/destroy a PHY and API's Just some trivial notes. > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c [] > @@ -0,0 +1,445 @@ [] > +static void de

Re: [RFC 1/4] ARM: topology: Add arch_scale_freq_power function

2012-06-13 Thread Joe Perches
On Wed, 2012-06-13 at 20:27 +0100, Andy Whitcroft wrote: > On Wed, Jun 13, 2012 at 02:52:49PM +0200, Peter Zijlstra wrote: > > On Tue, 2012-06-12 at 14:02 +0200, Vincent Guittot wrote: > > > } > > > smp_wmb(); > > > } > > > > You know what.. we should make checkpatch report an er

Re: [PATCH] slimbus: Linux driver framework for SLIMbus.

2012-06-03 Thread Joe Perches
On Tue, 2012-05-29 at 19:11 -0600, Sagar Dharia wrote: > SLIMbus (Serial Low Power Interchip Media Bus) is a specification > developed by MIPI (Mobile Industry Processor Interface) alliance. Just a few trivial notes before stopped reading as it was very long. > diff --git a/drivers/of/of_slimbus.

Re: [PATCH 4/5] netdev/phy: Add driver for Broadcom BCM87XX 10G Ethernet PHYs

2012-05-22 Thread Joe Perches
On Tue, 2012-05-22 at 11:26 -0700, David Daney wrote: > On 05/22/2012 11:17 AM, Joe Perches wrote: > > On Tue, 2012-05-22 at 10:59 -0700, David Daney wrote: > >> From: David Daney > > > > trivia: > > As long as we are splitting hairs... and zooming in and

Re: [PATCH 4/5] netdev/phy: Add driver for Broadcom BCM87XX 10G Ethernet PHYs

2012-05-22 Thread Joe Perches
On Tue, 2012-05-22 at 10:59 -0700, David Daney wrote: > From: David Daney trivia: > diff --git a/drivers/net/phy/bcm87xx.c b/drivers/net/phy/bcm87xx.c [] > @@ -0,0 +1,237 @@ > +static int bcm87xx_of_reg_init(struct phy_device *phydev) > +{ > + const __be32 *paddr; > + int len, i, ret; >

Re: [PATCH] drivers/ata/pata_mpc52xx.c: add missing kfree

2012-03-10 Thread Joe Perches
On Sat, 2012-03-10 at 19:13 +0100, Wolfram Sang wrote: > On Sat, Mar 10, 2012 at 06:56:39PM +0100, Julia Lawall wrote: > > From: Julia Lawall > > There is no need to call the devm cleanup functions on failure of a probe > > or remove function. > > Signed-off-by: Julia Lawall > the maintainer for

Re: [PATCH] drivers/ata/pata_mpc52xx.c: add missing kfree

2012-03-10 Thread Joe Perches
On Sat, 2012-03-10 at 19:44 +0100, Wolfram Sang wrote: > > Anatolij is not listed as a maintainer for this file > > nor has he ever written or signed a patch for it. > I noticed that Grant was in CC, assumed that it was because of his previous > MPC > maintainership and mentioned that Anatolij too

Re: [PATCH v4] serial/efm32: add new driver

2012-01-25 Thread Joe Perches
On Wed, 2012-01-25 at 09:05 +0100, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König trivial comments below: > diff --git a/drivers/tty/serial/efm32-uart.c b/drivers/tty/serial/efm32-uart.c [] > @@ -0,0 +1,830 @@ > +#if defined(CONFIG_SERIAL_EFM32_UART_CONSOLE) && defined(CONFIG_MAGIC_SY

Re: [RFC] scripts/get_maintainer: add emails based on keywords in the patch

2009-10-09 Thread Joe Perches
On Fri, 2009-10-09 at 04:23 -0700, Joe Perches wrote: > If this facility is desired by many others, it might be > better to have a separate file of 'regex generates email' > read at initialization. Perhaps it's better to use the existing MAINTAINERS file and extend it wit

Re: [RFC] scripts/get_maintainer: add emails based on keywords in the patch

2009-10-09 Thread Joe Perches
On Fri, 2009-10-09 at 12:32 +0200, Wolfram Sang wrote: > +my %keywords_to_mail = ( > + 'of_get_property' => 'L: devicetree-discuss@lists.ozlabs.org', maybe: '\bof_get_property\b' > + # Check the lines which a patch modifies for keywords; add mail if > found. > + } elsif (m/^