Re: [PATCH 3/3] MAINTAINERS: Refactor device tree maintainership

2013-07-21 Thread Jon Loeliger
> On Sat, Jul 20, 2013 at 5:19 AM, Grant Likely wrote > : > > > Device tree bindings require a lot more attention than they used to. > > We've got a group of volunteers willing to take over maintaining > > bindings. This patch adds them to the MAINTAINERS file. > > > > This group still needs to w

Re: [PATCH] Bump version number to 1.4.0

2013-06-22 Thread Jon Loeliger
07a5dbabd80ebf type commit tag v1.4.0 tagger Jon Loeliger 1371924387 -0500 DTC 1.4.0 The Mandate from the Masses release. gpg: Signature made Sat 22 Jun 2013 01:06:41 PM CDT using RSA key ID B0272867 gpg: Good signature from "Jon Loe

Re: [PATCH] Bump version number to 1.4.0

2013-06-22 Thread Jon Loeliger
> >> > >> How about if nobody objects, a release is made by the end of the > >> week? > > > > Works for me. > > Great! I didn't see any objections, and the week is basically over. > Are we good for a release today? I get it, thanks. I also have to have time to do it. jdl

Re: [PATCH] Bump version number to 1.4.0

2013-06-15 Thread Jon Loeliger
> > Hrm. We should make a new release. But I don't think we should bump > the version without actuall rolling a release. ..and are we ready to do so? jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org

Re: [PATCH V2] dtc: ensure #line directives don't consume data from the next line

2013-06-03 Thread Jon Loeliger
> From: Stephen Warren > > Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} > could match line-break characters. If the #line directive did not contain > the optional flags field at the end, this could cause any integer data on > the next line to be consumed as part of the

Re: [0/10] Pending patches pull request

2013-05-29 Thread Jon Loeliger
> Hi Jon, > > Here's a batch of patches, a few from me, mostly from others, which I > think should go into dtc/libfdt. Please apply, or you can pull from: > git://github.com/dgibson/dtc.git (branch 'master') Pulled and pushed! Thanks, jdl ___ d

Re: [PATCH v2] libfdt: Add fdt_next_subnode() to permit easy subnode iteration

2013-04-28 Thread Jon Loeliger
> On Fri, Apr 26, 2013 at 05:43:31AM -0700, Simon Glass wrote: > > Iterating through subnodes with libfdt is a little painful to write as we > > need something like this: > > > > for (depth = 0, count = 0, > > offset = fdt_next_node(fdt, parent_offset, &depth); > > (offset >= 0) && (depth

Re: [PATCH 04/10] util_version: new helper for displaying version info

2013-04-22 Thread Jon Loeliger
> On Monday 22 April 2013 11:37:12 Jon Loeliger wrote: > > > hmm, looks like patch #2 (utilfdt_read and handling of the len argument) > > > was taken from the first patch series rather than the 3rd ? > > > > > > i'd suggest reverting it a

Re: [PATCH 04/10] util_version: new helper for displaying version info

2013-04-22 Thread Jon Loeliger
> > > hmm, looks like patch #2 (utilfdt_read and handling of the len argument) was > taken from the first patch series rather than the 3rd ? > > i'd suggest reverting it and applying instead the one from this series ... > Message-Id: <1366078397-14889-3-git-send-email-vap...@gentoo.org> Please

Re: [PATCH 04/10] util_version: new helper for displaying version info

2013-04-21 Thread Jon Loeliger
> > On Mon, Apr 15, 2013 at 10:13:11PM -0400, Mike Frysinger wrote: > > This is so all utilities can have this flag and not just dtc. > >=20 > > Acked-by: David Gibson > > Signed-off-by: Mike Frysinger > > Jon, > > Please apply these first 4 patches, regardless of the rest of the > series. Do

Re: [PATCH] Added license header to dtc/libfdt/fdt.h and libfdt_env.h

2013-02-18 Thread Jon Loeliger
> > On Fri, Feb 15, 2013 at 11:06:10AM -0500, Justin Sobota wrote: > > This commit adds a license header to fdt.h and libfdt_env.h because the l= > icense was omitted. > >=20 > > Signed-off-by: Justin Sobota > Acked-by: David Gibson Applied! Thanks, jdl

Making a Release

2013-02-13 Thread Jon Loeliger
Folks, I'd like to tag an official release of the DTC soon. To that end, here is a call for any last minute patches that are desired for this release! I am still waiting on a spin of a patch that adds copyright headers (with signoffs!) to a few libfdt files. Others? jdl

Re: [dtc][PATCH] Fix typo

2013-02-03 Thread Jon Loeliger
> Hi, > $subject :-) > > Fran=C3=A7ois. > > >From ad0c53de9b5a1d060127bdea138043306eed881c Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Fran=3DC3=3DA7ois=3D20Revol?=3D > Date: Sun, 3 Feb 2013 00:49:10 +0100 > Subject: [PATCH] Fix typo > MIME-Version: 1.0 > Content-Type: text/plain; charset=3DUTF

Re: [PATCH 4/8] Export fdt_stringlist_contains()

2013-01-27 Thread Jon Loeliger
> This function is useful outside libfdt, so export it. > > Signed-off-by: Simon Glass Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 3/8] .gitignore: Add rule for *.patch

2013-01-27 Thread Jon Loeliger
> Ignore any patch files that we find, since these are likely to be > used when sending patches upstream. > > Signed-off-by: Simon Glass Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.

Re: [PATCH 2/8] Move property-printing into util

2013-01-27 Thread Jon Loeliger
> The function that prints a property can be useful to other programs, > so move it into util. > > Signed-off-by: Simon Glass Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinf

Re: [PATCH v2 1/8] Adjust util_is_printable_string() comment and fix test

2013-01-27 Thread Jon Loeliger
> This commit which changed the behaviour of this function broke one > of the tests. Also the comment should be updated to reflect its new > behaviour. > > Signed-off-by: Simon Glass > --- > Changes in v2: > - Add new test to check byte output of a string list property Applied. Thanks, jdl ___

Re: New DTC Release

2013-01-24 Thread Jon Loeliger
> > Jon, > > David informed me the master is generally stable enough to consume True. > but I'd feel more comfortable using an official DTC release. It's in the works. I have a few more patch I'll apply first for sure. (At least 1 through 3 of the recent 6 patch series.) > One additional i

Re: Fix test relying in wrong behavior of is_printable

2013-01-07 Thread Jon Loeliger
> Err, > > I can rework and resubmit to remove the comment, but the test doesn't = > fail: > > > $ make check | grep 'MyBoardName.*-t s.*compatible' > > fdtget-runtest.sh MyBoardName MyBoardFamilyName -t s > > label01.dts.fdtget.test.dtb / compatible: PASS > > > > As of today's pull. My b

Re: Fix test relying in wrong behavior of is_printable

2013-01-06 Thread Jon Loeliger
> Hi David > > =CE=91=CF=80=CF=8C =CF=84=CE=BF iPhone =CE=BC=CE=BF=CF=85 > > 6 =CE=99=CE=B1=CE=BD 2013, 5:58, =CE=BF/=CE=B7 David Gibson opbear.id.au> =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5: > > > On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote: > >> After fixing the is_printabl

Re: [PATCH] Allow simple cross-compilation of library

2013-01-06 Thread Jon Loeliger
> On Wed, Jun 27, 2012 at 08:22:57AM -0500, Jon Loeliger wrote: > > > > [ Forwarded to devicetree dev list for comment. --jdl ] > > Yeah, I guess that makes sense. > > > > > > > --- Forwarded Message > > > > Subject: [PATCH] Allow si

Re: [PATCH REPOST] fdtget-runtest.sh: use printf instead of /bin/echo -e

2013-01-06 Thread Jon Loeliger
> From: Stephen Warren > > Not all /bin/echo implementations support the -e option. Instead, use > printf, which appears to be more widely available than /bin/echo -e. > > See commit eaec1db "fdtget-runtest.sh: Fix failures when /bin/sh isn't > bash" for history. > > I have tested this on Ubunt

Re: [PATCH] dtc: Drop the '-S is deprecated' warning

2013-01-06 Thread Jon Loeliger
> The 'deprecated' warning is in there for more than 4 years now > and nobody seemed to be confused enough to vote it out. Let's > drop the warning then. > > This reverts commit 315c5d095ebdf29f1912186e76ab9f95e694b18a. > > Signed-off-by: Horst Kronstorfer Applied. Thanks, jdl ___

Re: [PATCH 4/4] dtc/libfdt: sparse fixes

2013-01-06 Thread Jon Loeliger
> libfdt/fdt.c:104:28: warning: incorrect type in argument 1 (different base > types) > libfdt/fdt.c:104:28:expected restricted fdt32_t [usertype] x > libfdt/fdt.c:104:28:got unsigned int const [unsigned] [usertype] > libfdt/fdt.c:124:40: warning: incorrect type in argument 1 (different b

Re: [PATCH v4 3/4] dtc/libfdt: introduce fdt types for annotation by endian checkers

2013-01-06 Thread Jon Loeliger
> Projects such as linux and u-boot run sparse on libfdt. libfdt > contains the notion of endianness via usage of endian conversion > functions such as fdt32_to_cpu. As such, in order to pass endian > checks, libfdt has to annotate its fdt variables such that sparse > can warn when mixing bitwise

Re: [PATCH 2/4] dtc/fdtdump: include libfdt_env.h prior to fdt.h

2013-01-06 Thread Jon Loeliger
> in order to get the upcoming fdt type definitions. > > Signed-off-by: Kim Phillips Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 1/4] dtc/tests: don't include fdt.h prior to libfdt.h

2013-01-06 Thread Jon Loeliger
> tests will need fdt type definitions provided in a subsequent patch > to libfdt_env.h. Since libfdt.h includes libfdt_env.h in the right > order anyway, just remove the fdt.h include. > > Signed-off-by: Kim Phillips Applied. Thanks, jdl ___ devicet

Re: Fix util_is_printable_string

2013-01-06 Thread Jon Loeliger
> The method used did not account for multi-part strings. > > Signed-off-by: Pantelis Antoniou Applied. Plese consider a follow-up patch to address David's concerns. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org

Re: fdtdump: properly handle multi-string properties

2013-01-06 Thread Jon Loeliger
> Device tree can store multiple strings in a single property. > We didn't handle that case properly. > > Signed-off-by: Pantelis Antoniou Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlab

Re: RFC: New release for DTC?

2012-12-11 Thread Jon Loeliger
> >> > > >> > This has been a bit of a perrenial problem. dtc development has been > >> > sufficiently gradual that there haven't been many obvious points for > >> > making new releases. dtc developers (i.e. Jon and my, mostly) don't > >> > feel much pain from the lack of releases, since the git

Re: [PATCH 3/4 v2] dtc/libfdt: introduce fdt types for annotation by endian checkers

2012-11-14 Thread Jon Loeliger
Hi Kim, > > I hope this addresses all your comments, David. Which is why David didn't see this patch earlier. :-) > index 213d7fb..302d5cb 100644 > --- a/libfdt/libfdt_env.h > +++ b/libfdt/libfdt_env.h > @@ -5,25 +5,63 @@ > #include > #include > > +#ifdef __CHECKER__ > +#define __force

Re: [RFC/PATCH] Add documentation on how to submit patches

2012-10-16 Thread Jon Loeliger
> Signed-off-by: Michael Ellerman > --- > > Assuming the details are correct? .. Indeed. Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] dtc: srcpos_verror() should print to stderr

2012-10-16 Thread Jon Loeliger
> Errors should go to stderr. > > Signed-off-by: Michael Ellerman Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH V3] dtc: fix for_each_*() to skip first object if deleted

2012-10-08 Thread Jon Loeliger
> On Fri, Oct 05, 2012 at 09:57:41AM -0600, Stephen Warren wrote: > > From: Stephen Warren > > > > The previous definition of for_each_*() would always include the very > > first object within the list, irrespective of whether it was marked > > deleted, since the deleted flag was not checked on t

Re: dtc: import latest upstream dtc

2012-10-01 Thread Jon Loeliger
> > What more do you think needs discussion re: dtc+cpp? How not to abuse the ever-loving shit out of it? :-) jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: dtc: import latest upstream dtc

2012-10-01 Thread Jon Loeliger
> > Seems dtc doesn't really have a maintainer. Picking nits, let's be clear on that phraseology: Seems dtc doesn't really have a maintainer within the kernel repository. Over in git.jdl.com land, there is a well established maintainer for the upstream DTC. > Probably makes more sense

Re: [PATCH V3 2/2] dtc: cpp co-existence: add support for #line directives

2012-09-30 Thread Jon Loeliger
> > > > > > Jon, please apply. > > > > Both 1/2 and 2/2 applied and pushed out. > > Ah. I had further comments about 1/2. Oh well, I'll look at patches > to fix it up later. Sorry, didn't realize that. jdl ___ devicetree-discuss mailing list device

Re: [PATCH] dtc: import latest upstream dtc

2012-09-29 Thread Jon Loeliger
e filename being compiled. > * Many additions to the libfdt API. > > Signed-off-by: Stephen Warren For what it might be worth: Acked-by: Jon Loeliger jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [RFC PATCH 0/2] dtc: enable use of pre-processor

2012-09-28 Thread Jon Loeliger
> From: Stephen Warren > > I'll post a patch to update the in-kernel dtc to the upstream dtc as > soon as one final dtc patch has been applied, and this series will then > depend on that patch. And that patch, I think, has just been applied to the upstream DTC repo at git.jdl.com: commit 3

Re: [PATCH] dtc: zero out new label objects

2012-09-28 Thread Jon Loeliger
> From: Stephen Warren > > Without this, new->deleted may be left set to some random value, which > may then cause future label references to fail to locate the label. The > code that allocates properties and nodes already contains the equivalent > memset(). > > Signed-off-by: Stephen Warren A

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-28 Thread Jon Loeliger
> > > > I think you should just smack the PowerPC guys. :-) > > For the record in this thread, it was a regression I introduced into dtc > - the patch I just sent was for this. Ah, ok. I'll apply the DTC patch, but I think you should still smack the PowerPC guys on general principle. :-) jdl _

Re: [PATCH 1/1] Fix segfault in DTC

2012-09-28 Thread Jon Loeliger
> > > > Yeah, seems like the kernel DTC is quite old. > > FYI, I'm working on a patch to the kernel to bring in the latest dtc. Awesome. Thank you. > I've run a regression test vs. the old dtc in the kernel ... Which is the icky step. Again, thank you. > ... and found that > some of the Pow

Re: [PATCH V3 2/2] dtc: cpp co-existence: add support for #line directives

2012-09-28 Thread Jon Loeliger
> On Thu, Sep 27, 2012 at 05:11:05PM -0600, Stephen Warren wrote: > > From: Stephen Warren > > > > Line control directives of the following formats are supported: > > #line LINE "FILE" > > # LINE "FILE" [FLAGS] > > > > This allows dtc to consume the output of pre-processors, and to provi

Re: [PATCH V3] dtc: Add ability to delete nodes and properties

2012-09-06 Thread Jon Loeliger
> On Tue, Aug 07, 2012 at 10:50:15PM -0600, Stephen Warren wrote: > > From: Stephen Warren > > > > dtc currently allows the contents of properties to be changed, and the > > contents of nodes to be added to. There are situations where removing > > properties or nodes may be useful. This change im

Re: [PATCH v2 dtc-1.3.0] dtc: Add --strip-disabled option to dtc(v2).

2012-08-20 Thread Jon Loeliger
> From: Srinivas Kandagatla > > This patch allows dtc to strip out nodes in its output based on status > property. Now the dtc has additional long option --strip-disabled to > strip all the nodes which do not have status property set to "okay" or > "ok". Nodes which do not have status property ar

Re: [DTC] Compilation issue on Red-hat host systems

2012-07-29 Thread Jon Loeliger
> > My flex version on system is flex version 2.5.4 > I tried by -Wstrict-prototypes form Makefile, But still I got the same > error. > > Do I need to upgrade my flex. > > Regards, > Jagan. My flex is: $ flex --version flex 2.5.35 $ gcc --version gcc (Debian 4.4.5-8) 4.4.5

Re: [PATCH v2 5/5] fdtput: Add -p option to create subnodes along entire path

2012-07-12 Thread Jon Loeliger
> This option mimics mkdir's -p option. It automatically creates nodes > as needed along the path provided. If the node already exists, no > error is given. > > Signed-off-by: Simon Glass Whole 5-part patchset applied. Thanks, jdl ___ devicetree-discu

Re: [PATCH 1/5] fdtput: Fix nit in help message

2012-07-11 Thread Jon Loeliger
> On Tue, Jul 10, 2012 at 05:56:44AM -0700, Simon Glass wrote: > > There was an extra < in the help message, so fix it. > > > > Signed-off-by: Simon Glass > > Acked-by: David Gibson Applied. jdl ___ devicetree-discuss mailing list devicetree-discuss

Re: [PATCH REPOST] Add test for re-defining an identical label

2012-07-08 Thread Jon Loeliger
> > > > Applied. > > Hrm, apparently not pushed out, though. Rats. I am dumb. Should be there now. Sorry, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 2/2] Allow toggling of semantic checks

2012-07-08 Thread Jon Loeliger
> This patch adds -W and -E options to dtc which allow toggling on and off > of the various built in semantic checks on the tree. > > Signed-off-by: David Gibson Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.

Re: [PATCH 1/2] Re-work level setting on checks code

2012-07-08 Thread Jon Loeliger
> Currently each of the semantic checks in checks.c has a "level" between > IGNORE and ERROR. This single level makes it awkward to implement the > semantics we want for toggling the checks on the command line. > > This patch reworks the code to instead have separate boolean flags for > warning a

Re: [PATCH REPOST] Add test for re-defining an identical label

2012-07-08 Thread Jon Loeliger
> On Tue, Jul 03, 2012 at 02:09:30PM -0600, Stephen Warren wrote: > > From: Stephen Warren > > > > When merging one device tree over the top of a previous tree, it is > > possible to define a duplicate label that has the same name and points > > to the same property or node. This is currently all

[PATCH] Allow simple cross-compilation of library

2012-06-27 Thread Jon Loeliger
[ Forwarded to devicetree dev list for comment. --jdl ] --- Forwarded Message Subject: [PATCH] Allow simple cross-compilation of library To: j...@jdl.com From: Christoffer Dall Date: Tue, 05 Jun 2012 13:09:59 -0400 Message-ID: <20120605170959.12774.39782.stgit@ubuntu> This is extremely u

Re: [PATCH] Fix compilation warning/error in setprop_inplace.c

2012-06-27 Thread Jon Loeliger
> On Wed, Jun 13, 2012 at 12:31:52PM +1000, David Gibson wrote: > > On Tue, Jun 12, 2012 at 02:48:12PM -0600, Stephen Warren wrote: > > > From: Stephen Warren > > >=20 > > > When compiling the current code-base with gcc 4.6.1, the following wa= > rning > > > is raised, which is interpreted as an e

Re: [0/3] libfdt: Add some new convenience functions

2012-06-03 Thread Jon Loeliger
> This patch series adds some convenience functions to libfdt - all > trivial wrappers on existing functions. 1/3 is a preliminary cleanup > which removes some obsolete testcases, to avoid updating them for the > new code. > > Please apply. All three applied and pushed out. jdl ___

Re: [PATCH v2 2/2] Add integer expressions files to .gitignore

2012-04-19 Thread Jon Loeliger
> Several files were added, and should be in .gitignore. The *.test.dts > pattern should catch future source files which are generated by tests. > It also subsumes the old *.dtb.test.dts pattern. > > Signed-off-by: Simon Glass > --- > Changes in v2: > - Split ordering change into a separate patch

Re: [PATCH v2 1/2] dtc: Adjust .gitignore to be in alphabetical order

2012-04-19 Thread Jon Loeliger
> This is the intent, so correct it. > > Signed-off-by: Simon Glass > --- > Changes in v2: > - Split ordering change into a separate patch Applied. jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/li

Re: [PATCH] Remove invalid macro starting with _ from libfdt_env.h

2012-04-14 Thread Jon Loeliger
> libfdt_env.h in the device tree compiler currently defines a _B() macro. This > is in the > namespace reserved for the implementation, and Cygwin's ctype.h actually > defines a macro > with this name. This renames _B to EXTRACT_BYTE. > > Signed-off-by: Bert Kenward Applied. Thanks, jdl

Re: [PATCH v2] dtc: Remove spurious output on stderr

2012-04-14 Thread Jon Loeliger
> On Wed, Apr 11, 2012 at 04:32:26PM -0700, Simon Glass wrote: > > Outputing to stderr is best avoided unless there is an error or warning to > > display. At present dtc always displays the name of the file it is compiling > > and the input/output formats. For example: > > > > DTC: dts->dts on fi

Re: [PATCH] dtc: Basic integer expressions

2012-04-10 Thread Jon Loeliger
> > > > can we update the kernel with it in next I'm goint to use it for at91 too > > Sure. > > Grant, > > Should I just port this individual patch, or pull in the whole of ToT > dtc? I vaguely recall you advocating the latter sometime recently. We should wait and include the recently posted pa

[PATCH] Rename _B to _XBYTE in libfdt_env.h.

2012-04-10 Thread Jon Loeliger
+0200 X-Google-Sender-Auth: Shpb895xEpu8vb2twHQiSB32YTQ Message-ID: Subject: Re: [PATCH] Rename _B to _XBYTE in libfdt_env.h. To: Jon Loeliger Content-Type: multipart/alternative; boundary=20cf3074d9a8475ab904bd4ff20c Received-SPF: pass X-SPF-Guess: pass X-Spam-Score: 1.5 - --20cf3074d9a8475ab904bd4ff20c Content-Typ

Re: [PATCH] Rename _B to _XBYTE in libfdt_env.h.

2012-04-09 Thread Jon Loeliger
53-1-git-send-email-and...@andree.sk> References: <1333434921-14153-1-git-send-email-and...@andree.sk> Comments: In-reply-to Andrej Krutak message dated "Tue, 03 Apr 2012 08:35:21 +0200." Date: Mon, 09 Apr 2012 08:49:04 -0500 From: Jon Loeliger X-Spam-Score: -0.0 > The _B m

Re: [PATCH] dtc: Basic integer expressions

2012-04-09 Thread Jon Loeliger
> Written by David Gibson . Additions by me: > * Ported to ToT dtc. > * Renamed cell to integer throughout. > * Implemented value range checks. > * Allow U/L/UL/LL/ULL suffix on literals. > * Enabled the commented test. > > Signed-off-by: Stephen Warren > --- > v3: > * Fix printf warning by s/%ld

Re: [PATCH V2] dtc: Basic integer expressions

2012-03-31 Thread Jon Loeliger
> Written by David Gibson . Additions by me: > * Ported to ToT dtc. > * Renamed cell to integer throughout. > * Implemented value range checks. > * Allow L/UL/LL/ULL suffix on literals. > * Enabled the commented test. > > Signed-off-by: Stephen Warren > --- > v2: > * s/cell/integer/ throughout. >

Re: [PATCH] fdtget-runtest.sh: Fix failures when /bin/sh isn't bash

2012-03-31 Thread Jon Loeliger
> > Uh, it was "this isn't perfect, but it's better than what we have, > please apply". Sorry, I misunderstood. > I've forwarded Stephen's patch to you again. I've applied it. jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.or

Re: [PATCH] fdtget-runtest.sh: Fix failures when /bin/sh isn't bash

2012-03-26 Thread Jon Loeliger
> On Wed, Mar 21, 2012 at 02:26:53PM +1100, David Gibson wrote: > > On Tue, Mar 20, 2012 at 08:23:46PM -0600, Stephen Warren wrote: > > > On Ubuntu, /bin/sh is dash (at least by default), and dash's echo doesn't > > > accept the -e option. This means that fdtget-runtest.sh's EXPECT file will > > >

Re: [PATCH v2] dtc: Add -i option to support search paths

2012-03-18 Thread Jon Loeliger
> It is often inconvenient to place device tree files in the same directory > as their includes, or to specify the full path to include files. > > An example of this is in U-Boot where we have a .dtsi file for each SOC > type, and this is included by the board .dts file. We need to either use > a

Re: [PATCH] dtc: Add -i option to support search paths

2012-03-12 Thread Jon Loeliger
> It is often inconvenient to place device tree files in the same directory > as their includes, or to specify the full path to include files. > > An example of this is in U-Boot where we have a .dtsi file for each SOC > type, and this is included by the board .dts file. We need to either use > a

Re: Some slightly random musings on device tree expression syntax

2012-03-12 Thread Jon Loeliger
> I was thinking some more about how to expand the device tree syntax to > allow expressions. Excellent! > I wondered if we should use a concept/syntax more > inspired by template processors. Playing with jinja2 and gpp led me > towards (...) being an inline expression syntax that can calculate >

Re: [PATCH 2/4] fdtget: Add -p to list the properties of a node

2012-03-07 Thread Jon Loeliger
> On Wed, Mar 07, 2012 at 01:27:59PM -0600, Jon Loeliger wrote: > > > This option lists the properties of each node given as a parameter, one > > > property per line. > > > > > > Signed-off-by: Simon Glass > > > > Applied. > > But not pu

Re: [PATCH v2 4/4] fdtget: Add -d to provide a default value

2012-03-07 Thread Jon Loeliger
> Sometimes the requested node or property is not present in the device > tree. This option provides a way of reporting a default value in this > case, rather than halting with an error. > > Signed-off-by: Simon Glass > Acked-by: David Gibson > --- > Changes in v2: > - Rebased on top of changes

Re: [PATCH v2 3/4] fdtget: Add -l to list the subnodes of a node

2012-03-07 Thread Jon Loeliger
> This option lists the subnodes of each node given as a parameter, one > subnode per line. > > Signed-off-by: Simon Glass Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/d

Re: [PATCH 4/4] fdtget: Add -d to provide a default value

2012-03-07 Thread Jon Loeliger
> Sometimes the requested node or property is not present in the device > tree. This option provides a way of reporting a default value in this > case, rather than halting with an error. > > Signed-off-by: Simon Glass I'll wait for the respin here too. jdl __

Re: [PATCH 2/4] fdtget: Add -p to list the properties of a node

2012-03-07 Thread Jon Loeliger
> This option lists the properties of each node given as a parameter, one > property per line. > > Signed-off-by: Simon Glass Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinf

Re: [PATCH 3/4] fdtget: Add -l to list the children of a node

2012-03-07 Thread Jon Loeliger
> This option lists the children of each node given as a parameter, one > child per line. > > Signed-off-by: Simon Glass I'll wait for the respin here. jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.or

Re: [PATCH 1/4] fdtget: Fix multiple arg bug and add test for it

2012-03-07 Thread Jon Loeliger
> There is a rather unfortunate bug in fdtget in that if multiple argument > sets are provided, it just repeats displaying the first set ones for > each set. > > Fix this bug and add a test for it. > > Signed-off-by: Simon Glass Applied. Thanks, jdl

Re: [PATCH] dtc: Fix zero-length input segfault

2012-02-17 Thread Jon Loeliger
> This patch fixes a segmentation fault caused by dereferencing a NULL > pointer (pos->file aka yylloc.file) in srcpos_string when the input > length is 0 (fe 'dtc with 0 and the tokenizer, which updates yylloc.file via srcpos_update > doesn't get a chance to run on zero-length input. > > Signed-

Re: [PATCH] Fix uninitialized access bug in utilfdt_decode_type

2012-02-03 Thread Jon Loeliger
> I just found this little bug with valgrind. strchr() will return true > if the given character is '\0'. This meant that utilfdt_decode_type() > could take a path which accesses uninitialized data when given the > (invalid) format string "L". > > Signed-off-by: David Gibson Applied. Thanks,

Re: [0/10] Assorted cleanups (esp for fdt{get,put} tests)

2012-02-03 Thread Jon Loeliger
> As noted earlier, there were a few things I wasn't totally happy with > in the recently applied fdt{get,put} patches, mostly in the test code. > I had a look at cleaning up those problems today, which kind of > expanded into a whole bunch of little cleanups for tests and a few > other things. >

Re: [PATCH] scripts: dtc: fix compile warnings

2012-01-26 Thread Jon Loeliger
> RmVsaXBlIEJhbGJpIHdyb3RlIGF0IFRodXJzZGF5LCBKYW51YXJ5IDI2LCAyMDEyIDQ6MjAgQU06 > DQo+IEZpeCBmb2xsb3dpbmcgY29tcGlsZSB3YXJuaW5nczoNCj4gDQo+IHNjcmlwdHMvZHRjL2Zs > YXR0cmVlLmM6IEluIGZ1bmN0aW9uIOKAmGZsYXRfcmVhZF9tZW1fcmVzZXJ2ZeKAmToNCj4gc2Ny > aXB0cy9kdGMvZmxhdHRyZWUuYzo3MDA6MTQ6IHdhcm5pbmc6IHZhcmlhYmxl

Re: [PATCH v6 2/2] Add fdtput utility to write property values to a device tree

2012-01-21 Thread Jon Loeliger
> This simple utility allows writing of values into a device tree from the > command line. It aimes to be the opposite of fdtget. > > What is it for: > - Updating fdt values when a binary blob already exists >(even though source may be available it might be easier to use this > utility rat

Re: [PATCH v6 1/2] Add fdtget utility to read property values from a device tree

2012-01-21 Thread Jon Loeliger
> This simply utility makes it easy for scripts to read values from the device > tree. It is written in C and uses the same libfdt as the rest of the dtc > package. > > What is it for: > - Reading fdt values from scripts > - Extracting fdt information within build systems > - Looking at particular

Re: [PATCH v2 REPOST] dtc: Add support for named integer constants

2012-01-16 Thread Jon Loeliger
> > > For what it's worth, I'd tend towards a simple expression-based syntax > > where property values can be calculated with C-style expressions. Basic > > math stuff like ( ) + - * / & | ~ << >> and some basic string handling > > operations (str(int) and concatenation). > > ... > > I think appl

Re: [PATCH V2 REPOST] dtc: Implement -d option to write out a dependency file

2012-01-13 Thread Jon Loeliger
> This will allow callers to rebuild .dtb files when any of the /include/d > .dtsi files are modified, not just the top-level .dts file. > > Signed-off-by: Stephen Warren > Acked-by: David Gibson > --- > v2: Replaced fputs/fputc with fprintf. > v2 repost: Add David's ack. > > This patch is for

Re: [PATCH V2] dtc: Implement -d option to write out a dependency file

2012-01-12 Thread Jon Loeliger
> > Um.. so, the mail I was replying to you above, was for the dtc repo > and you were on the recipient list. Given the frequency with which I > need to resend my own patches, I'm beginning to wonder if your mail > system is dropping things, Jon.. It is not. See Stephen's mail, for example. jd

Re: [PATCH V2] dtc: Implement -d option to write out a dependency file

2012-01-12 Thread Jon Loeliger
> > I'm not saying he didn't do the worl, nor am I saying he > didn't post such a past. I'm saying *I* don't have it! Yeeesh. s/worl/work/ s/past/patch/ jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.

Re: [PATCH v2 REPOST] dtc: Add support for named integer constants

2012-01-12 Thread Jon Loeliger
> I find it ironic that the very first device tree implementation, dating > back to 1989, was built around a Turing complete language. ...and that my uncle wrote one of the very first books about that language. :-) jdl ___ devicetree-discuss mailing li

Re: [PATCH V2] dtc: Implement -d option to write out a dependency file

2012-01-12 Thread Jon Loeliger
> On Wed, Jan 11, 2012 at 08:29:58AM -0600, Jon Loeliger wrote: > > > On Tue, Jan 10, 2012 at 10:12:48AM -0700, Stephen Warren wrote: > > > > This will allow callers to rebuild .dtb files when any of the /include/d > > > > .dtsi files are modifi

Re: [PATCH v2 REPOST] dtc: Add support for named integer constants

2012-01-11 Thread Jon Loeliger
> On Tue, Jan 10, 2012 at 01:54:30PM -0800, Stephen Warren wrote: > > John, David, > > > > What can we do to reach consensus on expanding dtc to handle named > > constants, or in general any future direction to extend the syntax with > > expressions etc.? > > Hrm, so, I'm not at all keen to add a

Re: [PATCH V2] dtc: Implement -d option to write out a dependency file

2012-01-11 Thread Jon Loeliger
> On Tue, Jan 10, 2012 at 10:12:48AM -0700, Stephen Warren wrote: > > This will allow callers to rebuild .dtb files when any of the /include/d > > .dtsi files are modified, not just the top-level .dts file. > > > > Signed-off-by: Stephen Warren > > Nice. > > Acked-by: David Gibson > > Jon, pl

Re: libfdt: Activate testcase for appending properties

2012-01-11 Thread Jon Loeliger
> Commit a31e3ef83bfce62d07695355e5f06cd4d0e44b86 introduced new libfdt > functions to append to existing properties. It also included a test case > for this, but neglected to update the Makefile and run_tests.sh script > to actually build and execute this testcase. > > This patch corrects the ov

Re: [PATCH 1/2] dtc: Implement -d option to write out a dependency file

2012-01-09 Thread Jon Loeliger
> This will allow callers to rebuild .dtb files when any of the /include/d > .dtsi files are modified, not just the top-level .dts file. > > Signed-off-by: Stephen Warren > --- > This patch is against the Linux kernel's copy of dtc, but it applies to > upstream dtc with a couple of trivial confli

Re: RFC: option to toggle dtc checks on and off

2012-01-09 Thread Jon Loeliger
> Jon, I was hoping I'd get some comment on this patch eventually. Sorry/ . > On Fri, Oct 28, 2011 at 04:15:25PM +1100, David Gibson wrote: > > Here is a draft patch which adds a -C option to dtc, allowing > > individual semantic checks to be turned on and off. It also allows > > indivudual chec

Re: [PATCH v5 4/5] Add fdtget utility to read property values from a device tree

2011-12-22 Thread Jon Loeliger
> Hi Jon, > > >> Has this been applied? I cannot see it in the repo. > > Please can you let me know about the status of this patch? > > Regards, > Simon Simon, Sorry. Except for a minor "we should test this" comment from David, I thought my devtree patch queue was empty. If you (or anyone els

Re: libfdt: Add support for appending the values to a existing property

2011-12-05 Thread Jon Loeliger
> From: Minghuan Lian > > Some properties may contain multiple values, these values may need > to be added to the property respectively. this patch provides this > functionality. The main purpose of fdt_append_prop() is to append > the values to a existing property, or create a new property if it

Re: [PATCH] fdtdump: rename from ftdump

2011-10-26 Thread Jon Loeliger
> The freetype package already installs a binary named "ftdump", so the dtc > package conflicts with that. So rename the newer dtc tool to "fdtdump". > This even makes a bit more sense: > ftdump: [F]lat device [T]ree [dump] > fdtdump: [F]lat [D]evice [T]ree [dump] > > Signed-off-by: M

Re: [PATCH v4 0/3] Variable sized array element support

2011-10-11 Thread Jon Loeliger
> This patch set adds, tests, and documents support for variable sized elements > in > arrays (known as cell lists when they could only support 32-bit entries). The > new syntax is: > > property = /bits/ [8|16|32|64] <0x00 0x12>; > > So arrays of 8, 16, 32, or 64-bit elements can now b

Re: [PATCH v4 3/3] dtc: Add support for variable sized elements

2011-10-11 Thread Jon Loeliger
> >> > >> Signed-off-by: Anton Staaf > > > > What the hell, I think I've convinced myself that /bits/ is good > > enough. > > Thanks David, I haven't thought of anything more appropriate either. > I'm looking forward to getting this landed. :) To facilitate that, could you post current patch se

Re: [PATCH v5 3/5] ftdump: use utilfdt to read blob

2011-09-22 Thread Jon Loeliger
> Now that we have utilfdt_read(), ftdump should use it too. > > Signed-off-by: Simon Glass > Acked-by: David Gibson Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/device

Re: [PATCH v5 2/5] Make testutils use utilfdt

2011-09-22 Thread Jon Loeliger
> The load_blob() and save_blob() functions are very similar to the utilfdt > versions. This removes the duplicated code. > > Signed-off-by: Simon Glass > Acked-by: David Gibson Applied. Thanks, jdl ___ devicetree-discuss mailing list devicetree-disc

  1   2   >