RE: [PATCH v3 5/5] ARM: Samsung: Remove the MIPI PHY setup code

2013-06-27 Thread Kukjin Kim
- > -- > 5 files changed, 75 deletions(-) > delete mode 100644 arch/arm/plat-samsung/setup-mipiphy.c > Looks good, please feel free to add my ack on this, Acked-by: Kukjin Kim Thanks, - Kukjin ___ devicetree-discuss mailing li

RE: [PATCH V10 1/4] pci: Add PCIe driver for Samsung Exynos

2013-06-24 Thread Kukjin Kim
Bjorn Helgaas wrote: > > On Fri, Jun 21, 2013 at 04:24:54PM +0900, Jingoo Han wrote: > > Exynos5440 has a PCIe controller which can be used as Root Complex. > > This driver supports a PCIe controller as Root Complex mode. > > > > Signed-off-by: Surendranath Gurivireddy Balla > > Signed-off-by: Si

Re: [PATCH 0/5] clk/exynos5420: add clocks for hdmi subsystem

2013-06-24 Thread Kukjin Kim
On 06/24/13 13:28, Rahul Sharma wrote: [...] I never got these patches. I'm not subscribed to devicetree-devel or linux-samsung so I only got two replies to patch #0, but none of the code. Can you or Rajul resend? Sure mike. Acked-by: Mike Turquette Applied with Mike's ack. Thanks, - K

Re: [PATCH 0/5] clk/exynos5420: add clocks for hdmi subsystem

2013-06-19 Thread Kukjin Kim
On 06/19/13 13:04, Rahul Sharma wrote: + mike Mike, I'm waiting for your reply on this. If you're OK, let me take this series on top of exynos5420 stuff in samsung tree. Of course, if any concerns, please let me know. Thanks, - Kukjin On Tue, Jun 18, 2013 at 8:03 PM, Rahul Sharma wrote:

Re: [PATCH v3 3/3] ARM/dts: change compatible strings for hdmi subsystem

2013-06-19 Thread Kukjin Kim
On 06/19/13 22:50, Kukjin Kim wrote: On 06/19/13 21:51, Rahul Sharma wrote: This patch renames the combatible strings for hdmi, mixer, ddc and hdmiphy. It follows the convention of using compatible string which represent the SoC in which the IP was added for the first time. Signed-off-by

Re: [PATCH v3 3/3] ARM/dts: change compatible strings for hdmi subsystem

2013-06-19 Thread Kukjin Kim
On 06/19/13 21:51, Rahul Sharma wrote: This patch renames the combatible strings for hdmi, mixer, ddc and hdmiphy. It follows the convention of using compatible string which represent the SoC in which the IP was added for the first time. Signed-off-by: Rahul Sharma Acked-by: Kukjin Kim

Re: [PATCH v2 0/4] ARM: dts: Add LCD and PWM support for exynos4210-origen

2013-06-18 Thread Kukjin Kim
On 06/11/13 15:29, Sachin Kamat wrote: This series is based on for-next branch of Kukjin's tree. Tested on Origen board. Changes since v1: * Split LCD patch into LCD and PWM as suggested by Tomasz Figa. * Added all PWM output nodes to pinctrl dtsi file. Sachin Kamat (3): ARM: dts: exynos4210

Re: [PATCH 0/5] clk/exynos5250: add clocks for hdmi subsystem

2013-06-18 Thread Kukjin Kim
On 06/18/13 14:09, Rahul Sharma wrote: Hi Mr. Kukjin, Kindly consider the following patches for review and integration. (+ Mike) Rahul, basically, looks good to me but I'm waiting for Mike's ack on this series... regards, Rahul Sharma. On Fri, Jun 14, 2013 at 3:39 PM, Arun Kumar K wrote

Re: [PATCH V2] Documentation: Add examples to samsung-pinctrl device tree bindings documentation

2013-06-17 Thread Kukjin Kim
On 06/18/13 01:21, Linus Walleij wrote: On Mon, Jun 17, 2013 at 2:57 PM, Leela Krishna Amudala wrote: This patch adds examples to samsung-pinctrl.txt documentaion file on how to make gpio binding and gpio request Signed-off-by: Leela Krishna Amudala Reviewed-by: Doug Anderson Looks like ge

RE: [PATCH RESEND V2] ARM: dts: Correct the base address of pinctrl_3 on Exynos5250

2013-06-17 Thread Kukjin Kim
3.10. Just note, the wrong address added during v3.10 merge window. If you want, Acked-by: Kukjin Kim If any problems, please kindly let me know. Thanks, - Kukjin > --- > Changes since V1: > - Added platform name in the subject line. > > arch/arm/boot/dts/exynos5250-pinc

RE: [PATCH] Documentation: Add examples to samsung-pinctrl device tree bindings documentation

2013-06-17 Thread Kukjin Kim
Kukjin Kim wrote: > > Leela Krishna Amudala wrote: > > > > This patch adds examples to samsung-pinctrl.txt documentaion file > > on how to make gpio binding and gpio request > > > > Signed-off-by: Leela Krishna Amudala > > Reviewed-by: Doug Anderson

RE: [PATCH] Documentation: Add examples to samsung-pinctrl device tree bindings documentation

2013-06-17 Thread Kukjin Kim
Leela Krishna Amudala wrote: > > This patch adds examples to samsung-pinctrl.txt documentaion file > on how to make gpio binding and gpio request > > Signed-off-by: Leela Krishna Amudala > Reviewed-by: Doug Anderson > --- > .../bindings/pinctrl/samsung-pinctrl.txt | 48 > ++

RE: [PATCH RESEND V2] ARM: dts: wm8994: Add wm8994 regulator support on smdk5250.

2013-06-17 Thread Kukjin Kim
Padmavathi Venna wrote: > > This patch adds the required regulator supplies and properties > for wm8994 codec on smdk5250 board. > > Signed-off-by: Padmavathi Venna > --- > > Changes since V1: > - Clubbed the same supply regulators as suggested by Mark. > Applied, thanks. - Kukjin

RE: [PATCH V6 6/6] clk: exynos5250: Add enum entries for divider clock of i2s1 and i2s2

2013-06-17 Thread Kukjin Kim
Padma Venkat wrote: > > Hi Mike, > > On Thu, Jun 13, 2013 at 8:32 AM, Padma Venkat wrote: > > Hi Mike, > > > > On Wed, Jun 12, 2013 at 10:15 PM, Mike Turquette > wrote: > >> Quoting Padmavathi Venna (2013-06-12 01:07:43) > >>> This patch adds enum entries for div_i2s1 and div_i2s2 which are > >

Re: [RFC PATCH 5/5] ARM: Samsung: Remove MIPI PHY setup code

2013-06-16 Thread Kukjin Kim
On 06/15/13 02:45, Sylwester Nawrocki wrote: Generic PHY drivers are used to handle the MIPI CSIS and MIPI DSIM DPHYs so we can remove now unused code at arch/arm/plat-samsung. If so, sounds good :) In case there is any board file for S5PV210 platforms using MIPI CSIS/DSIM (not any upstream c

RE: [PATCH RESEND V2] ARM: dts: Correct the base address of pinctrl_3 on Exynos5250

2013-06-13 Thread Kukjin Kim
Padmavathi Venna wrote: > > This patch corrects the base address of pinctrl_3 on Exynos5250 > platform. > > Signed-off-by: Padmavathi Venna > --- > Changes since V1: > - Added platform name in the subject line. > > arch/arm/boot/dts/exynos5250-pinctrl.dtsi |2 +- > arch/arm/boot/dts/

RE: [PATCH 1/1] ARM: dts: Remove combiner IRQ node from exynos4x12.dtsi

2013-06-05 Thread Kukjin Kim
Sachin Kamat wrote: > > These nodes have separately been added to 4212 and 4412 dtsi > files by commit 30269ddff1 ("ARM: exynos: add missing properties > for combiner IRQs"). The existing node also contained a few > incorrect entries. > > Signed-off-by: Sachin Kamat > --- > Patch based on linux-

RE: [PATCH 1/3] ARM: dts: Add DT node for DP controller for Arndale Board

2013-06-05 Thread Kukjin Kim
Kukjin Kim wrote: > > Jingoo Han wrote: > > > > On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote: > > > > > > Add DT node for DP controller to exynos5250 based Arndale Board > > > > > > Signed-off-by: Vikas Sajjan > > > &g

RE: [PATCH 1/3] ARM: dts: Add DT node for DP controller for Arndale Board

2013-06-05 Thread Kukjin Kim
Jingoo Han wrote: > > On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote: > > > > Add DT node for DP controller to exynos5250 based Arndale Board > > > > Signed-off-by: Vikas Sajjan > > Hi Vikas Sajjan, > > Reviewed-by: Jingoo Han > Applied, thanks. - Kukjin > Best regards, > Jingoo Han

RE: [PATCH 2/3] ARM: dts: Add clock provider information for DP controller in Exynos5250 SoC

2013-06-05 Thread Kukjin Kim
Jingoo Han wrote: > > On Wednesday, May 08, 2013 3:02 PM, Vikas Sajjan wrote: > > > > Adds clock provider information for DP controller required by CCF. > > > > Signed-off-by: Vikas Sajjan > > Signed-off-by: Arun Kumar K > > Hi Vikas Sajjan, > > Acked-by: Jingoo Han > Applied, thanks. - Kuk

RE: [PATCH v2 0/3] Add DP related DT and Display-timing Node to exynos5250 based Arndale Board

2013-05-30 Thread Kukjin Kim
Vikas Sajjan wrote: > > This patch series adds support for DP on Exynos5250 based Arndale Board > > changes since v1: > - moved display-timimg node inside fimd DT node as suggested by > Steffen Trumtrar s.trumt...@pengutronix.de > > Is based on branch "for-next" > http://git.kernel.o

Re: [PATCH v3 00/13] ARM: EXYNOS: Fix Universal C210 support

2013-04-27 Thread Kukjin Kim
could pick up this series in the late/* branch with my ack: Acked-by: Kukjin Kim Thanks. - Kukjin ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v3 00/13] ARM: EXYNOS: Fix Universal C210 support

2013-04-25 Thread Kukjin Kim
On 04/25/13 23:46, Arnd Bergmann wrote: On Universal C210 board, both with and without DT: Tested-by: Tomasz Figa Reviewed-by: Arnd Bergmann Olof, Kgene, I think we should have this one in 3.10 since it fixes a regression. It looks bigger than it really is because I asked Tomasz to do small

Re: [PATCH v2 2/3] ARM: EXYNOS: Fix support of Exynos4210 rev0 SoC

2013-04-23 Thread Kukjin Kim
On 04/23/13 23:26, Tomasz Figa wrote: Hi Kukjin, [...] Acked-by: Arnd Bergmann Note that it would be helpful to mention here that this is required for the calling samsung_timer_init from the exynos4-dt.c file. I did 'amend' as per your suggestion and added your ack on this series. Thanks.

Re: [PATCH v5 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

2013-04-23 Thread Kukjin Kim
On 04/23/13 23:44, Tomasz Figa wrote: Tomasz, can you address comments? Please discard this series for now. OK. I've decided to post it for 3.11, including a driver for Common Clock Framework and several cleanup patches, which I have ready and waiting. Sounds good. Thanks. - Kukjin ___

Re: [PATCH v5 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

2013-04-23 Thread Kukjin Kim
On 04/18/13 02:46, Rob Herring wrote: + vic0: interrupt-controller@7120 { These nodes should be off a "simple-bus" node. Hmm, is there any reason behind it? I thought simple bus was just a convenient helper to represent hierarchical bus structures if one has a need to do so. No. The

Re: [PATCH v2 2/3] ARM: EXYNOS: Fix support of Exynos4210 rev0 SoC

2013-04-23 Thread Kukjin Kim
On 04/23/13 06:10, Arnd Bergmann wrote: On Monday 15 April 2013, Tomasz Figa wrote: This patch extends exynos_init_time() function to handle Exynos4210 rev0 SoC, which differs in availability of system timers and needs different clocksource initialization. This makes it possible to use exynos_i

Re: [PATCH v2 0/3] ARM: EXYNOS: DT-enabled support for Universal C210

2013-04-22 Thread Kukjin Kim
On 04/15/13 23:41, Tomasz Figa wrote: This series intends to add support for Universal C210 board using Device Tree. Main difference from other boards based on Exynos 4210 is that hardware revision of the SoC used on Universal C210 does not support MCT timers and legacy PWM timers must be used in

Re: [PATCH v5 00/14] ARM: samsung-time: Prepare for multiplatform support

2013-04-22 Thread Kukjin Kim
On 04/13/13 05:51, Arnd Bergmann wrote: On Friday 12 April 2013, Tomasz Figa wrote: This series is an attempt to make the samsung-time clocksource driver ready for multiplatform kernels. It moves the driver to drivers/clocksource, cleans it up from uses of static platform-specific definitions, s

Re: [PATCH 1/4] ARM: dts: Add TMU clock entries to exynos4210.dtsi

2013-04-22 Thread Kukjin Kim
On 04/22/13 13:32, Sachin Kamat wrote: Adds TMU clock entries to exynos4210.dtsi file. Signed-off-by: Sachin Kamat --- arch/arm/boot/dts/exynos4210.dtsi |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi index 50ab9

Re: [PATCH 0/6] thermal:exynos4: Thermal Measurement Unit fixes for Samsung SoCs

2013-04-22 Thread Kukjin Kim
On 04/20/13 01:38, Lukasz Majewski wrote: This patch series provide various fixes for TMU block. Namely, support for common clock framework and proper regulator VDD_TS has been added. Moreover device tree definitions and documentation entry are now in place. Lukasz Majewski (6): clk:exynos4:T

Re: [PATCH 0/2] ARM: Exynos: Add DT based I/O mapping for Chip-ID controller

2013-04-22 Thread Kukjin Kim
On 04/22/13 20:20, Thomas Abraham wrote: On 4 April 2013 12:27, Kukjin Kim wrote: Thomas Abraham wrote: This patch series allows device tree enabled platforms to setup a runtime I/O mapping for the chip-id controller. This helps to remove statically defined I/O mapping for the Chip-ID

Re: [PATCH v2 0/2] ARM: Exynos: Add DT based I/O mapping for Chip-ID controller

2013-04-22 Thread Kukjin Kim
On 04/22/13 20:35, Thomas Abraham wrote: Changes since v1: - Rebased to v3.9-rc8 This patch series allows device tree enabled platforms to setup a runtime I/O mapping for the chip-id controller. This helps to remove statically defined I/O mapping for the Chip-ID controller. This series is based

RE: [PATCH v5 0/3] ARM: Exynos5250: Enabling dwc3-exynos driver

2013-04-10 Thread Kukjin Kim
Vivek Gautam wrote: > > This patch-set is in continuation with patch-series: > [PATCH v4 0/4] Enable ehci, ohci and dwc3 devices on exynos5250 > out of which follwowing patches have been picked up: > ARM: Exynos5250: Enabling ehci-s5p driver > ARM: Exynos5250: Enabling ohci-exynos driver > > Base

RE: [PATCH v4 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-04-10 Thread Kukjin Kim
Vivek Gautam wrote: > > Based on 'for-next' of linux-samsung tree with following patches > from Doug on top: > usb: Document clocks in samsung, exynos4210-ehci/ohci bindings > ARM: dts: add usb 2.0 clock references to exynos5250 device tree > > Also depending upon following patch-series for Samsu

RE: [PATCH v2 0/3] ARM: S3C24XX: Add devicetree support for s3c2416

2013-04-10 Thread Kukjin Kim
Heiko Stübner wrote: > > This is the second installment of beginning devicetree support the > Samsung S3C24xx architectures and focuses on the s3c2416 for now. > > Included is the devicetree support for the s3c24xx irq controller and > basic support for smdk2416 boards, which can sucessfully boot

RE: [PATCH v2 1/2] ARM: dts: Add MFC clock entries for exynos4

2013-04-10 Thread Kukjin Kim
Sachin Kamat wrote: > > Added MFC related clock entries in exynos4.dtsi file. > > Signed-off-by: Sachin Kamat > Reviewed-by: Sylwester Nawrocki Applied this series. Thanks. - Kukjin ___ devicetree-discuss mailing list devicetree-discuss@lists.ozla

RE: [PATCH v11 0/3] Add DRM FIMD DT support for Exynos4 DT Machines

2013-04-08 Thread Kukjin Kim
Vikas Sajjan wrote: > > This patch series adds support for DRM FIMD DT for Exynos4 DT Machines, > specifically for Exynos4412 SoC. > > changes since v10: > - addressed comments from Sylwester Nawrocki > > > changes since v9: > - dropped the patch "ARM: dts: Add lcd pinctrl node entr

RE: [PATCH v2 0/7] Add G2D nodes to Exynos4 machines

2013-04-08 Thread Kukjin Kim
Sachin Kamat wrote: > > On 11 March 2013 12:24, Kukjin Kim wrote: > > Sachin Kamat wrote: > >> > >> Hi Kukjin, > >> > >> Can you please look into this series as it is pending since quite some > time. > >> > > Applied, I have a

[PATCH 4/4] ARM: dts: update bootargs to boot from sda2 for exynos5440-ssdk5440

2013-04-04 Thread Kukjin Kim
From: Subash Patel Updated the bootargs to boot the system with rootfs in hard-disk instead of ramdisk. Signed-off-by: Subash Patel Signed-off-by: Kukjin Kim --- arch/arm/boot/dts/exynos5440-ssdk5440.dts |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/arch/arm

[PATCH 3/4] ARM: dts: add PMU support in exynos5440

2013-04-04 Thread Kukjin Kim
From: Subash Patel PMU in exynos5440 generates one interrupt per core and needs to be passed from DT to GIC to register it. Signed-off-by: Subash Patel Signed-off-by: Kukjin Kim --- arch/arm/boot/dts/exynos5440.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff

[PATCH 1/4] ARM: dts: Add node for GMAC for exynos5440

2013-04-04 Thread Kukjin Kim
From: Byungho An This patch adds node for GMAC for exynos5440 EXYNOS5440 SoC supported by GMAC driver. Signed-off-by: Byungho An Signed-off-by: Kukjin Kim --- arch/arm/boot/dts/exynos5440.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot

[PATCH 2/4] ARM: dts: add PDMA0 changes for exynos5440

2013-04-04 Thread Kukjin Kim
From: Subash Patel PDMA0@0x121000 changes are added into the architecture DTS file. Signed-off-by: Subash Patel Signed-off-by: Kukjin Kim --- arch/arm/boot/dts/exynos5440.dtsi | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/exynos5440

[PATCH 0/4] ARM: dts: update device tree for exynos5440

2013-04-04 Thread Kukjin Kim
This patch updates device tree for exynos5440 including for PMU, PDMA0 and GMAC. arch/arm/boot/dts/exynos5440-ssdk5440.dts |6 + arch/arm/boot/dts/exynos5440.dtsi | 35 ++-- 2 files changed, 28 insertions(+), 13 deletions(-) [PATCH 1/4] ARM: dts: Add nod

RE: [PATCH 0/2] ARM: Exynos: Add DT based I/O mapping for Chip-ID controller

2013-04-03 Thread Kukjin Kim
Thomas Abraham wrote: > > This patch series allows device tree enabled platforms to setup a runtime > I/O mapping for the chip-id controller. This helps to remove statically > defined I/O mapping for the Chip-ID controller. > > Thomas Abraham (2): > ARM: Exynos: Create virtual I/O mapping for C

RE: [PATCH v2] usb: Document clocks in samsung,exynos4210-ehci/ohci bindings

2013-04-03 Thread Kukjin Kim
Jingoo Han wrote: > > On Friday, March 15, 2013 8:01 AM, Doug Anderson wrote: > > > > The exynox4210-ehci and exynos4210-ohci nodes need a clock specified > > using the common clock framework. Document it. > > > > Signed-off-by: Doug Anderson > > It looks good. > Acked-by: Jingoo Han > > App

RE: [PATCH V3 0/7] Update Arndale board support

2013-04-03 Thread Kukjin Kim
Tushar Behera wrote: > > Arndale board support has been updated using pin-control and > common clock framework. > > The patchset is based on Kukjin's for-next. > commit d58f6a153f40 ("Merge branch 'next/clk-exynos-2' into for-next") > > It depends on following patchset. > > [PATCH 0/2] ARM: dts

RE: [PATCH v2] ARM: dts: Add SYSREG block node for S5P/Exynos4 SoC series

2013-04-02 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > This patch adds device tree node for the SYSREG registers block > found in Samsung S5P/Exynos SoC series. The SYSREG module > generates control signals for the ARM CPU and various IP blocks > and buses. SYSREG block registers are exposed through APB bus > interface. A

RE: [PATCH v6 7/7] irqchip: s3c24xx: add devicetree support

2013-04-02 Thread Kukjin Kim
Rob Herring wrote: > > On 03/26/2013 05:10 PM, Heiko Stübner wrote: > > Add the necessary code to initialize the interrupt controller > > thru devicetree data using the irqchip infrastructure. > > > > Signed-off-by: Heiko Stuebner > > Acked-by: Rob Herring > Rob, thanks for your ack. Applied

RE: [PATCH v6 0/7] move s3c24xx-irq to drivers/irqchip and add dt support

2013-04-02 Thread Kukjin Kim
Arnd Bergmann wrote: > > On Tuesday 26 March 2013, Heiko Stübner wrote: > > This v6 addresses more comments from Arnd Bergmann, setting the > compatible > > property to the first supported SoC (s3c2410) instead of using the > s3c24xx > > wildcard. It also switches the parent-irq and controller irq

RE: [PATCH v9 0/4] Add DRM FIMD DT support for Exynos4 DT Machines

2013-03-25 Thread Kukjin Kim
Vikas Sajjan wrote: > > Hi Kukjin Kim, > > Can you please apply these patches? > Please address comments from Thomas about board-specific feature. Thanks. - Kukjin ___ devicetree-discuss mailing list devicetree-discuss@lists.o

RE: [PATCH 0/2] ARM: dts: Add default pin states for client nodes on Exynos4/5 platforms

2013-03-25 Thread Kukjin Kim
Tushar Behera wrote: > > On 03/07/2013 01:45 PM, Linus Walleij wrote: > > On Wed, Mar 6, 2013 at 1:36 PM, Thomas Abraham > > wrote: > > > >> This patch series populates the default pin states in client nodes > >> of Exynos4 and Exynos5 platforms. Exynos4/5 platforms are migrating > >> to use pinc

RE: [PATCH 0/2] ARM: dts: Add default pin states for client nodes on Exynos4/5 platforms

2013-03-25 Thread Kukjin Kim
Linus Walleij wrote: > > On Wed, Mar 6, 2013 at 1:36 PM, Thomas Abraham > wrote: > > > This patch series populates the default pin states in client nodes > > of Exynos4 and Exynos5 platforms. Exynos4/5 platforms are migrating > > to use pinctrl framework and having the default pin states listed

RE: [PATCH v4 0/4] Initial Device Tree support for S3C64xx

2013-03-24 Thread Kukjin Kim
Tomasz Figa wrote: > > Hi, > > On Saturday 09 of March 2013 21:29:31 Tomasz Figa wrote: > > This series adds Device Tree support for Samsung S3C64xx SoC series. > > > > It fixes several problems preventing from booting an S3C64xx-based > > system using Device Tree, adds all the infrastructure for

RE: RE: RE: RE: [PATCH v6 00/16] clk: exynos4/5: migrate to common clock framework

2013-03-24 Thread Kukjin Kim
Mike Turquette wrote: [...] > > Yeah, I know. So if you want to add your ack on drivers/clk stuff for > this series in samsung tree, please let me know. > > > > The patches are in pretty good shape. Please add my ack if you are able OK, I will. > to rebase comfortably. But if rebasing causes

RE: RE: RE: [PATCH v6 00/16] clk: exynos4/5: migrate to common clock framework

2013-03-21 Thread Kukjin Kim
Mike Turquette wrote: [...] > > > > > Furthermore if I *had* agreed on the previous version it would still > > > have been appropriate to put my Acked-by on those patches, which is > > > clearly missing today. > > > > > BTW, how about following? > > > > http://www.spinics.net/lists/arm-kernel/msg2

RE: RE: [PATCH v6 00/16] clk: exynos4/5: migrate to common clock framework

2013-03-19 Thread Kukjin Kim
Mike Turquette wrote: > > Quoting Kukjin Kim (2013-03-19 17:00:09) > > Mike Turquette wrote: > > > > > > > [...] > > > > > > > Thomas, > > > > > > > > > > Are you planning a V7 series which includes the clock

RE: [PATCH v6 00/16] clk: exynos4/5: migrate to common clock framework

2013-03-19 Thread Kukjin Kim
Mike Turquette wrote: > [...] > > > Thomas, > > > > > > Are you planning a V7 series which includes the clock alias bits from > > > patch #1? > > > > Kukjin has already applied this series into the linux-samsung tree [0]. > > Thanks, Heiko. Mike, yes I did, as we discussed before. Since I misse

RE: [PATCH v2 0/7] Add G2D nodes to Exynos4 machines

2013-03-10 Thread Kukjin Kim
Sachin Kamat wrote: > > Hi Kukjin, > > Can you please look into this series as it is pending since quite some time. > Applied, I have another opinion about the compatible string though... I think, it can be sorted out next time :-) Thanks. - Kukjin > On 18 February 2013 10:32, Sachin Kamat

RE: [PATCH 2/5] ARM: dts: exynos5250-arndale: Add PMIC node entry

2013-03-10 Thread Kukjin Kim
amit daniel kachhap wrote: > > The V2 of this patch is posted with comments suggested by Anil and > some missing LDO's. > OK, I see. - Kukjin ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/dev

RE: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons

2013-03-10 Thread Kukjin Kim
Tomasz Figa wrote: > > Hi, > > I'm wondering why Exynos5250 has not been migrated to use pinctrl yet. > > Support for it in pinctrl-samsung driver has been already merged, but I > don't see any pinctrl nodes in exynos5250.dtsi. > > This is important because the legacy gpio-samsung support is go

RE: [PATCH v3 0/4] Initial Device Tree support for S3C64xx

2013-03-09 Thread Kukjin Kim
Tomasz Figa wrote: > > This series adds Device Tree support for Samsung S3C64xx SoC series. > > It fixes several problems preventing from booting an S3C64xx-based system > using Device Tree, adds all the infrastructure for Device Tree-based board > support, including mach-s3c64xx-dt and dts inclu

RE: [PATCH v6 01/16] clk: samsung: add common clock framework helper functions for Samsung platforms

2013-03-09 Thread Kukjin Kim
Kukjin Kim wrote: [...] Thomas, As I said, I applied this whole series into Samsung tree, following error happens with exynos4_defconfig(non-DT) though. drivers/clk/samsung/clk.c: In function 'samsung_clk_of_register_fixed_ext': drivers/clk/samsung/clk.c:251:2: error: implicit decl

RE: [PATCH v6 01/16] clk: samsung: add common clock framework helper functions for Samsung platforms

2013-03-06 Thread Kukjin Kim
Tomasz Figa wrote: > > Hi, > > On Sunday 03 of March 2013 12:17:29 Sylwester Nawrocki wrote: > > Hi, > > > > On 03/03/2013 02:08 AM, Heiko Stübner wrote: > > > But is there an easy way to define more than one alias? On the s3c2416 > > > for example the hsmmc hclk is the "hsmmc" io-clock, as well

RE: [PATCH 1/2] ARM: EXYNOS: Add PCIe driver support

2013-03-06 Thread Kukjin Kim
Thomas Petazzoni wrote: > > Dear Thomas Abraham, > > On Mon, 4 Mar 2013 16:01:59 +0530, Thomas Abraham wrote: > > On 4 March 2013 15:52, Jingoo Han wrote: > > > Exynos5440 has two PCIe controllers which can be used as Root Complex. > > > This driver supports the PCIe controllers as Root Complex

RE: [PATCH v6 5/5] ARM: dts: Add FIMD DT binding Documentation

2013-03-06 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > On 03/06/2013 10:13 PM, Sylwester Nawrocki wrote: > > @@ -305,9 +305,9 @@ struct platform_device s5p_device_jpeg = { > > #ifdef CONFIG_S5P_DEV_FIMD0 > > static struct resource s5p_fimd0_resource[] = { > > [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K), > > -

RE: [PATCH v6 05/12] iommu/exynos: support for device tree

2013-02-12 Thread Kukjin Kim
KyongHo Cho wrote: > > On Fri, Feb 1, 2013 at 10:51 PM, Joerg Roedel wrote: > > Cho, > > > > On Wed, Jan 02, 2013 at 02:53:49PM +0900, KyongHo Cho wrote: > >> On Tuesday, January 1, 2013, Sylwester Nawrocki > > > > >> > Cc: devicetree-discuss@lists.ozlabs.org > > > > Since patch 7 of this set is

RE: [PATCH v5 1/4] ARM: Exynos5250: Enabling ehci-s5p driver

2013-02-08 Thread Kukjin Kim
Vivek Gautam wrote: > > Adding EHCI device tree node for Exynos5250 along with > the device base adress and gpio line for vbus. > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han > Acked-by: Grant Likely > --- > > Changes from v4: > - Added gpio line for VBUS of USB2.0 on snow board. >

RE: [PATCH v2 0/6] ARM: dts: Add MFC support for Exynos4

2013-02-04 Thread Kukjin Kim
Sachin Kamat wrote: > > Hi Kukjin, > > On 30 January 2013 14:30, Sylwester Nawrocki > wrote: > > On 01/30/2013 08:11 AM, Sachin Kamat wrote: > >> Changes since v1: > >> Addressed comments from Sylwester > >> - Updated documentation > >> - Added 'status' to the nodes > >> - Updated Kconfig

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Kukjin Kim
Kukjin Kim wrote: > Oops, I'm re-sending due to my e-mail client problem :-( > Sylwester Nawrocki wrote: > > > > On 02/01/2013 09:33 AM, Sachin Kamat wrote: > > > On 1 February 2013 06:57, Inki Dae wrote: > > >> > > >> For example, > &g

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-02-01 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > On 02/01/2013 09:33 AM, Sachin Kamat wrote: > > On 1 February 2013 06:57, Inki Dae wrote: > >> > >> For example, > >> If compatible = "samsung,g2d-3.0" is added to exynos4210.dtsi, it'd be > >> reasonable. But what if that compatible string is added to exynos4.dtsi?.

RE: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

2013-01-31 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > Hi Inki, > Hi Sylwester and Inki, > On 01/31/2013 02:30 AM, Inki Dae wrote: > >> -Original Message- > >> From: Sylwester Nawrocki [mailto:sylvester.nawro...@gmail.com] > >> Sent: Thursday, January 31, 2013 5:51 AM > >> To: Inki Dae > >> Cc: Sachin Kamat; lin

RE: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

2013-01-31 Thread Kukjin Kim
Tomasz Figa wrote: > > Hi Vivek, [...] > > + usb@1212 { > > + compatible = "samsung,exynos4210-ohci"; > > + reg = <0x1212 0x100>; > > + interrupts = <0 71 0>; > > For Samsung platforms we decided per board enabling of nodes and so this > node should also

RE: [PATCH 1/4] ARM: dts: add support for hdmi to exynos4

2013-01-31 Thread Kukjin Kim
Rahul Sharma wrote: [...] > + hdmi { > + compatible = "samsung,exynos4-hdmi14"; > >>> > >>> > >>> > >>> What "-hdmi14" signifies here ? And to which Exynos4 SoC revisions this > >>> compatible property is supposed to apply ? > >>> > >> > >> -hdmi14 signifies 1.4 comp

RE: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: > > Hi Tomasz, > > > On Wed, Jan 16, 2013 at 8:35 PM, Vivek Gautam > wrote: > > Hi Tomasz, > > > > > > On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa > wrote: > >> Hi Vivek, > >> > >> Don't you need also some clkdev lookup entry to make the clock available > >> in the driver?

RE: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: > > Adding PHY driver support for USB 3.0 controller for Samsung's > SoCs. > > Signed-off-by: Vivek Gautam > --- > > Changes from v3: > - Making SAMSUNG_USB3PHY dependent on SAMSUNG_USBPHY. > - Adding USB_DWC3 to dependencies of SAMSUNG_USB2PHY since >dwc3 controller a

RE: [PATCH v4 1/2] usb: phy: samsung: Common out the generic stuff

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: > > Moving register and structure definitions to header file, > and keeping the generic functions to be used across > multiple PHYs in common file "samsung-usbphy.c". > Also renaming the usb 2.0 phy driver to "samsung-usb2.c" Just in my opinion, Samsung-usb2phy is more clear?.

RE: [PATCH v2 2/2] ARM: Exynos5250: Enabling samsung-usb3-phy driver

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: > > Adding usb3.0 phy node for Exynos5250 along with the > necessary device data to be parsed. > > Signed-off-by: Vivek Gautam > --- > arch/arm/boot/dts/exynos5250.dtsi | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/

RE: [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver

2013-01-29 Thread Kukjin Kim
Vivek Gautam wrote: > > Adding usbphy node for Exynos5250 along with the > necessary device data to be parsed. > > Signed-off-by: Vivek Gautam > --- > arch/arm/boot/dts/exynos5250.dtsi | 15 +++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dt

RE: [PATCH 0/6] Initial Device Tree support for S3C64xx

2013-01-25 Thread Kukjin Kim
Tomasz Figa wrote: > > On Sunday 13 of January 2013 02:10:52 Tomasz Figa wrote: > > This series is adds Device Tree support for Samsung S3C64xx SoC series. > > > > It fixes several problems preventing from booting an S3C64xx-based > > system using Device Tree, adds all the infrastructure for Devic

RE: [PATCH 5/6] ARM: dts: Add basic dts include files for Samsung S3C64xx SoCs

2013-01-25 Thread Kukjin Kim
Tomasz Figa wrote: [...] > > Well, the number of CPU types does not grow rapidly. It will be much > > less than one per SoC -- so keeping the list up to date shouldn't be > > that much effort. > > > > For ARM1176JZF-S, it could make sense for the comatible list to be > > > > "arm,arm1176jzf-

RE: [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device

2013-01-25 Thread Kukjin Kim
'm fine on this series, I'm still thinking we need to sort out the chip name in compatible for IP though. Felipe, please go ahead, if you want my ack, feel free to add: Acked-by: Kukjin Kim Thanks. - Kukjin ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

RE: [PATCH] ARM: dts: specify all the per-cpu interrupts of arch timer for exynos5440

2013-01-22 Thread Kukjin Kim
Mark Rutland wrote: > + devicetree-discuss, Grant Likely, Rob Herring and Tony Lindgren > On Tue, Jan 22, 2013 at 01:41:27AM +, Kukjin Kim wrote: > > From: Thomas Abraham > > > > Need to be changed requirements in the 'cpus' node for exynos5440 > >

RE: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-22 Thread Kukjin Kim
Felipe Balbi wrote: > Hi, > Hi Felipe, [...] > > Right, DWC has version number, but that being the kind of USB controller > > (USB 2.0 and USB 3.0) > > > > DWC2: USB High Speed controller (as also indicated in the patch from > > Paul: [RFC PATCH 0/6] DWC2 DesignWare HS OTG driver) > > DWC3: USB

RE: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-21 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > On 12/24/2012 09:13 AM, Vivek Gautam wrote: > These two changes look good to me. For both of them: > > Reviewed-by: Doug Anderson > >>> > >>> Well, I have another idea. Yes, I know, specific chip name should be used. > >> But > >>> you know the specifi

RE: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-21 Thread Kukjin Kim
+-- > include/linux/usb/samsung_usb_phy.h| 16 + > 6 files changed, 635 insertions(+), 73 deletions(-) > create mode 100644 include/linux/usb/samsung_usb_phy.h > > -- > 1.7.6.5 Looks good to me, Felipe and Greg, I don't know who should take this series anyway, feel free to add my ack: Acked-by: Kukjin Kim Thanks. - Kukjin ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

RE: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-21 Thread Kukjin Kim
Felipe Balbi wrote: > > On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote: > > > This patch-set enables the samsung-usbphy driver on exynos5250, > > > which enables the support for USB2 type and USB3 type phys

RE: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-17 Thread Kukjin Kim
Rob Herring wrote: [...] > > As long as we're consistently inconsistent... What about 4210 and 4x12? > Hopefully, the reason was to avoid breaking them. > > This creates horrible incompatibilities between dts and kernel versions > by changing both. Any prior kernel will not work with this dts o

RE: [PATCH v7] usb: phy: samsung: Add support to set pmu isolation

2013-01-17 Thread Kukjin Kim
Vivek Gautam wrote: > > Adding support to parse device node data in order to get > required properties to set pmu isolation for usb-phy. > > Signed-off-by: Vivek Gautam > Reviewed-by: Sylwester Nawrocki > Reviewed-by: Doug Anderson This looks good to me, Acked-by: Kukj

RE: [PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl

2013-01-09 Thread Kukjin Kim
Olof Johansson wrote: > > On Wed, Jan 2, 2013 at 4:20 PM, Kukjin Kim > wrote: > > Fix the incorrect compatible property value of pinctrl for EXYNOS4 SoCs. > > Ah, this answers my question from the previous patch. So, why do 5450 > as a separate patch? > OK, let me

RE: [RFC PATCH 5/7] ARM: s3c64xx: Add board file for boot using Device Tree

2013-01-09 Thread Kukjin Kim
Tomasz Figa wrote: > > This patch adds board file that will be used to boot S3C64xx-based boards > using Device Tree. > > Signed-off-by: Tomasz Figa > --- > arch/arm/mach-s3c64xx/Kconfig | 13 + > arch/arm/mach-s3c64xx/Makefile | 1 + > arch/arm/mach-s3c64xx/mach-s3c64xx

RE: [RFC PATCH 4/7] ARM: s3c64xx: Fix build error with CONFIG_S3C_DEV_FB disabled

2013-01-09 Thread Kukjin Kim
Tomasz Figa wrote: > > If there is no board selecting CONFIG_S3C_DEV_FB enabled, build will fail on > arch/arm/mach-s3c64xx/pm.c, where s3c_device_fb is referenced. > > This patch adds ifdef guard around the code making it compile only when > CONFIG_S3C_DEV_FB is enabled. > > Signed-off-by: Toma

[PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl

2013-01-02 Thread Kukjin Kim
Fix the incorrect compatible property value of pinctrl for EXYNOS4 SoCs. Cc: Thomas Abraham Cc: Linus Walleij Cc: Grant Likely Signed-off-by: Kukjin Kim Cc: devicetree-discuss@lists.ozlabs.org --- .../devicetree/bindings/pinctrl/samsung-pinctrl.txt| 12 ++-- arch/arm/boot

[PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440

2013-01-02 Thread Kukjin Kim
From: Thomas Abraham Fix the incorrect compatible property value of pin-controller module EXYNOS5440 SoC. Signed-off-by: Thomas Abraham Cc: Linus Walleij Cc: Grant Likely [kgene@samsung.com: fixed it in gpio together for exynos5440] Signed-off-by: Kukjin Kim Cc: devicetree-discuss

RE: [PATCH] ARM: dts: add board dts file for EXYNOS4412 based Origen board

2012-12-30 Thread Kukjin Kim
Kukjin Kim wrote: > > Thomas Abraham wrote: > > > > Add a minimal board dts file for EXYNOS4412 based Insignal Origen board. > > > > Signed-off-by: Thomas Abraham > > --- > > arch/arm/boot/dts/Makefile |1 + > >

RE: [PATCH] ARM: dts: add board dts file for EXYNOS4412 based Origen board

2012-12-30 Thread Kukjin Kim
Thomas Abraham wrote: > > Add a minimal board dts file for EXYNOS4412 based Insignal Origen board. > > Signed-off-by: Thomas Abraham > --- > arch/arm/boot/dts/Makefile |1 + > arch/arm/boot/dts/exynos4412-origen.dts | 45 > +++ > 2 files changed, 4

RE: [PATCH v5 00/12] clk: exynos4: migrate to common clock framework

2012-12-30 Thread Kukjin Kim
Olof Johansson wrote: > > On Sat, Dec 29, 2012 at 04:33:29PM -0800, Thomas Abraham wrote: > > Changes since v4: > > - Rebased to linux-3.8-rc1. > > > > Changes since v3: > > - Includes changes suggested by Tomasz Figa > > > > This patch series migrates the Samsung Exynos4 SoC clock code to adopt

RE: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-23 Thread Kukjin Kim
Kukjin Kim wrote: > Re-sending due to e-mail client problem... > Doug Anderson wrote: > > > > On Fri, Dec 21, 2012 at 12:14 AM, Vivek Gautam > > wrote: > > > On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam > > wrote: > > >> > > >&g

RE: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-12-23 Thread Kukjin Kim
Kukjin Kim wrote: > Re-sending due to e-mail client problem :( > Padma Venkat wrote: > > > > Hi, > > > > On Wed, Dec 19, 2012 at 10:39 PM, Mark Brown > > wrote: > > > On Wed, Dec 19, 2012 at 01:24:14PM +, Grant Likely wrote: > > >

RE: [PATCH v4 00/12] clk: exynos4: migrate to common clock framework

2012-11-26 Thread Kukjin Kim
f. Of course, I can create topic branch for your clk-next if you want. Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. > Thanks, > Mike > > > This patch series migrates the Samsung Exynos4 SoC clock code to

  1   2   >