Hello Mark,
On 06/21/2014 10:40 PM, Mark Brown wrote:
On Tue, Jun 17, 2014 at 06:05:29PM +0200, Javier Martinez Canillas wrote:
On 06/17/2014 04:12 PM, Mark Brown wrote:
I just looked at regulator_register() and saw that it does
rdev-dev.parent =
dev, so yes this has to be the MFD
Hello Ajay,
Not an extensive review since I'm not familiar with the graphics stack
but a few things I noticed are commented below.
On Wed, Jun 11, 2014 at 8:27 PM, Ajay Kumar ajaykumar...@samsung.com wrote:
This patch adds a simple driver to handle all the LCD and LED
powerup/down routines
Hello Ajay,
On Wed, Jun 11, 2014 at 8:27 PM, Ajay Kumar ajaykumar...@samsung.com wrote:
From: Vincent Palatin vpala...@chromium.org
This patch adds drm_bridge driver for parade DisplayPort
to LVDS bridge chip.
Signed-off-by: Vincent Palatin vpala...@chromium.org
Signed-off-by: Andrew
I get a board.
Otherwise, can anyone give me tested-by? and I'd happy to give me
reviewed-by so that I can pick this patch series up.
Thanks,
Inki Dae
I've also tested this series on an Exynos5420 Peach pit board and LVDS
display was working for me.
Tested-by: Javier Martinez Canillas
Hello Doug,
On 06/24/2014 06:05 AM, Doug Anderson wrote:
Andreas,
On Mon, Jun 23, 2014 at 3:46 PM, Andreas Färber afaer...@suse.de wrote:
Hi Doug,
Am 23.06.2014 21:47, schrieb Doug Anderson:
Thanks for posting! A first pass on this is below...
Thanks a lot for your quick review! My
-by: Doug Anderson diand...@chromium.org
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Along with the dependency patches on next-20140623, tested keyboard on
Peach-Pi board.
Tested-by: Tushar Behera tusha...@samsung.com
Some comments below.
---
Changes in v2:
- Now just
Hello Mark,
On 06/23/2014 11:47 AM, Mark Brown wrote:
On Mon, Jun 23, 2014 at 11:28:25AM +0200, Javier Martinez Canillas wrote:
On 06/21/2014 10:40 PM, Mark Brown wrote:
That's not really relevant here - I'm asking if the regulators get their
own supplies rather than if anything uses them
Hello Naveen,
On Wed, Jun 25, 2014 at 7:04 AM, Naveen Krishna Ch
naveenkrishna...@gmail.com wrote:
Doug,
On 25 June 2014 03:24, Doug Anderson diand...@chromium.org wrote:
Naveen,
On Tue, Jun 24, 2014 at 5:19 AM, Naveen Krishna Chatradhi
ch.nav...@samsung.com wrote:
Exynos5420 based Peach
Hello Krzysztof,
On 06/25/2014 12:05 PM, Krzysztof Kozlowski wrote:
On czw, 2014-06-19 at 20:20 +0200, Javier Martinez Canillas wrote:
From: Doug Anderson diand...@chromium.org
The max77686 includes an RTC that keeps power during suspend. It's
convenient to be able to use it as a wakeup
-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
index 5d49f2b..832fe8c 100644
--- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
+++ b
= adc 6;
+ };
+};
+
dp {
status = okay;
pinctrl-names = default;
--
1.7.9.5
Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
--
To unsubscribe from this list: send the line unsubscribe devicetree in
the body of a message to majord
Hello Krzysztof,
On 06/25/2014 04:19 PM, Krzysztof Kozlowski wrote:
On czw, 2014-06-19 at 20:20 +0200, Javier Martinez Canillas wrote:
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code
On 06/25/2014 07:24 PM, Doug Anderson wrote:
Hi,
On Wed, Jun 25, 2014 at 3:29 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Yes, the original Chrome OS 3.8 max77xxx also called the irq worker thread to
ack the interrupt.
So the real problem is that an interrupt
Hello Doug,
Thanks a lot for your feedback.
On 06/25/2014 08:06 PM, Doug Anderson wrote:
Javier,
On Thu, Jun 19, 2014 at 11:20 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
@@ -33,6 +38,6 @@ Example: Clock consumer node
foo@0 {
compatible
):
mfd: max77686: Allow the max77686 rtc to wakeup the system
Javier Martinez Canillas (13):
mfd: max77686: Convert to use regmap_irq
clk: max77686: Add DT include for MAX77686 PMIC clock
clk: max77686: Improve Maxim 77686 PMIC clocks binding
clk: Add generic driver for Maxim PMIC clocks
.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3:
- Add support for Exynos5800 based Peach pi board. Suggested by Doug Anderson.
- Model the actual regulators relationship instead of a simplistic model.
Suggested by Mark Brown.
Changes since v2: None
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3:
- Don't use the same clock driver name in clock-names since it's a consumer
concept and most
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3: None
drivers/rtc
the i2c
bus up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3:
- Keep the note that this patch needs another change due wakeup
ordering problems.
drivers/rtc/rtc
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
the regmap lock.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3: None
drivers/base/regmap/regmap.c | 34 ++
include/linux/regmap.h | 9 +
2 files changed, 43 insertions(+)
diff --git a/drivers/base
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be to be shared between the
clk-max77686 clock driver and DeviceTree source files.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
By using the generic IRQ support in the Register map API, it
is possible to get rid max77686-irq.c and simplify the code.
Suggested-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Lee Jones lee.jo...@linaro.org
, clocks outputs and the RTC.
This patch adds the core support for MAX77802 PMIC and is based
on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3:
- Remove unnecessary OOM error message since
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3: None
Changes since v2:
- Explain better the Dynamic Voltage Scaling (DVS) support in some Buck
regulators and the max77802,pmic-buck-{dvs
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v3: None
Changes since v2: None
Changes since v1:
- Use
;
+ vdd-supply = ldo8_reg;
+ vdd_osc-supply = ldo10_reg;
+ vdd_pll-supply = ldo8_reg;
};
usbdrd_phy0 {
--
1l.7.9.5
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
--
To unsubscribe from this list: send the line unsubscribe devicetree
and also we may later factor out common
DTS fragments on these two boards in .dtsi include files so is better
to keep the diff as small as possible.
};
hsi2c_7 {
--
1.7.9.5
With that trivial change:
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Best regards,
Javier
Hello Krzysztof,
Thanks a lot for your feedback.
On 06/26/2014 12:08 PM, Krzysztof Kozlowski wrote:
On śro, 2014-06-25 at 21:03 +0200, Javier Martinez Canillas wrote:
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all
Hello Yadwinder,
Thanks a lot for your feedback.
On 06/26/2014 01:51 PM, Yadwinder Singh Brar wrote:
Hi Javier,
Sorry for jumping in late, but just one concern mentioned inline.
[ .. ]
+
+static unsigned long max_gen_recalc_rate(struct clk_hw *hw,
+
Hello Naveen,
Thanks a lot for testing!
On 06/26/2014 03:32 PM, Naveen Krishna Ch wrote:
Hello Javier,
On 26 June 2014 00:33, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
MAX77802 is a PMIC that contains 10 high efficiency Buck regulators,
32 Low-dropout (LDO
Hello Naveen,
On Thu, Jun 26, 2014 at 2:19 PM, Naveen Krishna Chatradhi
ch.nav...@samsung.com wrote:
This patchset does the following
1. Create a common dtsi file cros-exynos-peach.dtsi for
exynos5420-peach-pit.dts and exynos5800-peach-pi.dts
There was some previous discussion in this list
Hello Doug,
On 06/26/2014 06:12 PM, Doug Anderson wrote:
Javier,
On Thu, Jun 26, 2014 at 4:13 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
+
+#ifdef CONFIG_PM_SLEEP
+static int max77802_suspend(struct device *dev)
+{
+struct i2c_client *i2c = container_of(dev
Hello Doug,
On 06/26/2014 06:29 PM, Doug Anderson wrote:
Javier,
On Thu, Jun 26, 2014 at 9:18 AM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Hello Doug,
On 06/26/2014 06:12 PM, Doug Anderson wrote:
Javier,
On Thu, Jun 26, 2014 at 4:13 AM, Javier Martinez Canillas
):
mfd: max77686: Allow the max77686 rtc to wakeup the system
Javier Martinez Canillas (13):
mfd: max77686: Convert to use regmap_irq
clk: max77686: Add DT include for MAX77686 PMIC clock
clk: max77686: Improve Maxim 77686 PMIC clocks binding
clk: Add generic driver for Maxim PMIC clocks
clk
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v4: None
Changes
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
---
Changes since v4: None
Changes since v3:
- Add support for Exynos5800 based Peach pi board. Suggested by Doug Anderson.
- Model the actual regulators relationship
the regmap lock.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v4: None
Changes since v3: None
drivers/base/regmap/regmap.c | 34 ++
include/linux/regmap.h | 9 +
2 files changed, 43 insertions(+)
diff
, clocks outputs and the RTC.
This patch adds the core support for MAX77802 PMIC and is based
on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Tested
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v4: None
Changes since v3
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v4: None
Changes since v3:
- Don't use the same clock driver name in clock-names since it's a consumer
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be to be shared between the
clk-max77686 clock driver and DeviceTree source files.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
By using the generic IRQ support in the Register map API, it
is possible to get rid max77686-irq.c and simplify the code.
Suggested-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Lee Jones lee.jo...@linaro.org
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Reviewed
the i2c
bus up before the max77686 wakeup runs.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v4: None
Changes since v3:
- Keep the note
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v4: None
Changes since v3: None
Changes since v2:
- Explain better the Dynamic Voltage Scaling (DVS) support in some Buck
regulators
Hello Andreas,
On 06/27/2014 09:48 AM, Andreas Färber wrote:
Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be to be shared between the
can be shared?
As it should be quite clear right now I'm
Hello Andres,
Thanks a lot for your feedback.
On 06/27/2014 09:52 AM, Andreas Färber wrote:
Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas
Hello Andreas,
Thanks a lot for your feedback.
On 06/27/2014 10:06 AM, Andreas Färber wrote:
Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Hello Andreas,
On 06/27/2014 10:26 AM, Andreas Färber wrote:
Hi Javier,
Am 27.06.2014 09:53, schrieb Javier Martinez Canillas:
Hello Andreas,
On 06/27/2014 09:48 AM, Andreas Färber wrote:
Am 26.06.2014 20:15, schrieb Javier Martinez Canillas:
This patch adds a dt-binding include
Hello Lee,
On 06/27/2014 11:21 AM, Lee Jones wrote:
On Thu, 26 Jun 2014, Javier Martinez Canillas wrote:
From: Doug Anderson diand...@chromium.org
The max77686 includes an RTC that keeps power during suspend. It's
convenient to be able to use it as a wakeup source.
NOTE: due to wakeup
Hello Lee,
Thanks a lot for your feedback.
On 06/27/2014 11:26 AM, Lee Jones wrote:
On Thu, 26 Jun 2014, Javier Martinez Canillas wrote:
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802
Hello Peter,
On Fri, Jun 27, 2014 at 8:01 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote:
Palmas class of devices can provide 32K clock(s) to be used by other devices
on the board. Depending on the actual device the provided clocks can be:
CLK32K_KG and CLK32K_KGAUDIO
or only one:
CLK32K_KG
Hello Yadwinder,
Thanks a lot for your feedback.
On 06/30/2014 06:01 AM, Yadwinder Singh Brar wrote:
Hi Javier,
On Thu, Jun 26, 2014 at 11:45 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Maxim Integrated Power Management ICs are very similar with
regard
Hello Russell,
Thanks a lot for your suggestion.
On 06/30/2014 01:35 PM, Russell King - ARM Linux wrote:
On Mon, Jun 30, 2014 at 12:58:57PM +0200, Javier Martinez Canillas wrote:
+ if (!max_gen-lookup)
+ return ERR_PTR(-ENOMEM);
+
+ max_gen-lookup-con_id = hw
Hello Lee,
Thanks a lot for your feedback.
On 07/01/2014 05:15 PM, Lee Jones wrote:
On Thu, 26 Jun 2014, Javier Martinez Canillas wrote:
Maxim MAX77802 is a power management chip that contains 10 high
efficiency Buck regulators, 32 Low-dropout (LDO) regulators used
to power up application
Hello Mike,
On Wed, Jul 2, 2014 at 6:33 AM, Mike Turquette mturque...@linaro.org wrote:
Quoting Peter Ujfalusi (2014-06-29 22:56:55)
Hi Javier,
On 06/27/2014 09:23 PM, Javier Martinez Canillas wrote:
Hello Peter,
On Fri, Jun 27, 2014 at 8:01 AM, Peter Ujfalusi peter.ujfal...@ti.com
Hello Tushar,
Thanks a lot for your feedback.
On 07/02/2014 11:20 AM, Tushar Behera wrote:
On 06/26/2014 11:45 PM, Javier Martinez Canillas wrote:
Peach pit and pi boards uses a Maxim 77802 power management
IC to drive regulators and its Real Time Clock. This patch
adds support for this chip
Hello Mike,
On 07/01/2014 07:26 PM, Mike Turquette wrote:
Quoting Yadwinder Singh Brar (2014-06-29 21:01:36)
Hi Javier,
On Thu, Jun 26, 2014 at 11:45 PM, Javier Martinez Canillas
javier.marti...@collabora.co.uk wrote:
Maxim Integrated Power Management ICs are very similar with
regard
Hello Mike,
On 07/01/2014 07:29 PM, Mike Turquette wrote:
Quoting Javier Martinez Canillas (2014-06-26 11:15:36)
Like most clock drivers, the Maxim 77686 PMIC clock binding
follows the convention that the #clock-cells property is
used to specify the number of cells in a clock provider
the system
Javier Martinez Canillas (22):
mfd: max77686: Convert to use regmap_irq
mfd: max77686: Add power management support
mfd: max77686: don't define dummy function if OF isn't enabled
mfd: max77686: make platform data over-rule DT
mfd: max77686: Return correct error when pdata isn't
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v5:
- Fix typo error in DT binding. Suggested by Andreas Farber.
- Add clock-output-names
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v5:
- Use max77686,* properties instead of max77802,* since the support is
now in the max77686 driver and that IP defined the properties first
.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
---
Changes since v5:
- Fix style issues and a typo on peach pit and pi DTS.
Suggested by Tushar Behera.
Changes since v4: None
Changes since v3:
- Add support
The MAX77686 PMIC submodule has Dynamic Voltage Scaling (DVS)
support on some regulators. Now that the regulator driver has
bindings to configure it, these bindings have to be documented.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Documentation/devicetree
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v5: None
Changes since v4
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v5: None
Changes
, clocks outputs and the RTC.
This patch adds support for MAX77802 to the MAX77686 driver and is
based on a driver added to the Chrome OS kernel 3.8 by Simon Glass.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
NOTE: I didn't carry previous {Review,Acked,Tested
MAX77686 PMIC support Dyamic Voltage Scaling (DVS) on a set
of Buck regulators. A number of GPIO are connected to these
lines and are requested by the mfd driver. Setup the GPIO
pins from the regulator driver.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers
the regmap lock.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v5: None
Changes since v4: None
Changes since v3: None
---
drivers/base/regmap/regmap.c | 34 ++
include/linux/regmap.h | 9 +
2 files
.
Also, explain that the clocks identifiers are defined in a
header file that can be included by Device Tree source with
client nodes to avoid using magic numbers.
Finally, add clock-output-names as an optional property
since now is supported by the clock driver.
Signed-off-by: Javier Martinez Canillas
Clocks drivers for Maxim PMIC are very similar so they can
be converted to use the generic Maxim clock driver.
Also, while being there use module_platform_driver() helper
macro to eliminate more boilerplate code.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed
This patch adds a dt-binding include for Maxim 77686
PMIC clock IDs that can be used by both the max77686
clock driver and Device Tree source files.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Reviewed-by: Mike
Maxim Integrated Power Management ICs are very similar with
regard to their clock outputs. Most of the clock drivers for
these chips are duplicating code and are simpler enough that
can be converted to use a generic driver to consolidate code
and avoid duplication.
Signed-off-by: Javier Martinez
Error checking across the driver is mostly consistent besides
a few exceptions, so change these exceptions for consistency.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
lines connected to them.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686.c | 115 +++
include/linux/mfd/max77686.h | 18 ---
2 files changed, 125 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd
There is no need to print out-of-memory errors since this is already
done by the memory management subsystem which even calls dump_stack().
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions
When platform data is not found an -EIO (I/O error) code is returned.
This doesn't seem to be the correct error so better return -EINVAL
(Invalid argument) which is what most drivers do in this case.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686
The function max77802_i2c_parse_dt_pdata() should only be called
if there isn't already platform data for the device.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd
The driver doesn't have PM operations defined so add a suspend
and resume function handlers to allow the PMIC IRQ to wakeup
the system when it is put into a sleep state.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
drivers/mfd/max77686.c | 40
When the CONFIG_OF option was not enabled, a dummy function
max77686_i2c_parse_dt_pdata() was defined since this is called
unconditionally on probe(). Just always define the real function
and conditionally call it if CONFIG_OF is enabled instead.
Signed-off-by: Javier Martinez Canillas
By using the generic IRQ support in the Register map API, it
is possible to get rid max77686-irq.c and simplify the code.
Suggested-by: Krzysztof Kozlowski k.kozlow...@samsung.com
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Acked-by: Lee Jones lee.jo...@linaro.org
Hello Krzysztof,
Again, thanks a lot for taking the time to review the series.
On 07/04/2014 01:15 PM, Krzysztof Kozlowski wrote:
On pią, 2014-07-04 at 11:55 +0200, Javier Martinez Canillas wrote:
Some regulators on the MAX77686 PMIC have Dynamic Voltage Scaling
(DVS) support that allows
Hello Krzysztof,
On 07/04/2014 01:30 PM, Krzysztof Kozlowski wrote:
On pią, 2014-07-04 at 11:55 +0200, Javier Martinez Canillas wrote:
Maxim MAX77802 is a power management chip that contains 10 high
efficiency Buck regulators, 32 Low-dropout (LDO) regulators used
to power up application
Hello Krzysztof,
Thanks a lot for your feedback.
On 07/04/2014 01:56 PM, Krzysztof Kozlowski wrote:
On pią, 2014-07-04 at 11:55 +0200, Javier Martinez Canillas wrote:
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
Hello Krzysztof,
On 07/04/2014 03:11 PM, Krzysztof Kozlowski wrote:
On pią, 2014-07-04 at 14:52 +0200, Javier Martinez Canillas wrote:
Hello Krzysztof,
Thanks a lot for your feedback.
On 07/04/2014 01:56 PM, Krzysztof Kozlowski wrote:
On pią, 2014-07-04 at 11:55 +0200, Javier Martinez
) Chromebooks and it's composed of the following patches:
Doug Anderson (1):
rtc: max77686: Allow the max77686 rtc to wakeup the system
Javier Martinez Canillas (23):
mfd: max77686: Convert to use regmap_irq
mfd: max77686: Add power management support
mfd: max77686: Don't define dummy
The MAX7802 PMIC has a Real-Time-Clock (RTC) with two alarms.
This patch adds support for the RTC and is based on a driver
added by Simon Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v6:
- Remove unused code
.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
---
Changes since v6: None
Changes since v5:
- Fix style issues and a typo on peach pit and pi DTS.
Suggested by Tushar Behera.
Changes since v4: None
Changes
The MAX77802 PMIC has two 32.768kHz Buffered Clock Outputs with
Low Jitter Mode. This patch adds support for these two clocks.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Changes since v6: None
Changes
Add Device Tree binding documentation for Maxim 77802 PMIC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v6: None
Changes since v5:
- Use max77686,* properties instead of max77802,* since the support is
now in the max77686 driver and that IP
, clocks outputs and the RTC.
This patch adds support for MAX77802 to the MAX77686 driver and is
based on a driver added to the Chrome OS kernel 3.8 by Simon Glass.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout
(LDO) regulators. This patch adds support for all these regulators
found on the MAX77802 PMIC and is based on a driver added by Simon
Glass to the Chrome OS kernel 3.8 tree.
Signed-off-by: Javier Martinez Canillas javier.marti
Add Device Tree binding documentation for the clocks
outputs in the Maxim 77802 Power Management IC.
Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
---
Changes since v6: None
Changes since v5:
- Fix typo error in DT binding. Suggested by Andreas Farber.
- Add clock
1 - 100 of 794 matches
Mail list logo
