[xwiki-devs] [XWiki Day] BFD#193

Hello devs, This Thursday is BFD#193: http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingday Our current status is: * -76 bugs over 120 days (4 months), i.e. we need to close 76 bugs to have created bugs == closed bugs * -127 bugs over 365 days (1 year) * -173 bugs over 500 days

Re: [xwiki-devs] [STAMP/Test] Metrics we need to improve + strategy

> On 17 Oct 2018, at 15:54, Vincent Massol wrote: > > Hi, > >> On 17 Oct 2018, at 11:20, Vincent Massol wrote: >> >> Hi, >> >> [snip] >> >>> Process to run DSpot: >>> 1) Pick a module. Measure coverage and mutation score (or take the value >>> there already if they’re in the pom.xml).

Re: [xwiki-devs] [UX][Proposal] Distribution Wizard: Never Button

On Wed, Oct 17, 2018 at 7:13 PM Vincent Massol wrote: > > > > On 17 Oct 2018, at 18:10, Ecaterina Moraru (Valica) > wrote: > > > > On Wed, Oct 17, 2018 at 6:58 PM Vincent Massol > wrote: > > > >> > >> > >>> On 17 Oct 2018, at 17:46, Ecaterina Moraru (Valica) > > >> wrote: > >>> > >>> Hi

Re: [xwiki-devs] [UX][Proposal] Distribution Wizard: Never Button

> On 17 Oct 2018, at 18:10, Ecaterina Moraru (Valica) wrote: > > On Wed, Oct 17, 2018 at 6:58 PM Vincent Massol wrote: > >> >> >>> On 17 Oct 2018, at 17:46, Ecaterina Moraru (Valica) >> wrote: >>> >>> Hi Vincent, >>> >>> This proposal doesn't apply to the "Install" button, since there

Re: [xwiki-devs] [UX][Proposal] Distribution Wizard: Never Button

On Wed, Oct 17, 2018 at 6:58 PM Vincent Massol wrote: > > > > On 17 Oct 2018, at 17:46, Ecaterina Moraru (Valica) > wrote: > > > > Hi Vincent, > > > > This proposal doesn't apply to the "Install" button, since there are > steps > > where there is not just a single button. > > Each Wiki or

Re: [xwiki-devs] [UX][Proposal] Distribution Wizard: Never Button

> On 17 Oct 2018, at 17:46, Ecaterina Moraru (Valica) wrote: > > Hi Vincent, > > This proposal doesn't apply to the "Install" button, since there are steps > where there is not just a single button. > Each Wiki or Flavor could have their own "Install", so that's why the > position is related

Re: [xwiki-devs] [UX][Proposal] Distribution Wizard: Never Button

Hi Vincent, This proposal doesn't apply to the "Install" button, since there are steps where there is not just a single button. Each Wiki or Flavor could have their own "Install", so that's why the position is related to each type of entity, see an example of multiple "Upgrade" buttons

Re: [xwiki-devs] [UX][Proposal] Distribution Wizard: Never Button

Hi Caty, Thanks for this. Actually the screenshot you have at https://design.xwiki.org/xwiki/bin/download/Proposal/Upgrade/DWNeverButton/WebHome/dw-welcomeStep.png is not the only issue for me. The problem I had was on the flavor screen because you need to click “install” at the top and not

Re: [xwiki-devs] [UX][Proposal] Distribution Wizard: Never Button

Both VAR1 and VAR2 look good to me. Thanks, Marius On Wed, Oct 17, 2018 at 5:49 PM Ecaterina Moraru (Valica) wrote: > Hi devs, > > This is an improvements proposal for the "Never" button from Distribution > Wizard. > https://design.xwiki.org/xwiki/bin/view/Proposal/Upgrade/DWNeverButton/ > >

[xwiki-devs] [UX][Proposal] Distribution Wizard: Never Button

Hi devs, This is an improvements proposal for the "Never" button from Distribution Wizard. https://design.xwiki.org/xwiki/bin/view/Proposal/Upgrade/DWNeverButton/ I've listed several variants of fixing the usability issue, let me know which one is your favorite. My +1 goes to VAR2:

Re: [xwiki-devs] [STAMP/Test] Metrics we need to improve + strategy

Hi, > On 17 Oct 2018, at 11:20, Vincent Massol wrote: > > Hi, > > [snip] > >> Process to run DSpot: >> 1) Pick a module. Measure coverage and mutation score (or take the value >> there already if they’re in the pom.xml). Same as for Descartes testing. >> 2) Run DSpot on the module, see >>

[xwiki-devs] [ANN] XWiki 9.11.8 released

The XWiki development team is proud to announce the availability of XWiki 9.11.8. This is a bugfix release that covers important issues that we have discovered since 9.11.7 has been released. You can download it here: http://www.xwiki.org/xwiki/bin/view/Main/Download Make sure to review the

Re: [xwiki-devs] [Proposal] Change ObservationManager behaviour with CancelableEvents

An use case is to be able to log all the events that happen in XWiki. It would be stupid to not be able to log an event because there's another event listener that cancels the event before. On Wed, Oct 17, 2018 at 3:21 PM Marius Dumitru Florea < mariusdumitru.flo...@xwiki.com> wrote: > -0. I

Re: [xwiki-devs] [Proposal] Change ObservationManager behaviour with CancelableEvents

-0. I would be OK to stop the event propagation if the list of event listeners were *ordered* but AFAIK there's no order between event listeners ATM. It should always be possible to catch an event, even if that event is going to be canceled by some other listener: * either by registering an event

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

> On 17 Oct 2018, at 11:37, Thomas Mortagne wrote: > > On Wed, Oct 17, 2018 at 11:29 AM Vincent Massol wrote: >> >> >> >>> On 17 Oct 2018, at 11:08, Simon Urli wrote: >> >> [snip] >> > I reused the existing UI which does not look so bad IMO (see the > screenshot in the

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

On Wed, Oct 17, 2018 at 11:29 AM Vincent Massol wrote: > > > > > On 17 Oct 2018, at 11:08, Simon Urli wrote: > > [snip] > > >>> I reused the existing UI which does not look so bad IMO (see the > >>> screenshot in the design page). > >> This is what happens in the AntiSpam app when

Re: [xwiki-devs] [Proposal] Change ObservationManager behaviour with CancelableEvents

On 10/17/18 11:29 AM, Guillaume Delhumeau wrote: Le mer. 17 oct. 2018 à 10:47, Simon Urli > a écrit : On 10/17/18 10:35 AM, Guillaume Delhumeau wrote: > I'm OK. > > > I'm just thinking about an other particular case: > Imagine you

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

> On 17 Oct 2018, at 11:08, Simon Urli wrote: [snip] >>> I reused the existing UI which does not look so bad IMO (see the >>> screenshot in the design page). >> This is what happens in the AntiSpam app when the event is cancelled (ie >> when it finds some spam in the doc):

Re: [xwiki-devs] [Proposal] Change ObservationManager behaviour with CancelableEvents

Le mer. 17 oct. 2018 à 10:47, Simon Urli a écrit : > > > On 10/17/18 10:35 AM, Guillaume Delhumeau wrote: > > I'm OK. > > > > > > I'm just thinking about an other particular case: > > Imagine you have 3 event listeners (A, B, C): > > - A receives the event and perform some actions (saving

Re: [xwiki-devs] [STAMP/Test] Metrics we need to improve + strategy

Hi, [snip] > Process to run DSpot: > 1) Pick a module. Measure coverage and mutation score (or take the value > there already if they’re in the pom.xml). Same as for Descartes testing. > 2) Run DSpot on the module, see > https://massol.myxwiki.org/xwiki/bin/view/Blog/TestGenerationDspot for >

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

On 10/17/18 10:43 AM, Vincent Massol wrote: On 17 Oct 2018, at 10:41, Simon Urli wrote: On 10/17/18 10:37 AM, Vincent Massol wrote: On 17 Oct 2018, at 10:31, Simon Urli wrote: On 10/17/18 10:22 AM, Vincent Massol wrote: Hi Simon, On 17 Oct 2018, at 10:12, Simon Urli wrote: Hi

Re: [xwiki-devs] [Proposal] Change ObservationManager behaviour with CancelableEvents

On 10/17/18 10:35 AM, Guillaume Delhumeau wrote: I'm OK. I'm just thinking about an other particular case: Imagine you have 3 event listeners (A, B, C): - A receives the event and perform some actions (saving something in the database). - B receives the event and cancels it - C don't

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

> On 17 Oct 2018, at 10:41, Simon Urli wrote: > > > > On 10/17/18 10:37 AM, Vincent Massol wrote: >>> On 17 Oct 2018, at 10:31, Simon Urli wrote: >>> >>> >>> >>> On 10/17/18 10:22 AM, Vincent Massol wrote: Hi Simon, > On 17 Oct 2018, at 10:12, Simon Urli wrote: > > Hi

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

On 10/17/18 10:37 AM, Vincent Massol wrote: On 17 Oct 2018, at 10:31, Simon Urli wrote: On 10/17/18 10:22 AM, Vincent Massol wrote: Hi Simon, On 17 Oct 2018, at 10:12, Simon Urli wrote: Hi Vincent and all, On 10/17/18 9:41 AM, Vincent Massol wrote: Hi Simon, On 16 Oct 2018, at

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

> On 17 Oct 2018, at 10:31, Simon Urli wrote: > > > > On 10/17/18 10:22 AM, Vincent Massol wrote: >> Hi Simon, >>> On 17 Oct 2018, at 10:12, Simon Urli wrote: >>> >>> Hi Vincent and all, >>> >>> On 10/17/18 9:41 AM, Vincent Massol wrote: Hi Simon, > On 16 Oct 2018, at 17:43,

Re: [xwiki-devs] [Proposal] Change ObservationManager behaviour with CancelableEvents

I'm OK. I'm just thinking about an other particular case: Imagine you have 3 event listeners (A, B, C): - A receives the event and perform some actions (saving something in the database). - B receives the event and cancels it - C don't receive the event because it had been canceled However, we

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

On 10/17/18 10:22 AM, Vincent Massol wrote: Hi Simon, On 17 Oct 2018, at 10:12, Simon Urli wrote: Hi Vincent and all, On 10/17/18 9:41 AM, Vincent Massol wrote: Hi Simon, On 16 Oct 2018, at 17:43, Simon Urli wrote: Hello everyone, I'm coming back on this proposal as the work is

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

Hi Simon, > On 17 Oct 2018, at 10:12, Simon Urli wrote: > > Hi Vincent and all, > > On 10/17/18 9:41 AM, Vincent Massol wrote: >> Hi Simon, >>> On 16 Oct 2018, at 17:43, Simon Urli wrote: >>> >>> Hello everyone, >>> >>> I'm coming back on this proposal as the work is going on, to basically

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

Hi Vincent and all, On 10/17/18 9:41 AM, Vincent Massol wrote: Hi Simon, On 16 Oct 2018, at 17:43, Simon Urli wrote: Hello everyone, I'm coming back on this proposal as the work is going on, to basically propose to dropping the warning on copy action. I try to sum up why in the

Re: [xwiki-devs] [Proposal] Change ObservationManager behaviour with CancelableEvents

Hi all, I took the liberty to already create the PR, then you can see the impact on the code: https://github.com/xwiki/xwiki-commons/pull/49 Simon. On 10/17/18 9:09 AM, Thomas Mortagne wrote: +1 to stopping event propagation when it's cancelled On Tue, Oct 16, 2018 at 6:07 PM Simon Urli

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

Hi Simon, > On 16 Oct 2018, at 17:43, Simon Urli wrote: > > Hello everyone, > > I'm coming back on this proposal as the work is going on, to basically > propose to dropping the warning on copy action. > > I try to sum up why in the following. > > When implementing the proposal, I was

Re: [xwiki-devs] [Proposal] Change ObservationManager behaviour with CancelableEvents

+1 to stopping event propagation when it's cancelled On Tue, Oct 16, 2018 at 6:07 PM Simon Urli wrote: > > Hi everyone, > > the current behaviour of the ObservationManager is to always triggers > the listeners if it matches the events. > Now regarding the CancelableEvents, the match is only done

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

+1 to drop it. Never understood why it was a problem anyway On Tue, Oct 16, 2018 at 5:43 PM Simon Urli wrote: > > Hello everyone, > > I'm coming back on this proposal as the work is going on, to basically > propose to dropping the warning on copy action. > > I try to sum up why in the following.