Re: [xwiki-devs] [Proposal] WikiMacro inline editing: 2 new dedicated macros

2019-05-14 Thread Marius Dumitru Florea
On Thu, May 9, 2019 at 4:15 PM Simon Urli wrote: > Hi, > > On 09/05/2019 14:52, Vincent Massol wrote: > > Hi Simon, > > > >> On 9 May 2019, at 09:36, Simon Urli wrote: > >> > >> Hi Vincent, > >> > >> On 09/05/2019 09:10, Vincent Massol wrote: > >>> Hi Simon, > On 7 May 2019, at 08:21,

Re: [xwiki-devs] [Proposal] WikiMacro inline editing: 2 new dedicated macros

2019-05-09 Thread Simon Urli
Hi, On 09/05/2019 14:52, Vincent Massol wrote: Hi Simon, On 9 May 2019, at 09:36, Simon Urli wrote: Hi Vincent, On 09/05/2019 09:10, Vincent Massol wrote: Hi Simon, On 7 May 2019, at 08:21, Simon Urli wrote: Hi everyone, I'm currently working on allowing inline editing on new

Re: [xwiki-devs] [Proposal] WikiMacro inline editing: 2 new dedicated macros

2019-05-09 Thread Vincent Massol
Hi Simon, > On 9 May 2019, at 09:36, Simon Urli wrote: > > Hi Vincent, > > On 09/05/2019 09:10, Vincent Massol wrote: >> Hi Simon, >>> On 7 May 2019, at 08:21, Simon Urli wrote: >>> >>> Hi everyone, >>> >>> I'm currently working on allowing inline editing on new wikimacros. >> Why only on

Re: [xwiki-devs] [Proposal] WikiMacro inline editing: 2 new dedicated macros

2019-05-09 Thread Simon Urli
Hi Vincent, On 09/05/2019 09:10, Vincent Massol wrote: Hi Simon, On 7 May 2019, at 08:21, Simon Urli wrote: Hi everyone, I'm currently working on allowing inline editing on new wikimacros. Why only on wikimacros? We also need to be able to edit existing wikimacros to make them

Re: [xwiki-devs] [Proposal] WikiMacro inline editing: 2 new dedicated macros

2019-05-09 Thread Simon Urli
Hi Marius, all, On 08/05/2019 14:09, Marius Dumitru Florea wrote: Hi Simon, As I commented on https://github.com/xwiki/xwiki-platform/pull/1109 I think that most of the time you will want to use a scripting macro + HTML macro like this: {{velocity}} {{html clean="false"}} ... ...

Re: [xwiki-devs] [Proposal] WikiMacro inline editing: 2 new dedicated macros

2019-05-09 Thread Vincent Massol
Hi Simon, > On 7 May 2019, at 08:21, Simon Urli wrote: > > Hi everyone, > > I'm currently working on allowing inline editing on new wikimacros. Why only on wikimacros? We also need to be able to edit existing wikimacros to make them inline-editable. > My first challenge right now is to cope

Re: [xwiki-devs] [Proposal] WikiMacro inline editing: 2 new dedicated macros

2019-05-08 Thread Thomas Mortagne
This mail is missing the most important part of what we talked about with Simon actually but maybe the plan was to do that in another mail ? Without entering too much in the details (I let Simon do that ;)) the core idea to support inline editing in wiki macro is to cleanup macro implementation

Re: [xwiki-devs] [Proposal] WikiMacro inline editing: 2 new dedicated macros

2019-05-08 Thread Marius Dumitru Florea
Hi Simon, As I commented on https://github.com/xwiki/xwiki-platform/pull/1109 I think that most of the time you will want to use a scripting macro + HTML macro like this: {{velocity}} {{html clean="false"}} ... ... {{/html}} {{/velocity}} An example of such a macro could be: {{figure

[xwiki-devs] [Proposal] WikiMacro inline editing: 2 new dedicated macros

2019-05-07 Thread Simon Urli
Hi everyone, I'm currently working on allowing inline editing on new wikimacros. My first challenge right now is to cope with the problem of inserting the macro content and allowing to inline edit it. In order to do so, I propose to create two new dedicated macro: - wikimacrocontent: would