[xwiki-devs] [Brainstorming] How should we review translations?

2018-05-18 Thread Adel Atallah
Hello everyone, As you probably know, we have decided to use Weblate as our new translation platform (l10n.xwiki.com). We still need to make some decisions before making an official announcement to the community. I'd like to know here how we should deal with translation

[xwiki-devs] Fwd: [Question for the xwiki security feature] Hi xwiki security members

2018-05-18 Thread Adel Atallah
Password Validation is weak >> >> It seems xwiki allow weak password to register new user. >> >> Is it possible to use strong password only when new user registered in xwiki? > > It's possible to add a lot of constraint in the registration form. See > http://extensions.xwiki.org/xwiki/bin/view/Extension/Administration%20Application#HValidationConstraints. > >> >> >> >> These are the all issue they addressed. >> >> Please let me know the answer. >> >> Thank you and have a good day >> >> Kwan Kim > > > > -- > Thomas Mortagne Thanks for your report Kwan Kim :), Adel Atallah

Re: [xwiki-devs] [Brainstorming] How should we review translations?

2018-05-18 Thread Adel Atallah
validate a >> translation to be correct, that translation could auto validate itself? >> >> Option 2 seems the only option, because it allows Release Managers to >> validate multiple keys at the same time and it's similar to the current >> release process. >> &g

Re: [xwiki-devs] [Brainstorming] How should we review translations?

2018-05-18 Thread Adel Atallah
imilar to the current > release process. > > Thanks, > Caty > > On Fri, May 18, 2018 at 10:05 AM, Adel Atallah <adel.atal...@xwiki.com> > wrote: > >> Hello everyone, >> >> As you probably know, we have decided to use Weblate <https://weblate.org/> &g

Re: [xwiki-devs] [Brainstorming] How should we review translations?

2018-05-18 Thread Adel Atallah
On Fri, May 18, 2018 at 10:44 AM, Vincent Massol <vinc...@massol.net> wrote: > Hi, > >> On 18 May 2018, at 10:39, Adel Atallah <adel.atal...@xwiki.com> wrote: >> >> On Fri, May 18, 2018 at 10:23 AM, Thomas Mortagne >> <thomas.morta...@xwiki.com&

[xwiki-devs] [Brainstorming] Should we support multibranch translations?

2018-05-18 Thread Adel Atallah
Hi, Following my previous email on "How should we review translations?", I'd like to know here if we should support automatic multibranch translations in Weblate. What I mean here is that with the old l10n platform, we would apply new translations on multiple git branches (for some projects like

Re: [xwiki-devs] [Brainstorming] Should we support multibranch translations?

2018-05-22 Thread Adel Atallah
and apply them. An other way would be to use the list of translation files that we already have and write a script to replace (checkout) those files from master to the specified branch. WDYT? Thanks, Adel Adel Atallah Product developer intern adel.atal...@xwiki.com tel: +33 (0)6 12 96 35 06 On Fri

Re: [xwiki-devs] [Brainstorming] Should we support multibranch translations?

2018-05-22 Thread Adel Atallah
On Tue, May 22, 2018 at 1:51 PM, Vincent Massol <vinc...@massol.net> wrote: > FTR this is what I discussed with Adel and I asked him to post it here so > that we can agree. > >> On 22 May 2018, at 13:41, Adel Atallah <adel.atal...@xwiki.com> wrote: >> >> So

[xwiki-devs] [Brainstorming] Importing translations to Weblate

2018-05-23 Thread Adel Atallah
Hello devs, I need your opinion on how we should import new components (i.e. translations) into Weblate . Weblate allows you to create components directly on their platform but it will be very difficult for us to so because we would have to run an import script to generate

Re: [xwiki-devs] [Brainstorming] Importing translations to Weblate

2018-05-23 Thread Adel Atallah
On Wed, May 23, 2018 at 3:19 PM, Thomas Mortagne <thomas.morta...@xwiki.com> wrote: > > On Wed, May 23, 2018 at 12:20 PM, Adel Atallah <adel.atal...@xwiki.com> wrote: > > Hello devs, > > > > I need your opinion on how we should import new components (i.e.

Re: [xwiki-devs] [Translation] Translation migration

2018-05-24 Thread Adel Atallah
On Thu, May 24, 2018 at 2:27 PM, Vincent Massol <vinc...@massol.net> wrote: > Hi, > >> On 24 May 2018, at 13:58, Adel Atallah <adel.atal...@xwiki.com> wrote: >> >> Hi, >> >> To fix some issues we have, we want to transform translation files so tha

Re: [xwiki-devs] [Translation] Translation migration

2018-05-24 Thread Adel Atallah
I fixed some issues you could find on the previous test commit. Here is the new one <https://github.com/atallahade/xwiki-platform/commit/12ffd02abe6276be3b2c25f758a47e559002ffae> . On Thu, May 24, 2018 at 2:33 PM, Adel Atallah <adel.atal...@xwiki.com> wrote: > > On Thu, May 2

[xwiki-devs] [Translation] Translation migration

2018-05-24 Thread Adel Atallah
Hi, To fix some issues we have, we want to transform translation files so that they have the same structure as the english base translation file. You can have a look at this test commit to see what the

Re: [xwiki-devs] [Brainstorming] Best practices on indentation for rendering macros in scripts

2018-06-06 Thread Adel Atallah
I don't think we need top level indentation to make it clear that a macro is being used so I would go for option A-1. On Wed, Jun 6, 2018 at 11:49 AM, Vincent Massol wrote: > Hi, > > Context 1: https://jira.xwiki.org/browse/WIKIEDITOR-58 > Context 2: Fill the “velocity code style” section of >

Re: [xwiki-devs] [Brainstormoing] Removing old "since" from xwiki.org

2018-06-18 Thread Adel Atallah
Hi, I think it makes sense to remove information related to XWiki versions below the LTS one as long as the information is not required to do an upgrade or the information can at least be seen in a release note or somewhere else. Thanks, Adel On Mon, Jun 18, 2018 at 1:19 PM, Vincent Massol

Re: [xwiki-devs] [Proposal] Add a new method in the icon API

2018-06-15 Thread Adel Atallah
u call render() and renderHTML() but it obviously doesn't work if > you call render* on an AJAX request that returns JSON. > > Thanks, > Marius > > > On Thu, Jun 14, 2018 at 12:56 PM, Adel Atallah > wrote: > >> Hi devs, >> >> I'm making a rest resource to

Re: [xwiki-devs] [Vote][UX] Visible Save buttons

2018-05-29 Thread Adel Atallah
On Tue, May 29, 2018 at 5:41 PM, Ecaterina Moraru (Valica) wrote: > So preferable in inline mode, the bar should not be full width, but just > the size of the content. +1, I think it's weird to have a full width bar both on the WYSIWYG/XWiki editor and inline editor. > This needs to be

Re: [xwiki-devs] [Brainstorming] Next gen functional testing for XWiki

2018-07-02 Thread Adel Atallah
Also I hope it will not make CI builds a lot longer. Adel Atallah Product developer intern adel.atal...@xwiki.com tel: +33 (0)6 12 96 35 06 On Mon, Jul 2, 2018 at 10:52 AM, Adel Atallah wrote: > Hi, > > It will be very useful to be able to run functional tests on all > suppor

Re: [xwiki-devs] [Brainstorming] Next gen functional testing for XWiki

2018-07-02 Thread Adel Atallah
Hi, It will be very useful to be able to run functional tests on all supported browsers. However I wonder if it will also be as useful for different servlet containers and databases (at least when the database schema doesn't change). I tried to run the tests on my machine but I got an error:

Re: [xwiki-devs] [Proposal] Velocity Test Coverage strategy

2018-07-29 Thread Adel Atallah
On Sun, Jul 29, 2018 at 5:56 PM, Vincent Massol wrote: > Hi devs, > > During XWiki SAS’s hackathon last week, Simon and me worked on implementing > test coverage computation for velocity code and more precisely to measure the > code coverage we get in XWiki XML pages when running our tests. > >

Re: [xwiki-devs] [VOTE] Update the xar plugin and stop committing XML wiki page date fields

2018-07-31 Thread Adel Atallah
+1 enabled by default, obviously. Le mar. 31 juil. 2018 18:43, Eduard Moraru a écrit : > Hi, devs. > > We have had 2 previous discussions on this topic: > * July 2016 (discussion): https://markmail.org/thread/oodciq7pv6pj7eic > * Jan 2018 (proposal): https://markmail.org/thread/ymwsebvr3k7voy3p

Re: [xwiki-devs] [Contrib] New application for copying pages from one wiki to another (name suggestions welcome)

2018-08-20 Thread Adel Atallah
Hello, Are the documents "re-published" when updated? Maybe you could name the application "Synchronization Application" or something similar if this is the case. On Mon, Aug 20, 2018 at 4:48 PM, Vincent Massol wrote: > Hi Anca/Stephane, > >> On 20 Aug 2018, at 16:39, Anca Luca wrote: >> >>

Re: [xwiki-devs] Follow-up brainstorming about adding apps in administration (menu, scheduler)

2018-09-05 Thread Adel Atallah
Hello, On Wed, Sep 5, 2018 at 2:57 PM, Simon Urli wrote: > Hello everyone, > > I'm writing this email as a follow-up after (yet another) brainstorming with > Vincent about how adding the app Menu in the administration > (https://jira.xwiki.org/browse/XWIKI-15483). > > Sorry in advance if I

Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-07 Thread Adel Atallah
I've created a Jira issue, I would appreciate to have some feedback or changes if needed: https://jira.xwiki.org/browse/XWIKI-15582 Thanks, Adel On Fri, Sep 7, 2018 at 3:02 PM, Thomas Mortagne wrote: > On Thu, Sep 6, 2018 at 2:58 PM Adel Atallah wrote: >> >> Hi devs, >> &

[xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-06 Thread Adel Atallah
Hi devs, Working on the auto-suggestion feature [1], I've been integrating it in xproperties holding a reference to a page. Those xproperties are of type String and have been changed to the Page type so that the page displayer is used and shows the auto-suggestion when needed. I now need to

Re: [xwiki-devs] [STAMP/Test] Metrics we need to improve + strategy

2018-08-30 Thread Adel Atallah
Hello, Maybe we should agree on having a whole day dedicated on using these tools with a maximum number of developers. That way we will be able to help each other and maybe it will make the process easier to carry out in the future. WDYT? Thanks, Adel On Wed, Aug 29, 2018 at 11:20 AM, Vincent

Re: [xwiki-devs] [STAMP/Test] Metrics we need to improve + strategy

2018-08-30 Thread Adel Atallah
10:38, Thomas Mortagne wrote: >> >> Indeed we discussed this but I don't see it in your mail Vincent. >> >> On Thu, Aug 30, 2018 at 10:33 AM, Adel Atallah >> wrote: >>> Hello, >>> >>> Maybe we should agree on having a whole day dedicat

Re: [xwiki-devs] [Brainstorming] Preparation for XWiki 10.7 aka the "Quality Release"

2018-07-05 Thread Adel Atallah
Hi, I agree that we should do both bugs fixing/closing and tests improvement but I don't think having dedicated days for one and the other is necessary. On Thu, Jul 5, 2018 at 10:43 AM, Vincent Massol wrote: > Hi devs, > > We’ll soon start XWiki 10.7 (see >

[xwiki-devs] Onboarding feedback

2018-04-19 Thread Adel Atallah
. A link to a real application could maybe give a better understanding. Thanks again for the help I had! <http://www.xwiki.com/> *Adel Atallah* *Product developer intern* adel.atal...@xwiki.com <corina.lu...@xwiki.com> tel: +33 (0)6 12 96 35 06

Re: [xwiki-devs] [Proposal] Weblate as XWiki's translation platform

2018-04-25 Thread Adel Atallah
lt;http://docs.translatehouse.org/projects/translate-toolkit/en/latest/commands/index.html> . Thanks for your reply, <http://www.xwiki.com/> *Adel Atallah* *Product developer intern* adel.atal...@xwiki.com tel: +33 (0)6 12 96 35 06 On Wed, Apr 25, 2018 at 10:47 AM, Vincent Massol <vinc.

[xwiki-devs] [Proposal] Weblate as XWiki's translation platform

2018-04-23 Thread Adel Atallah
/WeblateasXWikistranslationplatform Feel free to discuss it by responding here or directly in the design page. Thanks, <http://www.xwiki.com/> *Adel Atallah* *Product developer intern* adel.atal...@xwiki.com <corina.lu...@xwiki.com> tel: +33 (0)6 12 96 35 06

Re: [xwiki-devs] [Proposal] Weblate as XWiki's translation platform

2018-04-24 Thread Adel Atallah
tools have, we can consider them for sure. As for Python, why would it decrease maintainability and other what? Thanks again, <http://www.xwiki.com/> *Adel Atallah* *Product developer intern* adel.atal...@xwiki.com tel: +33 (0)6 12 96 35 06 On Tue, Apr 24, 2018 at 3:44 PM, Clément

Re: [xwiki-devs] [Best Practice] Use lowercase for JIRA labels

2018-10-22 Thread Adel Atallah
Hello, +1 :) Thanks, Adel On Mon, Oct 22, 2018 at 3:17 PM Vincent Massol wrote: > > Hi, > > I’d like to propose to use a consistent naming scheme for jira labels and use > lowercase (and fix all the upper case we can find). > > Ok for everyone? > > Thanks > -Vincent >

Re: [xwiki-devs] [Proposal] Remove MenuIT that is not using Docker

2018-10-24 Thread Adel Atallah
Hello Vincent, I'd like to try the new tests on my machine if that's ok. I remember having some issues in the past. Thanks, Adel On Wed, Oct 24, 2018 at 12:11 PM Vincent Massol wrote: > > Hi devs, > > Now that the docker-based MenuIT test is working and passing in our CI, I’m > proposing to

Re: [xwiki-devs] [Proposal] Remove MenuIT that is not using Docker

2018-10-30 Thread Adel Atallah
Hello Vincent, I still have some issues: https://up1.xwikisas.com/#V3wnoMPSr2uZC0Pz0x279Q Am I the only one having trouble running the tests? I'm running docker version 18.06.1-ce (and docker-compose version 1.21.0) on Debian testing (buster). Thanks, Adel On Tue, Oct 30, 2018 at 7:05 PM

Re: [xwiki-devs] [Proposal] Update database support strategy

2018-10-31 Thread Adel Atallah
Hello, On Wed, Oct 31, 2018 at 9:07 AM Vincent Massol wrote: > > Hi devs, > > We currently have > https://dev.xwiki.org/xwiki/bin/view/Community/DatabaseSupportStrategy > > However, it doesn’t say explicitly which versions we officially support: > * For HSQLDB it says 2.3.3 which is wrong since

Re: [xwiki-devs] [Proposal] Update servlet container support strategy

2018-10-31 Thread Adel Atallah
Hi Vincent, +1 Thanks, Adel On Wed, Oct 31, 2018 at 10:07 AM Marius Dumitru Florea wrote: > > +1 > > Thanks, > Marius > > On Wed, Oct 31, 2018 at 11:04 AM Vincent Massol wrote: > > > Hi devs, > > > > We now have > >

Re: [xwiki-devs] [Proposal] Delete all in the recycle bin

2018-10-29 Thread Adel Atallah
Hello Simon, On Mon, Oct 29, 2018 at 2:59 PM Simon Urli wrote: > > Hi everyone, > > I'll work this month on adding the "delete all" functionality in the > recycle bin. > However I'd like to have your opinion on how it should looks like for > the users. > I have at least 4 proposals that I

Re: [xwiki-devs] [Proposal] Move Doxia-based syntaxes in contrib

2018-10-29 Thread Adel Atallah
Hello, +1 Thanks, Adel On Mon, Oct 29, 2018 at 2:33 PM Ecaterina Moraru (Valica) wrote: > > +0 > > Thanks, > Caty > > On Mon, Oct 29, 2018 at 3:15 PM Marius Dumitru Florea < > mariusdumitru.flo...@xwiki.com> wrote: > > > +0 > > > > Thanks, > > Marius > > > > On Sat, Oct 27, 2018 at 3:01 PM

Re: [xwiki-devs] [Proposal] Delete all in the recycle bin

2018-10-29 Thread Adel Atallah
On Mon, Oct 29, 2018 at 3:09 PM Ecaterina Moraru (Valica) wrote: > > On Mon, Oct 29, 2018 at 4:06 PM Adel Atallah wrote: > > > Hello Simon, > > > > On Mon, Oct 29, 2018 at 2:59 PM Simon Urli wrote: > > > > > > Hi everyone, > > >

Re: [xwiki-devs] [Brainstorming] Should we merge the 3 xwiki repos: commons, rendering & platform?

2018-11-12 Thread Adel Atallah
Hello, +1 to have a mono repository. Maybe the simplest thing to do would be to create a new repository where the other three are merged, WDYT? Thanks, Adel On Sat, Nov 10, 2018 at 11:58 AM Vincent Massol wrote: > > Some additional notes below. > > > On 10 Nov 2018, at 11:52, Vincent Massol

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-12 Thread Adel Atallah
On Fri, Nov 9, 2018 at 5:35 PM Marius Dumitru Florea wrote: > > On Fri, Nov 9, 2018 at 4:58 PM Adel Atallah wrote: > > > On Fri, Nov 9, 2018 at 12:08 PM Marius Dumitru Florea > > wrote: > > > > > > Try to view the macro parameters listed as a boolean exp

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-13 Thread Adel Atallah
Hello, I'd like to briefly summarize the situation so that we can make some progress. What we have: * We define "parameters" in a macro by creating a Java Bean, which provides all the getters and setters of the parameters we want. * We can use annotations on these getters/setters to define some

Re: [xwiki-devs] [Brainstorming] Should we merge the 3 xwiki repos: commons, rendering & platform?

2018-11-12 Thread Adel Atallah
on of xwiki. As for the "small independent units", aren't components what they are about? > On Mon, Nov 12, 2018 at 11:16 AM Vincent Massol wrote: > > > > > > > > On 12 Nov 2018, at 10:13, Adel Atallah wrote: > > > > > > Hello, > > &g

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-16 Thread Adel Atallah
p({"target", "entityReference"}) @PropertyFeature("reference") reference @PropertyGroup({"target", "entityReference"}) type @PropertyGroup("target") @PropertyFeature("reference") document <<<<<<<<<<

Re: [xwiki-devs] [Proposal] Jobs for the multiple configuration testing

2018-11-07 Thread Adel Atallah
Hello, I'm +1 to try having both jobs. Thanks, Adel On Wed, Nov 7, 2018 at 9:20 AM Vincent Massol wrote: > > Hi Thomas, > > > On 7 Nov 2018, at 08:44, Thomas Mortagne wrote: > > > > On Mon, Nov 5, 2018 at 5:22 PM Vincent Massol wrote: > >> > >> Hi devs, > >> > >> I’m still not sure but FTM I

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-15 Thread Adel Atallah
> > > > > > > > > Thanks > > > > -Vincent > > > > > > > >> > > > >> Thanks, > > > >> Marius > > > >> > > > >> > > > >>> I’d prefer to have some simple annotat

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-15 Thread Adel Atallah
On Thu, Nov 15, 2018 at 11:13 AM Thomas Mortagne wrote: > > On Thu, Nov 15, 2018 at 11:06 AM Adel Atallah wrote: > > > > Ok so it seems like we are getting back to the proposition we made with > > Vincent. > > We need one annotation to enforce the dependence bet

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-15 Thread Adel Atallah
On Thu, Nov 15, 2018 at 1:56 PM Thomas Mortagne wrote: > > On Thu, Nov 15, 2018 at 1:24 PM Adel Atallah wrote: > > > > On Thu, Nov 15, 2018 at 11:13 AM Thomas Mortagne > > wrote: > > > > > > On Thu, Nov 15, 2018 at 11:06 AM Adel Atallah > >

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-09 Thread Adel Atallah
On Fri, Nov 9, 2018 at 11:20 AM Marius Dumitru Florea wrote: > > On Wed, Nov 7, 2018 at 5:34 PM Adel Atallah wrote: > > > Hello everyone, > > > > So what we thought about with Vincent for implementing the "concept of > > aliases or groups" wo

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-09 Thread Adel Atallah
On Fri, Nov 9, 2018 at 11:57 AM Marius Dumitru Florea wrote: > > On Fri, Nov 9, 2018 at 12:29 PM Vincent Massol wrote: > > > Hi, > > > > > On 9 Nov 2018, at 11:20, Marius Dumitru Florea < > > mariusdumitru.flo...@xwiki.com> wrote: > > >

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-07 Thread Adel Atallah
ge" parameter. WDYT? Thanks, Adel On Tue, Sep 25, 2018 at 11:51 AM Marius Dumitru Florea wrote: > > On Wed, Sep 19, 2018 at 4:31 PM Vincent Massol wrote: > > > > > > > > On 19 Sep 2018, at 14:47, Adel Atallah wrote: > > > > > > On Wed, Jul

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-11-09 Thread Adel Atallah
erence AND type 2. Page and Reference are conflicting => (page XOR reference) AND type 3. Type depends on Reference => (page XOR (reference AND type)) WDYT? > > On Fri, Nov 9, 2018 at 12:30 PM Adel Atallah wrote: > > > On Fri, Nov 9, 2018 at 11:20 AM Marius Dumitr

Re: [xwiki-devs] [Proposal] Improve our Test Coverage strategy (TAKE 2)

2018-10-03 Thread Adel Atallah
Hi, I think it's a good idea and +1 to run the job during the night. I hope it won't be too long/difficult to take care of this during an XS release though :). Thanks, Adel On Wed, Oct 3, 2018 at 10:56 AM Vincent Massol wrote: > > Hi devs, > > We started discussing a first global test coverage

Re: [xwiki-devs] [STAMP/Test] Metrics we need to improve + strategy

2018-09-03 Thread Adel Atallah
incent > >> WDYT? >> >> Thanks >> -Vincent >> >>> On 30 Aug 2018, at 12:27, Adel Atallah wrote: >>> >>> Just to be clear, when I proposed "having a whole day dedicated on >>> using these tools", I didn't meant having to

Re: [xwiki-devs] [Proposal] Turn off redirects in page move/rename

2018-09-20 Thread Adel Atallah
+1 but we have to make sure that users will be aware of this change. On Thu, Sep 20, 2018 at 7:30 AM Vincent Massol wrote: > > Hi devs, > > We see more and more wikis with tons of redirects and issues to manage them, > see https://jira.xwiki.org/browse/XWIKI-14570 > > “ > Rationale for turning

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-21 Thread Adel Atallah
+1 for the warning, but I would not forbid simple users from renaming or moving pages but instead just hide the action (from the page menu). On Fri, Sep 21, 2018 at 4:44 PM Simon Urli wrote: > > Hi all, > > users might currently break their AWM application by renaming/moving > pages containing

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-21 Thread Adel Atallah
On Fri, Sep 21, 2018 at 4:56 PM Simon Urli wrote: > > > > On 9/21/18 4:53 PM, Adel Atallah wrote: > > +1 for the warning, but I would not forbid simple users from renaming > > or moving pages but instead just hide the action (from the page menu). > > OK I should

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-24 Thread Adel Atallah
gt; Hi Simon, > >> > >>> On 21 Sep 2018, at 16:58, Simon Urli wrote: > >>> > >>> > >>> > >>> On 9/21/18 4:53 PM, Adel Atallah wrote: > >>>> +1 for the warning, but I would not forbid simple users from renaming > >

Re: [xwiki-devs] [Proposal] Prevent users from renaming/move pages with XClass definition

2018-09-26 Thread Adel Atallah
"copy" action. > > WDYT? > > Simon > > > On 9/25/18 11:36 AM, Vincent Massol wrote: > > Hi Marius, > > > >> On 25 Sep 2018, at 11:34, Marius Dumitru Florea > >> wrote: > >> > >> On Sun, Sep 23, 2018 at 11:12 AM Vincent Masso

Re: [xwiki-devs] [Need proposal] How to show "conflicting" macro parameters

2018-09-19 Thread Adel Atallah
On Wed, Jul 18, 2018 at 5:00 PM Vincent Massol wrote: > > > > > On 5 Jul 2018, at 12:06, Vincent Massol wrote: > > > > > > > >> On 4 Jul 2018, at 12:07, Thomas Mortagne wrote: > >> > >> Here are more details on the actual use case we need to support: > >> > >> In include/Display macro either

Re: [xwiki-devs] [Proposal] Turn off redirects in page move/rename

2018-09-20 Thread Adel Atallah
case. Thanks, Adel On Thu, Sep 20, 2018 at 10:22 AM Vincent Massol wrote: > > > > > On 20 Sep 2018, at 09:54, Adel Atallah wrote: > > > > +1 but we have to make sure that users will be aware of this change. > > What do you suggest? > > IMO having it in

Re: [xwiki-devs] [Brainstorming] Auto-suggestion on space, wiki and attachment xproperties

2018-09-23 Thread Adel Atallah
t seems that XWIKI-15582 corresponds to what Thomas has > suggested, right? Yes. > Sounds good to me. > > Thanks > -Vincent > Thanks, Adel > > On 7 Sep 2018, at 16:45, Adel Atallah wrote: > > > > I've created a Jira issue, I would appreciate to have some feed

[xwiki-devs] [ANN] XWiki 10.8 released

2018-09-24 Thread Adel Atallah
The XWiki development team is proud to announce the availability of XWiki 10.8. This version adds a new tab in the user profile which displays the groups a user is part of, the Menu application is now available in the Administration page, auto-suggestions has been added for pages in several

[xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-17 Thread Adel Atallah
Hi devs, After discussing with Marius and Thomas, we thought it might be a good idea to do the following to have a document picker in the include and display maros: * Remove the deprecation of the document parameter (only for the include macro). * Introduce a new annotation to macro parameters to

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-18 Thread Adel Atallah
On Fri, Jan 18, 2019 at 11:27 AM Vincent Massol wrote: > > Hi Adel, > > > On 17 Jan 2019, at 11:05, Adel Atallah wrote: > > > > Hi devs, > > > > After discussing with Marius and Thomas, we thought it might be a good > > idea to do the follo

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-21 Thread Adel Atallah
On Sat, Jan 19, 2019 at 11:33 AM Vincent Massol wrote: > > Hi Adel, > > > On 18 Jan 2019, at 11:59, Adel Atallah wrote: > > > > On Fri, Jan 18, 2019 at 11:27 AM Vincent Massol wrote: > >> > >> Hi Adel, > >> > >>>

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-21 Thread Adel Atallah
21, 2019 at 9:30 AM Adel Atallah wrote: > > On Sat, Jan 19, 2019 at 11:33 AM Vincent Massol wrote: > > > > Hi Adel, > > > > > On 18 Jan 2019, at 11:59, Adel Atallah wrote: > > > > > > On Fri, Jan 18, 2019 at 11:27 AM Vincent Massol > >

[xwiki-devs] [ANN] XWiki 10.11.1 released

2019-01-15 Thread Adel Atallah
The XWiki development team is proud to announce the availability of XWiki 10.11.1. This is a bugfix release that covers important issues that we have discovered since 10.11 has been released. Make sure to review the release notes:

Re: [xwiki-devs] [Proposal] Document picker in include and display macros

2019-01-23 Thread Adel Atallah
On Wed, Jan 23, 2019 at 11:31 AM Marius Dumitru Florea wrote: > It's not that simple.. If the reference parameter already has a value that > is not a document reference then by showing the document picker that value > will be parsed / resolved as a document reference and thus displayed as if > a

Re: [xwiki-devs] [Proposal] Let contrib committers be JIRA administrators for contrib projects?

2018-12-06 Thread Adel Atallah
On Thu, Dec 6, 2018 at 12:49 PM Vincent Massol wrote: > > Hi devs, > > Stephane Lauriere was asking us to have admin rights for the chartjs contrib > project so that he could do a release. > > Right now only the owner + global jira admins have admin rights. > > I’m proposing to change the

Re: [xwiki-devs] [Proposal] Change of XS Cycle strategy to account for Christmas

2018-12-10 Thread Adel Atallah
Hello, +1 for the proposal. Thanks, Adel On Sun, Dec 9, 2018 at 4:07 PM Vincent Massol wrote: > > Ok, summarizing again after feedback from Simon, Caty and Marius, here’s the > proposal; > > * Duration: 11 minor releases (e.g. N.0 till N.10), one each month, from > January to November. > *

Re: [xwiki-devs] [Proposal] New xwiki-clover-maven repository

2018-11-30 Thread Adel Atallah
+1 as well On Fri, Nov 30, 2018 at 9:11 AM Thomas Mortagne wrote: > > +1 > On Thu, Nov 29, 2018 at 6:41 PM Vincent Massol wrote: > > > > Hi devs, > > > > I’d like to refactor the groovy code that I’ve currently put at > >

Re: [xwiki-devs] [Proposal] WCAG exception: consecutive line breaks

2018-11-21 Thread Adel Atallah
Hello, On Wed, Nov 21, 2018 at 5:36 PM Simon Urli wrote: > > Hi everyone, > > one of the most validation error we have with WCAG is about consecutive > line breaks: basically a presents in a page. > > This happens mostly in our translation pages since the linebreaks in > plain syntax are

Re: [xwiki-devs] [Proposal] Always add a link to the reference doc in the RN items

2018-11-19 Thread Adel Atallah
Hello, +1 to enforce the link to the documentation. We could find a nice way to show the link by adding an icon next to the RN note or put the link on the title for instance. Thanks, Adel On Sun, Nov 18, 2018 at 2:56 PM Vincent Massol wrote: > > Hi devs, > > This is something I mentioned a

Re: [xwiki-devs] [Proposl] Improve JIRA resolution and introduce a "Solved by" resolution

2019-01-10 Thread Adel Atallah
+1 for the proposed solution because you could also have two issues describing a different problem but with the same fix. Thanks, Adel On Thu, Jan 10, 2019 at 1:37 PM Vincent Massol wrote: > > > > > On 10 Jan 2019, at 13:24, Marius Dumitru Florea > > wrote: > > > > On Thu, Jan 10, 2019 at

[xwiki-devs] Hibernate upgrade

2019-01-07 Thread Adel Atallah
Hi devs, As you may know, we are currently using a pretty old version of Hibernate in XWiki and we could benefit from its upgrade. The new version should bring many bug and security fixes (even though they don't all apply to our current version) along with better APIs and the possibility to