Re: [PULL] topic/hdr-formats
Hey, Op 07-03-2019 om 18:12 schreef Adam Jackson: > On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote: >> Hi Sean and Joonas, >> >> Here's a pull request for HDR format enabling in i915. Can this be pulled to >> drm-misc-next and dinq? > Could you also add Kevin Strasser's patch for FP16 formats? For that > matter I'd like to see FP32 added too, but I don't think there's been a > patch sent for that yet. Added kevin to CC. Is the mesa side considered completely reviewed then? If so, I wouldn't mind sending a second pull req for fp16 support this week. ~Maarten ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PATCH 0/4] dim setup improvements
On Mon, Mar 04, 2019 at 03:07:38PM -0800, Lucas De Marchi wrote: > On Mon, Mar 04, 2019 at 11:12:21PM +0200, Jani Nikula wrote: > > On Mon, 04 Mar 2019, Lucas De Marchi wrote: > > > We had some small problems when calling dim setup. This should > > > hopefully fix them all, making it easier to setup a new environment > > > like I was doing. > > > > > > Now setting up the environment from scratch has a bigger chance of > > > working. Maybe we can update the docs with something like: > > > > > > curl -O \ > > > https://gitlab.freedesktop.org/drm/maintainer-tools/raw/master/dim > > > > ~/bin/dim > > > chmod +x ~/bin/dim > > > DIM_PREFIX=/path/to/setup/the/project dim setup > > > > > > I think the documentation should be to start by cloning the > > maintainer-tools repo, and continue from there. > > yeah, as long as that's done inside DIM_PREFIX, it should be good. > > Documentation idea: > > export DIM_PREFIX=/path/to/setup/the/project I'd start with .dimrc and putting your path in there instead of this. But this works too I guess, a bit a bikeshed. > cd $DIM_PREFIX > git clone https://gitlab.freedesktop.org/drm/maintainer-tools.git > ./maintainer-tools/dim setup > > After that mention the .dimrc in which some customizations can be made, > including the DIM_PREFIX above, as well as keeping the maintainer-tools > on PATH (although lately I'm just calling ../maintainer-tools/dim) Yeah makes sense, and more what we've been aiming for than your patch 4. On patches 1-3: Acked-by: Daniel Vetter Not sure what to do with patch 4 ... > I also miss a --non-interactive or the like so dim doesn't keep asking > me questions about the name of the remotes. Sounds like a good idea. Making it a global dim option is probably simplest, and makes sense. We could then have a small wrapper function, for consistency and reuse (like we have with warn_or_fail, maybe ask_user_default or something like that). -Daniel > > Lucas De Marchi > > > > > BR, > > Jani. > > > > > > > > Another thing we may want to improve: add a --no-interactive or change > > > the default behavior so dim just do the right thing without asking. > > > Thoughts? > > > > > > Lucas De Marchi (4): > > > dim: clone in the right dir > > > dim: do all setup relative to $DIM_PREFIX > > > dim: update branches after setup > > > dim: automatically clone maintainer-tools repo > > > > > > dim | 32 +++- > > > 1 file changed, 19 insertions(+), 13 deletions(-) > > > > -- > > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] topic/hdr-formats
Quoting Maarten Lankhorst (2019-03-07 11:48:24) > Hi Sean and Joonas, > > Here's a pull request for HDR format enabling in i915. Can this be pulled to > drm-misc-next and dinq? I was travelling on Fri, so sorry for delay. This is now pulled to dinq, too. Regards, Joonas > > Cheers, > Maarten > > topic/hdr-formats-2019-03-07: > Add support for Y21x and Y41x to drm core and i915, and P01x support to i915. > The following changes since commit 4b057e73f28f1df13b77b77a52094238ffdf8abd: > > Merge tag 'drm-misc-fixes-2019-02-22' of > git://anongit.freedesktop.org/drm/drm-misc into drm-next (2019-03-05 08:14:22 > +1000) > > are available in the Git repository at: > > git://anongit.freedesktop.org/drm/drm-misc tags/topic/hdr-formats-2019-03-07 > > for you to fetch changes up to 296e9b19eff6157e1e4f130fa436e105c45725e9: > > drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for universal > planes (2019-03-05 12:49:00 +0100) > > > Add support for Y21x and Y41x to drm core and i915, and P01x support to i915. > > > Juha-Pekka Heikkila (3): > drm/i915: Add P010, P012, P016 plane control definitions > drm/i915: Preparations for enabling P010, P012, P016 formats > drm/i915: Enable P010, P012, P016 formats for primary and sprite planes > > Swati Sharma (3): > drm: Add Y2xx and Y4xx (xx:10/12/16) format definitions and fourcc > drm/i915/icl: Add Y2xx and Y4xx (xx:10/12/16) plane control definitions > drm/i915/icl: Enabling Y2xx and Y4xx (xx:10/12/16) formats for > universal planes > > drivers/gpu/drm/drm_fourcc.c | 6 ++ > drivers/gpu/drm/i915/i915_reg.h | 9 +++ > drivers/gpu/drm/i915/intel_atomic_plane.c | 2 +- > drivers/gpu/drm/i915/intel_display.c | 57 ++-- > drivers/gpu/drm/i915/intel_drv.h | 1 + > drivers/gpu/drm/i915/intel_pm.c | 14 ++-- > drivers/gpu/drm/i915/intel_sprite.c | 108 > -- > include/uapi/drm/drm_fourcc.h | 16 + > 8 files changed, 194 insertions(+), 19 deletions(-) ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PATCH 0/4] dim setup improvements
On Mon, Mar 11, 2019 at 12:08:42PM +0100, Daniel Vetter wrote: On Mon, Mar 04, 2019 at 03:07:38PM -0800, Lucas De Marchi wrote: On Mon, Mar 04, 2019 at 11:12:21PM +0200, Jani Nikula wrote: > On Mon, 04 Mar 2019, Lucas De Marchi wrote: > > We had some small problems when calling dim setup. This should > > hopefully fix them all, making it easier to setup a new environment > > like I was doing. > > > > Now setting up the environment from scratch has a bigger chance of > > working. Maybe we can update the docs with something like: > > > > curl -O \ > > https://gitlab.freedesktop.org/drm/maintainer-tools/raw/master/dim > ~/bin/dim > > chmod +x ~/bin/dim > > DIM_PREFIX=/path/to/setup/the/project dim setup > > > I think the documentation should be to start by cloning the > maintainer-tools repo, and continue from there. yeah, as long as that's done inside DIM_PREFIX, it should be good. Documentation idea: export DIM_PREFIX=/path/to/setup/the/project I'd start with .dimrc and putting your path in there instead of this. But this works too I guess, a bit a bikeshed. have you seen the update to the docs I sent? cd $DIM_PREFIX git clone https://gitlab.freedesktop.org/drm/maintainer-tools.git ./maintainer-tools/dim setup After that mention the .dimrc in which some customizations can be made, including the DIM_PREFIX above, as well as keeping the maintainer-tools on PATH (although lately I'm just calling ../maintainer-tools/dim) Yeah makes sense, and more what we've been aiming for than your patch 4. On patches 1-3: Acked-by: Daniel Vetter thanks Not sure what to do with patch 4 ... I think it makes no harm and covers the case maintainer-tools is not there. But it may be a bad option if the user is calling dim from elsewhere. Lucas De Marchi I also miss a --non-interactive or the like so dim doesn't keep asking me questions about the name of the remotes. Sounds like a good idea. Making it a global dim option is probably simplest, and makes sense. We could then have a small wrapper function, for consistency and reuse (like we have with warn_or_fail, maybe ask_user_default or something like that). -Daniel Lucas De Marchi > > BR, > Jani. > > > > > Another thing we may want to improve: add a --no-interactive or change > > the default behavior so dim just do the right thing without asking. > > Thoughts? > > > > Lucas De Marchi (4): > > dim: clone in the right dir > > dim: do all setup relative to $DIM_PREFIX > > dim: update branches after setup > > dim: automatically clone maintainer-tools repo > > > > dim | 32 +++- > > 1 file changed, 19 insertions(+), 13 deletions(-) > > -- > Jani Nikula, Intel Open Source Graphics Center -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] topic/hdr-formats
On Mon, 2019-03-11 at 12:19 +0100, Maarten Lankhorst wrote: > Hey, > > Op 07-03-2019 om 18:12 schreef Adam Jackson: > > On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote: > > > Hi Sean and Joonas, > > > > > > Here's a pull request for HDR format enabling in i915. Can this be pulled > > > to drm-misc-next and dinq? > > Could you also add Kevin Strasser's patch for FP16 formats? For that > > matter I'd like to see FP32 added too, but I don't think there's been a > > patch sent for that yet. > > Added kevin to CC. > > Is the mesa side considered completely reviewed then? Is that strictly necessary for just adding a fourcc? I get wanting to see a real userspace consumer first, but this is just allocating some magic numbers not promising that a certain ioctl behaves a certain way. That said, I did say r-b for the Mesa series as a whole. Daniel Stone had some comments on 13/13 that made it sound like it (that specific patch) was unnecessary/undesirable, but everything before that looked great to me, and even if we only merged the first 12 we'd still have FP16 wired through for the gbm EGL platform, meaning HDR scanout could actually be a thing. - ajax ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
Re: [PULL] topic/hdr-formats
On Mon, Mar 11, 2019 at 01:52:13PM -0400, Adam Jackson wrote: > On Mon, 2019-03-11 at 12:19 +0100, Maarten Lankhorst wrote: > > Hey, > > > > Op 07-03-2019 om 18:12 schreef Adam Jackson: > > > On Thu, 2019-03-07 at 10:48 +0100, Maarten Lankhorst wrote: > > > > Hi Sean and Joonas, > > > > > > > > Here's a pull request for HDR format enabling in i915. Can this be > > > > pulled to drm-misc-next and dinq? > > > Could you also add Kevin Strasser's patch for FP16 formats? For that > > > matter I'd like to see FP32 added too, but I don't think there's been a > > > patch sent for that yet. > > > > Added kevin to CC. > > > > Is the mesa side considered completely reviewed then? > > Is that strictly necessary for just adding a fourcc? I get wanting to > see a real userspace consumer first, but this is just allocating some > magic numbers not promising that a certain ioctl behaves a certain way. It's a bit a grey area, since uapi/drm/drm_fourcc.h is both a simple magic number registry for userspace and also the source of truth for what that's supposed to mean for AddFB. Which is uapi. Having the full mesa->kms pipeline gives a bit more assurance we didn't flip something somewhere by accident or some other silliness. So for i915.ko stuff we've been pretty strict with this, just to make sure we don't ship broken stuff. But we definitely merged other patches without anything being able to consume/produce those formats in userspace (well anything open source at least), fitting the magic number registry. Imo this is an area each driver team can decide on how they want to handle it (with my maintainer hat on). -Daniel > > That said, I did say r-b for the Mesa series as a whole. Daniel Stone > had some comments on 13/13 that made it sound like it (that specific > patch) was unnecessary/undesirable, but everything before that looked > great to me, and even if we only merged the first 12 we'd still have > FP16 wired through for the gbm EGL platform, meaning HDR scanout could > actually be a thing. > > - ajax > > ___ > dim-tools mailing list > dim-tools@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dim-tools -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dim-tools mailing list dim-tools@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dim-tools
