Re: [Snowdrift-discuss] git.snowdrift.coop login: Permit GitHub OAuth?
On Fri, Jun 30, 2017 at 04:11:46AM -0700, voyager...@gmail.com wrote: > Sorry to be late to the thread. I know we're only talking about the > repository and not the main site, but any chance of supporting open > id for authentication? I use it to log into stackexchange and have > been quite pleased by it... Unfortunately, OpenId is not listed as an option. I feel like there's some reason we wouldn't want to use it anyway, but I don't remember what that would be... ? signature.asc Description: Digital signature ___ Discuss mailing list Discuss@lists.snowdrift.coop https://lists.snowdrift.coop/mailman/listinfo/discuss
Re: [Snowdrift-discuss] git.snowdrift.coop login: Permit GitHub OAuth?
Sorry to be late to the thread. I know we're only talking about the repository and not the main site, but any chance of supporting open id for authentication? I use it to log into stackexchange and have been quite pleased by it... Sent from my iPhone > On Jun 29, 2017, at 10:52 AM, Bryan Richter wrote: > > On Thu, Jun 29, 2017 at 01:53:23PM +0200, Robert Martinez (mray) > wrote: > On 06/28/2017 02:04 PM, Bryan Richter wrote: While poking around the admin panel for git.snowdrift.coop's githost account, I found that I can enable GitHub OAuth. I've already turned it on as an experiment. Should we leave it on? >> >> I feel we should not jump to so many hoops to turn our back on >> github but then stick their logo on our gitlab repo anyway. >> >> If catering to "lazy" devs is important I'm ok with treating github >> as a second class citizen. So the "Sign in with *GITHUBLOGO*" could >> be a textual note only. >> >> I created a realted issue that shows what I would have in mind: >> https://git.snowdrift.coop/sd/design/issues/10 > > I ignore images and look for text. You do the opposite. ;) > > You're right, though. And since we don't have the control to make that > page look as you have suggested, I have simply *turned OAuth off*. > > (The only part of that page we can adjust is the space under the > logo.) > ___ > Discuss mailing list > Discuss@lists.snowdrift.coop > https://lists.snowdrift.coop/mailman/listinfo/discuss ___ Discuss mailing list Discuss@lists.snowdrift.coop https://lists.snowdrift.coop/mailman/listinfo/discuss
Re: [Snowdrift-discuss] git.snowdrift.coop login: Permit GitHub OAuth?
On Thu, Jun 29, 2017 at 01:53:23PM +0200, Robert Martinez (mray) wrote: > > On 06/28/2017 02:04 PM, Bryan Richter wrote: > > > >> While poking around the admin panel for git.snowdrift.coop's > >> githost account, I found that I can enable GitHub OAuth. > >> > >> I've already turned it on as an experiment. Should we leave it > >> on? > > I feel we should not jump to so many hoops to turn our back on > github but then stick their logo on our gitlab repo anyway. > > If catering to "lazy" devs is important I'm ok with treating github > as a second class citizen. So the "Sign in with *GITHUBLOGO*" could > be a textual note only. > > I created a realted issue that shows what I would have in mind: > https://git.snowdrift.coop/sd/design/issues/10 I ignore images and look for text. You do the opposite. ;) You're right, though. And since we don't have the control to make that page look as you have suggested, I have simply *turned OAuth off*. (The only part of that page we can adjust is the space under the logo.) signature.asc Description: Digital signature ___ Discuss mailing list Discuss@lists.snowdrift.coop https://lists.snowdrift.coop/mailman/listinfo/discuss
Re: [Snowdrift-discuss] git.snowdrift.coop login: Permit GitHub OAuth?
On 28.06.2017 23:51, Aaron Wolf wrote: > On 06/28/2017 02:04 PM, Bryan Richter wrote: >> While poking around the admin panel for git.snowdrift.coop's githost >> account, I found that I can enable GitHub OAuth. >> >> I've already turned it on as an experiment. Should we leave it on? >> >> Pros: >> >> - New devs, who probably already have GitHub accounts, can easily >> create an account on git.snowdrift.coop. Less friction. >> >> Cons: >> >> - GitHub knows when these people sign in to git.snowdrift.coop. >> >> - OAuth login is not compatible with two-factor auth. >> >> I think the pros outweigh the cons. Creating an account is the "hard" >> part... enabling passphrase login and two-factor auth can be done >> later. >> >> I have put a message listing the cons on the login page. You can see >> it quickly by viewing https://git.snowdrift.coop/users/sign_in in a >> private/incognito window. >> >> Any thoughts or feedback? >> >> P.S. Amusingly, we can also use git.snowdrift.coop *as an OAuth >> provider*, if we wanted to use it to log in to other sites... >> >> > > Interesting. Anyone making commits that get to master will be mirrored > to GitHub anyway. Anyone who cares about being free of GitHub can still > do that. > > I think that allowing it with qualifications and not treating it as the > default sounds good. I would object to Facebook or something like that > because (well, not sure that's OAuth even) Facebook is a more deeply > horrible company. GitHub is at the level where I like acknowledging > known issues and then maximizing participation from both of two groups: > those who would be upset at us fully embracing GitHub (like just using > GitHub directly) and those who will be turned off by barriers to entry > (such as not using GitHub directly). > > I think qualified GitHub OAuth is an excellent balance. > > > I feel we should not jump to so many hoops to turn our back on github but then stick their logo on our gitlab repo anyway. If catering to "lazy" devs is important I'm ok with treating github as a second class citizen. So the "Sign in with *GITHUBLOGO*" could be a textual note only. I created a realted issue that shows what I would have in mind: https://git.snowdrift.coop/sd/design/issues/10 signature.asc Description: OpenPGP digital signature ___ Discuss mailing list Discuss@lists.snowdrift.coop https://lists.snowdrift.coop/mailman/listinfo/discuss
Re: [Snowdrift-discuss] git.snowdrift.coop login: Permit GitHub OAuth?
> "GitHub is a non-FLO service, so we emphasize using direct log-in with > email even though the GitHub login may be more convenient." Provided that's there, it's okay with me :-) ___ Discuss mailing list Discuss@lists.snowdrift.coop https://lists.snowdrift.coop/mailman/listinfo/discuss
Re: [Snowdrift-discuss] git.snowdrift.coop login: Permit GitHub OAuth?
On 06/28/2017 03:53 PM, Alyssa Rosenzweig wrote: > Hrm. This could be interpreted as endorsing proprietary software... > ___ > Discuss mailing list > Discuss@lists.snowdrift.coop > https://lists.snowdrift.coop/mailman/listinfo/discuss > If the wording of the qualification sounds like an endorsement, then the qualification wording should be improved to emphasize that we do NOT endorse the GitHub approach, even though we'll allow it. Perhaps something like: "GitHub is a non-FLO service, so we emphasize using direct log-in with email even though the GitHub login may be more convenient." signature.asc Description: OpenPGP digital signature ___ Discuss mailing list Discuss@lists.snowdrift.coop https://lists.snowdrift.coop/mailman/listinfo/discuss
Re: [Snowdrift-discuss] git.snowdrift.coop login: Permit GitHub OAuth?
Hrm. This could be interpreted as endorsing proprietary software... ___ Discuss mailing list Discuss@lists.snowdrift.coop https://lists.snowdrift.coop/mailman/listinfo/discuss
Re: [Snowdrift-discuss] git.snowdrift.coop login: Permit GitHub OAuth?
On Wed, Jun 28, 2017 at 02:36:41PM -0700, Alyssa Rosenzweig wrote: > Does GitHub OAuth work with JavaScript disabled? Nope, but I suspect regular ol' logins still work. :) OAuth is just an alternative shown under the password/login form, which hasn't changed. signature.asc Description: Digital signature ___ Discuss mailing list Discuss@lists.snowdrift.coop https://lists.snowdrift.coop/mailman/listinfo/discuss
Re: [Snowdrift-discuss] git.snowdrift.coop login: Permit GitHub OAuth?
On 06/28/2017 02:04 PM, Bryan Richter wrote: > While poking around the admin panel for git.snowdrift.coop's githost > account, I found that I can enable GitHub OAuth. > > I've already turned it on as an experiment. Should we leave it on? > > Pros: > > - New devs, who probably already have GitHub accounts, can easily > create an account on git.snowdrift.coop. Less friction. > > Cons: > > - GitHub knows when these people sign in to git.snowdrift.coop. > > - OAuth login is not compatible with two-factor auth. > > I think the pros outweigh the cons. Creating an account is the "hard" > part... enabling passphrase login and two-factor auth can be done > later. > > I have put a message listing the cons on the login page. You can see > it quickly by viewing https://git.snowdrift.coop/users/sign_in in a > private/incognito window. > > Any thoughts or feedback? > > P.S. Amusingly, we can also use git.snowdrift.coop *as an OAuth > provider*, if we wanted to use it to log in to other sites... > > Interesting. Anyone making commits that get to master will be mirrored to GitHub anyway. Anyone who cares about being free of GitHub can still do that. I think that allowing it with qualifications and not treating it as the default sounds good. I would object to Facebook or something like that because (well, not sure that's OAuth even) Facebook is a more deeply horrible company. GitHub is at the level where I like acknowledging known issues and then maximizing participation from both of two groups: those who would be upset at us fully embracing GitHub (like just using GitHub directly) and those who will be turned off by barriers to entry (such as not using GitHub directly). I think qualified GitHub OAuth is an excellent balance. signature.asc Description: OpenPGP digital signature ___ Discuss mailing list Discuss@lists.snowdrift.coop https://lists.snowdrift.coop/mailman/listinfo/discuss
Re: [Snowdrift-discuss] git.snowdrift.coop login: Permit GitHub OAuth?
Does GitHub OAuth work with JavaScript disabled? ___ Discuss mailing list Discuss@lists.snowdrift.coop https://lists.snowdrift.coop/mailman/listinfo/discuss
