Re: Help needed with X-Forwarded-For

2007-09-21 Thread Ian Holsman
Leo Soto M. wrote: > On 9/20/07, Deryck Hodge <[EMAIL PROTECTED]> wrote: > >> I completely agree you shouldn't use this middleware unless you know >> and trust the proxy setup, but I can easily imagine (large corporate >> networks) a situation where there could be multiple proxies. Seems to

Re: More separation between admin and models

2007-09-21 Thread Yuri Baburov
2007/9/22, James Bennett <[EMAIL PROTECTED]>: > > On 9/21/07, Yuri Baburov <[EMAIL PROTECTED]> wrote: > > Please, read my whole post. > > I don't want to create my own implementation of filters. > > I don't want to create my own implementation of changelist sorting. > > etc. > > If you don't need

Re: More separation between admin and models

2007-09-21 Thread Yuri Baburov
> On 9/21/07, Yuri Baburov <[EMAIL PROTECTED]> wrote: > > I like newforms-admin very much, because it's customizeable. > > But now imagine that you have 10 usual models in admin interface, but > > 11th needs to be special. > > One possible example: you need to show, how much LogEntries for each >

Re: More separation between admin and models

2007-09-21 Thread James Bennett
On 9/21/07, Yuri Baburov <[EMAIL PROTECTED]> wrote: > Please, read my whole post. > I don't want to create my own implementation of filters. > I don't want to create my own implementation of changelist sorting. > etc. If you don't need a custom implementation of those bits, don't write custom

Re: force_unicode(strings_only) and DateTime objects

2007-09-21 Thread Malcolm Tredinnick
On Sat, 2007-09-22 at 01:24 +0800, Russell Keith-Magee wrote: > Hi all, > > I've been looking at #5553 [1] tonight; it looks to be a good patch to > fix some Datetime serialization issues that have arisen recently. > > [1] http://code.djangoproject.com/ticket/5553 > > It's a fairly small

Re: More separation between admin and models

2007-09-21 Thread Yuri Baburov
2007/9/22, James Bennett <[EMAIL PROTECTED]>: > > On 9/21/07, Yuri Baburov <[EMAIL PROTECTED]> wrote: > > I like newforms-admin very much, because it's customizeable. > > But now imagine that you have 10 usual models in admin interface, but > > 11th needs to be special. > > One possible example:

Re: More separation between admin and models

2007-09-21 Thread James Bennett
On 9/21/07, Yuri Baburov <[EMAIL PROTECTED]> wrote: > I like newforms-admin very much, because it's customizeable. > But now imagine that you have 10 usual models in admin interface, but > 11th needs to be special. > One possible example: you need to show, how much LogEntries for each > model was

More separation between admin and models

2007-09-21 Thread Yuri Baburov
Hi All, I like newforms-admin very much, because it's customizeable. But now imagine that you have 10 usual models in admin interface, but 11th needs to be special. One possible example: you need to show, how much LogEntries for each model was created by each user for some date interval. What

Re: Some concerns about [6399]

2007-09-21 Thread Brian Harring
On Fri, Sep 21, 2007 at 09:43:26PM -0500, James Bennett wrote: > > While I'm all in favor of faster template variable resolution, I've > been poking at the new Variable class and noticed that the patch was > apparently never updated for a post-Unicode Django; in some fairly > simple tests I've

Re: Ticket #5516 / Changeset 6400

2007-09-21 Thread Russell Keith-Magee
On 9/22/07, Todd O'Bryan <[EMAIL PROTECTED]> wrote: > > I have a couple of reservations about the version of app commands that > got committed and just wanted to bring them up here. ... > I'm worried that we're setting ourselves up for two things: > 1. Name collisions. > 2. Command confusion. I

Some concerns about [6399]

2007-09-21 Thread James Bennett
While I'm all in favor of faster template variable resolution, I've been poking at the new Variable class and noticed that the patch was apparently never updated for a post-Unicode Django; in some fairly simple tests I've been able to break it pretty badly by passing in Unicode strings and

Re: Discussion for #5446

2007-09-21 Thread Malcolm Tredinnick
On Sat, 2007-09-22 at 01:35 +, [EMAIL PROTECTED] wrote: > Ticket 5446 discusses some ideas for putting more international > country data into Django. The ticket is here - > http://code.djangoproject.com/ticket/5446 > > The last comment is a request to bring to this list for comment. So, >

Fwd: Ticket #5516 / Changeset 6400

2007-09-21 Thread Todd O'Bryan
I have a couple of reservations about the version of app commands that got committed and just wanted to bring them up here. In my original patch you had to use the following form for app-supplied commands: $ django-admin.py app_name.command I also separated out the help contents by app so that

Re: trunk broken since [6402]

2007-09-21 Thread Malcolm Tredinnick
On Sat, 2007-09-22 at 09:17 +0800, Russell Keith-Magee wrote: > On 9/22/07, Michael Radziej <[EMAIL PROTECTED]> wrote: [...] > > BTW, wouldn't it be nice (TM) if new commits first went to side branch and > > only get committed to trunk after the buildbot has given green light? I have > > no idea

Discussion for #5446

2007-09-21 Thread [EMAIL PROTECTED]
Ticket 5446 discusses some ideas for putting more international country data into Django. The ticket is here - http://code.djangoproject.com/ticket/5446 The last comment is a request to bring to this list for comment. So, here I am ;) The gist is that this is a request to add some

Re: trunk broken since [6402]

2007-09-21 Thread Michael Radziej
On Sat, Sep 22, Russell Keith-Magee wrote: > It is probably worth opening a ticket so that this idea doesn't get > forgotten. #5571 G'night! Michael -- noris network AG - Deutschherrnstraße 15-19 - D-90429 Nürnberg - Tel +49-911-9352-0 - Fax +49-911-9352-100 http://www.noris.de - The

Re: About convenience of caching contenttypes in generic relations

2007-09-21 Thread msaelices
On 22 sep, 03:21, Michael Radziej <[EMAIL PROTECTED]> wrote: > On Fri, Sep 21, msaelices wrote: > > > You don't see well the code. > > Oh, you're right! > > I better stop triaging and go to bed now ;-) Good night. I do the same (It's 3:26AM) :-( > > To quote Malcolm: Sorry for the unconvenience

Re: About convenience of caching contenttypes in generic relations

2007-09-21 Thread Michael Radziej
On Fri, Sep 21, msaelices wrote: > > You don't see well the code. Oh, you're right! I better stop triaging and go to bed now ;-) To quote Malcolm: Sorry for the unconvenience ;-) Michael -- noris network AG - Deutschherrnstraße 15-19 - D-90429 Nürnberg - Tel +49-911-9352-0 - Fax

Re: trunk broken since [6402]

2007-09-21 Thread Russell Keith-Magee
On 9/22/07, Michael Radziej <[EMAIL PROTECTED]> wrote: > > On Sat, Sep 22, Russell Keith-Magee wrote: > > > Sorry for the inconvienience. > > Oh come on ... go ahead and let's have a bit more of these buglets, so that > the rest of us feel less bad for proposing wrong patches ;-) Oh... ok then.

Re: #4796 - Needs an expert's eye.

2007-09-21 Thread Malcolm Tredinnick
On Fri, 2007-09-21 at 22:43 +, Andrew Durdin wrote: > I was looking into #4796, and submitted a patch that fixes the error > -- and I'm fairly sure that it fixes it in the appropriate spot. > However, I didn't quite grok the runtime interaction between the > __proxy__ objects and the

Re: About convenience of caching contenttypes in generic relations

2007-09-21 Thread msaelices
You don't see well the code. The code does caching of django_contenttype table like the other file. It reduces by caching this SQL sentence: obj1.related_object select * from django_content_types where id = 4 ---> a content type for one relationship select * from myapp_mytable where id = 27 --->

Re: trunk broken since [6402]

2007-09-21 Thread Russell Keith-Magee
On 9/22/07, Michael Radziej <[EMAIL PROTECTED]> wrote: > > Hi, > > would be nice if a commit could clean up the current trunk, there's a > trivial typo. See ticket #5569 Fixed in [6404]. Sorry for the inconvienience. Yours Russ Magee %-) --~--~-~--~~~---~--~~

Re: About convenience of caching contenttypes in generic relations

2007-09-21 Thread Michael Radziej
On Fri, Sep 21, msaelices wrote: > > I have uploaded a patch for improve generic relations performance: > >http://code.djangoproject.com/ticket/5570 > > But mir closed my ticket because it think patch is not convenient. > > I think there are a lot of files with same type of caching. I

Tutorial wiki broken: Failed to load TOC proccessor

2007-09-21 Thread msaelices
The problem is the [[TOC]] proccessor situated on top: http://code.djangoproject.com/wiki/Tutorials --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to

About convenience of caching contenttypes in generic relations

2007-09-21 Thread msaelices
I have uploaded a patch for improve generic relations performance: http://code.djangoproject.com/ticket/5570 But mir closed my ticket because it think patch is not convenient. I think there are a lot of files with same type of caching. I don't use django cache framework. I use a simple

trunk broken since [6402]

2007-09-21 Thread Michael Radziej
Hi, would be nice if a commit could clean up the current trunk, there's a trivial typo. See ticket #5569 http://code.djangoproject.com/ticket/5569 Michael -- noris network AG - Deutschherrnstraße 15-19 - D-90429 Nürnberg - Tel +49-911-9352-0 - Fax +49-911-9352-100 http://www.noris.de - The

#4796 - Needs an expert's eye.

2007-09-21 Thread Andrew Durdin
I was looking into #4796, and submitted a patch that fixes the error -- and I'm fairly sure that it fixes it in the appropriate spot. However, I didn't quite grok the runtime interaction between the __proxy__ objects and the delayed_loader function, so I'd appreciate it if someone else could cast

Re: Visual recognition of Django website

2007-09-21 Thread Adam Fast
I'm +1 as well, I think it will be handy. On 9/21/07, Jan Oberst <[EMAIL PROTECTED]> wrote: > > > On Sep 21, 10:29 pm, Matt Boersma <[EMAIL PROTECTED]> wrote: > > On Sep 21, 2007, at 2:22 PM, SmileyChris <[EMAIL PROTECTED]> wrote: > > > > > > > > > On Sep 19, 11:44 pm, Ned Batchelder <[EMAIL

Re: Visual recognition of Django website

2007-09-21 Thread Jan Oberst
On Sep 21, 10:29 pm, Matt Boersma <[EMAIL PROTECTED]> wrote: > On Sep 21, 2007, at 2:22 PM, SmileyChris <[EMAIL PROTECTED]> wrote: > > > > > On Sep 19, 11:44 pm, Ned Batchelder <[EMAIL PROTECTED]> wrote: > >> Now we just need to get someone to put it on the site... > > > +1. Easy to do, looks

Re: Visual recognition of Django website

2007-09-21 Thread Matt Boersma
On Sep 21, 2007, at 2:22 PM, SmileyChris <[EMAIL PROTECTED]> wrote: > > On Sep 19, 11:44 pm, Ned Batchelder <[EMAIL PROTECTED]> wrote: >> Now we just need to get someone to put it on the site... > > +1. Easy to do, looks good. +1. It's excellent.

MEDIA_URL and trailing slash (documentation)

2007-09-21 Thread SmileyChris
Currently the docs [1] say "Note that this should have a trailing slash if it has a path component." Common use is now href="{{ MEDIA_URL }}images/a.png" so it seems to me like you should *always* put a trailing slash in, whether there is a path component or not. Am I missing something? [1]

Re: Visual recognition of Django website

2007-09-21 Thread SmileyChris
On Sep 19, 11:44 pm, Ned Batchelder <[EMAIL PROTECTED]> wrote: > Now we just need to get someone to put it on the site... +1. Easy to do, looks good. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Django

Re: Visual recognition of Django website

2007-09-21 Thread Marcus
I absolutely agree; I think Ned's icon looks great. A favicon would make the Django site more professional, and that cannot be a bad thing. On Sep 19, 6:44 am, Ned Batchelder <[EMAIL PROTECTED]> wrote: > I agree that a favicon is one of those fit-and-finish touches that helps > complete a

force_unicode(strings_only) and DateTime objects

2007-09-21 Thread Russell Keith-Magee
Hi all, I've been looking at #5553 [1] tonight; it looks to be a good patch to fix some Datetime serialization issues that have arisen recently. [1] http://code.djangoproject.com/ticket/5553 It's a fairly small change, but I'm still coming to terms with the finer points of the unicode changes,

Re: Help needed with X-Forwarded-For

2007-09-21 Thread Leo Soto M.
On 9/21/07, Deryck Hodge <[EMAIL PROTECTED]> wrote: [...] > Of course, this is straying a bit from the original topic. I still > think the middleware as reverted by Jacob is correct. Whether or not > you trust REMOTE_ADDR to be the actual client IP after using the > middleware is a matter of

Re: django on jython (new version)?

2007-09-21 Thread Leo Soto M.
On 9/21/07, Tristan King <[EMAIL PROTECTED]> wrote: > Ok I've been working on the problem quoted at the end of this email and have > come up with a solution. but i'm not sure what to make of it. [...] > My question is. Why, if in CPython object.__unicode__ doesn't exist, why > does it in

Re: django on jython (new version)?

2007-09-21 Thread Tristan King
Ok I've been working on the problem quoted at the end of this email and have come up with a solution. but i'm not sure what to make of it. Poll extends from Model and does not implement __str__ or __unicode__, but inherits __str__ from Model, which calls __unicode__, and __unicode__ from object.

Re: Help needed with X-Forwarded-For

2007-09-21 Thread Deryck Hodge
On 9/20/07, Chris Bennett <[EMAIL PROTECTED]> wrote: > > As an aside, is anyone talking about seriously using this for access > control? We've established that using X-F-F is a bad idea for that, in > fact, I'd say that even known REMOTE_ADDR based auth is a bad idea, so > why does it matter

Re: Help needed with X-Forwarded-For

2007-09-21 Thread Deryck Hodge
On 9/20/07, Leo Soto M. <[EMAIL PROTECTED]> wrote: > > On 9/20/07, Deryck Hodge <[EMAIL PROTECTED]> wrote: > > > > A quick Google search turns up that this is indeed easily configurable > > for both Squid and mod_proxy and the defaults look sane. > > What are those defaults?. > > My google-foo is

Re: 0.96.1 / 096-bugfixes

2007-09-21 Thread Malcolm Tredinnick
On Fri, 2007-09-21 at 12:47 +, Philippe Raoult wrote: > I was wondering why there is no 096-bugfixes branch. Does that reflect > a policy change since previous versions ? Well, the policy is that the -bugfixes branch was for security fixes only. We haven't had to do a security release yet

0.96.1 / 096-bugfixes

2007-09-21 Thread Philippe Raoult
I was wondering why there is no 096-bugfixes branch. Does that reflect a policy change since previous versions ? Since 0.97 looks pretty far away with all the merging waiting to happen (queryset-refactor & newforms-admin at least), would it make sense to backport a few bugfixes and maybe a couple

Re: A thought about temples and escaping

2007-09-21 Thread Malcolm Tredinnick
On Fri, 2007-09-21 at 05:22 -0700, [EMAIL PROTECTED] wrote: > Hi all. I'll first state that I'm not a django developer (my only > patch was rejected and that's sad, cause I've learned python only to > make it :( ). Yet I like django, I have started to work with it, for > some experiments, and

A thought about temples and escaping

2007-09-21 Thread [EMAIL PROTECTED]
Hi all. I'll first state that I'm not a django developer (my only patch was rejected and that's sad, cause I've learned python only to make it :( ). Yet I like django, I have started to work with it, for some experiments, and came to think of something wrong with the way the templates work, or