Re: Ticket 13023: Admin inlines, max_num, and extra

2010-03-16 Thread Gabriel Hurley
Thanks for the IRC log, Ivan. That offers some perspective. Ideally a complete solution would have the following characteristics: 1. Makes behavior consistent with or without Javascript enabled. I personally would argue against any solution that caused extra and max_num to have different effects

Re: Ticket 13023: Admin inlines, max_num, and extra

2010-03-16 Thread Iván Raskovsky
Hi Gabriel, here's a follow up after I asked in django-dev if I should file the ticket: http://botland.oebfare.com/logger/django-dev/2010/3/4/1/ Unfortunately I can't find my original conversation. One thing that might be important to take into consideration is that without the patch users

Re: Deprecating cmemcache, adding pylibmc

2010-03-16 Thread mrts
On Mar 1, 5:27 pm, Jacob Kaplan-Moss wrote: > Also, a step 2.5, if you'd like, would be to write a tiny app on pypi > that enabled the use of pylibmc via an external cache backend. We > could point to it in the deprecation notes when we explain why > cmemcache is being

Re: logialogin_required does not check User.is_active

2010-03-16 Thread mattd
interesting. i'm using the django-provided login form from 1.1, waiting for 1.2 to be released before using it. here's an example of my point: you run an internal tool for staff to discuss the topics of the day. a few staff are let go or otherwise deemed ineligible, and their access is revoked.

Re: logialogin_required does not check User.is_active

2010-03-16 Thread Gabriel Hurley
I linked to the 1.1 docs there, but the 1.2 docs add: "However, the AuthenticationForm used by the login() view does perform this check, as do the permission-checking methods such as has_perm() and the authentication in the Django admin." So in this instance, if using the built-in django login

Re: logialogin_required does not check User.is_active

2010-03-16 Thread mattd
if it's a design decision, it's a silly one imo. why should i have to work around django's ever-so-convenient "login_required" decorator to prevent a deactivated user from viewing a page they're no longer allowed to view? a deactivated user *shouldn't even be allowed to be be logged in*, but

Ticket 13023: Admin inlines, max_num, and extra

2010-03-16 Thread Gabriel Hurley
I couldn't help notice that #13023 was mentioned in Russ' latest 1.2 status update as a ticket that "will require some significant design work". Since I've accepted that ticket I'd love to get some feedback from folks. The ticket: http://code.djangoproject.com/ticket/13023 The ticket was opened

Re: logialogin_required does not check User.is_active

2010-03-16 Thread Gabriel Hurley
The docs have this to say about is_active: "This doesn’t control whether or not the user can log in. Nothing in the authentication path checks the is_active flag, so if you want to reject a login based on is_active being False, it is up to you to check that in your own login view. However,

logialogin_required does not check User.is_active

2010-03-16 Thread Sean Brant
A co-worker of mine noticed this bug today http://code.djangoproject.com/ticket/13125. Should it be marked for 1.2 or punt it until after the release candidate? It looks to be a bug so it could probably go in at anytime. Let me know your thoughts. -- You received this message because you are

Re: Call for sprinters for 1.2

2010-03-16 Thread Tobias McNulty
Hi all, We're doing another Django sprint THIS WEEKEND at Carrboro Creative Coworking in the NC Triangle, for anyone in the area: http://code.djangoproject.com/wiki/Sprint201003TriangleNC Again the sprint is this weekend, March 20 & 21, from 9am to 5pm both days. Caktus will be sponsoring

Re: Model validation outside of ModelForms.

2010-03-16 Thread Harro
Just my brainfart when looking at this: Can't you simply add a pre save signal to call the full clean method? Dunno if that will work or not, just the first thing I would try. On Mar 16, 5:12 pm, James Bennett wrote: > On Tue, Mar 16, 2010 at 10:36 AM, orokusaki

Re: Model validation outside of ModelForms.

2010-03-16 Thread James Bennett
On Tue, Mar 16, 2010 at 10:36 AM, orokusaki wrote: > It doesn't seem that the core team is interested in working on Model > validation at the moment: http://code.djangoproject.com/ticket/13121 > (my failed ticket) Stop right there and actually go back and *read* all the

Re: Model validation outside of ModelForms.

2010-03-16 Thread orokusaki
Strong 1+ It doesn't seem that the core team is interested in working on Model validation at the moment: http://code.djangoproject.com/ticket/13121 (my failed ticket) The current thinking by the powers that be is that you cannot introduce model-level validation enforcement without breaking the

Call for sprinters for 1.2

2010-03-16 Thread James Bennett
Russ is about to put up a post on the Django weblog with the current state of 1.2. There's been quite a bit of progress since the last update, but there are still around 60 tickets which will need in-depth attention before we hit the point of releasing 1.2; the remainder of the tickets on the