Re: Breaking out localflavor

2012-08-16 Thread Jannis Leidel
On 16.08.2012, at 23:48, Łukasz Rekucki wrote: > On 16 August 2012 23:42, Jacob Kaplan-Moss wrote: >> On Thu, Aug 16, 2012 at 3:38 PM, Adrian Holovaty wrote: >>> You mean like a magic import thing, right? >> >> Well, Python *does* have some namespace package support stuff. It's >> something o

Re: Breaking out localflavor

2012-08-16 Thread Jannis Leidel
On 16.08.2012, at 23:38, Russell Keith-Magee wrote: > On Fri, Aug 17, 2012 at 5:26 AM, Adrian Holovaty wrote: >> I'd like to move all Django localflavor code into a separate package, >> distributed separately from Django the framework. > > +1. I've had the exact same thought myself over the pa

Re: Breaking out localflavor

2012-08-16 Thread Jannis Leidel
On 16.08.2012, at 23:26, Adrian Holovaty wrote: > I'd like to move all Django localflavor code into a separate package, > distributed separately from Django the framework. +1 > PROPOSED SOLUTION > > I think it makes most sense for there to be country-specific packages, > such as django-forms-

Re: Breaking out localflavor

2012-08-16 Thread bhuztez
> So for a namespace at django.contrib.localflavor.* I *think* that django > and django.contrib would both need to be namespace packages as well. > If i'm right about that > thenhttps://github.com/django/django/blob/master/django/__init__.py > will need to be moved to somewhere else as well. Yes,

Re: Breaking out localflavor

2012-08-16 Thread Donald Stufft
I could be wrong but offhand to make a namespace package you're going to need to make a namespace package for everything above it. So for a namespace at django.contrib.localflavor.* I *think* that django and django.contrib would both need to be namespace packages as well. If i'm right about that t

Re: Breaking out localflavor

2012-08-16 Thread Adrian Holovaty
On Thu, Aug 16, 2012 at 4:38 PM, Russell Keith-Magee wrote: > I agree that this is certainly one way that we could address the > problem. However, localflavor isn't just forms. Some of the packages > (US in particular; and I think there's also a patch lurking for AU) > have database models as well

Re: Breaking out localflavor

2012-08-16 Thread Łukasz Rekucki
On 16 August 2012 23:42, Jacob Kaplan-Moss wrote: > On Thu, Aug 16, 2012 at 3:38 PM, Adrian Holovaty wrote: >> You mean like a magic import thing, right? > > Well, Python *does* have some namespace package support stuff. It's > something of a mess, with one implementation internally, another in >

Re: Breaking out localflavor

2012-08-16 Thread Alex Gaynor
On Thu, Aug 16, 2012 at 9:42 PM, Jacob Kaplan-Moss wrote: > On Thu, Aug 16, 2012 at 3:38 PM, Adrian Holovaty > wrote: > > You mean like a magic import thing, right? > > Well, Python *does* have some namespace package support stuff. It's > something of a mess, with one implementation internally, a

Re: Breaking out localflavor

2012-08-16 Thread Jacob Kaplan-Moss
On Thu, Aug 16, 2012 at 3:38 PM, Adrian Holovaty wrote: > You mean like a magic import thing, right? Well, Python *does* have some namespace package support stuff. It's something of a mess, with one implementation internally, another in setuptools, and (IIRC) a new PEP that'll take hold in Python

Re: Breaking out localflavor

2012-08-16 Thread Russell Keith-Magee
On Fri, Aug 17, 2012 at 5:39 AM, Alex Gaynor wrote: > > > On Thu, Aug 16, 2012 at 9:38 PM, Russell Keith-Magee > wrote: >> >> On Fri, Aug 17, 2012 at 5:26 AM, Adrian Holovaty >> wrote: >> > PROPOSED SOLUTION >> > >> > I think it makes most sense for there to be country-specific packages, >> > su

Re: Breaking out localflavor

2012-08-16 Thread Alex Gaynor
On Thu, Aug 16, 2012 at 9:38 PM, Russell Keith-Magee < russ...@keith-magee.com> wrote: > On Fri, Aug 17, 2012 at 5:26 AM, Adrian Holovaty > wrote: > > I'd like to move all Django localflavor code into a separate package, > > distributed separately from Django the framework. > > +1. I've had the e

Re: Breaking out localflavor

2012-08-16 Thread Russell Keith-Magee
On Fri, Aug 17, 2012 at 5:26 AM, Adrian Holovaty wrote: > I'd like to move all Django localflavor code into a separate package, > distributed separately from Django the framework. +1. I've had the exact same thought myself over the past couple of years. My hesitation historically has been the lim

Re: Breaking out localflavor

2012-08-16 Thread Adrian Holovaty
On Thu, Aug 16, 2012 at 4:33 PM, Jacob Kaplan-Moss wrote: > An added benefit that you didn't mention is easier maintenance -- each > individual localflavor package could have its own maintainer(s), > meaning they wouldn't have to get the attention of a core committer to > get fixes in. Totally --

Re: Breaking out localflavor

2012-08-16 Thread Jacob Kaplan-Moss
+1! An added benefit that you didn't mention is easier maintenance -- each individual localflavor package could have its own maintainer(s), meaning they wouldn't have to get the attention of a core committer to get fixes in. One question: would you be thinking of doing some sort of namespace pack

Breaking out localflavor

2012-08-16 Thread Adrian Holovaty
I'd like to move all Django localflavor code into a separate package, distributed separately from Django the framework. WHY? 1. We shouldn't be in the business of updating Romanian phone number rules (e.g., https://github.com/django/django/pull/275). That doesn't belong in a Web framework. 2. Th