Re: How to test patch

Thanks Jan for the contributions. I'll add a couple bits to Russ's excellent reply. I generally will run just a specific test, or a subset of the tests while developing the patch initially, this is much faster and can let you iterate much more quickly. Julien has put together a great tool for

Re: How to test patch

On Sun, Oct 28, 2012 at 7:33 AM, Jan Bednařík wrote: > Hi all, > > I'm using Django for more than four years and last week I started > contributing. > > In docs about contributing I didn't find how detailed should be my testing > while I'm writing or reviewing patch? Is

Re: #3011 - Custom User Models -- Call for final review

On Sat, Oct 27, 2012 at 7:25 PM, Ludwig Kraatz wrote: > Hi Russ, > > >> >> > - The last_login field is in the AbstractBaseUser, but it isn't >> > documented as a required field. Is this field required for something? >> > Is it needed as part of AbstractBaseUser? >> >> Yes,

How to test patch

Hi all, I'm using Django for more than four years and last week I started contributing. In docs about contributing I didn't find how detailed should be my testing while I'm writing or reviewing patch? Is enough to run tests only for patched module? Or should I run full test suite for each

preventing 'csrftoken' cookie fixation attacks

Hi there, I'd like to discuss the behavior of the 'csrftoken' cookie that is used for django's CSRF protection [1]. I noticed that the cookie content does not change when performing a login (like the 'sessionid' cookie does). According to [1] this seems to be the documented behavior: "This cookie

Re: #3011 - Custom User Models -- Call for final review

Hi Russ, > > > - The last_login field is in the AbstractBaseUser, but it isn't > > documented as a required field. Is this field required for something? > > Is it needed as part of AbstractBaseUser? > > Yes, last_login is required - it's needed in order to generate > password reset tokens