Hi Russell, On Tue, 4 Feb 2014, Russell Keith-Magee wrote:
A definite "Maybe". :-) For my money, this is probably something that is handled better by the web server. Apache, for example, logs one line per request, and can be configured to dump full GET and POST contents if you need that information. Aside from reproducing functionality available elsewhere, my concern would be performance. Adding a single logging call isn't much, but you're adding it into a critical path, so the impact could be large (especially if you're logging the full contents of POST and FILES data). So - I'm probably wavering between a +0 and -0, depending on the actual impact your proposed change has. At the very least, it's worth opening a ticket -- even if the idea is ultimately rejected, a ticket allows us to archive the decision making process (since I doubt you're the first, or will be the last person to think of this idea).
Thanks, I've created ticket https://code.djangoproject.com/ticket/21949, with some more information on my reasons for proposing this.
Cheers, Chris. -- Aptivate | http://www.aptivate.org | Phone: +44 1223 967 838 Citylife House, Sturton Street, Cambridge, CB1 2QF, UK Aptivate is a not-for-profit company registered in England and Wales with company number 04980791. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/alpine.DEB.2.02.1402041018340.19498%40lap-x201.fen.aptivate.org. For more options, visit https://groups.google.com/groups/opt_out.
