Re: future of QuerySet.extra()?

2015-07-31 Thread Michael Manfre
As some one who has had to abuse .extra() at times to make mssql things work, I support this approach. On Fri, Jul 31, 2015 at 4:00 PM, Tim Graham wrote: > I had in mind a documentation note like this: > > Use this method as a last resort > > > This is an old API that we

Re: future of QuerySet.extra()?

2015-07-31 Thread Christophe Pettus
+1. On Jul 31, 2015, at 2:12 PM, Marc Tamlyn wrote: > Sounds good to me. > > On 31 July 2015 at 21:00, Tim Graham wrote: > I had in mind a documentation note like this: > > Use this method as a last resort > > > > This is an old API that we aim

Re: future of QuerySet.extra()?

2015-07-31 Thread Marc Tamlyn
Sounds good to me. On 31 July 2015 at 21:00, Tim Graham wrote: > I had in mind a documentation note like this: > > Use this method as a last resort > > > This is an old API that we aim to deprecate at some point in the future. > Use it only if you cannot express your query

Re: future of QuerySet.extra()?

2015-07-31 Thread Tim Graham
I had in mind a documentation note like this: Use this method as a last resort This is an old API that we aim to deprecate at some point in the future. Use it only if you cannot express your query using other queryset methods. If you do need to use it, please file a ticket with your use case

Re: future of QuerySet.extra()?

2015-07-31 Thread Collin Anderson
I wonder if there's a way in the docs we can deprecate it as in "we don't recommend you use it", but not actually schedule it for removal. On Friday, July 31, 2015 at 2:01:20 PM UTC-4, Marc Tamlyn wrote: > > I don't know about unmaintained, but I think there's a consensus that > .extra() has a

Re: future of QuerySet.extra()?

2015-07-31 Thread Andres Osinski
Would the expressions API be able to define fields that are aggregations of complex foreign relationships? I keep using it when I need fields that are the result of weird aggregations over multiple JOINs with some unusual stuff like CASE fields and subqueries. On Fri, Jul 31, 2015 at 2:58 PM, Tim

Re: future of QuerySet.extra()?

2015-07-31 Thread Marc Tamlyn
I don't know about unmaintained, but I think there's a consensus that .extra() has a horrible API and we should do away with it eventually. That said I think there are still enough things that can't be done without it at present. A lot fewer now we have expressions, but still some. I'd be happy

future of QuerySet.extra()?

2015-07-31 Thread Tim Graham
In light of the new expressions API, the idea of deprecating QuerySet.extra() has been informally discussed in IRC and elsewhere. I wonder if there is consensus to mark extra() as "unmaintained" and to suggest filing feature requests for functionality that can be performed through extra() but