Re: Question about ticket #20456: Easier unit testing for class-based views

2019-10-08 Thread Felipe Lee
Sounds good, thanks for the input. I'll work on that this week/weekend. Best, Felipe On Tuesday, October 8, 2019 at 3:02:42 AM UTC-5, Carlton Gibson wrote: > > Hi Felipe, > > Thanks for the question! > > For me, yes, this seems reasonable given that we already have the > `setup()` hook. Please

CSV row delete problem(using pandas)

2019-10-08 Thread Jordan Micle
I am going to delete row from csv but I got this error KeyError at /tools/universe/delete_instrument/ "['3'] not found in axis" views.py instrument = request.POST.get("symbol") universe_id = request.POST.get("id") universe = get_object_or_404(Universe_Universe, id=universe_id)

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Jani Tiainen
IIRC correctly I had problems with alpine and it's GIS libraries when preparing for my workshop on Djangocon EU 2019. Most of the required libs weren't available in stable version. Haven't checked if situation has improved since. ti 8. lokak. 2019 klo 14.05 Tom Forbes kirjoitti: > I did experi

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Nick Sarbicki
That makes sense. Do we have a list of the versions required? I'm happy to try it out and see if it makes a difference. - Nick On Tue, Oct 8, 2019 at 12:05 PM Tom Forbes wrote: > I did experiment with it. The main problem is that the image we use > requires a bunch of system libraries (see >

Re: Feature Request: Enabling hooking into the autodetector from a third-party app.

2019-10-08 Thread Carlton Gibson
Hi Emil. Thanks for this. Ticket was https://code.djangoproject.com/ticket/30849 Closed as wontfix, since at least constraints are now handled. I don't think that covers everything you propose but see again Simon and Josh's comments on the first thread you opened

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Tom Forbes
I did experiment with it. The main problem is that the image we use requires a bunch of system libraries (see https://github.com/django/django-docker-box/blob/master/Dockerfile#L4 ). I think a few where missing our outdated

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Carlton Gibson
I’ll have a look.. 👀 On Tue, 8 Oct 2019 at 12:52, Josh Smeaton wrote: > I was going to archive the repo, but it seems I don't have the necessary > permissions. Carlton, do you? > > On Tuesday, 8 October 2019 21:45:22 UTC+11, Adam Johnson wrote: >> >> +1 to archiving django-box >> >> On Tue, 8 Oc

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Nick Sarbicki
Just out of interest, Tom, have you tried using Alpine as the base? Or is there a reason to avoid it? I usually find once you introduce all the dependencies for django it doesn't make a huge difference but it might shave some of the weight off if we're worried about image size. - Nick On Tue,

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Josh Smeaton
I was going to archive the repo, but it seems I don't have the necessary permissions. Carlton, do you? On Tuesday, 8 October 2019 21:45:22 UTC+11, Adam Johnson wrote: > > +1 to archiving django-box > > On Tue, 8 Oct 2019 at 11:01, Tom Forbes > > wrote: > >> Thank you for the kind words Bruno! I'

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Adam Johnson
+1 to archiving django-box On Tue, 8 Oct 2019 at 11:01, Tom Forbes wrote: > Thank you for the kind words Bruno! I'm glad it's helped you, if you have > any suggestions for improvements then please open an issue on the repo or > post a message here, I know it's not perfect. I would have replied e

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Tom Forbes
Thank you for the kind words Bruno! I'm glad it's helped you, if you have any suggestions for improvements then please open an issue on the repo or post a message here, I know it's not perfect. I would have replied earlier but this message didn't get delivered to me. I'm biased, but I'd be +1 o

Re: PEP 484 type hinting in Django

2019-10-08 Thread Carlton Gibson
Maxim Kurnikov has begun a draft DEP for adding hints into Django. https://github.com/django/deps/pull/65 Please contribute your thoughts there. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django

Fellow Reports -- October 2019

2019-10-08 Thread Carlton Gibson
Hi all, Calendar Week 40 -- ending 06 October. Triaged: https://code.djangoproject.com/ticket/30808 -- Create a reference to the Django Forum in Docs (Accepted — pending board approval.) https://code.djangoproject.com/ticket/30825 -- Confusing message on the default Django home page mentio

Re: Explore integrating django-docker-box in some way?

2019-10-08 Thread Carlton Gibson
Hi Bruno. Thanks for your post! I've come to take silence as positive feedback, but actual comments go further than you'd think. :) Tom was the driver here, so credit to him, and those who helped/tested. Hi Josh. Yes, it's probably time. (I imagine "use a VM running docker" is now likely the e

Re: Question about ticket #20456: Easier unit testing for class-based views

2019-10-08 Thread Carlton Gibson
Hi Felipe, Thanks for the question! For me, yes, this seems reasonable given that we already have the `setup()` hook. Please do proceed. Kind Regards, Carlton On Monday, 7 October 2019 09:20:12 UTC+2, Adam Johnson wrote: > > Moving the head=get line sounds sensible to me! > > On Sun, 6 Oc

Re: Form customization

2019-10-08 Thread Carlton Gibson
Hi Alex Can you be more specific please? On Sunday, 6 October 2019 01:11:52 UTC+2, Alex Scott wrote: > > Would it be a terrible idea to allow these to be set in settings or in a > base form that gets inherited by everything else? > Without seeing exactly the problems you have in mind, it's ha