Re: Deprecate CICharField, CIEmailField, CITextField

2022-01-25 Thread Mariusz Felisiak
wtorek, 25 stycznia 2022 o 13:59:54 UTC+1 Adam Johnson napisał(a): > My initial concern was around the minimum PostgreSQL version that Django > 5.0 will support. According to > https://en.wikipedia.org/wiki/PostgreSQL#Release_history , PostgreSQL 10 > is supported until 2022-11-10 , and

Re: Deprecate CICharField, CIEmailField, CITextField

2022-01-25 Thread Tom Carrick
Hi, I'm not too sure about this. While Postgres encourages using non-deterministic collations, they're not without their downsides. For example, you can't do a LIKE query on a field using a non-deterministic collation, but you can with CItext - although I don't believe there's a way to index it.

Re: Deprecate CICharField, CIEmailField, CITextField

2022-01-25 Thread Paolo Melchiorre
Hi Mariusz, I agree with you on deprecating and then removing CI fields. I only would suggest adding some examples of migrations from CI fields to collations in the deprecation notes to help users to easily migrate. So +1 for me too. Ciao, Paolo On Tue, Jan 25, 2022 at 1:39 PM Mariusz

Re: Deprecate CICharField, CIEmailField, CITextField

2022-01-25 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
My initial concern was around the minimum PostgreSQL version that Django 5.0 will support. According to https://en.wikipedia.org/wiki/PostgreSQL#Release_history , PostgreSQL 10 is supported until 2022-11-10 , and version 11 until 2023-11-09. With Django 5.0 expected in 2024-01, it should be fine

Deprecate CICharField, CIEmailField, CITextField

2022-01-25 Thread Mariusz Felisiak
Hi y'all,     Django 3.2+ supports "db_collation" [1] for "CharField" and "TextField" along with migration operations ("CreateCollation()", "RemoveCollation") and the database function "Collate()" [3]. Moreover CI fields and the entire "citext" module are discouraged since PostgreSQL 12 [4]