Re: Easy Pickings: support robust on_commit handlers

2022-04-06 Thread Om Anirudh
Hi Josh, all I am interested to work on this ticket, this would be my first time contributing. I have read and worked through the article "Writing your first patch for Django". I should be fine with the getting started part. I am looking for someone reach out to personally to get my

Re: Ticket #21289 - Login rate limiting

2022-04-06 Thread Fran Hrženjak
Having a 5 seconds “forbidden window” could be bad UX for users with password managers (like LastPass, or even just Apple’s built-in whatever-they-call-it fingerprint-scanning password autofill). It often takes about a second to submit the login form in such cases. Maybe 1 second interval

Re: [Feature Request] extra_context -> dataclass

2022-04-06 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
Template contexts are namespaces, for which a dictionary is an ideal type. If you want type safety with dicts, you can use TypedDict in type hints. You haven't presented any advantage to using dataclasses, plus it doesn't seem that inconvenient to add your own wrapper that calls asdict(). On Wed,

[Feature Request] extra_context -> dataclass

2022-04-06 Thread Arthur
Hi all! Currently django views do not accept dataclasses as context. I stumbled about this because I wanted to do something like this: @cached_property def extra_context(self): data = MyDataClass(...) ... return data Unfortunately, this is unpacked by get_context_data and throws