Re: Adding save to UploadedFile

2007-08-17 Thread Marty Alchin
On 8/16/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > My preference would be to make a new ticket and reference the other > ones. The advantage of this is that it keeps comments and retries > concerning your patch easy to read and not tangled up with comments > about the original ticket(s).

Re: Adding save to UploadedFile

2007-08-16 Thread Malcolm Tredinnick
On Thu, 2007-08-16 at 22:37 -0400, Marty Alchin wrote: [...] > On a related note, if (as I expect would the case here) a patch ends > up involving multiple tickets, how should that be handled in Trac? > Just pick one of the tickets that seems most important and go with > that one? These kinds of

Re: Adding save to UploadedFile

2007-08-16 Thread Marty Alchin
On 8/16/07, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > The stuff I'm doing can safely be ignored because it's an addition on > top of existing stuff. The reason for this approach is that it's 100% > backwards-compatible and it doesn't fall into the trap of prematurely > limiting options --

Re: Adding save to UploadedFile

2007-08-16 Thread Malcolm Tredinnick
On Thu, 2007-08-16 at 12:39 -0400, Marty Alchin wrote: > On 8/16/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: [...] > There was some discussion a while back[1] about trying to make > FileField more self-sufficient, but I had been holding off on any of > that until Malcolm reveals his grand

Re: Adding save to UploadedFile

2007-08-16 Thread Marty Alchin
On 8/16/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > Yeah, add me to that list... > > I've been toying with the idea of file "backends" -- small modules > responsible for storing and retrieving files (and their URLs). The > filesystem backend is the most obvious, but this system could allow

Re: Adding save to UploadedFile

2007-08-16 Thread Jacob Kaplan-Moss
On 8/16/07, Marty Alchin <[EMAIL PROTECTED]> wrote: > Of course, there are those of us who think that should be factored out > for other reasons anyway. :) I won't spoil this thread with that rant, > though. Yeah, add me to that list... I've been toying with the idea of file "backends" -- small

Re: Adding save to UploadedFile

2007-08-16 Thread Marty Alchin
On 8/16/07, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > If you're going to tackle this issue, keep in mind that the > infrastructure to save files already exists as part of the > save_FILE_file() implementation in a model. This would need to be > factored out to avoid duplication. Of

Re: Adding save to UploadedFile

2007-08-16 Thread Russell Keith-Magee
On 8/16/07, Mads Sülau Jørgensen <[EMAIL PROTECTED]> wrote: > > Hi. > > Perhaps it's just me beeing lazy, but would a .save(path_to_save_to) > method on a UploadedFile not be quite convienent? > > Just wanted to check with you before opening a ticket + patch. I briefly considered this idea, but

Adding save to UploadedFile

2007-08-16 Thread Mads Sülau Jørgensen
Hi. Perhaps it's just me beeing lazy, but would a .save(path_to_save_to) method on a UploadedFile not be quite convienent? Just wanted to check with you before opening a ticket + patch. -- Mads Sülau Jørgensen [EMAIL PROTECTED] --~--~-~--~~~---~--~~ You