Re: Call for comment: #5390 Many To Many signals

2010-01-09 Thread Russell Keith-Magee
On Sat, Jan 9, 2010 at 3:10 PM, Xia Kai(夏恺) wrote: > Hi, > > First thing first, I shall explain why this have something to do with admin. > > Django's admin save m2m relationship in ModelAdmin's change_view method. > After some tracing, you would find that the m2m relationship

Re: Call for comment: #5390 Many To Many signals

2010-01-08 Thread 夏恺
ail.com http://blog.xiaket.org -- From: "Russell Keith-Magee" <freakboy3...@gmail.com> Sent: Saturday, January 09, 2010 1:26 PM To: <django-developers@googlegroups.com> Subject: Re: Call for comment: #5390 Many To Many signals On Sat,

Re: Call for comment: #5390 Many To Many signals

2010-01-08 Thread Russell Keith-Magee
On Sat, Jan 9, 2010 at 9:47 AM, Xia Kai(夏恺) wrote: > Hi all, > > IMHO this patch would still make django issue illogical signals in admin. > frans and I have pointed out that the __set__ method in the > ManyRelatedObjectsDescriptor is flawed[1-2], which is used by admin. It

Re: Call for comment: #5390 Many To Many signals

2010-01-08 Thread 夏恺
ssell Keith-Magee" <freakboy3...@gmail.com> Sent: Friday, January 08, 2010 8:04 PM To: "Django Developers" <django-developers@googlegroups.com> Subject: Call for comment: #5390 Many To Many signals Hi all, I've just uploaded a patch for #5390, which adds signals to m

Re: Call for comment: #5390 Many To Many signals

2010-01-08 Thread Russell Keith-Magee
On Fri, Jan 8, 2010 at 9:46 PM, Luke Plant wrote: > On Friday 08 January 2010 12:04:27 Russell Keith-Magee wrote: > >> Any feedback on this design? > > Just a few things: > > 1) In assessing performance impact, people need to be clear that there > is just one signal handler

Re: Call for comment: #5390 Many To Many signals

2010-01-08 Thread Luke Plant
On Friday 08 January 2010 12:04:27 Russell Keith-Magee wrote: > Any feedback on this design? Just a few things: 1) In assessing performance impact, people need to be clear that there is just one signal handler for the whole project, like for the post_save signal etc. Adding a handler will

Call for comment: #5390 Many To Many signals

2010-01-08 Thread Russell Keith-Magee
Hi all, I've just uploaded a patch for #5390, which adds signals to many-to-many modifying operations. This is a ticket that was a low-priority accepted item for 1.1 (ORM-18), but got bumped due to time [1]. For some reason, it wasn't resubmitted for 1.2. The purpose of this post is twofold: